From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C241C54E67 for ; Wed, 27 Mar 2024 09:58:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3577D6B0083; Wed, 27 Mar 2024 05:58:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E07F6B0085; Wed, 27 Mar 2024 05:58:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 181606B0087; Wed, 27 Mar 2024 05:58:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E8BA06B0083 for ; Wed, 27 Mar 2024 05:58:02 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AFA95A061B for ; Wed, 27 Mar 2024 09:58:02 +0000 (UTC) X-FDA: 81942368004.10.76115C3 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf19.hostedemail.com (Postfix) with ESMTP id B8BC71A0003 for ; Wed, 27 Mar 2024 09:58:00 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mOIXkQY1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711533480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QopJNOBOfdWDKEhIs+lfUYOsEwEuPxfB93MVZOHtOng=; b=bMzKAt8amLuBP+LROtEVtn+jaHy55823Ypmvgoj8Kb0VUXUd/VyolXPfVFi3f2Ksgy6fCd XgqBh66J3k3VDOAAMUeN3xqnW5MNNQs5Wti2UtIduGXWtJRjSbo8v+3pEh9+4MdN5ulZJu DHQTEDmMCMeBxhwYrzjowGQ2r79MjDA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mOIXkQY1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711533480; a=rsa-sha256; cv=none; b=UGQZhzmDVONpS3MAlxyhpoc4ZCIozC+qwYzyGX3gXobO5SI0b3XP20rdHQL6oyq+Z+uRM0 JSdYR9VwdaD7FiO7CFbRJBdspaCe5+AT3eKuT3ak5mtInrd4v81DKpuv5u5y/5W/lsUX1w vC+gOx0CrVmdSkMuhFd2hW1ghKs3ivM= Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-514ba4e5640so636355e87.1 for ; Wed, 27 Mar 2024 02:58:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711533479; x=1712138279; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=QopJNOBOfdWDKEhIs+lfUYOsEwEuPxfB93MVZOHtOng=; b=mOIXkQY1VWqUZwTvLCUvw8G+F0dwQ70cMT4/3iSjy8zFOfBxrPG73N+eWkf14FYfjy yLtBMHbsWdTtO8SK5WOMOXY+6X0nc4KAeRW3uNFdZRYeHMytUqWPAJLIncxdfjZsiCkm rZtkVKrdt1KVEyEaUQtK1ET3DOsbWD+lVMZo+XUSeMAFxHz1Lp31UY1aSJ+uwIKtDzyS uzyh0Z2tP+vtD9Mgd/gOrKFea+3+VpNVPvuOV2eLW/GgHnRTJ5iXmWk/E6VqCenPG1C8 W2sCc7WhtOOg/RSUHLB20rNz8aQBfUloKUm0KG+buCr28WRYPtVCMoCIg4TBVXEn5z88 wv4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711533479; x=1712138279; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QopJNOBOfdWDKEhIs+lfUYOsEwEuPxfB93MVZOHtOng=; b=XioWjdKojU/qwOdntI/j/cHFvbdDXVuAEV0+v0BA0thvW0XnSCkbhw6GjA4U5LY5qW diEwWKm0tRi+eINWJl/X30sM72sE0e8qTDkS6LNl1b2nioa2jCceiw3PuY9RfdBdejb/ j+AJ4o6tu+g/88I8ne/csVxWOMDqBJtO3+QfgOtsopnM6E+cX8tw1TI2uRBuBAnM7AHZ oC04my20QqFfsjG9rVDi6msecvf+R26JAJ0uENwXW/lgQvnpia+r7dFSviZ38X5hW+Xx wnp5KqdKKoXhoXk8+EDp1zG485DpTriPpV68xTvzR+4XjXsNlL9rRBzKcS6DZn9disjW LaCg== X-Gm-Message-State: AOJu0Yw1J6cMFjw2cNm6t+Wo9r4HWj8SS1KrpKnJ1lzkQADb0MwDwVXm FfoXoF26WL3F04x2eT2Wffdj0WlRzBWrkaezg8H0BEvjqto8UhVe X-Google-Smtp-Source: AGHT+IGNHk4VXGK92BMuktzvNP/X/D7okPVLzJeDLDLPjt5GvdI1soAbEZ8YvB/oHYPPgUKkxClsEg== X-Received: by 2002:ac2:5b88:0:b0:513:e29d:6840 with SMTP id o8-20020ac25b88000000b00513e29d6840mr1408447lfn.15.1711533478532; Wed, 27 Mar 2024 02:57:58 -0700 (PDT) Received: from pc636 (host-90-235-28-241.mobileonline.telia.com. [90.235.28.241]) by smtp.gmail.com with ESMTPSA id k11-20020a192d0b000000b0051589cc26afsm1788961lfj.72.2024.03.27.02.57.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 02:57:58 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 27 Mar 2024 10:57:56 +0100 To: Jens Axboe Cc: Linux-MM , Andrew Morton , "Uladzislau Rezki (Sony)" , Omar Sandoval Subject: Re: [PATCH] mm: vmalloc: annotate find_vmap_area_exceed_addr_lock() for lockdep Message-ID: References: <86cb4eaa-2ef3-47e6-87f8-96b15895a7ce@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86cb4eaa-2ef3-47e6-87f8-96b15895a7ce@kernel.dk> X-Rspamd-Queue-Id: B8BC71A0003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: sfo1go389hk9u16ijoziyq73fsnkazc4 X-HE-Tag: 1711533480-574789 X-HE-Meta: U2FsdGVkX1+zm1D2sZcD0Fjf1jE6s6+3HDHEkio1uJJZ3mx9kpYoee19ahx+5tEgIt8EasFqKB7st7Z3eHT4YtHyPfUgAZMS2GlwfMVtgUFpwIc9VRg9br9a5kTo2kW3wyTdRpTwZZBtFCtF2v97CUND/8XCVWFCX+/eOhHsCBzs9fr2BllGgnXIh8I2gwf72B4yC8rQk8Vg0jSHl/Mg//OJ9E4HSAA+8sN3P2YVD2QUrgVfet8kKQyYW5hYqhNge3VCkC0bobCye+7x3iMfwEIoxYBJ0z5DYiSpTX4o7SFOAotjq/DhJPsNsF5oP+P2wjCKqxPlhv9QH8KYG3OmdTp2Y8WmeJdPLOcTtKhAt6gSUFsah1is9iqi5qHFGraFfLyKBoiwXx5AZFvjWKVCpQAWV24+Cepq6CqsTmLz0eM4MVZF+he+LwKFREy0XzLyFRDTZrmyhAmjhfdDnS0t5azeI4TJYA81kCpsnjzgH/HEmQPSWHxWPkOogkLMjZvVBpp/wuQza8g5MY44GIcUQfUKiIU3MV0q3hXDjVJ5M/mQdCVKCf0PYMxR8/MCtDruzR8bNMVHyWSyZ9DWDf950Myb7i1MJiuMEuRBLXJeubhmTBaNP+kPEnZ2YJ7P6Pkee2FdivofemxWSAHaqE2DfW4uoDtFG+aSLmnsGot19o9zPdBECh5XHOB0cX+0SFDLf0h/gAP+T61r80loFVsaHE1Zyzk3iqEK9uupLJuArd7osXNr5M8hjmmr0lCvoBN5xGauapTX6RAiHm6VmtMP0AUWX7gkvmtYfaAd3cijxCjukdsItMJc69Rd3tpxgfUHgKeyib+UT1Wzpo/oGyPxIHw7WDnBeaqq0V/UUN2NbVk8ay43NYVfzeOZgHqb9rucqIkdTMEbBUtw3XhUAjlS5IKm5MbVKD+jJOdrGX4qAB0q4PWdh4kY5YyCvIHZ9m/zCtBd4+eFyBJFeh6aK7R 0AIALj0S kJ4L5ePbeMKRvu2CLVpx4tf/MnZ0C1IWBXHoMKgt5gITad7TaKGdu1zvBArsqYLcLr3ZokTlpMKmADjpf9ZZBMjKBtk2L/fm5fGVUYB1tNQXLKDmCxQV3A3uIeQ74qQHOfMg0kiAdHvNg9Y1eisaR6oBjRJhEBGzayNso1iAWix33QbfGZzyIIO2MlltLcSYxEGW+kekRcsUc2AkxpY9DOdJYaEzBLZ7zPFc9013/uPI6n8bZrTQRe4MAMzjW4TPFceD+XuRcnxJLxwEZHQV5n6uCW5lxnfSQRnV76benG9r6AZ4M4J3CcxotBPCRxjXcNHI2GNPVbSazPNJ7PttsthYINrmi1x9Y8JoC9oolWha5BPElhtFbRLApnlwbi8pttNO3SOW8jDXZrVGISKi8X0cMqgoIR6RZAyTsB1j2APGznlCrBCTJpFElNQEuVyMPPUVxzT1nDJH/VPr4xcqCTqp19A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 26, 2024 at 04:24:01PM -0600, Jens Axboe wrote: > On 3/26/24 3:25 PM, Jens Axboe wrote: > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 22aa63f4ef63..26a69fa6809c 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -1032,7 +1032,7 @@ find_vmap_area_exceed_addr_lock(unsigned long addr, struct vmap_area **va) > > for (i = 0; i < nr_vmap_nodes; i++) { > > vn = &vmap_nodes[i]; > > > > - spin_lock(&vn->busy.lock); > > + spin_lock_nested(&vn->busy.lock, i); > > va_lowest = __find_vmap_area_exceed_addr(addr, &vn->busy.root); > > if (va_lowest) { > > if (!va_node || va_lowest->va_start < (*va)->va_start) { > > Omar said he tested this and ran into lockdep complaining as it only > supports 8 subclasses. So this patch can't work, but that still leaves > the current kernel code buggy... > It is a bit tricky. Let me rewrite it so a lockdep does not complain. Thank you for your report. -- Uladzislau Rezki