From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67CEBC54E67 for ; Tue, 26 Mar 2024 20:43:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 853E26B0085; Tue, 26 Mar 2024 16:43:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 803F06B0089; Tue, 26 Mar 2024 16:43:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A4EA6B0092; Tue, 26 Mar 2024 16:43:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5AFA06B0085 for ; Tue, 26 Mar 2024 16:43:30 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 313571C0C37 for ; Tue, 26 Mar 2024 20:43:30 +0000 (UTC) X-FDA: 81940365780.05.AAFF8CB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 060F380005 for ; Tue, 26 Mar 2024 20:43:27 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jHdcMmZt; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711485808; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+7bjw/hteF8djmOoWPYQb6GfOlzxEGXIn8a6dn1jJ20=; b=MfJmFTDJ+sbAJXUr1r+nmG5QIOmu/LivjsEAAEcnZ1p0erkBZjHdjCc5147Ge+tAyBWQc6 cyVzDjeF4lE6+T8+AFvz1ClEgdFUEAixp5iJa/cXPe4Y7y5Ck2/YzsOeo9KUyvXhFFI+On 90W9nfwy+a52UiJBVMeUVJ8XD0CI01Q= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jHdcMmZt; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711485808; a=rsa-sha256; cv=none; b=KmJYhdAPP9PcZ+kyQDQV4+JobpGT69b/WjJdghx77m93wRXVVvQBZ1jHXm+7gqrsDPJWws dxZstugIrTw8CJEZ2+kM0mTIN5dvlG199m9AepTFgaQKhrfJCKZ5Pqeq6Yjoye9hX5hHQQ eX76FsPseG19DtRBCfmfflhFjSToWoI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711485807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+7bjw/hteF8djmOoWPYQb6GfOlzxEGXIn8a6dn1jJ20=; b=jHdcMmZtUhidgRdYg+DRxR9GYu90Hpi9IqVwr6to9n/n1AAg+7JXURKPKFfoDoxtJyNVsV zS1/sCXgvGsCOJrQh5t0+IeK06vgR/F1cVen4aBs3iX+GUxW68lRuJIaSMXDaVbBI00+Dq XR6awTvoXSyIyEFzJJ2ejDiaqilPHlg= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-EBiAcG2xM3ezrztrj9kdtg-1; Tue, 26 Mar 2024 16:43:23 -0400 X-MC-Unique: EBiAcG2xM3ezrztrj9kdtg-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-430d45c66acso9831241cf.1 for ; Tue, 26 Mar 2024 13:43:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711485803; x=1712090603; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+7bjw/hteF8djmOoWPYQb6GfOlzxEGXIn8a6dn1jJ20=; b=DhU7+TjEVXS/TRcMxDSpjs85HwtIq4pApmGKxcrd28ahRRZu7Z1OBpcm75Z++t3/QD b5Qp8NHid1ek6f8h45uyGt9gOehq2MaeasDJVIMF6XMKH6/LE+Hz9peMcaEj6KP+pnfX DtDeY1+0d9Ushy6BWUCMFvy6/UTsVpTJB3Bo1v3prQsRX+b1qXP/lBV4uGCdCaYiApRs mPck4rah+nAQX378ufYs/rHDv9l3I37o3vLhCFZ4+yNVf88rLGNi5UPEvMpPIMne4DIQ wB2mm2rw/h0JB4Np2FkNIPnSJ27Li8E45S0CfAYpLR99NrGYm0eFIn/lRAiKRUNMJf9e rSQw== X-Forwarded-Encrypted: i=1; AJvYcCXPkWZzDfGKjGx1800cZksh0ZVCm/UlFY4u5yA/OIDa6jGucZFye3omPGpTosSnnExBp9giCUOS49r0IFPkSr94Yhk= X-Gm-Message-State: AOJu0YxK0BzgEdiNaFeWSewGP86eHzfxr6FgGavxg7GFXiQm3sysyP57 kmRNvkVUU6m9snx7UigUOimtQdTYoZfvu7Qab0hszr3NK6si3NA8P3260cF3U0vhNfdun6IVmE+ yHWvgvX7iDh2eZdxltNLOuI22GOkf4V6AA1U1LRMXi/cMCHFx X-Received: by 2002:a05:6214:3d8c:b0:696:6f95:4421 with SMTP id om12-20020a0562143d8c00b006966f954421mr12036050qvb.1.1711485803020; Tue, 26 Mar 2024 13:43:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE9o8Lvkh94OFhBwTYfrdCOZFUwRaCCOcIoegLN8mEEkmbFgDRGFirXEVx9siaWwZdIpqlZMA== X-Received: by 2002:a05:6214:3d8c:b0:696:6f95:4421 with SMTP id om12-20020a0562143d8c00b006966f954421mr12036034qvb.1.1711485802644; Tue, 26 Mar 2024 13:43:22 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id fw11-20020a056214238b00b0069693e10869sm1875364qvb.143.2024.03.26.13.43.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 13:43:22 -0700 (PDT) Date: Tue, 26 Mar 2024 16:43:20 -0400 From: Peter Xu To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, SeongJae Park , Jason Gunthorpe , Mike Rapoport , Matthew Wilcox , kernel test robot Subject: Re: [PATCH] mm/arch: Provide pud_pfn() fallback Message-ID: References: <20240323151643.1047281-1-peterx@redhat.com> <20240326132726.67e82559a928ac1636c8050c@linux-foundation.org> MIME-Version: 1.0 In-Reply-To: <20240326132726.67e82559a928ac1636c8050c@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 060F380005 X-Stat-Signature: z8cjbuwms56jdqq9ky35s5xx9s1nzam9 X-Rspam-User: X-HE-Tag: 1711485807-590427 X-HE-Meta: U2FsdGVkX1/O/XtAHQ5cpEWbJl0usioLiqx8HgE7rLl6HkeY2wu6NB7025A6+9nNd1Jm2fWWvsaJQjGOk2enEElwDWgr+8wO30Mr1xEj7wglIINoq4oaK4kaX0xgniu3OWmK+3oIaCzN1PmS6BvKjTsxEeFeyCBgme5FYlnAb5aq2cPYCWxmE1g9LCQsSWNO/KlEQ29OPanVtbOoQoz2wf0+yZ/eAPYwP6dRPBpcIaCwnuSZU2mc2O0mrTwc2fdspI0OrAkQEGVNhg9H+vNEaYNDWImnEs9nPLuUOc+cue5YPZwZe53iVsLOy+3BPPLj3uJnTHaXx3YzmEC5EARGnuQ3ESybQzmBkhXsPT6B76zpf34yM83qWlEvuYq1X2IBeN8yO0vWH6B7vCwvkZy3zhKWGYhi91/bD+RtI6mYrS2xXbMQG2SNCs5SiTNmkzeoMCioH2snY/XAok8ueV5IxHbzdroCHTXj4nDaxd4SH75iS4NBSDCWYgffelA8qsYfj0buGjacrtMb8E1Cz9Tf7ypEd0gP3JAhVvf3DS2oB/Bjd2zUUrf3RMujs8DY2unCyQm/QHxo8RXuk+nnYuH+ZXWmWbhvogvmAnGeI7nvpzzV06wMWk+u4/cE3i7Z1yMkxqI64/d/J3hdvyyroNSjQhkJTVeOQIxa7Y8RfHRig5Wi25+ivH5He7FD1oO8dVSoT6cPs7G9Ni8IKtPLV11obKX2XxEgvOo1jT/Cu6z1/i/YBj6gCMnFEr3w2n3tP7O+fhfyrHrULUVMnHjJG+7mca14a4D2H2Eqm1z/n5xG1IdRTnzvOYdb2fYxMdww+t2Nhl5nQlXbyQSZt2PJ3HpbN8P6wph/kX70jHeoPCBoZWvuNzTwIXIjXv2pMi5LM4DYfRlZLk4XagCVq4Yoh4JZ14P1Q0MqD7DMBTHM3YHKS3/6odY1doSBDFDCHEex9TdH0tvYpZEPUeGwS8Ury1X B9ZJ76BE 6BFRwb5n10HDOSuYreL+JKrgQi+xPHJdokPMW9FH1XicPnkG0oiwP/IBOkb9KTNGDyboE1kLoZWwZkKz8UXV4cklx78ZCY75+ZLRstsjcZEjepUDEKsd3bGmGMnFiRGcUfCJYePHMc5DXPPSYTC41c58lb/Ys3jN0c2mMIP3NHO62MDswF1BWtGEZrczh6YwpJY5fo9/ohcK5jzUL6sLDt0KRpgzn7FlBjDB6ZT1PaBiLoWqCD9G7u9Ghj/ZBwXHw4KTi0vg/VP/+gX6+3hclZqD5b0vORo8kiC/9RXB7xr7D2FQOaMUAQd6Yug/e2j+pk+ZzVn+YT2icDTFx8gDHsP3hsS/TMGv6kQZ7Q0C1YzTEc6ptn2aqsq6+Pz0OsxYSLMbFQ17Lh57yI+eEYPJLKZlNfusXkQ2xG6htPNO5JlI8iYScUPlskRpNQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 26, 2024 at 01:27:26PM -0700, Andrew Morton wrote: > On Sat, 23 Mar 2024 11:16:43 -0400 peterx@redhat.com wrote: > > > From: Peter Xu > > > > The comment in the code explains the reasons. We took a different approach > > comparing to pmd_pfn() by providing a fallback function. > > > > Another option is to provide some lower level config options (compare to > > HUGETLB_PAGE or THP) to identify which layer an arch can support for such > > huge mappings. However that can be an overkill. > > > > ... > > > > If we care about per-commit build errors (and if it is ever feasible to > > reorder), we can move this patch to be before the patch "mm/gup: handle > > huge pud for follow_pud_mask()" in mm-unstable to unbreak build on that > > commit. > > I temporarily disabled that whole series a few days ago. Because of > multiple build issues, iirc. > > Let's make that permanent. Please redo the whole series against > mm-unstable and resend? Yes, that's the plan. Feel free to ignore this as this is not used until that GUP rework series, I'll include it in the whole set to be reposted. I'm currently doing the build tests; just finished writting the harness for testing the matrix. It'll take a bit time to run through the tests I specified (I tried to cover a few more archs/configs), and I'll repost with all patches included (fixups squashed) when test finished. [side note: I think I can reproduce the other not-reported issue, on arm+alldefconfig; that'll get covered too] Thanks, -- Peter Xu