From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8405C54E67 for ; Tue, 26 Mar 2024 19:48:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B3F16B0096; Tue, 26 Mar 2024 15:48:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7641D6B0098; Tue, 26 Mar 2024 15:48:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62B1C6B0099; Tue, 26 Mar 2024 15:48:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 50DCD6B0096 for ; Tue, 26 Mar 2024 15:48:15 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2529B1C0F08 for ; Tue, 26 Mar 2024 19:48:15 +0000 (UTC) X-FDA: 81940226550.14.9DABB08 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf11.hostedemail.com (Postfix) with ESMTP id 4CFC74001A for ; Tue, 26 Mar 2024 19:48:13 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DqHzhr92; spf=pass (imf11.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711482493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MxBAPr9eXOadeecJbaBW+PIKQfHxWzuOy7OIoDoAlhI=; b=Tzm6MRUT9uyB5NAzXmuNQZq11XpQFX8D+67ZRDCa+q2IivQHu0Z19onF08lztYTGCU9aRT TtFuxYCB4ahQqGIKqaJL+w7OiB6Zzi0I5hF8DouzDRiypJYpXOkgQVzeSw2ajsFrrFojfo Bcu3wqGpTlNiPbBHX+rVjCe9UDgSS1E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711482493; a=rsa-sha256; cv=none; b=LQX9emZFZKBzBh7ig9GC3NvMYlPp++2oFVwTWC8uVW/r7InCBDFJiv5yjW7wT4JgudLF0s YD/JMGnNyKc0vZsMLIBYh6h2vPpfMsWEzkjDFuDm1FC8cmpCx1YinuTEsN7O8OcU6nVPYC cS69VD7Yw1gb/Hf2ETYS1bNLMQFGMWg= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DqHzhr92; spf=pass (imf11.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1e0025ef1efso38416815ad.1 for ; Tue, 26 Mar 2024 12:48:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711482492; x=1712087292; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MxBAPr9eXOadeecJbaBW+PIKQfHxWzuOy7OIoDoAlhI=; b=DqHzhr92+VxvWo9/pjrUCgSiFIBFDgaG+qsFjWN6YOcPY9hp8+A2xFjFvStfcdZWqx 6CEFdK0Fl0TpFyld7kyjrtaFgJicShReoyLAx73EiYi+Np+WTnPeXGESKy3k53VlKaZC 5OwI3K2aPijkJ54C2AjgRsogoEb1+RzCyYRHuVZC0YG2rlhkz5MjQko/yQQteiwH2m4G 2Q6Z/gNWbwnqL3BsFQrTfDgckMNpgORc3i/mkh6GpXPtGVjvbMhVjD17DP9zlxfyd6op 05Sppu4NbJ9CkSBYvmLO2MuteuajChSNYqIRom2GCnif8xEJr6hc3rFHT1NwoOgYr/t/ c73w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711482492; x=1712087292; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MxBAPr9eXOadeecJbaBW+PIKQfHxWzuOy7OIoDoAlhI=; b=YsGSnQyQsjJLpUZ5XV4AjCF7x6wboRSwrRNzJ5ash31kO+9sjEOEHrddpR6/POQF9r AtVX2kwxmBZtGy/U3WVThnrEBYcjH9FSpD0CcZzhqCZ+CdYXGEEXGHzIRx02FJLA0mHm fQCWqdXsC19gkSYIKrIfFHnLli/W5OnIWvuScAaeh/SPwQ2uBQtTS/XbRW301/2RjIcA l6t+UaB6Ahk+HgOmoeMLrDT6NJUAI0TPDJ+Q7SKFkCFNWA7SWRc9BIlYFaC7nRWDqrut ygpusQ3Mkigy49QVkinGI59Gg9hvd4RT4hWRECU0lLMMDPvZmm5skyGxSTjvYAhHBKRQ h7iA== X-Forwarded-Encrypted: i=1; AJvYcCWSCEpg+Y5wxzRAxY3f+vx15awI32LNelg48vPmR+dz6Zt9grcgWdYR9dC0oBZjk3hJqArDyry4CsicWbEu5wfIDh8= X-Gm-Message-State: AOJu0YxcLgXH0hoo/kKIaNnbbJnznMNGSgFk7SYQhJhUeqUXxOk11eZc YKTxKBudLDdnPsyltNkqm4FExxdRG/90GmognuFqnyuiS6thaxsF X-Google-Smtp-Source: AGHT+IHgG6MA5Lsu+aw0wxyCe4+UncFf8kJs1/g6C00v9EoIyHznZ9wyUpauWmcrhILSNtqUOtgwbw== X-Received: by 2002:a17:902:ea11:b0:1e0:a731:ea4d with SMTP id s17-20020a170902ea1100b001e0a731ea4dmr2248814plg.62.1711482492054; Tue, 26 Mar 2024 12:48:12 -0700 (PDT) Received: from fedora (c-73-170-51-167.hsd1.ca.comcast.net. [73.170.51.167]) by smtp.gmail.com with ESMTPSA id p7-20020a170902e74700b001e0b5d4a2a8sm5279877plf.149.2024.03.26.12.48.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 12:48:11 -0700 (PDT) Date: Tue, 26 Mar 2024 12:48:09 -0700 From: Vishal Moola To: Qi Zheng Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com, rppt@kernel.org, willy@infradead.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 3/3] s390: supplement for ptdesc conversion Message-ID: References: <04beaf3255056ffe131a5ea595736066c1e84756.1709541697.git.zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <04beaf3255056ffe131a5ea595736066c1e84756.1709541697.git.zhengqi.arch@bytedance.com> X-Rspamd-Queue-Id: 4CFC74001A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: hxcb3z7xzsbrpiqgk1odjfotx1n48oiz X-HE-Tag: 1711482493-290606 X-HE-Meta: U2FsdGVkX18AXXdziqIH5BGuZHJ8c/FksPHr76qX0P6Zc6SEOzgYY4wPelrvy25hE41Ge/tiwjRrfuO1Jl2ol6p7BwnPKj76DUV7gpmplp72ndmriys9ZMWNCAgrGiZkgKeX51DJ6yOhJ7X0w0DMxLoCKWcTvuiktKaVKfGhalf6u2OvQK31vN45HUy4bypHDlZXLowQZZ4fHcczbLGIM7sAR5wndUwoBkV+L3E3MVGctaPBSf1eBYlzp8csx6Pd/pF/azvf3T5m7YHLrf+093uW8YkC3d95x+7ndA8pIv+uL4XACODwjGAMQg2Y/VmZFpM9CagqWlTdMYmv7wImtutMgEnBhSXRJTJdEgVwa54fVDqNDOQNcjYp/6fpQSNU7jDAxlwAYZriVGBO+pqoMVHlBKzrM7YwmbKrtVnhrms6J+6mJ8U42XJcjtUFgzmaXWdH/vB2/F5RA6bv1I4N588zVii9RMcIxExEYxp21/uFmHCkOUlbqoA8b9qo3UWLugH35/gXzBWtuLt4cNeUgVFPITREA7fQpc/i9Cd04ZWuzd4KFzIOI6yILz3C71xp2Tp1NBoiH4RtQRrxDOXCWB8KCvGGP677DUNIQN2CpNFyyCCr7kw7GnRWaxhzkNjfJpb1PUQF9CJ9x1vjsMLDjghjk6pDgiWDch3wWhQ/SDX+LR0Rkz4hg5XFs6w/7w2f3d5zyvi+snnJQE909PslXAn98IzN2ADadX61RUkW/kWn8RTOooFux+ap90ubr6jCf+dINuwP6ZaiprM824pjb70bFCPKmE/YOIBl2TfPPkcOrwkrmPyR0jBJlWvMIjKOpH4DxIDVf27rQvgq3gOScKys87PcOGgl27ukov18Ui18LQhZ8KG+NkiKrP8/yjzD3U047+MhnGKFbep4pJrOLgM6rkbsR2FvpM3/R77hBBiowdGADAUF3kCLcWYMVEeFJZ64tH/o9uA8RS2Fpfb NWnNslP6 2V+cqz1OFGwitBgqEc8jIaw8ygNuX40u7JZF52HS0HPZa3H2IqhntTTcBJ6teMFkIEUC0or84Y4ktd7XHLejqYetN0IRreaB1eYXG/bg4pRf1zAQnV9IevCqcivA1+3ZVoagt37GeUPqzZuNqkSY4El6XxM8x/cwzY4CgqJL932sZ8tdEzya7rWmLUS3q9qF+L7/mU2k5orLVm4vejdCsvrt6x76FpL9k65rVdjHYn8x2C1WIfBECKN5J4rzhhGSbuKW0Qmm8eQfMo93bPW2LPmmbxo/F9BHIK8hKaQjz6Dx0j4to5Jw5cxkX7e3TpltvJziphANgUalZt2leEE0SZUkf0BQ4+m9W6cAps0oBUQrMvCLxWINI/FvycEKYwe1NxT/GmSq3Qhnwwn9Ys6RrQU/yY/8wiG5GHKPwq2EtYQ1PvWTTlpBRUtFcaFRG5Qz3BtAJKZKS7+Q7y0PN5crzdPQfbw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000345, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 04, 2024 at 07:07:20PM +0800, Qi Zheng wrote: > --- a/arch/s390/mm/gmap.c > +++ b/arch/s390/mm/gmap.c > @@ -206,9 +206,11 @@ static void gmap_free(struct gmap *gmap) > > /* Free additional data for a shadow gmap */ > if (gmap_is_shadow(gmap)) { > + struct ptdesc *ptdesc; > + > /* Free all page tables. */ > - list_for_each_entry_safe(page, next, &gmap->pt_list, lru) > - page_table_free_pgste(page); > + list_for_each_entry_safe(ptdesc, next, &gmap->pt_list, pt_list) > + page_table_free_pgste(ptdesc); An important note: ptdesc allocation/freeing is different than the standard alloc_pages()/free_pages() routines architectures are used to. Are we sure we don't have memory leaks here? We always allocate and free ptdescs as compound pages; for page table struct pages, most archictectures do not. s390 has CRST_ALLOC_ORDER pagetables, meaning if we free anything using the ptdesc api, we better be sure it was allocated using the ptdesc api as well. Like you, I don't have a s390 to test on, so hopefully some s390 expert can chime in to let us know if we need a fix for this.