From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6883FC6FD1F for ; Tue, 26 Mar 2024 19:25:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7B3D6B007B; Tue, 26 Mar 2024 15:25:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2C076B009F; Tue, 26 Mar 2024 15:25:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF3016B00A1; Tue, 26 Mar 2024 15:25:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BE92E6B007B for ; Tue, 26 Mar 2024 15:25:12 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7E32AC0DCD for ; Tue, 26 Mar 2024 19:25:12 +0000 (UTC) X-FDA: 81940168464.19.000DDE5 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by imf28.hostedemail.com (Postfix) with ESMTP id 841EDC0007 for ; Tue, 26 Mar 2024 19:25:10 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=b6Z2ws5C; spf=pass (imf28.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711481110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1xHcSlRlsL2MMtbELEV9tvcgwC1xTcE9YjZjsSqQUc0=; b=Su359zpqIb69IZJ+3Q/4iELJCmyzHeml2afq0HaY84cZ+gTuIFNoi8AsXuTMwsR4jWsN2A fvG1RoJsnvC36KSj+TyHrmoMhCPKpl8p5TGYfN3cwgybtL6LO4twyWq0QBgbfQylNPh6R8 ZumFbexOWI4jP1luKaap4ALPFHRVulw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711481110; a=rsa-sha256; cv=none; b=mKIWA4j2DLg4BqX8XC0D8UO2w23XepfHxgvyOJwK5bRR9htXBq7cfP3iUkF28fhSSVLYBg Wh7GhaHDfeFKAdagLV9RHR5Dre0DQjmlTUmTl1hm3qwxnm+n8AcI+b/Br21lL44NgfILKX 3BSczVVL+qaLDPIViEkc9Wzi0Yalmpg= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=b6Z2ws5C; spf=pass (imf28.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so4226918a12.1 for ; Tue, 26 Mar 2024 12:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711481109; x=1712085909; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1xHcSlRlsL2MMtbELEV9tvcgwC1xTcE9YjZjsSqQUc0=; b=b6Z2ws5CIVUbZXOqYD0r8yKFOEaCilPMy0zvaJ2rP234zkNBJr9me02iNvjNdNXjzo ZyniIW7k7Vtm8FTnjsbYSLP+iYRecWDBGxGq2p49MockTgkAvQRgwPbz6wJBncu0A/rr vaZ8pp2+zPv5gEKqr3VBuL6j8wrfc7DjiUYrtg6pk4syd9CFn88oj+Wyh1tAgF3hGDvl yjcRb6Vafk0Q4K3569Hpl6GNLen86hxtbTUaASltyGmx/iu8uLHrQC7SM9Nm+lQt9lEe FOWQ2RUAZ7ZNARoPC6OLhRFdEU3CQ5MXrA8Hk0OZ2efVfUCNl8eOZk5QkvJxwElvx6Kd QgKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711481109; x=1712085909; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1xHcSlRlsL2MMtbELEV9tvcgwC1xTcE9YjZjsSqQUc0=; b=Q/OJ3pKFX7bH3QS/+nOPf0ZatKJ9rFWES+a9n971Sca1+aTO1xc1VZDBXaWLWjd0dX QmtoNJe1L3CO+CDoT1YvZL4k/EbeMqTF43zmhFsisx1wGFZdh9xvgz1kMuVj9A4IGRvr R8GvNIK4Qm2GkjpUvp825+QDbfCY+grfwMdZJZtr0HGq5JDjU0V0zyxr178qqXtXdPwr gKclEU1ZQazYeb4MgvZpXLiCMnlAS1K+OvK5zdPPnhTnSmbGwTaJcllgEFs/dDSzDxc1 lcHbk93wc08cVh0duga+BM9K2e/xCL51CrszcedoB3wYdbs7VzVj9jZFEkbHHJhOKxpw 5GKw== X-Forwarded-Encrypted: i=1; AJvYcCUUFR9pmfACLjj7J+DIU7PDmxsTgS6Fr+8b4+kddnuZreeOqidJe0UG+dUpTNUYCSmeArHoktRqjxHz96Tj/aedtFY= X-Gm-Message-State: AOJu0YwmVlXUMDDiNdUQ/1BnbuA60T9iOQwxYD7wk946MNU92qKCyCvN idZVSEjktI6PT+pEgraDXNzPfOsgsSD8ilBKMxhhijZBiAeyh7NI X-Google-Smtp-Source: AGHT+IEFNXe6M/FjjmkT+Pzey2UZvruczwOvB08e5gQq6a7X+FamiRz1uFsQyhIOpxd+4UlBnKbPtA== X-Received: by 2002:a17:902:e807:b0:1dd:8c28:8a97 with SMTP id u7-20020a170902e80700b001dd8c288a97mr721240plg.6.1711481109313; Tue, 26 Mar 2024 12:25:09 -0700 (PDT) Received: from fedora (c-73-170-51-167.hsd1.ca.comcast.net. [73.170.51.167]) by smtp.gmail.com with ESMTPSA id p12-20020a170902eacc00b001dc3c3be4adsm7205550pld.297.2024.03.26.12.25.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 12:25:08 -0700 (PDT) Date: Tue, 26 Mar 2024 12:25:06 -0700 From: Vishal Moola To: Qi Zheng Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com, rppt@kernel.org, willy@infradead.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] mm: pgtable: add missing pt_index to struct ptdesc Message-ID: References: <283624c2af45fb2090b41a6b1b5481bb0a45bad7.1709541697.git.zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <283624c2af45fb2090b41a6b1b5481bb0a45bad7.1709541697.git.zhengqi.arch@bytedance.com> X-Rspamd-Queue-Id: 841EDC0007 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: gutext4q7kau57nh3cgr4af5twr8xhdj X-HE-Tag: 1711481110-973392 X-HE-Meta: U2FsdGVkX1/9yF0dHQPLIAOmATQ+nhMoPvA9B0skFMe5QQzBXdSPwPo2ycEE+RQfWPOHVVfMgswxvz0dP1ZfkIflKvixyi1UBu/Z9iYqdTyuPkP3AMax2s3mY9zi/LinAxsZPOuuE1ID9AHtR4RqPcjO1WiZMV7boEF5MeBvkP4pgENogZKd9+eV0P7iJFJTkVro58qoa/UXOAQARlPXFFHSeirDxt7ORRoeKvt+sxjLjbn3y4tV+MmI+pRAGWcSbImAwqI3A1apmNsd14EsvDQ30h52yvkFDZuhrvrJSLGvlZaYujCE1o1VPSxixFM1P+k9vLDhPfD7JBswseIenFgahdb0QFv+X0C4W8nClZBQ3gXOpU0BciX36xKo6Q+ekn2NC69FlwyiUYun6znU6Jk0dnOUVcXI1BHB74WXfZ37pcWORLu2FtDDggVtEFgAeDIZLc0CF/6apVI7oreJ6ZKFd4e6yIgl9kA2671rMLRWqkZHsCXoYlwVwk4FWIDd/j1d3Zav2gPyTs1ScWD/TRESbm3BTrYqzHdjPao0d+jwahYhuhGMqi+EovC2oZFDt9OxOzIglO+KhnLPm2tgnPYFonnbI6/tU6kAYFSm800oQc/ZM+Pdouejcnf4GwvXIAaC/IqgBU8+xsIARQ+ugtSYCkQfi30WIyUfyfoW/3kpALa3j6agohS4Hd7ygeMgzJLBNKzU3Fxh0FPDYYnL+IGDnOG4o0RDx0WgFYsjWaYEBS/++ywmt6Io/+T+ZCeVNBzuje7bzRc1AZBibC49abTVb/E3WinfACMlIFFefUtQMA+XFWwQoBkrwTKl4sQDlYqc16fKoDaDAD6QoyYJqridvF8pkDA+pQtpSCzB9VtlxFooSjEFOiiYklz/P/nQYrR4QQkvff8A4QJrI69cXrv6iUkSGg9ix8KLoB6323jOI7R8w1QaeaWlgdawlUVHuVS8w4C+iClkGQjTZAG e/grKfSy 6J5zAjXZJMBYbByOKNcLwxmEb1eD/BKQKmSjnTbDzkY+BECnxuBD2XrHIkL4CI6BLYl/Sv3hzQyK0IRuNiFsKcJuZ2qEuf3cQxFDrk4dedN40vgPO1eqlNcIGcyKNQKp9IBts31yYMHcoKeTVkh17YW3sLeg006YW4aNwXOR4ifRrz09GhNQT2kNXiRwGdNbAOmGu6AhIwu1Giah0UljPa/gdvmdIjk+PaS4p0TGAfSEXmWn8C4guCKCeWyg9rn3RaSrmV7FbwU0JS+A2sot3ZGoYt6RMKo/5qCBeRozNG/NU/GG8YqPMoxPsAVlEqnf3DH2PZ96poBfGHij0lNUk59MksyFCj9qLJ8JLbttgDi9jGOOeyd1al9vhRDsDucBJy2JP7tRVkUPOZHznzjncwVYnlAY4TVh5iw0bbkAzh6f4w6n9i+EUWqz6NWds7zcYiIGJ++caQa7vnLeTEuQGl2VhdnteMRyg/hdrZWs+ANaVQiZ6a1qZsnad9lAWeo/xlZtDJxZNVw8AYTjH8r9/OLd+af7U4/2aa4oFUlHVDJDVnX+CYMdWCURSjtdObE4fsYPTkab773P3toC06cD5Ao6lmKzvOjaVs6szZ9u724y4YCT/f6psZnQASb45xzcJ3GfycwInLKsATD8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 04, 2024 at 07:07:19PM +0800, Qi Zheng wrote: > In s390, the page->index field is used for gmap (see gmap_shadow_pgt()), > so add the corresponding pt_index to struct ptdesc and add a comment to > clarify this. Yes s390 gmap 'uses' page->index, but not for the purpose page->index is supposed to hold. It's alright to have a variable here, but I'd rather see it named something more appropriate to the purporse it serves. You can take look at this patch from v5 of my ptdesc conversion series for more info: https://lore.kernel.org/linux-mm/20230622205745.79707-3-vishal.moola@gmail.com/ > Signed-off-by: Qi Zheng > --- > include/linux/mm_types.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index 5ea77969daae..5240bd7bca33 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -425,6 +425,7 @@ FOLIO_MATCH(compound_head, _head_2a); > * @_pt_pad_1: Padding that aliases with page's compound head. > * @pmd_huge_pte: Protected by ptdesc->ptl, used for THPs. > * @__page_mapping: Aliases with page->mapping. Unused for page tables. > + * @pt_index: Used for s390 gmap. > * @pt_mm: Used for x86 pgds. > * @pt_frag_refcount: For fragmented page table tracking. Powerpc only. > * @_pt_pad_2: Padding to ensure proper alignment. > @@ -450,6 +451,7 @@ struct ptdesc { > unsigned long __page_mapping; > > union { > + pgoff_t pt_index; > struct mm_struct *pt_mm; > atomic_t pt_frag_refcount; > }; > @@ -475,6 +477,7 @@ TABLE_MATCH(flags, __page_flags); > TABLE_MATCH(compound_head, pt_list); > TABLE_MATCH(compound_head, _pt_pad_1); > TABLE_MATCH(mapping, __page_mapping); > +TABLE_MATCH(index, pt_index); > TABLE_MATCH(rcu_head, pt_rcu_head); > TABLE_MATCH(page_type, __page_type); > TABLE_MATCH(_refcount, __page_refcount); > -- > 2.30.2 >