From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75279C6FD1F for ; Tue, 26 Mar 2024 19:12:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 107A66B00A6; Tue, 26 Mar 2024 15:12:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B84A6B00A7; Tue, 26 Mar 2024 15:12:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC1EA6B00A8; Tue, 26 Mar 2024 15:12:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DBC896B00A6 for ; Tue, 26 Mar 2024 15:12:47 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 83DF5120BF7 for ; Tue, 26 Mar 2024 19:12:47 +0000 (UTC) X-FDA: 81940137174.11.868B676 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf17.hostedemail.com (Postfix) with ESMTP id 957C44001A for ; Tue, 26 Mar 2024 19:12:45 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mJ5pbA6r; spf=pass (imf17.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711480365; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2mGGrWWfny8vxYTsDd25f9lyrs9ggkVdG3oXeLlTXYM=; b=5QG01HFa0ypbf8N8w6qxwTCtT3OofN7w/kI91R1DNCMjKRZyFUqiR6qcv6SAWAGH8pDPxn PiZo4nKDYlifd5rCCsfKmV36xvpVtrUufzlRDqLXOs0gWWr9Pm9HzyW3MZvAfL/Cp/a7uA U+xoJE4dVZLHmSdIuGn+zoXReXrMEkU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711480365; a=rsa-sha256; cv=none; b=Mpi2VkAkxhR3gOFni4pjYYCtXIZBmz29aCiUY3/UkyRiLS3nhE64qLVWN+k4TyEXuxAcJM CBvtiZrYXDrtU6FvF9SQq4yhFQXAfA5kO8gOgbs890FgXd6BVtneqbDgbUE7dBITpRYncM y3uZPf4xQdUFtcYlJ/AnehWBFei2qao= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mJ5pbA6r; spf=pass (imf17.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6ea9a60f7f5so2730363b3a.3 for ; Tue, 26 Mar 2024 12:12:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711480364; x=1712085164; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2mGGrWWfny8vxYTsDd25f9lyrs9ggkVdG3oXeLlTXYM=; b=mJ5pbA6rbxo9hFcbOHXEhxQnRFUVydymfR0CmSkbUux9BeQ+91XilqWNrMCj5OXbId Ux8UeNugLNm9j3tuguIHb+h9PK/uuptbpy6uvxqYcz1SyypZ5i/FpP6g6QpbCkKHNEuV 6ABjH9/mj+/Xh5r/dnEhcSBjvfcnFBTuCysTw9xRSxMD/rzahzroOqQAk68G9GX8axjR pfu3ypJC+31m+TCuteZMiXZDcoCnJO1X6wZkMbUVkUzrYYvPVggYgIDCh5UDoudOfiQz wwdjtV2qYRbLO8CehL25RNogwNHroqLTJV7tIBQD7Gh5CfDTELJ/N6CbNPJBX4F3wtSV Dcmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711480364; x=1712085164; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2mGGrWWfny8vxYTsDd25f9lyrs9ggkVdG3oXeLlTXYM=; b=gGyaYeqLXmPCMY3Z2b2U0fuaawAxapH188+s9SAlgcSNJzRy7amAs0AEFjwqPIafwK 3MoEEVBgxxswYb6aAYrFtFKCJr8NdXqTeL7oHFtEWGOE07WmDekZ0TDCsRNAxl0+06zA QNL2uQtGGXsMj9AsXsmuoKlVowXrWDZ8Gk0im/pECRyeTx3B2OZTeVytQ5qo/Eq3ozZ4 wBoOuKr06mqQIAfQy8fUAiOWsSCN76dUc8O4nIQwYSfAPediDjLQFSjZscg9Iyi3U/2j rHq010fpo9MsN0eDlTa2JeIXh+4waGXXcs/PPuCXU5RNSwtOfS+AinBkNltsvBn8LtNq 3kwA== X-Forwarded-Encrypted: i=1; AJvYcCWrLZXJqsES5tdUNKCyMhKDTejWHgmF22G0O626bnKHpCrQvXXiwJE4rCNSjO64xxSbAPuXkPFKbOFkBxtcP5Jp3IE= X-Gm-Message-State: AOJu0YwFdwnZIysl4JDpiR9T4JnX+XEpDIPLxOKLXnjTe+q8PglR7kbD B9LueS6s1QwG6X0npOkBpSwz2o4WpaSRSFWES9sSEDJc48+ZDn1l X-Google-Smtp-Source: AGHT+IFHfMiy74Z+cK5cBKPwRlRvYXQIhGOGa27FmCmkRGifSL+EkOPIKIVsrTTgU5r8UJwYJlp9Dg== X-Received: by 2002:a05:6a21:3414:b0:1a3:6ee9:305 with SMTP id yn20-20020a056a21341400b001a36ee90305mr684773pzb.2.1711480364175; Tue, 26 Mar 2024 12:12:44 -0700 (PDT) Received: from fedora (c-73-170-51-167.hsd1.ca.comcast.net. [73.170.51.167]) by smtp.gmail.com with ESMTPSA id fa4-20020a056a002d0400b006e53cc789c3sm6336352pfb.107.2024.03.26.12.12.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 12:12:43 -0700 (PDT) Date: Tue, 26 Mar 2024 12:12:41 -0700 From: Vishal Moola To: Qi Zheng Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com, rppt@kernel.org, willy@infradead.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm: pgtable: correct the wrong comment about ptdesc->__page_flags Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 957C44001A X-Rspam-User: X-Stat-Signature: 6sq1frfqiqo11josn9w47spc7kfnorck X-Rspamd-Server: rspam03 X-HE-Tag: 1711480365-819744 X-HE-Meta: U2FsdGVkX1+d/huMAWMPWwz/Z+j+7lVygTp73UNPpvc7U/K9L7QgLzrIszIREcAmIphclHCmEhyyM8mKGnlijdOMtQDnxZ7DeaUTGSb/4alPPsS1Rs+6wggdLOVrdTMMhHwDs/JxrH1XsaH690TiT1iTgh9lXVmBMYMVUqKb8btwMGU8PVtKLPqkaLcKTAlsd+imLDTCrvbGWw6DtsBY1Nqdiw8P/Q2E+b97Yjm21CI6/KXO50PrRbMPsZFFFf9to8oipRtFRQ7B6cxcxoekXU13M/qiXCmozoyLVqA9RRr6gxIbHoPPeRyc/hYty8fqhbP5tPyv4PiN39Hl3NpPyRJFl79sOT3Yj4iHiB6Xc6i/goZX4gUXYlf17U7I7Qzqk+TmxFVCr1HWK+GF95f86T6dTsmIT+bIN6LIfbvaEe4TQsHL2NmX5LkKwEgbw5b2l707Oh9sirWgjoUmHQ3sBw5Tbz4e7+kaWYDIeNV+GulYQzVoC98NFQwhUZPib8T94FfaDebb9SNEZzQmWcfuo7gU3F2nI7mAP89GCge4QvZFb+zRWp9RTD3ff9eG1iZAsC0AhGYBa4sxljPDAKh7t3cWKxlX5GjX7FGaVu8RTeh+CqnuLaLjoW3N2ZJY5gkTtM9YjMJ0/jAxVSOSUm9zyUfiYB4IsNyyTFGq/9IzNQUUKYb6x0jGY31eSgQnbK1fOliuxrq+2PKPyM+psl/LaP8fs8USuJJw+za1UN5wuxYs6CTknYTLF+lPztPMm7q0uyAO+sTQj0ZIupTcE1vfYdnH09cSnKXyfBmLUqKU6ZpLiWwUcUtKO8pOCxDBVurx1jWMDLocCSlxKmaKHNRFhGYmuywkSz4bHaFOvueJhJU8/Zl5Yd2vV+2N+VSTOen1wQxOo2LCbNX8iAykCVnoWLCFb6A++hxZbtjc62x7anJRtB/o1Y/Q1gWhEdD+rak0p/hO1ufAxJB3t+f+zBW NB5hLsnY YuLVN/5z587/yaaCuoUhOkxdOeaH7236xC7XAtBWv0fjRiNtkgjCZwJuhePeD47jxHvStMSkjVLf7dzlqtEoIwMlTuKxKF3FYUvm4ouaZzJFoXuAD4fbewAmIFobyfZ62dk5fdwleBOeLqGWr3od7Qz1RiZB0eduYRqQAnZRzOfLNOg62eaYKswAdgmV2DA4Q4sLrkRTgRM0cY5YMmUCuR+uelsIrOrjsScdxRz9uXuTZoXbZ4ou5/96tJ5K13BjLF/LT0Qu23VVOBzInfKEsYDwjDeCGf4rX1rDbXp8PHG0YqpMb1IRBZnfqRh+8nKMSS50eXPv2OVmXLVylWEckDNRJE3o9sNFLOGx1tmTSuW+GTnVyGKfELUx9ZhZVgXPyM3Oy1/2QBODGfJsBMSnFWaK9PVr3mf0f+yqhAsXJhoHB9MUzGP990Cb/F5tSKL14FZ2ckhnLzZkVo1eDp/s0wNXuptwSq+pzwLDhWx3y2rzea6K/t1kWlt8JbXMkaPE1Z3Vg+8FVAPwuCj2vXx/IEnAN819BWOcN18mWuyUuAHZBQQ+FBr2tgqlaiyCJ3t7k0gmsV2d7ReB4QpNQkCahB06rMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 04, 2024 at 07:07:18PM +0800, Qi Zheng wrote: > The commit 32cc0b7c9d50 ("powerpc: add pte_free_defer() for pgtables > sharing page") introduced the use of PageActive flag to page table > fragments tracking, so the ptdesc->__page_flags is not unused, so > correct the wrong comment. Thanks for catching this! In regards to naming, we're trying to prefix unused variables with __underscores so I'd prefer to see the __ eliminated from the ptdesc->page_flags field here as well. This doesn't warrant a fix as it is already in 6.9-rc1, but is something to keep in mind for the future. Aside from that, LGTM. Reviewed-by: Vishal Moola (Oracle) > Signed-off-by: Qi Zheng > --- > include/linux/mm_types.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index a7223ba3ea1e..5ea77969daae 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -419,7 +419,7 @@ FOLIO_MATCH(compound_head, _head_2a); > > /** > * struct ptdesc - Memory descriptor for page tables. > - * @__page_flags: Same as page flags. Unused for page tables. > + * @__page_flags: Same as page flags. Powerpc only. > * @pt_rcu_head: For freeing page table pages. > * @pt_list: List of used page tables. Used for s390 and x86. > * @_pt_pad_1: Padding that aliases with page's compound head. > -- > 2.30.2 >