From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 415E0C54E67 for ; Tue, 26 Mar 2024 19:07:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A06366B00A4; Tue, 26 Mar 2024 15:07:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B5F36B00A5; Tue, 26 Mar 2024 15:07:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87DCF6B00A6; Tue, 26 Mar 2024 15:07:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 763646B00A4 for ; Tue, 26 Mar 2024 15:07:48 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 410E240C6C for ; Tue, 26 Mar 2024 19:07:48 +0000 (UTC) X-FDA: 81940124616.05.48C8607 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf01.hostedemail.com (Postfix) with ESMTP id 5DC3340010 for ; Tue, 26 Mar 2024 19:07:46 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=das1rrgn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711480066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BlKH85coPfvLXGKgP52Ck14DTun5Z9ZO3eF7ngWmZ0g=; b=GdqthOc7m84QwGprJILMCiH5JGgQvvmChBdXyBQ7hVpTUntlUwCEC3fIvr2/ndbFdgqQLn uCSQBd/3aQMw7ykSeY5J6h03vlvKnC+nPIQF6lIASaCubktB7vcIpU2YxlSp7oUnO527Pa cqy5mOfrUe0eoBZDBAzmEwD6DWnSrp8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=das1rrgn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711480066; a=rsa-sha256; cv=none; b=V72u5mAkTYZn6CI4Kls6XdqXVHJ8J5cUK0rXc37LM0aXBE57BdjJKn7sdb27s6c1AOx9gD YCeaNIjrOYWoXBzGSXI0Ih7nKeAF+qJzi5iDQiVM4fh1JQBIPqI31YK2DjhGjayjjucEu2 oUB+rLR0WxjO0vuXguldTaParOKj9q8= Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6e74bd85f26so4709918b3a.1 for ; Tue, 26 Mar 2024 12:07:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711480065; x=1712084865; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BlKH85coPfvLXGKgP52Ck14DTun5Z9ZO3eF7ngWmZ0g=; b=das1rrgnn3jebCCHmtdu8RB/wsLxXUFJmQNi8xTWa/hgtCv12/zmUuJce/9VNVjksZ 55ElcfakFqjjW5pB8oSP9h07O8UyMRHxnoqwdsDN68ET20Vf69ar85oIYG56k/C+LGd3 DmlOoZ5eUxYo7LQNMcDu8K+xVAlOj3dWLH/wn1NpM9V4eL86AuvnxztZzStNUBGcGS1H ZeFq6Z47rH04lE+B49KWT6BGnNAUHQ7fQjnFI1Auz6nO5SC2D0LS4Uw1VImi2ifRKqOh GSf/6mOVQian7iSRdHMW/TFFTiSynmmep3lBXCUr7uGsK95wRVfEWFOXw8rxk9jgzem0 rM3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711480065; x=1712084865; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BlKH85coPfvLXGKgP52Ck14DTun5Z9ZO3eF7ngWmZ0g=; b=c784WNeeD9S3M5oVnXMzRoV/YkADAS8TGjBxr6DYIEw5AMYjxQzeN673Zcw3Zyb3P9 2lLD0HL8CY0AI6Lw0lnl0m3pHOS3sKussUI7vkLcBu8EhHOt/S+1f3MOQ2WRE13yWmXs MLmqQuaku+WaExU3hxKjJ2abR3k+9NS1QQsfi2P48baRLq2y0e8Ttujm8Z+3tPZL0pwE AZzFoaewpt/KO2jgpXug+gzAPiC9zaJSTO4GY764mOtjQs6DUJAyXVjkqrdelWtGEd6i vMmu/P8CabSUGDw54idmlLisiXMY2gtbB6HzMLrAaI433bnwksaiCWkUpT4daWDtb9tQ TXEA== X-Forwarded-Encrypted: i=1; AJvYcCXSfsatmbnSQ65i1MUEtcLAZFcZT+EWOnlULb53v2RfT20rRJ9mzZ/GY7E4rnUvTG2pvR+GNuzK0RBK8zzKpz3liz8= X-Gm-Message-State: AOJu0YyGdhuUmz9kKhYJUVSOe20mE4rz4ZWP2bQxPgYCO0QQrvhmXYA2 QWrj1sq0t/u6+m32m6+DO6QlHy6kg7Rww0CDI5/5QvJtxHidxwFX X-Google-Smtp-Source: AGHT+IEEFY1XjrNqa1/3v96ZwnVdDhFYP1oZvq2A59ICrpFz65Qv+OLccXZpvBRh8GpimnMYhACUuw== X-Received: by 2002:a05:6a20:1a07:b0:1a3:5c60:112a with SMTP id cj7-20020a056a201a0700b001a35c60112amr395260pzb.36.1711480065179; Tue, 26 Mar 2024 12:07:45 -0700 (PDT) Received: from fedora (c-73-170-51-167.hsd1.ca.comcast.net. [73.170.51.167]) by smtp.gmail.com with ESMTPSA id y14-20020a056a00180e00b006e68b422850sm6303432pfa.81.2024.03.26.12.07.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 12:07:44 -0700 (PDT) Date: Tue, 26 Mar 2024 12:07:41 -0700 From: Vishal Moola To: Qi Zheng Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com, rppt@kernel.org, willy@infradead.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] minor fixes and supplement for ptdesc Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 5DC3340010 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: j7twjtm8o999uhhmdddyingknsxiwnoe X-HE-Tag: 1711480066-976161 X-HE-Meta: U2FsdGVkX1+AMI9NEPiWJxZtoStzYlVHEgOsL4xpFntS0htP48M+zEhB8h8ND7FQaxly0gehV6Rid0YVyDfAjaQVcC9ebbVOmwu8AB/gWZUG4rQM5+JMsYb6fBMXO0O6PC2AMy6ncEXwcLz245KiNDBojKNyGsFqGvLHrrcjjJG+VYPzurY8dIwWk3CLlr0mHXE0KEVXEljGmdNhTqwcVr+cnV60QABqmTBY/UjF3dWJ1nRZ61olwuH/7WyDyej/nulkydDzECQhm7sMA+4F/+PonLESX/+BvGWQX6zdxJzVOEdmsQjtko0atO2jruDktR68Zfb7B4YAm/JxFfRzyT7V27pxFLi6Fy+slEt3gd2fmk+QZLKjXbCBTulmV9+gJvc+XVIVmgMeYipMngX+wy46mM5eivW1Teo54hujrUFIW8m5rdfmL+lTUGs9RUHcduyqOXNcGC15ADRXK+nav6LqmJy5dJuhZVTAs8gsS8N6Ft57YcFjCrtIrjQ4UCBAjpL4zAKTTh00oystlqZlAXpQvvDJf4h6ElXfYTrudHD/8AkKvq+7/i3IF1h9Dtn+JMqnIybKdeXnRxhGx8v/cc0VRbJwz5lCwZ3AhHu4PhNjEziZINpVyHDVQW0Au1qX4XJtkQIohTz+xG9jaFA6leKQGrdjqttdBrq/HxDZAa7RE1mCb1P6D9vN9SlBzxXKFmGyrf1hluWlitYOkNmbyYEu+a5sdF/aqsRa0Y49CgvUPWooaz+z1cs6EWQoU6kN/M4+kPae1Li3FspdnADi4Jg28yccYBgvoCs8dgVzFnvIYSI3zvwJN1g79ACbQ/qV5w+uZ3oWqU5pAUHvHkhY/m6zJAXo58SgvAGFiVXGa6XEm7ahBJ4jJFNSy12mmXtg5yKEnBe7hodEs6+HzLGMFTHcTuX8N6lXccu2U+fdPUZek8CPfwbI+KhtviLwAO7pdNvrYLzM9vZe5ABOH63 HgdqShCR I0cu9mFjjdDKO16Xme0ifWKjM7bbhHXjTJrla5dMgg0smfDa/y1ruuzTYk7QupICotCZMmdMnMZEIAFYhm+uzPy1IW6EI9R0P18yiI5egwdd5TwMN8/jPe9VkoDI3ZR3+r6dH8vH2fNFewUPOtPDr+nXN6/41MoAaCu1HpgA1J6sPzfPeYHK+QAOrlwOnBK/aBicOsLeRmEQMZvZpqXZ36wy8zxHDqIHe9okhdtzwiG1IdMU/1pFx8xVhFFIQ/dK9FIiKtnkrGUkXvMxLYkNzlUbwzS9XgQAbdhbrZnX4+fPprTZbYAPV3dsy01McJlWm2Q2DX6d9Uo1QlsIzOn24qG+YF1WmR+r++k//iEmQ3rDr0Sbhuko5s1nVK/jziXpavLEV7qRScWu5l6NFt4zh9r4Jlj2pRrfbIF30GwmMB+BkT6qNp7t6ZgwEn0PPaf5K34X8Df13J4O37fY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.362627, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 04, 2024 at 07:07:17PM +0800, Qi Zheng wrote: > Hi all, Sorry for the late review. Thanks for looking at doing some ptdesc conversions. This patchset has the right idea and looks *mostly* fine. > In this series, the [PATCH 1/3] and [PATCH 2/3] are fixes for some issues > discovered during code inspection. > > The [PATCH 3/3] is a supplement to ptdesc conversion in s390, I don't know > why this is not done in the commit 6326c26c1514 ("s390: convert various pgalloc > functions to use ptdescs"), maybe I missed something. And since I don't have an It's important to keep in mind the end goal of ptdescs, cleaning up much of the struct page field misuse by standardizing their usage. s390 page tables and gmap are similar but not the same, so the conversions require deeper thought. My initial "Split ptdesc from struct page" patchset tried to focus on the most straightforward, simple conversions in order to introduce the descriptor and lay a foundation for future conversions - you can see some more complicated iterations v6 and prior. When converting to ptdescs (and any other newer descriptors), we should be careful about generating superficial code churn instead of using them to solve the problems they are trying to solve.