From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FC42C6FD1F for ; Tue, 26 Mar 2024 09:26:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC0896B0092; Tue, 26 Mar 2024 05:26:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A6E3E6B0093; Tue, 26 Mar 2024 05:26:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 935D66B0095; Tue, 26 Mar 2024 05:26:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 853BD6B0092 for ; Tue, 26 Mar 2024 05:26:02 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 495A0409F8 for ; Tue, 26 Mar 2024 09:26:02 +0000 (UTC) X-FDA: 81938658564.05.FEF11DC Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf08.hostedemail.com (Postfix) with ESMTP id 81802160013 for ; Tue, 26 Mar 2024 09:26:00 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=H12A+uJ+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711445160; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S/s/izCv8l/CUU3NLEYu5XonJ7bd0ulz2Xx91aG/m8c=; b=p8EawHN8u3TRirfSWCGxPcVHhtBjMHjmjVWdYIvkoOtgg4BLGSQIVrftqsIjGJfDhq3NNu ARDf8+9UKyIAGsapZUY6/QlotODCfn3LAmCXh4eZgXAV3vFozYR2w6EGMJ5/74IfQxHbe/ qTbYVB0hMcK8Z1FGug51DDP+UXUJAfw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=H12A+uJ+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711445160; a=rsa-sha256; cv=none; b=apCqRqZTugn1WNZD2FaeEIuAJAE545O55adsDmyW4Iz6Kj5Sr8A/v1lQB2H8kIwMw+RR1T 4l9enVguiyM35uJAwmhGRXVgBS08r9M14CU326+pjL8HGY2eyp1Yj1Kio87iQbpAIf6h5P hSm5py3dfRF3E9xX6oCp6TiLudWng0A= Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-513d599dbabso6917102e87.1 for ; Tue, 26 Mar 2024 02:26:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711445158; x=1712049958; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=S/s/izCv8l/CUU3NLEYu5XonJ7bd0ulz2Xx91aG/m8c=; b=H12A+uJ+/l6GQrg6KfSoZe8LWJbKSECG52/tJ2yHew4gTDxyiKn1GgkN84kxGLlCbm TsyL3oLuDc8r0bknVz1QXon7aErpyNIWp08wqlou0n+Pha/BAzl5+HEz9FvVG1q/9XEX SFHPEgjgWNHFwsQZ4PYjJoH8/223TrdbiJcobIt5LY1cMtx1dvviOn5Ytnq5ZkpSgMp+ D9yPndoo4MOwFiQzVbfWb6PenoObJeJerdR5kE56ZNwiAUxCyT5JQsvoLuWuIl6FlsSq WFbXdUSndz5jgQLcK1fUgT+2wyAZuznCaCdqUcSZmLWy3KvRysF3wM0UAPbB2zl7Uegr URsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711445158; x=1712049958; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=S/s/izCv8l/CUU3NLEYu5XonJ7bd0ulz2Xx91aG/m8c=; b=P1o+L5tNhP0fWf7oXO35nB81mpgbUFJOo7Bmda0sv7GKD+TJRpzfzZpYeRPgTdVvWN o6U5ph6WubUr+y6MnPM7wJYFKH/+7RPHfJ5fd5RUm5tuvEU5Uji3t3eR547oPoyi/YVE AHXrmCr41yeoh7phAeWY4TNGhO5YN6bopEGI7VJx2KQjh/dVHYRwrU1zjUNBau1PYFYC HYjvL1y003rCBUcJDl4/nG3O+BQrKZpJ5oeRMEt7PdS9ppZjPIBdj5JscQd8Cq92Fm78 FdAFdQiOu9GsWz18JYKsPDFOQFQGyZU3zqENNh9Z/3Hr2Pya/UE5FMQsqvN5Buw1KAng nBpQ== X-Forwarded-Encrypted: i=1; AJvYcCVSxIG4EvvQpdaIlKgOQDyV1Ns/G8foTgHf/h4xSddB2xliND2vRebJEk/9ciffmpeKSjxCOjfm1CgipdOQgZ3avGs= X-Gm-Message-State: AOJu0Yz0e65yMnufpJxozsBKN/rwJd8+g+46ZxFyyhK1VlFyyhqAv4lD ZlNtx4SJ+RGwKlHzb4MxpE68D6XLLxs0XdcHWWSaooVrf0jZIaUQ X-Google-Smtp-Source: AGHT+IF87zu4brJ+5iAZbQaWGSBNze4R4O/ksvb/NmXpkbjbP5nWtRpN/HYTqcHB+naRpQ9l0V+qDA== X-Received: by 2002:ac2:5b44:0:b0:515:8bde:56c3 with SMTP id i4-20020ac25b44000000b005158bde56c3mr7000385lfp.26.1711445158261; Tue, 26 Mar 2024 02:25:58 -0700 (PDT) Received: from pc636 (host-90-235-28-241.mobileonline.telia.com. [90.235.28.241]) by smtp.gmail.com with ESMTPSA id i1-20020a0565123e0100b00515ba4e47b7sm64694lfv.188.2024.03.26.02.25.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 02:25:57 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 26 Mar 2024 10:25:54 +0100 To: Heiko Carstens Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , Dave Chinner , Guenter Roeck , Oleksiy Avramchenko Subject: Re: [PATCH 1/1] mm: vmalloc: Bail out early in find_vmap_area() if vmap is not init Message-ID: References: <20240323141544.4150-1-urezki@gmail.com> <20240326074846.6078-D-hca@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240326074846.6078-D-hca@linux.ibm.com> X-Rspamd-Queue-Id: 81802160013 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 91yfj3o53dfecuna45xhey6gas1cz6ch X-HE-Tag: 1711445160-721794 X-HE-Meta: U2FsdGVkX1+h/0Sd3wYtvR7bPiYbj40Z7sAjzLuFTRskqlxdXAX7z6/hPAs+Ba5DDxvOLRzsKglMKxuO1mjlhAsmFIx/A92mudffZLQzyLvbihDbQS40H4QxVa8KCEBHqr2d7bcIBycwIgFRRgvbn/g+nCPmGCBB61b0xnpiXf7KicZb4Ox7B9+wKgdvzdl32vsg+3brvsADMyq0VG5WiYiDdrtNVG3e6K/3AGm1wSe/8AL1FXAfe7FDFqkJPNjjq1Fc/EJ5CszHXUHctueeVViSRRd9tFMKGuRmhtMdeFVz4lM1CwkZNhfKR5Q+Mq7uc4vEtoUJFNMiUUdwcy2i3aasvDGH6Dcyl1SlbvapGrI4qL3oWmG3pBJcUqIzEpJHxvwi9D5yaaHGCn7eOLZtBu7VLBChXlENSE/c83NF0PhnrPYcG3rmpQwgzrBYOXOlGHplZPBCttyzmlLp9a81WbEXj5M7f8dhUD11g+MLdTaM3Eq6r3TzapoC6oPA7HAli5wVCy7yCS1orE7ZQ3LtPXwwteg0qnEywvOkJMM6D8KBFPTd0LMrHZyKbbW+H1X4GCEGVvsCkOlrYCkZAtbj2K4sQ+Ep0CB/t3yHFa67ArzCpyEYWt4W9nMQc37ZIuKqW/wAlZJp5T4UqIjoNhlDvidaHVgOLYBADGOoN2twuZ4NE1r6/ajKDObBHsaGB/sWNpcXMr1YoxMt9B5CjFW9aiLXTUhSrU9B2EBpgYFZ/ukoQayfR65K/UtlqhOH83jiT7pSPVTGi/VSfz7givxK2dyMIKSnQeceTf3FkQp5+VqjVzlZicE7dR1i+eqioJoRtCvIzHbcyLN8wnBM0FIC+8lGRZSuT+MXdFApamMwYlvKFWqnVmtpCPMkU15yyxjVq4V2Xv+B56ex5OuZ5lSsJgdbrRiT6V1A6TLEWgv0gJ8IU85UfkiOuDrZGp490ucH/HpsRHr5a3TzuwfEQ18 dYWAx554 2t4IgfR3SYyGN1JtbIUURCT9a1fBTaGClINKqMjSP4J0PjLXYcKHrwXloF54MAr/sk1OBMtbuq+jTC2ROCbg/Ocbq013yyswJ7u4Uj0zc9/C84Rw9wKvmx3UVGA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 26, 2024 at 08:48:46AM +0100, Heiko Carstens wrote: > On Sat, Mar 23, 2024 at 03:15:44PM +0100, Uladzislau Rezki (Sony) wrote: > > During the boot the s390 system triggers "spinlock bad magic" messages > > if the spinlock debugging is enabled: > ... > > Some background. It worked before because the lock that is in question > > was statically defined and initialized. As of now, the locks and data > > structures are initialized in the vmalloc_init() function. > > > > To address that issue add the check whether the "vmap_initialized" > > variable is set, if not find_vmap_area() bails out on entry returning NULL. > > > > Fixes: 72210662c5a2 ("mm: vmalloc: offload free_vmap_area_lock lock") > > Signed-off-by: Uladzislau Rezki (Sony) > > --- > > mm/vmalloc.c | 3 +++ > > 1 file changed, 3 insertions(+) > > Thanks for fixing this, and FWIW: > Acked-by: Heiko Carstens > You are welcome and thank you! -- Uladzislau Rezki