From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7FEEC54E58 for ; Mon, 25 Mar 2024 18:41:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 652DF6B0092; Mon, 25 Mar 2024 14:41:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6027D6B0093; Mon, 25 Mar 2024 14:41:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F15A6B0095; Mon, 25 Mar 2024 14:41:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 404AE6B0092 for ; Mon, 25 Mar 2024 14:41:12 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0C5D51A01DB for ; Mon, 25 Mar 2024 18:41:12 +0000 (UTC) X-FDA: 81936428784.20.AEA4B02 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 3EF8418001A for ; Mon, 25 Mar 2024 18:41:10 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="fshS5v6/"; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711392070; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GyHaUurcX/968cY6G8Evo8k5/1kOtA+IGwx5RE4txdg=; b=fYDdKx0Mv3ZQhmRKEu9CdP64jNEb6PF8gZiSut8NKBcXUOyNk3Uj6kPLJ0JhwidDkhE3Eu OYPMcBnUTw0b+dcpF+h0hYpLSEn2Isbo0whT7vXGIBBJMTbhh8n8M/7ukgvU4RoDJNX7AP Uq2eZViG05Y5Z8646tuR8bVJphbkYMQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="fshS5v6/"; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711392070; a=rsa-sha256; cv=none; b=buOh7F5nNqxjR0RBJn58UopPy4yZxTnNQ6VJRmgs6DuQWV1pzPMx0U5gNaiQ0qfAhx5lIG TmdFEHajjwdayPm16lgXLi6OyGum48Qs+fJ6wmo8ZAXnS+gD3a1fxdXw4xP9H54vL+Ptw2 uCNLl7mtq3eQ4yFy9w3pNgvHV48ALL0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GyHaUurcX/968cY6G8Evo8k5/1kOtA+IGwx5RE4txdg=; b=fshS5v6/H1+vcNiHKHJ4eI3/k2 kRvn30zyth5jPfJWNf3A0fuUTOL6O9yB+oN/BSWsTWYY9LsGxkLySli6I2ropzZIqMTYf2iCnuqKc dMdm+4udG8q2NprRt2PxtwLhazt36yuGLydUWwisVi4vgSPrrUqfKy4xX103qcloQM3WVComDJzKQ GDq2NpkPTTw3NCK3cucNAgOfLzznMYfkd25JOReAC/ZgiJnP3DFMak8UB00PbBsOGyDArFLHlwjH1 UVphT3YhFbiXUOv+CPCOs72Im93u2tyDhs+ryi1OxrYHc4TeCneP7KkMRtSjbYSshmbsXvjyTZaoT wi8fwebg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1ropFl-0000000H5As-3Ade; Mon, 25 Mar 2024 18:41:01 +0000 Date: Mon, 25 Mar 2024 18:41:01 +0000 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, gost.dev@samsung.com, chandan.babu@oracle.com, hare@suse.de, mcgrof@kernel.org, djwong@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@fromorbit.com, akpm@linux-foundation.org, Pankaj Raghav Subject: Re: [PATCH v3 04/11] readahead: rework loop in page_cache_ra_unbounded() Message-ID: References: <20240313170253.2324812-1-kernel@pankajraghav.com> <20240313170253.2324812-5-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240313170253.2324812-5-kernel@pankajraghav.com> X-Rspam-User: X-Stat-Signature: zhwijhpsuewdr9ei33yaabostix5hawt X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3EF8418001A X-HE-Tag: 1711392070-47606 X-HE-Meta: U2FsdGVkX19Sy90HsfUfj4bd3B26BJc6/ucISlyQ06ObfHPOP074KTTPOOLbrkSy/ZV7Bc3YHNil+HdrtdW2kHaqgvLn4Ed61IbO+NN2aDpcabQyo6hxL1DmbCFEypPdJrRVT3zipFNloet7J1TPLasV+k1AIq0WUiXbhXKyjfVgLunkhlX4jhvVzZNmonO9HEjlHt8y0+r/9ZQd0ACGrvchRElz60GZ3qmU0pgZL6MHMS/S8SOMDqT3p5/YJmzmUaIYC6/jCIqiqHwi8LVV7AU/PMk0YUsV0pAtKI54ejNdLCZkJ3eiOv812zuMpy2z2Ey6wuhbCuQNdjhJ+Xd0yFuhgDCIW6b9OYwSVjuSuzI+MhRKsg60q8N0NV5BX6meDxklV8ukHXtjSSgIo3fzAdIHOToKFq8QL8sMkACwQrMpe64RXjO+gELt83paMHoZb9/lXXE8Bi4NIY2eAG6rlIOg7fW3OZ0bnTAUUNNemBhU5gIz5H2a5EV32XRURWx3CCUBur6LrWEY1M9+0dBP0d6UaxiVe5E8hNLKnhzt4v6MZvdDKwbkXB4o03fZgx0efj4l3zQTnlVgPCf35YibHwVbM2rb+7gP28t/2Y3Mbh7QlvAGti9AZ7zxiTPC4BzYJwLDWwFk7s/eb8+3yPBlkSU3FxzYrt2hbDEBT77gkx0mFfzB9vur2MsWaVqmRjrPG+RVw4Tgk514fu4CO/NCxfzPAqyzSlN11mOruu5W+7Ld3HNYg3ChBXHpWRZIU9P+huIbnKsh55UjBfWojlwcUc939MCe9vAx6tfJFfYBtjUuQerC3zOFuCE06CiIIMxfGWpdEAAT9smhhSafZHYbkVwUZFTxEoq7pzC3x6vESiytSXIxRl3vvWkqoTFh95GXs054t+SXLqa+wxV2u9c3X7H4Gt7QQseZweB/3p0lE9anfhyVphFc77gBLbJpcJUcuH9xCaYRQLeFWNQ8zIS gEIGxdFW xGckMOK8BB26OFkyrc9kGd4Dg6cnYOUCrTgAXUnkGBJWR1tgK10ZAovoGwCTQOATWih3G8USdbABOpGa3xc9jUD1oBEsTlNhfv+ZHkUx/Ucl7SVcKBDjlRjLGncQRvBom1ZcznDWCEw80lEGS+SPhWYLlyXxXwB2WNK/7p0fCBvMecvjZUp3vBNvePQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 13, 2024 at 06:02:46PM +0100, Pankaj Raghav (Samsung) wrote: > @@ -239,8 +239,8 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, > * not worth getting one just for that. > */ > read_pages(ractl); > - ractl->_index++; > - i = ractl->_index + ractl->_nr_pages - index - 1; > + ractl->_index += folio_nr_pages(folio); > + i = ractl->_index + ractl->_nr_pages - index; > continue; > } > > @@ -252,13 +252,14 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, > folio_put(folio); > read_pages(ractl); > ractl->_index++; > - i = ractl->_index + ractl->_nr_pages - index - 1; > + i = ractl->_index + ractl->_nr_pages - index; > continue; > } You changed index++ in the first hunk, but not the second hunk. Is that intentional?