From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6E44C54E64 for ; Mon, 25 Mar 2024 03:57:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4372B6B0082; Sun, 24 Mar 2024 23:57:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BFDF6B0083; Sun, 24 Mar 2024 23:57:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 261A26B0085; Sun, 24 Mar 2024 23:57:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 12D636B0082 for ; Sun, 24 Mar 2024 23:57:24 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A870BC07E7 for ; Mon, 25 Mar 2024 03:57:23 +0000 (UTC) X-FDA: 81934201566.14.E8CEF60 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 11903160013 for ; Mon, 25 Mar 2024 03:57:20 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=E2qN+W8S; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711339041; a=rsa-sha256; cv=none; b=th0Ryf9+0qMfntfCAxZdGuHk0tDEvoU7mO7gbI0jkMEiPIuRcnVE6hbUD2+JlXhoto8s9+ H+eQzNlKlMnjv/dGV08GF8Gz76NPSxm86JVl0RXXQjY2yS/mXUFIZQpazMbg+YHagMCZE/ LptmTWzTuqFs41BDJoEqNupLTbQXPJc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=E2qN+W8S; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711339041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IU3Dlzl1rVEiTSxVgVMPzC88N9hT6GmfL1S9I/2JgO0=; b=cwFRBKmmFIIYtEBVkB5kmWpYHsjc7DqNUXBh1JiTr4WSjIv6ADWy0WgW1PPwdMnl5LehtM HA79WtmIiixf1KKEp8b1hBKlm61H+T7gYmfoqFg9FoDXRXdwIjIWZdYrLToFOMZChf72Bo Kz1kP6RWIeczt+chn2RDXZHPLyr2lL4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IU3Dlzl1rVEiTSxVgVMPzC88N9hT6GmfL1S9I/2JgO0=; b=E2qN+W8S3ZU5YGOKUUO9cBO5zJ B4vbyccJGdv9eLdysd3ijpij1NV9BRohz3uOmTf4NlnOEmU9plOLo3xO0baioyQzSVdsbO4iKAN1J 3ctvmi7R3l4FWCQXAUEao1GPS8qQVI2oQOdPAuQNr6hXnl6I6vmm2j+3NoCxKKsDqY4qOWeiCgteg 8gZJivN4pdxgLg2bOOZeUKG3WvLwqaEN6B80ItvTZkmoNGUDCORSFQ1vrAakpYtWx11ik/dTS6kqw sgoio6lafIToR7obrEZm5aMJU2MZ+TQZXFKI9Gm8Bv3pifGAjRp1U8Ab4CuAHnnl72Gs0h/IVT5DO wg4LmchQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1robSM-0000000FbhS-0cGD; Mon, 25 Mar 2024 03:57:06 +0000 Date: Mon, 25 Mar 2024 03:57:06 +0000 From: Matthew Wilcox To: Liu Shixin Cc: stable@vger.kernel.org, Greg Kroah-Hartman , Andrew Morton , Sasha Levin , Dan Williams , Naoya Horiguchi , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH stable-5.10] mm/memory-failure: fix an incorrect use of tail pages Message-ID: References: <20240307124841.2838010-1-liushixin2@huawei.com> <026db58d-feea-8191-616a-3e6dca592786@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <026db58d-feea-8191-616a-3e6dca592786@huawei.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 11903160013 X-Stat-Signature: 6yo4fieop8mxp7ofw4azrixhn7tzk7r3 X-Rspam-User: X-HE-Tag: 1711339040-838604 X-HE-Meta: U2FsdGVkX182zbHrcJN3cnyBkiy1dFWU6w+2NWeFRJBotJAaeT1ijRLoWgMeOeuEdT3e6MrdDWtp1jFWA3i2xpRyKDPbhvKnjBTGj57ZLVF93VSHlYYMN/5AEv4sehCRRqUUa8d+9PrabMWOhvxelWjYH5Z59CgE4BB7oacJ2WSE3x+a/A31JKX77EuEZznHBRRZ4JZwhG20KmMHag0ZMm4dhKuaK3ZwIxuvZBn/eXLvohWiHlsFfnknvZBG3ze6n21VOMtWr3rtTa/EM3H99977OrrhNyNI7UBfBdaiRfce4OSuFxl0AWcmf2ekF7xPBA5LG8uwap7Eo3RX9RZz32F8JUQYrEds3jG84oxNRgmki/ELqL1QUoR87S191uT/3X/Prn3WiEjWnDmG1H3+3J5l7PvVkOeKiZDCRMwllNMqgwqfSfxwTn2o2vAlMS1qoCsybdOpWi3TUz1/xtomCUlxjD20nhIgZvZorjv+M5X5BgXvMXH4WGV73s0eR02Fp64Vt79yVflyFjfsTGlvhxE9sSkjY84ttHNT2pcqF9G/cZc9hTu7qm2yUXHzSDkmcaBPLbsfpJRQgjHFd7w+rGmM2CsgACDvPTr5VgYZ0fSGe3KNq+6KVu7NJv9fF7pcRmHtlcPxiCpmb7uGyXE5r9XYh1nZ2khqShRkiUZKWEmrKiHWyaw/8492L5HaQCHhinxe0oKUAZlZN82ZvWOc6x6RSbmdli/RWrU7gd7ZFKr161AL1iK6qVSQglqYvwjCaTxyZ+mrZMQWe7cAe0akulzRpWzn5QccO3Okh0IIJxaRYkePV//wkiWpxGnlS8W8pac5OAzq/oFi3+hF7hwL/cdNgIE/QST7yUM3V/bfYgaLYvMO0V6gL+agW29QCMvVMtMDU6sSYmObaR9bbkUn+VeSVLL2AgBIPXESJVn/1osWaGIctDFamxmF3QonlVU0+ntodBcmTNoltxNbHEf tIX5EaMF CK8iPNxRxDBgLz+nsCXgkFiBPxPoSw4/LLMSXsx9yxwIl65GIye/4zeXi6XJS+sGpBPMtt+Hk7sXcsHZzYsGwnp02SIwTRqbwIgEueZGpJqjdT0apLYUfFyMFdVjy6d/3kPPR/W6PONLkEaEWIbIocmL+0hTlPSv01+5v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 25, 2024 at 11:36:49AM +0800, Liu Shixin wrote: > Hi, > > After backport commit c79c5a0a00a9 ("mm/memory-failure: check the mapcount of the precise page"), > > I got an error message as written on the patch. The problem can be fixed by the patch or just revert. > > Now I prefer to revert because I think it is related to folio and no impact in stable, or maybe I'm wrong. I checked out what is going wrong here, and Liu Shixin is correct. Commit c79c5a0a00a9 was incorrectly backported to v5.10 and commit 70168fdc743b changees the page passed to try_to_unmap(). It now passes the tail page, and should always have passed hpage. Please apply the patch below to v5.10 (and any other trees that c79c5a0a00a9 got backported to). > > Thanks, > > > On 2024/3/7 20:48, Liu Shixin wrote: > > When backport commit c79c5a0a00a9 to 5.10-stable, there is a mistake change. > > The head page instead of tail page should be passed to try_to_unmap(), > > otherwise unmap will failed as follows. > > > > Memory failure: 0x121c10: failed to unmap page (mapcount=1) > > Memory failure: 0x121c10: recovery action for unmapping failed page: Ignored > > > > Fixes: 70168fdc743b ("mm/memory-failure: check the mapcount of the precise page") > > Signed-off-by: Liu Shixin > > --- > > mm/memory-failure.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > > index f320ff02cc19..dba2936292cf 100644 > > --- a/mm/memory-failure.c > > +++ b/mm/memory-failure.c > > @@ -1075,7 +1075,7 @@ static bool hwpoison_user_mappings(struct page *p, unsigned long pfn, > > unmap_success = false; > > } > > } else { > > - unmap_success = try_to_unmap(p, ttu); > > + unmap_success = try_to_unmap(hpage, ttu); > > } > > } > > if (!unmap_success) > >