From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21BF4CD1284 for ; Fri, 5 Apr 2024 03:36:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89A516B00D4; Thu, 4 Apr 2024 23:36:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84A2F6B00D6; Thu, 4 Apr 2024 23:36:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7116F6B00D5; Thu, 4 Apr 2024 23:36:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 53BF06B007B for ; Thu, 4 Apr 2024 23:36:08 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 168CE40DE5 for ; Fri, 5 Apr 2024 03:36:08 +0000 (UTC) X-FDA: 81974064816.25.BE47B9E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 7472E1C0005 for ; Fri, 5 Apr 2024 03:36:06 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KnE1kdDH; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712288166; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YgypSeYH3i2VABJBdQ8n7O1Ci6MVKApCIW3w9teQa8g=; b=b32xbMgug4eipPdjdqUGLf5Bbm3c4T6qF/NFzj/nYyxtOy6AlpklLvwS8PNtK9/FAkGfBs 4bxU61zIQ8phoiv7s80UgSLyUa9hUjNJkPBUYMVGY0q3Uabdm3BXDmUPQifNyWrHgGXSlZ 8OI5ZFo6fRUF0VVShGdb/b6c8H9PBFE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712288166; a=rsa-sha256; cv=none; b=WZdlBgOp0g722CwYNlIw8avLjd0IxM06l0d6Kh57QSsg0nhG0WUVUwyGPkyU3ue/JKefcq m8omM4NHk2oCo2bsCnyzNlcBCRuzBoWmU3/JQYB4bTHS3T0x3Hts1DZT+4tPaZ0ohqOngD pVUAuTdpHcwH/4JywWZ9rF7kiKunkXo= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KnE1kdDH; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YgypSeYH3i2VABJBdQ8n7O1Ci6MVKApCIW3w9teQa8g=; b=KnE1kdDHQ0+l2RtYnPW39XvQWB /ksbFn1pVcUQUu4ygucs3d4oLZHk5vz/36cnC8w++liHerMj4JvmmT+ibU/H2Ne7i+dONxaTiubEm N2U0ftWzAoCFMZNqG/3tYwYWWCBxYLYlINejPHjsmJcWFfxgInzDx0DB9c7wNajpNRqU/RFUAqWyp ySQs6mpkVjqbQbO6Or/dvuyk5c8In5hauv66Nu5dt/Bw/3lLkq9jfwLBuboMzS9KuMEz1+h8DgnN9 6GkXjRtNfImP2ol2DN86NzhhuAQhqwtry62chyZip0s0Z+CgH7SjYPQi8Vlq5J+eRs+Cfc1oJGF8g 3Mb5S23w==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsaN1-00000009X85-3Ksj; Fri, 05 Apr 2024 03:36:04 +0000 Date: Fri, 5 Apr 2024 04:36:03 +0100 From: Matthew Wilcox To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Janosch Frank , Claudio Imbrenda , Gerald Schaefer , Thomas Huth Subject: Re: [PATCH v1 3/5] s390/uv: convert PG_arch_1 users to only work on small folios Message-ID: References: <20240404163642.1125529-1-david@redhat.com> <20240404163642.1125529-4-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240404163642.1125529-4-david@redhat.com> X-Stat-Signature: hmiifh9wg6uiet4wop9ynpzff391j6h4 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7472E1C0005 X-Rspam-User: X-HE-Tag: 1712288166-416035 X-HE-Meta: U2FsdGVkX1/3fzxm+jWQEFBGTiPWIQHKBBNxxhmezCIrsMj2zNci6Eomxh85zb8a7s8JR4CCrbibB5FR64b1ZY3RfJF/CvsY7xQ21lr9dRFJkA8B9vlX6kW6ChMsxB5ttY7xauYXEDFClvfmnYBVU0C2U55zlAPzyygY3mTS7PGh0G+M1JNqSzxGtn+1wJIjh2/p10AUWLlHiSneV2BsFoksKTLTBaVSCNmuAVc311cJ0sLWWL1yXVPn9WIwkjtZJb0CzoqRR0RZ5nIv5OVaqInHMd7QfcG0x3FWvwdrgEDBdLoOciILb0NiYTvr+l5k45NnL6wx1KkEaMV0NL2U7n1ipNMNDm6y2kn31E2tJnMwSRirl5DVEO2TLo2b9LmGdPNXX2WBK4md/1VqXOFMp1AZw6hia6VMqm/qppiE9Vs9CHQVgOxqecukR22k264BDeCu1I/pEekMnRbWXT9TaKexqiwFXs5qaYaneozYqTF8gd/QriO1CCXHLRNYcTz9gMBWzfJIcPU9XtRgbT3X3SbtvpyqLXfRVc7MaBOUAneWJGv3ddrTO3tz1KH0k4+yHbjUpU+iS8O1AkhG0ynkJTKW3FZ0nI6BgBNQ1AqwqvZdR1LvVzr5DuTld5hjdj1bX8tMf4aYeJwPkxugLS3mCtVGIoGGydK9xycM8ljYOh3cWQQ7Ht5xvkwq/LzuPDaL6unYyX1abahK1gq7yfLyhqWZrrHhFMVyApzmyJhYoaHZ/HYLijhuPjEODHq8pp/jOOIq88E3JOfWyWooRt/BDxFdCVsB9zJaf8K+9IM1cZRQ0F8E6Rea/hk5uBG3EzAaEvSjBMXMozN8D6urZXRcZVpDO8BB/G++V7qsVK6zd8MXNRkok3LyAkITwQXtws/Z8Fo6z0VoL3PXDvjqo9XI8PyH+WmL16M/PsIv88sFF5BZCeAtMEb71aj01mBkMqgCuv8mZklG6YWRy/CNghS RflqUryc 7Bve5xAbqsk+/Cw/UKH+D/1lPIINaXD00OLXIjRG/Twxu/94hLQp2bJf0mnBycC/6488GcTFeFp6j4KjOBKObsKhjUxcdR4ML1okAFYUIugIOU7GQfedfeBgh4t4uoglQjy0ICI8BVmen1Ejs0BAHso0m3oNlevtARbCMflFpbFuND7ifUGMOuSPJ01rHXyP7dDJNWWmBGLuwpSOWPObEsUv6sQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002012, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 04, 2024 at 06:36:40PM +0200, David Hildenbrand wrote: > Now that make_folio_secure() may only set PG_arch_1 for small folios, > let's convert relevant remaining UV code to only work on (small) folios > and simply reject large folios early. This way, we'll never end up > touching PG_arch_1 on tail pages of a large folio in UV code. > > The folio_get()/folio_put() for functions that are documented to already > hold a folio reference look weird and it should probably be removed. > Similarly, uv_destroy_owned_page() and uv_convert_owned_from_secure() > should really consume a folio reference instead. But these are cleanups for > another day. Yes, and we should convert arch_make_page_accessible() to arch_make_folio_accessible() ... one of the two callers already has the folio (and page-writeback already calls arch_make_folio_accessible()