From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3A99CD1292 for ; Thu, 4 Apr 2024 22:33:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F7AB6B0093; Thu, 4 Apr 2024 18:33:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A76F6B009A; Thu, 4 Apr 2024 18:33:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 170716B009C; Thu, 4 Apr 2024 18:33:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EC8B86B0093 for ; Thu, 4 Apr 2024 18:33:46 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1D50D4037D for ; Thu, 4 Apr 2024 22:33:46 +0000 (UTC) X-FDA: 81973302852.04.2F7C329 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id CBD9E40010 for ; Thu, 4 Apr 2024 22:33:41 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Te+feZmU; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712270024; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=75VsQ8F7/H5KCW5vqBNrslkQ11lt96phTDSmVee/O9I=; b=c844/JBD4YG/SZssOpxgK3SI9EIHzCvymtodkAxhgshz0Em1/rPWSwEGEVdI33sqKVxCMN vfI+l2FjmHqZKbWKsosU0A4cD3uGjjMxSkPrindKbR1ymd4jIc4/fwOPtr2dh16TRiolYo zQdxCVbuFMbbAa4K5pwev7tt2FHVet0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Te+feZmU; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712270024; a=rsa-sha256; cv=none; b=38DRAKrVx4ZPN90KuxR7p9AwoUrDB53ajbrTWbZzKRsPNuogDhnHPk5RWW4o1MUFdBpYxu Se6vl70wmoEueqxak1G6M6+MRXMKVWrG9uiMBZUqXwANXW05EPsH60eYcWcYCUI+B2Es+T BZ5FgmHZ7Ob2TJ1rb+1msUwhdJF799o= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=75VsQ8F7/H5KCW5vqBNrslkQ11lt96phTDSmVee/O9I=; b=Te+feZmUkMzP94t2sItXjVWR5n UxqmPQpg1gH24py6VHZcp2Yzrj1xtO40Oy9nQUk/SjHo1dw0m+owjkqZGpr4mxYxKmnwmdMjKSARP PbPDBDjLGS/fO1KlJ/O15LF6KM0e1lNhDFdxUyeNlYmLmMRyZYt3Sb8nM6EsEN6Jb1ESmpoOUy/w7 zYZHPZ18PCnhDFfTlWkNlW8ibXtgOZvrCOq9ZiP8ZQw4feDaJphjSp942UnkuWrE0lUuvtUoTrRXN 0PeZviuO5MSV5ayE1r4TbxsnAojnzcKvwsJPAUPxosKblk92mi9rZW5UXmhFVDP1h8SdLCPdpocoQ pKS100xA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsVe6-000000092fK-1nQF; Thu, 04 Apr 2024 22:33:22 +0000 Date: Thu, 4 Apr 2024 23:33:22 +0100 From: Matthew Wilcox To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, joro@8bytes.org, will@kernel.org, trond.myklebust@hammerspace.com, anna@kernel.org, arnd@arndb.de, herbert@gondor.apana.org.au, davem@davemloft.net, jikos@kernel.org, benjamin.tissoires@redhat.com, tytso@mit.edu, jack@suse.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, jakub@cloudflare.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, linux-arch@vger.kernel.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linux-input@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, kent.overstreet@linux.dev Subject: Re: [PATCH 1/1] mm: change inlined allocation helpers to account at the call site Message-ID: References: <20240404165404.3805498-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: CBD9E40010 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: hj4o81w61ipjzc7hxsa5bk6593d6ihbk X-HE-Tag: 1712270021-704547 X-HE-Meta: U2FsdGVkX1/OWrterYwHrm60F3liTvfF3zdenm/76gCvvqXeYpcrGfNwOU1Am0F390XkRqDmN7Dxlf0+zpkJqVPe4lvluHBzEF6XKtZtBgBQDq0HVrj9hlrWsoTjGytbrZSKu1BNNCWx84pZlaoOqTjmblXAUphyVvbSrqVHexvued38FigCEd9s9CftmXM4KW6L9rY6xgTA1DLEpOTmvnKJixd0U5QIvlfF6vR0Fwg0aobPR+F66wNHyazIEYZvWoTb4H65Odzb7WGaBNfVL0//ThwQOtFszfVaEP99ROckeh2fTHwmKhD1o3I17Odvme1A3tYp7exjDdJKl7Yo0lO+xA9rX/iFfWsIjwt9cVWwEnNyUo+bPo1OdLBXdF7mHSWdp2yQOacBhcUOkwjmSeCibZ7d/1auFPiJudWZu1TtOVL0jUqjPaJv30+pFQ7TdoF/M+vnbWSRZRxpgGyHVwz3vLx3MpYHwK7hdJ1qSuOB2xlfx8RaLMw5HJjP80dNzF4UBL+9XaR2t7pncqoUFDLaascGawKLwM58Nr4rJpNWIb02Q9VIdk8y3EDIT/zprd5Op9f2ui/4GUtOHEI4JjrKFlzfbJizTsoSRtEepZ5P3BfcIH/qRmEC1M8zTRIVR/y68X1e7Cyq/01p5BqYgqqTNLsIGuU0x6pmHPtae2BGVKgebyDheX/radI3ufl3112iKqXC+l8qkia7TOfDNPU0ZoFJ6odZvb+hNUr1xfqqBuF/FsLARLCHiBJ4tdbawHR8OwVBtpss1isdPlNYaAo18eDjt6cVJXytgp/teL1K1+hWnR+qxwGNnEJbWQkj2zhuEitU5boZ1EwjgftbZcfHjwdI+RplnMHlGx/DQTRiOrLDvon/+m/Zx/wqWUkakF1NARoLx6B03FyL6FyXGmgAOt4MHjawh7lMnypIO1W2Hrh22O1NzBvJCzdEDRjZ2ySVwqfEm8DsDe04FDz 6TqreV3U iqrtfR606nTrdzGPUO4EzshqMtN3/jpjiPhbDPC5dg3uamAvpkM6Tcs3hI1qJYdMh12hGygINijGUYKTIE1ZhrNSZJRpI+qdAVBOVSfo03vAVQBUV+LOFk7sQ+FMNBi9pXMzLHEEtn6Xe7VLIOuSX/b8oebmoGP/iNk6dHfL/jI7nRt41oBpd32KqHX3jfXrp0CWZ/izIxFKX6R+Ob1L6xgjN6KuDcP/53F5B X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 04, 2024 at 03:17:43PM -0700, Suren Baghdasaryan wrote: > Ironically, checkpatch generates warnings for these type casts: > > WARNING: unnecessary cast may hide bugs, see > http://c-faq.com/malloc/mallocnocast.html > #425: FILE: include/linux/dma-fence-chain.h:90: > + ((struct dma_fence_chain *)kmalloc(sizeof(struct dma_fence_chain), > GFP_KERNEL)) > > I guess I can safely ignore them in this case (since we cast to the > expected type)? I find ignoring checkpatch to be a solid move 99% of the time. I really don't like the codetags. This is so much churn, and it could all be avoided by just passing in _RET_IP_ or _THIS_IP_ depending on whether we wanted to profile this function or its caller. vmalloc has done it this way since 2008 (OK, using __builtin_return_address()) and lockdep has used _THIS_IP_ / _RET_IP_ since 2006.