From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BC82CD1292 for ; Thu, 4 Apr 2024 20:53:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC1056B009D; Thu, 4 Apr 2024 16:53:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E71486B00A1; Thu, 4 Apr 2024 16:53:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D604C6B00A2; Thu, 4 Apr 2024 16:53:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B9BF96B009D for ; Thu, 4 Apr 2024 16:53:02 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7971EA0C1A for ; Thu, 4 Apr 2024 20:53:02 +0000 (UTC) X-FDA: 81973049004.07.7390527 Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [91.218.175.175]) by imf19.hostedemail.com (Postfix) with ESMTP id CA13E1A0004 for ; Thu, 4 Apr 2024 20:53:00 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Z+IjTsu7; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf19.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712263981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9agO9kC3t1/Wq0yV+pf2SQotdgdN2JIuAhDFcUHIGHs=; b=BwpOf/DbgzoaWesLWoQXL7KQsEygXBQnJ/V8aSF/VtlRa+ZCmS4/1OAfvCVMTGtvRz068u 1TFnBMJijmAG3AvFzjPW8PcsX05L9kgDi+WS9Yut6caO69wpPs9QecgmMBlXWNiplWuyna VCXMjfBut14cOFM4puq+vIuRD7B6OnY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Z+IjTsu7; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf19.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712263981; a=rsa-sha256; cv=none; b=5BjGU1M7yilZX0gew4Zr+9HEfna3OOV1rNoj5hfX4LLwuljBCfWwI/BhPlF1hMFc1bsdGj c1UxtnDzvbON4k22NiT1UVpfzS0LNFycCI7kWylDqSU3PBQeopR6SeGMyO1qvcm9DMKgtb AHparALaiqRZ0dYkk4rfd6TolskzUok= Date: Thu, 4 Apr 2024 13:52:55 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712263979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9agO9kC3t1/Wq0yV+pf2SQotdgdN2JIuAhDFcUHIGHs=; b=Z+IjTsu7logIWE4MddiQ8AW0Ang6UYIrUFbKUXQYqOxWRzHQKfsBLTDevCzq6HhkqlT0ld CB/d0dloDAJJl7XjJgHGNNUa+fYgpyDOTi7Ox/eV2O/Yg5MaIdgPRoxBhUSiZwTfRXHGah OlpDE4nRGbsehUZcOud9zk8E9D5/ogk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: David Hildenbrand Cc: Frank van der Linden , linux-mm@kvack.org, muchun.song@linux.dev, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm/hugetlb: pass correct order_per_bit to cma_declare_contiguous_nid Message-ID: References: <20240404162515.527802-1-fvdl@google.com> <20240404162515.527802-2-fvdl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CA13E1A0004 X-Stat-Signature: 4ocjn3oaiujnr4f76wuz4gxwodmq5gi4 X-HE-Tag: 1712263980-237713 X-HE-Meta: U2FsdGVkX1+H4hyZUGiI29g3LXrv5ZgpCBwCZ10AnX4aw4P0gIBffBKzp36Un9AI2JeqxKwHRPHVo2oZ3TFqtXBy94nc9Iy8SYnbeXmRawh7yuD3bavS1lz48GvyfQl6T2ZjfSatVYRVxVI1QQ625HA1BFk9B3VnvSf7nRY9CvM4+pfXeICUT/cxlR69/m9/B9tkL5z+jIsQCvkNO1LadU27KFWBuGDDxW9rQPiiAWsqmkVnp+0meRai3xPKiPpXG9h/0HVLoWtZeJjVZseLZhe0kQuecJxxUhO0c3WTq1VwvsZrcOI5c03A50Pp9a6vjJUtDSGbPVy/PMBc8+YsPXZfbigj6RsJZw2kx5Y7mzy7vCAjtspX0xQKKJfxxQFggHn/gPjOPmhMP6Cp4VhhPIS2JD7hDUR+t2CVMt+xU6Wfs8C+iLNaYEdehvlbKWX8TFYLXTLAIxQ3MDxWFPukgt0XBVHj5ezbMpoSLC9K7meSOxmdLizIf8S8Umjl9goF4kfX+cmDRMjEHL+EGVy6naY3NI7edfzFb5CGO0rwhHnrOdgvV6tmbMVrObL5oeqmRoi98vhsi2qVqx0Yu4ifodulbikcwL/n+X4to+bDptGjBSxHNWbZap85RDxC2J6nb0Ppq7/WbzoOGeui6jxIkZD50a4Rsgf0vwuSIe6J1vYge1hZZfpEAOXDc3AnplLki5MVGHiIelYcjlUyq8F4gygmmhLpsSi9XVb/vzLKHLIl6br7KcF2ySWnbYWym8hrrOuEVtR+kJP+/teKAXLEgk0W/G3Yq0kYnneJQrGQCnCHc6N9/Y2Etl6IdUmrszN6S+7cTbdvNdeGiQmibA/yrVDaBdrG79Pu5oljUqrTaylWdAfh6zvAuN6TyoxD4IikG9ygUnectHk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 04, 2024 at 10:13:21PM +0200, David Hildenbrand wrote: > On 04.04.24 18:25, Frank van der Linden wrote: > > The hugetlb_cma code passes 0 in the order_per_bit argument to > > cma_declare_contiguous_nid (the alignment, computed using the > > page order, is correctly passed in). > > > > This causes a bit in the cma allocation bitmap to always represent > > a 4k page, making the bitmaps potentially very large, and slower. > > > > So, correctly pass in the order instead. > > > > Signed-off-by: Frank van der Linden > > Cc: Roman Gushchin > > Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugepages using cma") > > It might be subopimal, but do we call it a "BUG" that needs "fixing". I > know, controversial :) We probably should not rush with a stable backporting, especially given your next comment on page sizes on arm.