From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C55DCD1292 for ; Thu, 4 Apr 2024 18:56:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95C2A6B0088; Thu, 4 Apr 2024 14:56:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E3FA6B0093; Thu, 4 Apr 2024 14:56:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D2A76B0095; Thu, 4 Apr 2024 14:56:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 615586B0088 for ; Thu, 4 Apr 2024 14:56:49 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E2209161058 for ; Thu, 4 Apr 2024 18:56:48 +0000 (UTC) X-FDA: 81972756096.29.E9D74C6 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) by imf08.hostedemail.com (Postfix) with ESMTP id E856716001A for ; Thu, 4 Apr 2024 18:56:46 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=eKRGb8nQ; spf=pass (imf08.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712257007; a=rsa-sha256; cv=none; b=tL0U8knSB2oQBPWYA3/6+XW+25EeCHkkXiYfPPFaFe/zc0yrkRZ9WU0dahTISFPtG+jYG1 1pyDy599Qx78P/RtzUoBShU70QUPlIpCWpa5Ezb7/yjkH+VERYlDDfmF+9A8M+MZhdqBbX lrIBhzleg4zyj4Ibr/G6P4tG1emQ8s8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=eKRGb8nQ; spf=pass (imf08.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712257007; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ekgsgNqeKKjrKE6jGlMBfAf5nKQ+ack6j3G4b68ujBU=; b=PucjOk/lyCnUvUvK81wotzXHCnGI6vPbjZuUC7YhMguFCkGng2Oh3iVbjHOaq8NR10kvYC RMPylBBxqFUeUmd+KTqDEwDQCGJXdLf9909cxbcfjUAZ5PM3oivqZ1aIyR+J6nDfL4oEWO 2f00Bg7jBLzigG/gVgUc81iTJvQ/5/0= Date: Thu, 4 Apr 2024 11:56:39 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712257004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ekgsgNqeKKjrKE6jGlMBfAf5nKQ+ack6j3G4b68ujBU=; b=eKRGb8nQyxQLzoJybEZ6TV2jXTmzQFx61X99Xnxraie8m4Ihh1eIgyRQMX7nbSU3zz5mig yJGFWw4IB0nVU6gIaB7Q16ykH1cSWZ10LOC0qb/nsfDmWzPnG+CQkn3N3ASdNRji5SniN7 w94KrNysvhntrzVD3nBoK3P6k0vAPA8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Frank van der Linden Cc: linux-mm@kvack.org, muchun.song@linux.dev, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm/hugetlb: pass correct order_per_bit to cma_declare_contiguous_nid Message-ID: References: <20240404162515.527802-1-fvdl@google.com> <20240404162515.527802-2-fvdl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240404162515.527802-2-fvdl@google.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E856716001A X-Stat-Signature: chfyd7313zsuu19hnommpx9xaxn9j1a1 X-Rspam-User: X-HE-Tag: 1712257006-95441 X-HE-Meta: U2FsdGVkX18QKiJG+Q4+dOHe0sMDhQjG+tP15gav3CknjSsPmc+zTOlb6WNc1hY5vEIhbVgfH4Y2y62a+vMCc7kTWJmLdcRtzOPGR9HGH6tTh+QBKW/IF7jtKEuvKPRTnOU3Z8lAo3En52rA9W5MCWMnsGt981LxI2HUFJfWeKvwS9d11QhWPTv3PoVqQWM7KRpUQdSHANXb2g3I11mGQYpiMZHLKiN4bDBr/pdJzul6SGMKXfxvGBB0BL+910FEZ8p0iCkll6sZzJzbcdWQVjAMJsSVwY63X/USxzO3Da8abJ9v5WHDhkU2QECPgnmAK/AwYSkoDSLBcVfzhDlSpPGn30wN79Trc4ke6oYX2E+I20SMPTSUKnhqjd+H/FfxmxrlKD4vfTPFFVCz6mU9O2gQiDDLTmJdOO4aBvg7cSNoLUssayUb37XTAe9rMYbRrUSHRkcFVF2iuyo2jFisabYO74zADLedMKdeBaZEXnOY+jKWhY6g4O7ucLaLKJt4ZkznpGa024+eSgOfggz2ixl2qRWH0KEE/n88DnwFJJW/bRFzHrZUeY4kYNvX2avsaBdNKnh/r2RBl01UqyiJaWxDfBr2r2QqG4j7QRQ6gNrIlNyTX2FaXuaEZMPZXotTKIH0KHyNKRlGQCEeM/psDmQlengPYbvPqwkaEV5mBYDTArayNdwIgMNiJ1CkYBK9AtrfYreX/xzEDsc+sMTpvJf1J+4LOpOgzaev5pc7NZl8VHTmokDsSfYTFFkVfHVgVLwv3C68jjxjam/FtzZzUqKpnOiIsuc68btNBmpRlS/uYMYGPB4Q6tM0L0uYv2NEqkqmmErHEkSpZd3h0ca0CEe8Qz0p5UTuzkwPrlesc9waGf/JJZ9XJxXGQN6MwWFP4S5dxYtuHOPKatCp1dql380u2xkZlI0KbzzGc3eHiOowhRQUApR97jhSsmISi6kLtMFBrU8dziiUyQOIXUs FmGgxGLi xu1NXhjrYJQ8XlVPyr7Spl8Sd4KHITm1kW+fs3mStfp8AzyyCVuhMaaOfpdNtIGncD4kDp+4LbpUYR7V3uge62EghJvluTjGWV3n5nwP4S+Ppxaz1Kl/OBUsxA11yDyXBoefMC2+jryS1PW/yJ/hlfgo3/FmWMVFZgXNHo6lwX5BqqfwP9kUVa0XK94FviQ/yTxN377F0itdcIEc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 04, 2024 at 04:25:15PM +0000, Frank van der Linden wrote: > The hugetlb_cma code passes 0 in the order_per_bit argument to > cma_declare_contiguous_nid (the alignment, computed using the > page order, is correctly passed in). > > This causes a bit in the cma allocation bitmap to always represent > a 4k page, making the bitmaps potentially very large, and slower. > > So, correctly pass in the order instead. > > Signed-off-by: Frank van der Linden > Cc: Roman Gushchin > Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugepages using cma") Hi Frank, there is a comment just above your changes which explains why order_per_bit is 0. Is this not true anymore? If so, please, fix the comment too. Please, clarify. Thanks!