From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 431B8CD1292 for ; Thu, 4 Apr 2024 12:49:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA5E86B0095; Thu, 4 Apr 2024 08:49:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B56076B009A; Thu, 4 Apr 2024 08:49:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1F186B009B; Thu, 4 Apr 2024 08:49:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 832886B0095 for ; Thu, 4 Apr 2024 08:49:11 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 41F95C0D47 for ; Thu, 4 Apr 2024 12:49:11 +0000 (UTC) X-FDA: 81971829702.23.B3C8D8A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf28.hostedemail.com (Postfix) with ESMTP id 0EA0DC0002 for ; Thu, 4 Apr 2024 12:49:08 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ISdw1Kg1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=IGW5qOax; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ISdw1Kg1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=IGW5qOax; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712234949; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8+/HnAezjLRt9n4+iHb7cFTsC2LplwLc1xaDDtuWmYQ=; b=0zzIXr+Fwqfi0Y7yc7htJ3xUHR2JxboKth/cuv2gCuXm+q7knQY0tRrizWZlH6ysl8xzmH xl6juVTEjfG2GAVC2bJWmIoC4whaqbwNayVJ4pCI6gNMk3vPwLEL/Bmav8+4mAoZIgP9xF VisXwUWz1sLTdfs0hygS/rI695AL22c= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ISdw1Kg1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=IGW5qOax; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ISdw1Kg1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=IGW5qOax; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712234949; a=rsa-sha256; cv=none; b=2zdro62O2UxKV9zhRQpzem+v8K0nMGL83qW9nhony+cE42h7pNqzck9KQD+rAENs5Jx29y 2mIGTSpFi8ecIYnPKv6xuuv8iJKWLRrIa2gQ8s/C8CXMtv3AZsn9rA3M1thY3aX/oGZ91Q HUt+HLOt3I3uM87um3zdy2tRG7ATti0= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6D14A5D96E; Thu, 4 Apr 2024 12:49:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712234947; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8+/HnAezjLRt9n4+iHb7cFTsC2LplwLc1xaDDtuWmYQ=; b=ISdw1Kg1i/QVu6zSkWOMz9Jh/1suGDLE1PYIDN9nIEk+7ZBzZvDTr0z0zCzuD2dt9/T395 0xE9NEJ9JYInCD6F4e8ZEa0P8tkZpcIMHEqgwkTkNU3Fut/+n29AeQLkOARGAsekwco5SW txWqINeYZf7BLMfPSePGFMQ5SxT9p+o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712234947; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8+/HnAezjLRt9n4+iHb7cFTsC2LplwLc1xaDDtuWmYQ=; b=IGW5qOaxj28jRVQFpkY2likrWYQdrhvkzIEs8EBHjYEgt/b4Y6mf5Mvfht7Ro+yvLAXbld xuXOuA6HBxBCglDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712234947; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8+/HnAezjLRt9n4+iHb7cFTsC2LplwLc1xaDDtuWmYQ=; b=ISdw1Kg1i/QVu6zSkWOMz9Jh/1suGDLE1PYIDN9nIEk+7ZBzZvDTr0z0zCzuD2dt9/T395 0xE9NEJ9JYInCD6F4e8ZEa0P8tkZpcIMHEqgwkTkNU3Fut/+n29AeQLkOARGAsekwco5SW txWqINeYZf7BLMfPSePGFMQ5SxT9p+o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712234947; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8+/HnAezjLRt9n4+iHb7cFTsC2LplwLc1xaDDtuWmYQ=; b=IGW5qOaxj28jRVQFpkY2likrWYQdrhvkzIEs8EBHjYEgt/b4Y6mf5Mvfht7Ro+yvLAXbld xuXOuA6HBxBCglDQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 0E996139E8; Thu, 4 Apr 2024 12:49:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id mzMBAcOhDmYNZwAAn2gu4w (envelope-from ); Thu, 04 Apr 2024 12:49:07 +0000 Date: Thu, 4 Apr 2024 14:50:35 +0200 From: Oscar Salvador To: "Vishal Moola (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, muchun.song@linux.dev, willy@infradead.org Subject: Re: [PATCH v2 2/3] hugetlb: Convert hugetlb_no_page() to use struct vm_fault Message-ID: References: <20240401202651.31440-1-vishal.moola@gmail.com> <20240401202651.31440-3-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240401202651.31440-3-vishal.moola@gmail.com> X-Rspamd-Queue-Id: 0EA0DC0002 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: mhnog87ix9ypbpyerc6ye8c7yob453cy X-HE-Tag: 1712234948-712485 X-HE-Meta: U2FsdGVkX1+BaSEHkz8SIEvQsafcp9O3QJCBXUoJpaDVH+qXdqUhWVA18JEMDW53rXumul3P/fljBkZUn7sSGsmjC4PBqjAbB/JEmD4sYizvXg3QnVKkl/SZ6qD2d+uW2hN3O9+0yqYk8c9QHAbtzbE1yhuiYmEasBzvznBpXA36p3NToia/Ihk3KIy4r5NWxo8xe7hIIcFDp7PCFs9Os1+6yfDx8BR/S19Iu87OYwfbudMJEibQmCw5X1op+SOPw5jLcwo8FRs0ywsL043ScHA7GK+QOxBSCvpv8ozuIe7GiYktiZh8SVw3a93zJffF6h9AfJUMT0q/ghYtsPihAyljcPiFb1ZjgI89hEziyMZ8VFexggyfnYEz7ccMa2t8yt0pX0j4lHjko1nAqgs267cj2YF3teIoJPcbeFtWiL2WbqczKRh+MZHiil69iKWQIshlHkV1G2n4lqUICT9vV1OF932NB7PaUk3l2cbBMQ15MBwhvobOmIhrz+NsbXFeLlhGYN8iwHCZWcQUonU/NTNtNaeVRpWHxgB2ZmBNLZvNW6eH0KyUsRUnyUCPanWSGwnmYMLbRov9rlyjlcOgWPhfTcgksuVSA7ekYbv/FaY0mjZHmtm+aioGBT+66zJtV0cjN+WLgKoFiN3H3PsWcVC8hPVsjxXdl2Ik9HaVTYRIqw7VXiGj7uxjI7p82vnYoRDnYkIIRSE+gzvefeiN079ZUQOkiWr93sFIJwhhmDZ7W7rlEa7obHJg29PVdJlfVy/gltCid8SMPAYqvGQDu/dn84AETM4K7n3pgWjiAigb0xdV+ymGKra0zUIBz46Uke9PtQZzdtwyOShpjng6mWx4XKbJL7m3QA3s8OFu9gP0TU/us4Kk3GsgBqTE4ODZvRWeyp32vcCVzXtqnZ3lodCEyybsF1zR3sOqX34XuDiz1diWXZDtF0B0ePs4U5ZrzxzK57Dv6iravSomDOm s7spS9qR KvDaqZhmzIrreB6K9Yny+xelqRaiz8FXC563dnwd4pQlpXqUBDQlaYbYZu0Sp7lF6NUVkvv6jyO7NzUIK2Fcgm2DwT5xgx9e4at0k/yNyn+Tt7qizehkYFBro77Wb14RFTp/PYhebB/I5MZMrf1pQyMfk+BG3u0/zUvJTeS++BP+g0cSZSp44hVaPuStHv8grJ9Y4QshMGpO/uZVSZ3XZt4X0QdP6WpGNcvpgnphYqHpBuNQFxqF0lWRR2MIgxRv13JjFqSQJwN56Sslb5ACjmpsq6jD8fBfVn5hajeC1DgMboo7TFpGguoClV3IcTRoIVi6iT1hKB4rBMoFqC/YTBPZw3g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 01, 2024 at 01:26:50PM -0700, Vishal Moola (Oracle) wrote: > hugetlb_no_page() can use the struct vm_fault passed in from > hugetlb_fault(). This alleviates the stack by consolidating 7 > variables into a single struct. > > Signed-off-by: Vishal Moola (Oracle) > --- > mm/hugetlb.c | 59 ++++++++++++++++++++++++++-------------------------- > 1 file changed, 29 insertions(+), 30 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 360b82374a89..aca2f11b4138 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -6189,9 +6189,7 @@ static bool hugetlb_pte_stable(struct hstate *h, struct mm_struct *mm, > > static vm_fault_t hugetlb_no_page(struct mm_struct *mm, > struct vm_area_struct *vma, > - struct address_space *mapping, pgoff_t idx, > - unsigned long address, pte_t *ptep, > - pte_t old_pte, unsigned int flags, > + struct address_space *mapping, AFAICS all this can be self-contained in vm_fault struct. vmf->vma->mm and vmf->vma. I mean, if we want to convert this interface, why not going all the way? Looks a bit odd some fields yes while some others remain. Or am I missing something? -- Oscar Salvador SUSE Labs