From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C458CD1296 for ; Thu, 4 Apr 2024 12:26:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 748F96B0092; Thu, 4 Apr 2024 08:26:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F91B6B0095; Thu, 4 Apr 2024 08:26:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59A636B0098; Thu, 4 Apr 2024 08:26:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3AB486B0092 for ; Thu, 4 Apr 2024 08:26:22 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0173D40589 for ; Thu, 4 Apr 2024 12:26:21 +0000 (UTC) X-FDA: 81971772204.07.71070F2 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf21.hostedemail.com (Postfix) with ESMTP id 8FADE1C0012 for ; Thu, 4 Apr 2024 12:26:19 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="qofd5n/t"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=axmGiTcH; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="qofd5n/t"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=axmGiTcH; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712233580; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kaNBuiDg+Yyb0ktBS/Z1u/Z6C+/cWf4P8ez4emkur5c=; b=xJ/PV1bLNhGDDpvGXgYgxTbecf3ntLE5MHXwsVZCOvcFooKsvMCI1Iu+Uy0tn8UBh6CJNl /MKlBl2O53a5rGfQmPH/z9eR8MGgNt3dpp6t60A36RXKP/tdm5Odofjgb+4gXs1zf26QGw xKFFlr87hSEJGuwWzjyjjfOmI2I0eBw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712233580; a=rsa-sha256; cv=none; b=1HFauPNR2LzC5p+RRktS/g58OdSv94+N2XgMdeA0KXUGr5l045jOCvQw/AgqrhyzxtGEvC 4m9yCV5naVMILPxytZnPRSwB/vu4GzUM88aEOWfMHNJcv5cukX6i3/58iA9Ad7HqIgbr+k 6TkvK2yoGQzm3tYurPovgB58H/taFCI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="qofd5n/t"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=axmGiTcH; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="qofd5n/t"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=axmGiTcH; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E40225D942; Thu, 4 Apr 2024 12:26:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712233577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kaNBuiDg+Yyb0ktBS/Z1u/Z6C+/cWf4P8ez4emkur5c=; b=qofd5n/tkDGjc5eFhdijwPecpVxKwVFrwnJo0HHEfIYVm4D1KQeCM629Q5yYPYYxD1j1lY g5eThqmJ3r9lW7YEz1zrQQKcO2c8jUHTYdaK4Zh33fSw3bq1068Fn+qHBKWeQaAb6353uO V6wlUdL4fSyy0zkjLdxKtKj1G7qe1Nc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712233577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kaNBuiDg+Yyb0ktBS/Z1u/Z6C+/cWf4P8ez4emkur5c=; b=axmGiTcH8F+XOxRTFHuKUxRS/ZYSLNUgepiydq7vuOUX86gOCJJCN9fh2biAwvkUcdCLqp +gr/R2Avugsx4gAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712233577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kaNBuiDg+Yyb0ktBS/Z1u/Z6C+/cWf4P8ez4emkur5c=; b=qofd5n/tkDGjc5eFhdijwPecpVxKwVFrwnJo0HHEfIYVm4D1KQeCM629Q5yYPYYxD1j1lY g5eThqmJ3r9lW7YEz1zrQQKcO2c8jUHTYdaK4Zh33fSw3bq1068Fn+qHBKWeQaAb6353uO V6wlUdL4fSyy0zkjLdxKtKj1G7qe1Nc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712233577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kaNBuiDg+Yyb0ktBS/Z1u/Z6C+/cWf4P8ez4emkur5c=; b=axmGiTcH8F+XOxRTFHuKUxRS/ZYSLNUgepiydq7vuOUX86gOCJJCN9fh2biAwvkUcdCLqp +gr/R2Avugsx4gAQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 82C1113AA3; Thu, 4 Apr 2024 12:26:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id pYszHWmcDmaSXwAAn2gu4w (envelope-from ); Thu, 04 Apr 2024 12:26:17 +0000 Date: Thu, 4 Apr 2024 14:27:37 +0200 From: Oscar Salvador To: "Vishal Moola (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, muchun.song@linux.dev, willy@infradead.org Subject: Re: [PATCH v2 1/3] hugetlb: Convert hugetlb_fault() to use struct vm_fault Message-ID: References: <20240401202651.31440-1-vishal.moola@gmail.com> <20240401202651.31440-2-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240401202651.31440-2-vishal.moola@gmail.com> X-Rspamd-Action: no action X-Rspamd-Queue-Id: 8FADE1C0012 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: yfo5ynca11f6eoo8m9h6gbf84uron1wd X-HE-Tag: 1712233579-867550 X-HE-Meta: U2FsdGVkX19dIWhKvGGEe3FEs5dV94Xckr0+2eO5YNwJfsSRgYOkbLUnkjXBemMDU8o1zEsPx7nOdpfpXWD7qsvOxvPFfI6XhYeDcbmqWbY++3SBoFhKQyuLE6Dmx8lxlZGVoDSJtkOQsWIFeN8ZAgrNavSAzXVm+Q7kGFMdKVuKn69buzNxHWQ1Oy/YQwvRPUk7y+YBXzii2qQAa5woytR3xb/THJkA0LpXJ+PLlkeny+zBdxWfE9u1z9+oLlj0sU+Cjd1bcA7XTFslpL3JQ39fM/ucW2vpAq8u4YmXcDwh7IT8Wko89+G71BOpl17dWGIvatMBFbeYO/3DQ1pil5Sb31iIZvEJdhesWVe7CielRL8ASUIHq4utnob8fENMCNuVE1X6TFwgm/Bu4wslgSEgWIzRl7qLwaK0OKpINFlfTq/RW8DAuN9UlSP2DoorMOUBpEzspSx/KHO4gMH2i+Myk4vZz6akPiDuVAX5JhaK957fFGpkXNdPk1U2XQzKE/KX9brPCcMsGo07XMkNc/xWe/HYGNfisrZp9EUHG4ybV4+2kh0jKVkyXUfMujlFSdzK/YW/oqGt4AgGFL2yDISHashbGlLePHSDz3RmF4Aw+d74dxKQX/+EhGYffV42yOGVdbNIc0wk/uYFkmVnTe/BZNNiTruSifnFs6kjJVQYWZrN37FF2c5UQWNlTl4b021tJLnAcNx160g+k6Jwx2gYL+aU5UlrwzKQq3nzZEX1ehZ6Izor8vNQQEmyXyJxAlGlU6/rHln1fsqKHoV1z3umi2h5cMFGypmuKII1hbNlkl0Rv4txpa96FSUZOGvtiv/n7pnCkDtGso+7OPIlxXBo0frp2wu4tj8pQvyGumYMto45MNpOeTsAhVIaj4OrAU3hR8RIn1fggXh4w9TVJzndEFSC/99fsHR4+XlckuWr2NeZ0QptF2NGleoQpSpgATUAGbnuL9uxqiHrD8W Vy4hMkBz V93zG+/ztjaAjPsyiduHbq0w6xIYEtr8Np3oHfwW1+yhSw3cZD1uOHpsSi9/glkLetazUcmhF3UT8Ca3/x+LG8CKYMFg8ezuk0BfukOUeIr8FZLOaFWIot2cjOyehzxG5CcuM09eyHxuOU2kU+T0GXoi1hYTLjMD/stMlaP255qDY1T8bmbN3uaWhmNwd7jrzbYmp7foqHafSb9u1Cjiv/ANfd8rc869YmDSnm1upy/mE5W25STsnzLAmqsNLShio3AKkjgL8H6A9kwhQrPpTXcyKMpW+Skc5ObtxPMot941Uc8s3259/gOBtCNOtWDVHnc4scrFaE247SLS9LM+Z0LZX4w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 01, 2024 at 01:26:49PM -0700, Vishal Moola (Oracle) wrote: > Now that hugetlb_fault() has a vm_fault available for fault tracking, use > it throughout. This cleans up the code by removing 2 variables, and > prepares hugetlb_fault() to take in a struct vm_fault argument. > > Signed-off-by: Vishal Moola (Oracle) Reviewed-by: Oscar Salvador A question below: > mm/hugetlb.c | 84 +++++++++++++++++++++++++--------------------------- > 1 file changed, 41 insertions(+), 43 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 8267e221ca5d..360b82374a89 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c ... > /* > - * entry could be a migration/hwpoison entry at this point, so this > - * check prevents the kernel from going below assuming that we have > - * an active hugepage in pagecache. This goto expects the 2nd page > - * fault, and is_hugetlb_entry_(migration|hwpoisoned) check will > - * properly handle it. > + * vmf.orig_pte could be a migration/hwpoison vmf.orig_pte at this "vmf.orig_pte could be a migration/hwpoison entry at ..." > - entry = pte_mkyoung(entry); > - if (huge_ptep_set_access_flags(vma, haddr, ptep, entry, > + vmf.orig_pte = pte_mkyoung(vmf.orig_pte); > + if (huge_ptep_set_access_flags(vma, vmf.address, vmf.pte, vmf.orig_pte, > flags & FAULT_FLAG_WRITE)) Would it make sense to teach huge_ptep_set_access_flags/set_huge_pte_at() to use vm_fault struct as well? All info we are passing is stored there. Maybe it is not worth the trouble though, just asking. -- Oscar Salvador SUSE Labs