From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48FE0CD1292 for ; Thu, 4 Apr 2024 12:00:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE7E96B008C; Thu, 4 Apr 2024 08:00:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A71E16B0092; Thu, 4 Apr 2024 08:00:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EA586B0093; Thu, 4 Apr 2024 08:00:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 713E06B008C for ; Thu, 4 Apr 2024 08:00:57 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F25E112108A for ; Thu, 4 Apr 2024 12:00:56 +0000 (UTC) X-FDA: 81971708112.25.0E8D882 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 3C8D110000B for ; Thu, 4 Apr 2024 12:00:54 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712232054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qfuooD1IfgatoIS7OAIU70Y79yHtd6slmR6Wd2lGo90=; b=JL6neeTGpLTO9+1Xl/TYWy2P+Pmy5OyPpOZaJPVHvbPR/6a9OezJKRtQjFPu5u7DUmqC8Y CbmLXqc6FMrpAjt0trw1oU7GtlDP1Zoo/seKLNGFoxxX+drYt3060mq2uvDtD6jGROBIMq aldHr+tVjiNIn7NKQqRuGX8n0YplmS0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712232054; a=rsa-sha256; cv=none; b=mp9LGfCqaEzWwqtkH1wOGO3Ev96NoF6UMxzaMv3QV0J80pysB1Af1WOsLzfhdzUaVy3Ehh 6oWDIGo6OrS6xFBMVR+KRhws3WcZFT1cx9Puj+k9/urWIqYlF4jv0lm77+oH7gi6etTXte lUqA7wQPifIoX5DJNzhKmT84FIBUx9s= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-AlYLoHugORm-zKs_6Ldi6g-1; Thu, 04 Apr 2024 08:00:52 -0400 X-MC-Unique: AlYLoHugORm-zKs_6Ldi6g-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-69939cb15faso101786d6.0 for ; Thu, 04 Apr 2024 05:00:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712232052; x=1712836852; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qfuooD1IfgatoIS7OAIU70Y79yHtd6slmR6Wd2lGo90=; b=MKTDH8OAoQVCW5YDLH/HiAdoG6ES0fnSp8gOor9r7NCsQzp2Zg9aaTvuqTe3lnfcXG 16Uf1tWGBlGfu5d5uQSftCN4B0QvmxXm4PjqKM1C060YJ3hJLtriuY07/AvJOwsLVBge auaqH9+zTk/hwcUuIaIeTo31fWvF1dN6AWVKthIF9C+QVtxH4CJEgs5ndGazY+X77eVL 5fiCpRq/gtYzQoaJTFZQGNqtEf0LaYe/RgoXf1FU1o1A3shfvWfxPCf/JhG9siCw0/Pa CIwQk0HpVjaNlx4WAY92gkgX6eBBD49+ZgHeacwPMVPeoPE7cSMwUBwRZTu0+l+uBKSa xr/g== X-Forwarded-Encrypted: i=1; AJvYcCWuflMk5rqcBjK0ITZb/C7/8tVJTlrUGShl8t1Ck493b7fSIryLjermY4QyFeQhQ05JDUYp3mDpH4j1a0EC0AhRIyc= X-Gm-Message-State: AOJu0YzMB8SP3AWe3m9n7oUvTvozjuSi6KT0sgHtcURrqlLsN6IwgXvy y5cYSoJExC01+0JwjXpaeHiqWQd1zdkn70nNT5wkc3ZQISrzbHfJ6RIB5+DdTivWtfB2DTciIH7 AtT5iEdg+46CU0EfYje/7TsIY4OYPnCl1H4ey9pX9n96efQz4 X-Received: by 2002:a05:6214:5007:b0:699:4d3:98dc with SMTP id jo7-20020a056214500700b0069904d398dcmr2122704qvb.0.1712232051120; Thu, 04 Apr 2024 05:00:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGMCWtQWiLpesBQTQo5kp7GWlhuKWfgLgdLeENDjrnl6Gj4+sgwXTUEXT7yElLHvch56DwpwQ== X-Received: by 2002:a05:6214:5007:b0:699:4d3:98dc with SMTP id jo7-20020a056214500700b0069904d398dcmr2122629qvb.0.1712232050343; Thu, 04 Apr 2024 05:00:50 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id jf14-20020a0562142a4e00b006987021a724sm7171209qvb.118.2024.04.04.05.00.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 05:00:50 -0700 (PDT) Date: Thu, 4 Apr 2024 08:00:47 -0400 From: Peter Xu To: Jason Gunthorpe Cc: Nathan Chancellor , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi , "Kirill A . Shutemov" , Mike Kravetz , John Hubbard , Michael Ellerman , Andrew Jones , Muchun Song , linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox , Rik van Riel , linux-arm-kernel@lists.infradead.org, Andrea Arcangeli , David Hildenbrand , "Aneesh Kumar K . V" , Vlastimil Babka , James Houghton , Mike Rapoport , Axel Rasmussen , Huacai Chen , WANG Xuerui , loongarch@lists.linux.dev Subject: Re: [PATCH v4 05/13] mm/arch: Provide pud_pfn() fallback Message-ID: References: <20240327152332.950956-1-peterx@redhat.com> <20240327152332.950956-6-peterx@redhat.com> <20240402190549.GA706730@dev-arch.thelio-3990X> <20240402225320.GU946323@nvidia.com> <20240403120841.GB1723999@nvidia.com> <20240404112404.GG1723999@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240404112404.GG1723999@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3C8D110000B X-Stat-Signature: 5mnxsyrx6qt979kc8h5a3puwyetgs959 X-HE-Tag: 1712232054-495958 X-HE-Meta: U2FsdGVkX1+NYg2L0MYD/DHHsODU5jndmMZc8hKgNU3lIC/rkvidwg5/cDU+d81UiESCKPMQE+8iMXcMCUkl17HFz79eOmLkFatnzwJ9/oAewP9bw7B+5jO+/NAx5zyt7lEeNvPCcYt6UE7upNS1T7Wnrx47QQUiaq4wMpb6kBGiL4zckGqlc+eKHgUiUtYQIXT+WRn1QRgB7A46GpLvRD74/5VUsfVtcFZErfw44N8aCxlM1qFyyFTRvzlnmBhs5gyg4E/xSToG6PBp3FI5e6+Xne9bNOoEBKkTlkH1WnP0yrAuUZb/zxpllQvDzJ7pgmd7mSc8GnIFtYZfhZrkuLhTR48K7iT7fRGHLtZH9ZVZcCX9rzMrRMrP3kT9ioWWezHbthYIXoTyegrqLd8kY3JEZqWQF2g6ymI24llqVudJHdSGEgWcMOTFCdjggnlxYqn77YCwNAQfOhzdU1R7SQtXVgiCPhv1dd/fqcd0axjRf2b0mJYIbyRKf8QDkC4a5LeHwnFufDQukcV0mvm/fFUZYx/PuMqjk19/pgYXTb7LXXbHUymE2Ye215y+6iK74Pn8tNR3ApptZakywxhTWGMHDFqPVyu1+n0HKXzBpp9YSJ7wmy81a5hPPzXjTAnQM+lDRIF43dDbeo4z2rghQeV2hMTZkEcGcLdT65yk4p6AJ82eFTWrs0wON/18jB9tJqxRxYvga1ELstZO7fgX2SbyOQC2VYCWnd26LYSTf9hfOCEmiP08BVC+CZvYNS9fDQST7TxaoIEkzzrS1ZmAubP0uh7xI0UtcQzibQKsdzJTjOQFDatAJmf0zyOi3do5/I3G9XRX1jhMoQn2C4n5r2ddBzdfQjWR706wfef6M0E86m90WyMNr6X6V5ROMMR/bySzlRUYvUQKWMCSpnkuNef+yjSTPrbGf5squd6uweW4eSahsa2seE7fWdkt/oZKaXokvzdn2bfDLuGHKDZ bfKyKN+G dvkONTcS72Om3Up7kBER9BAuk9B32ZyFtx2tdYsSqjYYIbWjqIuu4erxw2cHp2uDASVWxifsRUHrupRMHFTjMh/Ix3W3zNAp3Irs8Au97L0u7/FXhacXNK5p2gs+tkqj+9JONtF0BYqttPXo2AtKzxaJjrXQLQxfSQZc0LZFw+IDi3Rnz1UMG+CTJeI/xfeKDsOb1E6hyVpAXnANF/pgrNOOj+u2ohDA7wS9FZIW/twn/GNMzfnBQTS1TE80nyEVdUKgASL8yqeps5W6avsKj77n05INVNFsLOL4Q4KT3tNoQSMgs3J2lGhykE5mdsFpXNCMNiSHp7kjHHAQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 04, 2024 at 08:24:04AM -0300, Jason Gunthorpe wrote: > On Wed, Apr 03, 2024 at 02:25:20PM -0400, Peter Xu wrote: > > > > I'd say the BUILD_BUG has done it's job and found an issue, fix it by > > > not defining pud_leaf? I don't see any calls to pud_leaf in loongarch > > > at least > > > > Yes, that sounds better too to me, however it means we may also risk other > > archs that can fail another defconfig build.. and I worry I bring trouble > > to multiple such cases. Fundamentally it's indeed my patch that broke > > those builds, so I still sent the change and leave that for arch developers > > to decide the best for the archs. > > But your change causes silent data corruption if the code path is > run.. I think we are overall better to wade through the compile time > bugs from linux-next. Honestly if there were alot then I'd think there > would be more complaints already. > > Maybe it should just be a seperate step from this series. Right, that'll be imho better to be done separate, as I think we'd better consolidate the code. One thing I don't worry is the warning would cause anything real to fail; I don't yet expect any arch that will not define pud_pfn when it needs it.. so it can mean all of the build errors may not cause real benefits as of now. But I agree with you we'd better have it. I'll take a todo and I'll try to add it back after all these fallouts. With my cross build chains now it shouldn't be hard, just take some time to revisit each arch. Thanks, -- Peter Xu