mm/gup.c:679:22: error: call to '__compiletime_assert_382' declared with 'error' attribute: BUILD_BUG failed

mm/gup.c:679:22: error: call to '__compiletime_assert_382' declared with 'error' attribute: BUILD_BUG failed

[Miguel Ojeda]

Hi Peter, Andrew,

I am not sure if this is one of the issues that Peter mentioned [1] to
be resolved or not eventually, but I have spotted this in the last
couple -next runs for a LLVM=1 loongarch64 defconfig build [2].

Hope that helps!

Cheers,
Miguel

[1] https://lore.kernel.org/all/ZgMzaMu7oILiNLcG@x1n/
[2]

mm/gup.c:679:22: error: call to '__compiletime_assert_382' declared
with 'error' attribute: BUILD_BUG failed
679 | unsigned long pfn = pud_pfn(pud);
| ^
./include/linux/pgtable.h:1887:23: note: expanded from macro 'pud_pfn'
1887 | #define pud_pfn(x) ({ BUILD_BUG(); 0; })
| ^
./include/linux/build_bug.h:59:21: note: expanded from macro 'BUILD_BUG'
59 | #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed")
| ^
./include/linux/build_bug.h:39:37: note: expanded from macro 'BUILD_BUG_ON_MSG'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^
note: (skipping 1 expansions in backtrace; use
-fmacro-backtrace-limit=0 to see all)
././include/linux/compiler_types.h:448:2: note: expanded from macro
'_compiletime_assert'
448 | __compiletime_assert(condition, msg, prefix, suffix)
| ^
././include/linux/compiler_types.h:441:4: note: expanded from macro
'__compiletime_assert'
441 | prefix ## suffix(); \
| ^
<scratch space>:48:1: note: expanded from here
48 | __compiletime_assert_382
| ^
1 error generated.

Re: mm/gup.c:679:22: error: call to '__compiletime_assert_382' declared with 'error' attribute: BUILD_BUG failed

[Peter Xu]

On Thu, Apr 04, 2024 at 12:42:12PM +0200, Miguel Ojeda wrote:
> Hi Peter, Andrew,

Hi, Miguel,

> 
> I am not sure if this is one of the issues that Peter mentioned [1] to
> be resolved or not eventually, but I have spotted this in the last
> couple -next runs for a LLVM=1 loongarch64 defconfig build [2].

It's the one reported after that:

https://lore.kernel.org/r/20240402190549.GA706730@dev-arch.thelio-3990X

Please try this:

https://lore.kernel.org/r/20240403013249.1418299-4-peterx@redhat.com

It's already included in Andrew's latest mm-unstable, commit 8c9a7c14a7d4.
I don't know how fast it spreads to -next, but assume it'll get there soon
too.

Sorry for the issue!

> 
> Hope that helps!
> 
> Cheers,
> Miguel
> 
> [1] https://lore.kernel.org/all/ZgMzaMu7oILiNLcG@x1n/
> [2]
> 
> mm/gup.c:679:22: error: call to '__compiletime_assert_382' declared
> with 'error' attribute: BUILD_BUG failed
> 679 | unsigned long pfn = pud_pfn(pud);
> | ^
> ./include/linux/pgtable.h:1887:23: note: expanded from macro 'pud_pfn'
> 1887 | #define pud_pfn(x) ({ BUILD_BUG(); 0; })
> | ^
> ./include/linux/build_bug.h:59:21: note: expanded from macro 'BUILD_BUG'
> 59 | #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed")
> | ^
> ./include/linux/build_bug.h:39:37: note: expanded from macro 'BUILD_BUG_ON_MSG'
> 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
> | ^
> note: (skipping 1 expansions in backtrace; use
> -fmacro-backtrace-limit=0 to see all)
> ././include/linux/compiler_types.h:448:2: note: expanded from macro
> '_compiletime_assert'
> 448 | __compiletime_assert(condition, msg, prefix, suffix)
> | ^
> ././include/linux/compiler_types.h:441:4: note: expanded from macro
> '__compiletime_assert'
> 441 | prefix ## suffix(); \
> | ^
> <scratch space>:48:1: note: expanded from here
> 48 | __compiletime_assert_382
> | ^
> 1 error generated.
> 

-- 
Peter Xu

Re: mm/gup.c:679:22: error: call to '__compiletime_assert_382' declared with 'error' attribute: BUILD_BUG failed

[Miguel Ojeda]

On Thu, Apr 4, 2024 at 1:57 PM Peter Xu <peterx@redhat.com> wrote:
>
> It's the one reported after that:
>
> https://lore.kernel.org/r/20240402190549.GA706730@dev-arch.thelio-3990X
>
> Please try this:
>
> https://lore.kernel.org/r/20240403013249.1418299-4-peterx@redhat.com
>
> It's already included in Andrew's latest mm-unstable, commit 8c9a7c14a7d4.
> I don't know how fast it spreads to -next, but assume it'll get there soon
> too.
>
> Sorry for the issue!

No worries at all!

next-20240405 contains the commit and, indeed, the error is fixed for
me in an LLVM=1 loongarch64 defconfig build-test:

Tested-by: Miguel Ojeda <ojeda@kernel.org>

Thanks!

Cheers,
Miguel