From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 808B3CD1288 for ; Thu, 4 Apr 2024 01:38:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 144606B0083; Wed, 3 Apr 2024 21:38:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F5156B008C; Wed, 3 Apr 2024 21:38:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F26076B0092; Wed, 3 Apr 2024 21:38:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D525E6B0083 for ; Wed, 3 Apr 2024 21:38:36 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6D2981A0101 for ; Thu, 4 Apr 2024 01:38:36 +0000 (UTC) X-FDA: 81970139832.25.E5A4318 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id BBD1EA000C for ; Thu, 4 Apr 2024 01:38:34 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EZBS2WpY; spf=pass (imf15.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712194714; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c8stO057qLPT7BfAtB8i7nXQMVG/pdLRidGiWvNqCGw=; b=VYxpdP4qQAi9QxE7GmJ/gmdEt9H7ESXMwMIZEc7wl1u7OHGb7x7mreb8ZacTKijj8gyEhW QaUtG8rebAUqvcdVb7yrfiZOjrF7BcbjUdlrtvPn5AFbd7jqcGCM0p7sMIOo5SI89bDc88 FS8d191QiU4YMWL9LCQW3GSxzlCHJqs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712194714; a=rsa-sha256; cv=none; b=a0VcBqmY+aub8PX/Ucrhi8B+0G6iL64NdQA3k0UP+EjIK6GmYQBQAFqvo1sdiCmBZNQ7kt NMgMfCessTdJZur4uEerKbFjmhjEtyYG739XFmdkwwsZEYpWQoV3AMYjC+AlMX8AQCZKkQ D5Cmy+g94hIYPa1StIKfpfh6EdRgb7c= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EZBS2WpY; spf=pass (imf15.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712194714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c8stO057qLPT7BfAtB8i7nXQMVG/pdLRidGiWvNqCGw=; b=EZBS2WpYnfMZkL9atY7BlH6vKyL1J72c8C/D0lb5z7hYHW4++tOWPK8v81R0pjZrq3wvJQ Jhuq440nIKGj7coGD0V4uLkaoOkUgokH19jGq/r180SUvjOEmB0YIjANgNrPQx3tz6bpTB n3NZNNk+MX7lJxBxCp7c877/bJg15Fg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-230-zZ2ZAB-WMjqNX3_n4qPIMg-1; Wed, 03 Apr 2024 21:38:30 -0400 X-MC-Unique: zZ2ZAB-WMjqNX3_n4qPIMg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7CB69101A520; Thu, 4 Apr 2024 01:38:30 +0000 (UTC) Received: from localhost (unknown [10.72.116.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A562C1C060A4; Thu, 4 Apr 2024 01:38:29 +0000 (UTC) Date: Thu, 4 Apr 2024 09:38:12 +0800 From: Baoquan He To: Mike Rapoport Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mgorman@suse.de Subject: Re: [PATCH 1/7] mm: move array mem_section init code out of memory_present() Message-ID: References: <20240326061134.1055295-1-bhe@redhat.com> <20240326061134.1055295-2-bhe@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Stat-Signature: c83dzbdegbunzutp8pfk5mzy8dw4hn4f X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BBD1EA000C X-Rspam-User: X-HE-Tag: 1712194714-33144 X-HE-Meta: U2FsdGVkX1/Pao2K3xyepR6OMzVwKSKuSJmsH3Zr4t9u9RvB7AKCaMQ2/cCJGXO8bmr3q3JfYD1r3u6Cs1MYHFtJPLVDI8S9wzQCdWWAdu0o0hVjRe2uVdV/+XwJMEIlMg0ros+ppEUg4A2/79fvyAzVta21SOmCbr4svTZXSLm/NREKe4x8cSt3oNfnOKF/mW5urj6KlBKIVhbA2GqqQ9iSgMRk1YspYvBuUwHnGDX2FdWnLW6jGJkj4dhnwloTRSVRLJB1uKSS57MXgqLzvGMpZQkK3PTT7Vz4k7WapmTFyErvXqS0xWETdj+HJt2GBGO0ha+wG/pM0qTNzBqD14oniixl4f6vU+JVMaMZP9/QhWnlOIuk/EOSyPw59MQMehzodI3D0Qlc545MofhadmLX0cbnJN+T2PJZmirDVK51CffI+Wb9Idm+dlgeVE4iL1o112Vzm1yzSERX+YuL9i5IbkcZxGuojx4/Dp7ON6PIT0nbOZm/k+t65alFwLO4QqKA7EgnF/jlYutX9smRmiXcvtXAeoIZskOVYlK+MueiH0H+38Tpi+opUG4g0w1JMdZtfWULXQWBeZyAutXRcqj6HIoTHf35cy/uwp2DGcg2ITlfNA4/QeKqHLnjEwSRpu+dX3mXvOOqE6E2+J8O2i96ubTgk7kTSA4PPw5wXYs5f7reYqhCvWXgI5dgGz29HzIc1gqYMylJWLsNVetJTQxrQ7NLB62zOB2w5n3JTnuSVV1+xqmhYFdnsijMMBmvpWacCFO5qzjSgZ5jIrjclSCoBqIMRQALn42565VtiJ7OEe/jvyrpPEAAVhqBCtBpRxiJi6wdmO5ycxeXxZpG4luntfbVkg0qWKn/C07w+yKbGY9m9zDqxcwAApJvZ3XYUK4+7zVkoGPj+oJUbrqZ9ESPlHHN3Tu71VUQr0l4dQJ0yn7mw9yBBbzXi9vpX1tm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04/02/24 at 11:19am, Mike Rapoport wrote: > On Tue, Mar 26, 2024 at 02:11:27PM +0800, Baoquan He wrote: > > When CONFIG_SPARSEMEM_EXTREME is enabled, mem_section need be initialized > > to point at a two-dimensional array, and its 1st dimension of length > > NR_SECTION_ROOTS will be dynamically allocated. Once the allocation is > > done, it's available for all nodes. > > > > So take the 1st dimension of mem_section initialization out of > > memory_present()(), and put it into memblocks_present() which is a more > > appripriate place. > > > > Signed-off-by: Baoquan He > > --- > > mm/sparse.c | 26 +++++++++++++------------- > > 1 file changed, 13 insertions(+), 13 deletions(-) > > > > diff --git a/mm/sparse.c b/mm/sparse.c > > index aed0951b87fa..46e88549d1a6 100644 > > --- a/mm/sparse.c > > +++ b/mm/sparse.c > > @@ -226,19 +226,6 @@ static void __init memory_present(int nid, unsigned long start, unsigned long en > > { > > unsigned long pfn; > > > > -#ifdef CONFIG_SPARSEMEM_EXTREME > > - if (unlikely(!mem_section)) { > > - unsigned long size, align; > > - > > - size = sizeof(struct mem_section *) * NR_SECTION_ROOTS; > > - align = 1 << (INTERNODE_CACHE_SHIFT); > > - mem_section = memblock_alloc(size, align); > > - if (!mem_section) > > - panic("%s: Failed to allocate %lu bytes align=0x%lx\n", > > - __func__, size, align); > > - } > > -#endif > > - > > start &= PAGE_SECTION_MASK; > > mminit_validate_memmodel_limits(&start, &end); > > for (pfn = start; pfn < end; pfn += PAGES_PER_SECTION) { > > @@ -267,6 +254,19 @@ static void __init memblocks_present(void) > > unsigned long start, end; > > int i, nid; > > > > +#ifdef CONFIG_SPARSEMEM_EXTREME > > + if (unlikely(!mem_section)) { > > With the new calling sequence sparse_init() -> memblocks_present() -> > allocate mem_section, mem_section here will be NULL, so this if is not > really relevant. We might want to add WARN_ON_ONCE(mem_section) just in > case to catch multiple calls to sparse_init(). Sorry for late reply. Hmm, I am not very eager to add WARN_ON_ONCE(mem_section) becasue as you said it's not very relevant. Calling sparse_init() miltiple times is not acceptable, while it may not be good to let checking mem_section in memblocks_present() to catch it. > > > + unsigned long size, align; > > + > > + size = sizeof(struct mem_section *) * NR_SECTION_ROOTS; > > + align = 1 << (INTERNODE_CACHE_SHIFT); > > + mem_section = memblock_alloc(size, align); > > + if (!mem_section) > > + panic("%s: Failed to allocate %lu bytes align=0x%lx\n", > > + __func__, size, align); > > + } > > +#endif > > > + > > for_each_mem_pfn_range(i, MAX_NUMNODES, &start, &end, &nid) > > memory_present(nid, start, end); > > } > > -- > > 2.41.0 > > > > -- > Sincerely yours, > Mike. >