From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89A11CD128A for ; Wed, 3 Apr 2024 21:17:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08BC16B0088; Wed, 3 Apr 2024 17:17:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03BAC6B0092; Wed, 3 Apr 2024 17:17:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6B566B0093; Wed, 3 Apr 2024 17:17:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CE3E86B0088 for ; Wed, 3 Apr 2024 17:17:50 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 955671A0351 for ; Wed, 3 Apr 2024 21:17:50 +0000 (UTC) X-FDA: 81969482700.01.0C11467 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 931C114000F for ; Wed, 3 Apr 2024 21:17:47 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pJxSWxLB; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712179068; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dhmHDghsoZGRMIWGZP8kxp/Kdut0xfj1D+ElrVbM3AA=; b=JrOrFh2Pd5/85T8aTH9Y4OCWk9siFoAmr//oKqJEPOQWwOSr94sN3kTSl8gGvPjuaM/COP lWXEhWjErWh1Wdy9MatOExBHoYYCgipg86wg5IU3Ro58PLwSPB0SkgDml4U1iNrFHsqCpt x06auDjDin1GHDZEqjhBGLoKcX2apDs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pJxSWxLB; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712179068; a=rsa-sha256; cv=none; b=AFlqkkh8XSHSC8dmcQ+yngi+Uz3GEnRtmDA5pkIok+oQvCsOm4zTfky66DLfIIzMBAypjB 8MSaL6CRraZul0JbCf3RdDV1ZywUM1qRwgrqQGRlQZY9ug92w2Sv1xuXBy2oGmadk47FeL GwOLoz01OuM83sjWiqX1JFzPo7i/2R0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dhmHDghsoZGRMIWGZP8kxp/Kdut0xfj1D+ElrVbM3AA=; b=pJxSWxLBLof/DbjXwllW6s9Fgn bjMWcYDVMRbqVRMHmkE0Wj3SgkI2006kSyqjnfoMKcQPt47UgoK9rAVghmWzUogwuearbYlgXUtHx CS6LQSWkiEDK+o2RpcHKJn6KBWW7VRzLlI5a4sxHhbT5yKsej21JMfKH3me9jHE/YleH6540PIA6x Z/UHqRr+/tVHbGkJ2+/nm9Wogm7lqFZBB6diJW7FiCEb5TpDbj84pJ8UfwHYcxD03WI7ZBaV5sAKO akl59/uFiWXWGqwvvFZzjyYkPzGnO4/a5Eq1Tb7fpxtzagNQHmudo9AgcZk3vNEl+/6gMItFVy4pB qCsPnitg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rs7zN-00000006U4k-17ln; Wed, 03 Apr 2024 21:17:45 +0000 Date: Wed, 3 Apr 2024 22:17:45 +0100 From: Matthew Wilcox To: Oscar Salvador Cc: Muchun Song , Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH] hugetlb: Convert alloc_buddy_hugetlb_folio to use a folio Message-ID: References: <20240402200656.913841-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 931C114000F X-Stat-Signature: ro7gijhhd1rp1uhwpzhouxr963rtehbp X-Rspam-User: X-HE-Tag: 1712179067-799123 X-HE-Meta: U2FsdGVkX1/bSi4TFaWEjtNdVyTzaChKUKdq1u0H73qAHn9jrDmkHLW9i7AEXheJ2X4TLceL5gpdGil6k2ZwA93g1KPjO9spsh2zibukETfVAZY9y2D044LUkJBVmp81Cc3KvpPYMu/TDzsrnfOl3EU/45qVH11OsaMDKZjDzHFGrpyJ762ShJUj0W/YDJ1z7CsiNvj4D7FQ9s+QlifTayskrKyRh4Gh6GAxFsrTXKHsst33B3nRvfb/gnmEKaXShdMjwrlW3AiEKiQ/5StWgq49Cgj38Yzc8Fk3zbNgzibIglDh5tx41E86vJ5zvhLctZu7B5BM3YifWvYFXwQUTSww8VfXQy+47xI/MHXwt++/DPfopTdtb9y9yTE+pmvJu82LydBCSspMF4M2C5PFxyTdkPih+U1nGBlp7XaiydYxj+EqLutc1NcQ/JVeyOlRIAwIZdFnYRYZ8s40s8j/ZunotLPhRBGgvZM5n/lZbXmn8xFHBVc6Vo/7dgm0gOqgc9KpU/wKEKqKZT+sih0ybikhvAFQI+6zvNlsUA+7m2UDaYowIdGOf7DyR1FAcCje7j31s4ldYY0tnrl/ZumdPk/0IF9Atd6Tslm4ya7GBi2ExKMbsGlwiWY5AOiVBBdagyFfXNfnSL2o1K8H6L0DlWP0lXSeViNQarVsGoODP9Lzs7qCF9eyaFJTcvSY27bZNtgCuwhxHoBr9FnR7XkfnWmmaYLXexDnE34vWiFa8jo01e7QgyvihzGZuBPqf7dnxFt0ZLSAVMruoohjPcEwfXnYxedcnWTlh7Q0Nl8X9NtGK3tARry8EHcX1prZ0xnRFlOiZhwvy+55VhFeRZVouctAoOpX+bwkslWtvWbYhUBfWYyypXBsgmufzw7f8Bt0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 03, 2024 at 09:25:41AM +0200, Oscar Salvador wrote: > On Wed, Apr 03, 2024 at 02:19:19PM +0800, Muchun Song wrote: > > I think you mean this patch [1], right? With alloc_frozen_pages() > > introduced, we could get rid of the trick from HugeTLB code. > > Ah yes, that one, thanks. > It would be nice, but having read the discussion I am kind of skeptical. > > But maybe some to revisit. I haven't given up on it. It's just currently parked, awaiting more cleanups, some of which I have scheduled for the next merge window. Part of the memdesc project will involve not having refcounts for some memdescs. Slab, percpu and pagetable don't need them, for example. I think hugetlb is being unnecessarily paranoid here, tbh. Or maybe this part is just badly structured; if we're allocating a hugetlb folio, it should be fine for its refcount to be temporarily elevated by someone else. Not sure I can figure out what's going on in alloc_and_dissolve_hugetlb_folio() though.