From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D25CD128A for ; Wed, 3 Apr 2024 18:19:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B46CF6B0083; Wed, 3 Apr 2024 14:19:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF6626B0087; Wed, 3 Apr 2024 14:19:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 997D46B0088; Wed, 3 Apr 2024 14:19:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7860A6B0083 for ; Wed, 3 Apr 2024 14:19:29 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F1AEB80C3A for ; Wed, 3 Apr 2024 18:19:28 +0000 (UTC) X-FDA: 81969033216.02.FD7256E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id E9A7F100019 for ; Wed, 3 Apr 2024 18:19:26 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NUn2RWIH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712168367; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xdeUv3Ofjr2iqkst/jH7iP0eOxc0lfoJcFP/WPP4Da8=; b=j9YWgWJIuP3VIyv6ZUzRVD4QO57Kj68tHCmMzJDZJad0EEM8iEQKEVsKrC81ElfufMZeFf Ko0T/0jYqT1ey/MzJQ77c/zXwByS0TlbWIc5iaE7/RDSyG8q2tRTohHSEZoup1LItUTcWK QB3EBzbIAWoTQjr0Q/YDP7ji0Qqw0i0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NUn2RWIH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712168367; a=rsa-sha256; cv=none; b=L/EsdGMGMw98kgyyazitpVBcSkC2Ltnw93DB4xWVuAZ3Ibh9rrVp9O504rlHYJP1yfaobT kWBoswR+HqIUSWVfp0xTRkONbQYvd8mZOn6I33Ix4c3AP/kbfM8oW3bSAfQEV3sFG55d95 bd4OmQZp5qCJ+9WsIql/OfXtcvlbyGI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712168366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xdeUv3Ofjr2iqkst/jH7iP0eOxc0lfoJcFP/WPP4Da8=; b=NUn2RWIHCk2nZogVkzbCR8HWXGAriwl8iVsOU8ZoEyi9M8o0YcYAfSzTHvnnUj9TAoPGZ/ 6Xlzm1UZHrIS5qE91QE9FeD2pFZNC8olfLK8d6mSEOen0CRf2nvfah2omgyd4+Md5jqzcD GFFwaTfqlh+WpUSMx2lv9NBNjdovo8c= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-jXiqw3W2NLqtaesWfk8u8A-1; Wed, 03 Apr 2024 14:19:24 -0400 X-MC-Unique: jXiqw3W2NLqtaesWfk8u8A-1 Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-5a4aaa1bc96so58074eaf.1 for ; Wed, 03 Apr 2024 11:19:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712168364; x=1712773164; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xdeUv3Ofjr2iqkst/jH7iP0eOxc0lfoJcFP/WPP4Da8=; b=h62jGFBalW24Srxq7adw7zAsFlPlhke/BWidDMyy4o4ez1KrG3dlUTj5LviKJm90od 6+b7KaTSiZ8JsdtHECCaixEQAAW07oydgAeXIPdX0UxRHTdgMzvYhL/C3PmQr45y5A2C pv/dqHOXiuJrN8cOg6elDw5G/IGs/lMOm1kMuOqL3ZhigpQNH4iXBz5ykuBF7MMk6c0J O8kkciafCquR52DKkCN7ENIDBKILH3O4cKX15ZzPd+fzKSSfFohR1vOzFptzEFyPkPDE Nx9gwu8OPc0DKC53qnjxl+qzF3p9Wj6L6bE73bREAYtBR4gL10/hW4jJqgHuFHs0CCvv wcSQ== X-Gm-Message-State: AOJu0YycVvWLfB6y45hkM0A3Ppru2Q9dom5/YkzHH/B8emXvnXog+tBM KXUZDcl0Z9Ppg9ImR6eyC/PANJ61fV4OLtcEfCzPS8MHxsmzmHr7tcu4tihMxwyQSCW8reiDEJ5 u81UaMr+CmZVnFO9+CJrEt8lvd55dv6xEv2cORyodidn2Ojdy X-Received: by 2002:a05:6820:ec6:b0:5a6:2c6b:d3b with SMTP id en6-20020a0568200ec600b005a62c6b0d3bmr207972oob.0.1712168363824; Wed, 03 Apr 2024 11:19:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEHn1qy1mV6MIo0wP3BfV0wKGaxVdX31dolc6mtjUrNwwrXrfZXmbb7Bwh6zIgN4DaKiHm6bA== X-Received: by 2002:a05:6820:ec6:b0:5a6:2c6b:d3b with SMTP id en6-20020a0568200ec600b005a62c6b0d3bmr207951oob.0.1712168363366; Wed, 03 Apr 2024 11:19:23 -0700 (PDT) Received: from x1n ([99.254.121.117]) by smtp.gmail.com with ESMTPSA id fa13-20020a05622a4ccd00b00430bc1186aesm6767744qtb.28.2024.04.03.11.19.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 11:19:23 -0700 (PDT) Date: Wed, 3 Apr 2024 14:19:19 -0400 From: Peter Xu To: Ryan Roberts Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Muhammad Usama Anjum , David Hildenbrand , Nico Pache , Muchun Song Subject: Re: [PATCH] selftests/mm: run_vmtests.sh: Fix hugetlb mem size calculation Message-ID: References: <20240321215047.678172-1-peterx@redhat.com> <1c20b717-c5b5-4bdf-8fcd-d46db135b7fa@arm.com> MIME-Version: 1.0 In-Reply-To: <1c20b717-c5b5-4bdf-8fcd-d46db135b7fa@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E9A7F100019 X-Stat-Signature: kdsg3ocnu8wcrgkwh9te5yzw6r8kxage X-HE-Tag: 1712168366-432860 X-HE-Meta: U2FsdGVkX1+PRse7tzf+Ox6Tdds2R3Yw7/sHzZeKxUzr5SwxZABMAOWUIq5RhKvaN8NqXJVpZBK1vwHEsze45KWCwc1AbkGmnDAIDkwIBIPPHLOWfBgUJ7JSRDEFk8WGEUJG24q0PD+YxS++qWu4AdK4s9ZGOhezE+7MKaILm0fxNxN2XVhpNSu+sIh0j7fuMIf8Oc2CKTLvX2HHUSJEnHy0cG+sqH7yjLhh0jgSuDcaHK0X1ZGdO1jyYQgofoXTaA/1ZYjv6wECBYBvStgfJxKyq+ElDu7TTG0V3ZnDVq1wgOP4fdEig1BoH8kDWuIfMhltZvU7l07dU5MPYKCnV9fhqWDb7MqjGpTMjLdt7l1wXO5GF1+IO/w/pn7fBFhmR8G82k7JVmcGVNxfInQounLdBDANyCRCY07I5uNyDcjOud8SNgTqbDEJH6DggT9UXJLa1HpMr62LClQ2V9pjRvvFeFBvVM27fvtxptqm2exjrSlhrlrzIbavBghi3XNkVd7lvHUk6VtfQ1PdQcQySYT+Qd6BYK1kB1+4p+1/JU8QYIVjxZ+I9cKYabT7DVgFMlNUCW/407q9KSybNtq2bXCYIWeD6B+3LUaMPUxh5rg6M+SFOob/NmshNzwQn+RWJwC0xKFcMwS7r/aCunYFNR3x+tx3/BPwJcpj/6XQd0fxNeUPfBwqEwmGeytPFSGsgCKj3e1/4C67lknCtLDqWXQpkDfkmkkdJpdhmCA7/w0LZkx36LvDWopR3zvcUNWBaGsRuKWYeODaabO/cTvOaGhSZigMhYK72Z6heVkp9E9QxjkL+rCq91c2sR2PsM9FHPWfMUVuag0tqpluE0tYwBocDAxMTd0GBU2y5kzbkyxDPtYfObPT2G0sXnH6iwUmTHh3Ir1Xt5EbH1tHuA0Un4kvrgynSagc3AXFz4Nf89e/YEEFILdRGwkfE3HOqZKQNfgZPgsAEa43yT3+tVs MLvLpcNr UigDBRRwFfhJwuj4AFuf7Yr2N+WPJ0JE335iZCHCXW7PawvE+WG+Be7pw3VdW62Q688n0WCBLZh10EQ8nNlL2Sa3qiZS2Nl2uF7ogrMXABUWJX9SKOx2ZyD67gh4FXR92yWDZQ8svcPx2BHOr5wxiCnEqS6P4BFLCSSv6v31pkqrBV7092WwCbxKlencySiT9Ka7hPzyLCtHtb4Jh8wnRLys7ExzC/XtwL5tY1368d/f2uGyeRwd8ZegpSmcTRcPA6bcgE5euJgz9JgHxgiM2rTQeGnCULjzX/Y24K7PTO3YRi58adYOrXXUatNOkU0rsGnlDP03OVuj7FYmpw5HoLUxxES4PYz8DA/a1aj/Q+6V6Mp0gJZKSpizbQXtSVT1yH7sh/TUjC4y6qZ4azmp4j1Woh5kzsZGKwG+UDKeF89vJ77GURviCtExV3bx1Gwwpwt6oYo+Udxw1gnWGjhvroVzukISnh3AER892 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 03, 2024 at 12:04:00PM +0100, Ryan Roberts wrote: > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > > index c2c542fe7b17..b1b78e45d613 100755 > > --- a/tools/testing/selftests/mm/run_vmtests.sh > > +++ b/tools/testing/selftests/mm/run_vmtests.sh > > @@ -152,9 +152,13 @@ done < /proc/meminfo > > # both of these requirements into account and attempt to increase > > # number of huge pages available. > > nr_cpus=$(nproc) > > -hpgsize_MB=$((hpgsize_KB / 1024)) > > -half_ufd_size_MB=$((((nr_cpus * hpgsize_MB + 127) / 128) * 128)) > > Removing this has broken the uffd-stress "hugetlb" and "hugetlb-private" tests > (further down the file), which rely on $half_ufd_size_MB. Now that this is not > defined, they are called with too few params: Those FAILs can be burried in some other libc mismatch issues for me so I overlooked.. My apologies. I'll send a fixup soon, thank you Ryan! -- Peter Xu