From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5362C54E58 for ; Thu, 21 Mar 2024 12:58:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 258B76B0085; Thu, 21 Mar 2024 08:58:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 209426B0087; Thu, 21 Mar 2024 08:58:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AB266B0088; Thu, 21 Mar 2024 08:58:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EBE7F6B0085 for ; Thu, 21 Mar 2024 08:58:31 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B3AEA1C0C19 for ; Thu, 21 Mar 2024 12:58:31 +0000 (UTC) X-FDA: 81921050022.15.640FF38 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf19.hostedemail.com (Postfix) with ESMTP id 5ACDD1A0007 for ; Thu, 21 Mar 2024 12:58:29 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=eDRIT9VY; dkim=pass header.d=suse.com header.s=susede1 header.b=eDRIT9VY; spf=pass (imf19.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711025909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=93QxAQP5ZM16jg+U1fz+z2aWxXn55c/xIhJmz7m/Bz8=; b=3BA2mlD58fmcSsVZ3d27Ngedhil2Sc8sacq2qwV4qRepcJyR08gRSG96vyqG/Nu1aYYM87 tZFYK0WcNiaoYp7PnI4Z+wvZg2HjqJtr/mCxZpwxb1/hniKV5yD52V50+lKlcjiWhw9dO/ TYldMWWE1RXNYQv8HYo3Nl4yA7+/SPM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711025909; a=rsa-sha256; cv=none; b=P9jdAzyxwiI3HY12qV3EUS2ZxtkvDEV5cb289Oj4nHAeE66YOFnYQXzf1YO6olEpKvKyGr RfZjUofvjRmp9wNniH+FLIuFm0jsVlTGDRXHRqphwIueebnfpwUydRyr1JW8/V1hdLae9P WPJaPfjW6+m9Cr61LZxtPbvCMsjX5wU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=eDRIT9VY; dkim=pass header.d=suse.com header.s=susede1 header.b=eDRIT9VY; spf=pass (imf19.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6A6445CE7F; Thu, 21 Mar 2024 12:58:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1711025907; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=93QxAQP5ZM16jg+U1fz+z2aWxXn55c/xIhJmz7m/Bz8=; b=eDRIT9VYSu02snUagXPwSm/gDgHeLUNXI+Hv85SU8wBDFoKf2XkUDe0aHfpCLsVKPaqVrn ELj9Xx5Yxk9fpIvLd0r8tuTMLBR/iXfi5H+xDWoeGOd/y69j0xJ+6rkIU4ZLgN0D/w14FU 4MD7z65xI0Nq9zaDbaBzGCuWOWvt46w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1711025907; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=93QxAQP5ZM16jg+U1fz+z2aWxXn55c/xIhJmz7m/Bz8=; b=eDRIT9VYSu02snUagXPwSm/gDgHeLUNXI+Hv85SU8wBDFoKf2XkUDe0aHfpCLsVKPaqVrn ELj9Xx5Yxk9fpIvLd0r8tuTMLBR/iXfi5H+xDWoeGOd/y69j0xJ+6rkIU4ZLgN0D/w14FU 4MD7z65xI0Nq9zaDbaBzGCuWOWvt46w= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4C460136AD; Thu, 21 Mar 2024 12:58:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id DZvkD/Mu/GXhUAAAD6G6ig (envelope-from ); Thu, 21 Mar 2024 12:58:27 +0000 Date: Thu, 21 Mar 2024 13:58:18 +0100 From: Michal Hocko To: Johannes Weiner Cc: Andrew Morton , Roman Gushchin , Shakeel Butt , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: remove CONFIG_MEMCG_KMEM Message-ID: References: <20240320202745.740843-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240320202745.740843-1-hannes@cmpxchg.org> X-Rspamd-Queue-Id: 5ACDD1A0007 X-Rspam-User: X-Stat-Signature: eyyb7dzdbzaqwi15898h53jzdaredcxs X-Rspamd-Server: rspam03 X-HE-Tag: 1711025909-611163 X-HE-Meta: U2FsdGVkX1+UrmJ8DHhhrPnfZxDuT76hSDZm7GsvV5xh3edzEzDzSdFdqXi2TB/pG/DXZ5p6oNOMfElybiep+KN06Z7V392N5RAsmaa17G+NkY6uI5wvM3hrHkPEzbEHq7oalOkiwe1gp7mnIoUB7JIEOYmuX4ZALElFlPCy0GdMozRoXWefotq6LmxtDiebqF6Zb0PAELYQQiqOeWtCCyGmXYeLEXQxK38a9+ClcrYqaSlQfM+NSEvm2hQvZImt9Tmf6owEByY0WQEtkKFxdhkpFs9WZ5ahz7CXHp7PctOMf1oOq9Q9pilsAplnhTdMDZwB/E67ndBRnot2ORsHhpVU0sKAB7KoeznGCKTykfHHxePrp2HBbcricoS+ZaS1hIIkSCvJ57B1xCd7OR/tCMcSkvCzV0iaUxMibUtKTdSu96nrDISlWJnC3eLJlj42ieLI/n0XWiF0Do8skjqAKFMHt8A9EQxUl1yKBEP+TeofmpWG1xn4AeN99v9SJZDk86SB5Ag5axe3CsnKMxXcK/GKIzjvFzaY1u+YrXg/tRQ9Wup90OAoNq6p+YhYPcjUrzYkY+4WFJ/Ens72YlMoMpiWAsBaQemKSke9ug/g86flDPs/blDqKd9RpAnbdVRmvUpGfduzk7Gaj8k9oiD72La8h7aLiQwTZ+2h61JeCO4w3Ln9jc5TxEnfFXugbWCG85BXM4o4iCBC8F8Mtazw7oAazVfMN7boFt1A5JshoJ275OuB9fCvbGjRXiBXxek2teHPLcyqsjWoDbKkAPmNxJyQhsED6zVhiWzPn2yxc8zd25oTdkS0o54GepT1693NYhZpuhIXhWPWnYrCI26kF17ejD1glzUJoaXOn8gIv4SIRr5s05mUqeJTW8k6JdnFIqhmsUoNHXpyyvwWyVNFPBWB+Zq6A3rXU2p4nMYoObILlyjSUQyQJInJd+LhrjADEpgSzOOkSsTxsMuB57g QV4Atn0o noecapLW0+dzqmDke9unHBZGtPtcjVC2E1x2waP+WnUIdcYMKwlbqo55c+dDL5SjkccpOkTv3LY2Hcinv8pNzYmnP+bQmFJWkfI6NJAVSWne0PDQK5nTQ3yxVuekK8YjEnCm1gpvM2NC6vxe64CDPXiPsUycd8lkyBYQ3Y0IcDfNb9Par35dn/A1TVZT4wuPC6yYuiz5Mdbg+6ArrnKRu4WdTyoUvJaQqX+RdIWvc9I7sTQz6uMwgG4DS0Brf1u4TyUJIJVITAYd9G+wVw0vT73chXwDktIUzP8C9XzzQOo3fzQ2eWXQUeWRM5qowqJrr05c+y2VypHaiJjnLH5UkL6/P7PDehLUvHCbZAImD/PmQYloF7/sLsVc70etxhCY3P1Yj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 20-03-24 16:27:45, Johannes Weiner wrote: > CONFIG_MEMCG_KMEM used to be a user-visible option for whether slab > tracking is enabled. It has been default-enabled and equivalent to > CONFIG_MEMCG for almost a decade. We've only grown more kernel memory > accounting sites since, and there is no imaginable cgroup usecase > going forward that wants to track user pages but not the multitude of > user-drivable kernel allocations. > > Signed-off-by: Johannes Weiner Acked-by: Michal Hocko But this > @@ -422,7 +422,7 @@ kmalloc_caches[NR_KMALLOC_TYPES][KMALLOC_SHIFT_HIGH + 1]; > #define KMALLOC_NOT_NORMAL_BITS \ > (__GFP_RECLAIMABLE | \ > (IS_ENABLED(CONFIG_ZONE_DMA) ? __GFP_DMA : 0) | \ > - (IS_ENABLED(CONFIG_MEMCG_KMEM) ? __GFP_ACCOUNT : 0)) > + (IS_ENABLED(CONFIG_KMEM) ? __GFP_ACCOUNT : 0)) seems like a typo and should be CONFIG_MEMCG, right? -- Michal Hocko SUSE Labs