From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ED9CC54E67 for ; Wed, 20 Mar 2024 07:53:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D19796B009F; Wed, 20 Mar 2024 03:53:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD2956B00A0; Wed, 20 Mar 2024 03:53:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB8546B00A1; Wed, 20 Mar 2024 03:53:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AAF5F6B009F for ; Wed, 20 Mar 2024 03:53:05 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7A158C0939 for ; Wed, 20 Mar 2024 07:53:05 +0000 (UTC) X-FDA: 81916651530.18.F9A73F7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id D3305C0011 for ; Wed, 20 Mar 2024 07:53:03 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RikP5jal; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710921183; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fqiMQHqORmeDjYjtn7CCiO+1Zj4Lkm+sgSbsT1labdI=; b=y3k+rem+qlYE6zfqkwywKGX0fnfSkaOPzb7xgsRT5kd9GytSdko/Zq3wEOSvTSzli3xF0t 6AmgI0udqYCswKztQ+5MN/t9UgWVD+/Mt40+K4GC67Rzft73scwItQDoZHyh1ei3dSAAqe 3nVgPgz0lYpAHq0ckZHyG3smX2Np+OE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RikP5jal; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710921183; a=rsa-sha256; cv=none; b=mR60CYEADPhohtJsfp7Gt6UUNgTMP7Wz/WpV+VOnow6ehw3CfpbqsheEMwsYHqLNHZcfmY 4FSX5k9bHGQD6ZHS3GGrwNOuwbPUKO9Qrho21I0957Gff9IS5Jh/pZ9HXREepFA+Kx8ZC1 3gga6sxiurq9SBHldqDaOkp84cKDUow= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710921183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fqiMQHqORmeDjYjtn7CCiO+1Zj4Lkm+sgSbsT1labdI=; b=RikP5jalDf2CGsFKb/RjPHJz51yuXMyArv6csH6fishEwKctZMLxhvgQdlVOULUZgDn0uP M79no1xS7FecL/JM+ejbV2HgOq91u1KPm9XssVH0aBlwDu4ELW/w+p54zR7LPdbka1Xp+Q ZtY3tJcKM3GUfsgNs+H8OXliUPdfV+8= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-IpUFOGt-N_aQBzw5f2DQIQ-1; Wed, 20 Mar 2024 03:53:00 -0400 X-MC-Unique: IpUFOGt-N_aQBzw5f2DQIQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7BEF5383CD69; Wed, 20 Mar 2024 07:53:00 +0000 (UTC) Received: from localhost (unknown [10.72.116.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC8A91C060A6; Wed, 20 Mar 2024 07:52:59 +0000 (UTC) Date: Wed, 20 Mar 2024 15:52:52 +0800 From: Baoquan He To: Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org Subject: Re: [PATCH 2/6] x86: remove memblock_find_dma_reserve() Message-ID: References: <20240318142138.783350-1-bhe@redhat.com> <20240318142138.783350-3-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Rspamd-Queue-Id: D3305C0011 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 6yoo649m8bpxbqetj6hn6s6n9c1bth14 X-HE-Tag: 1710921183-183704 X-HE-Meta: U2FsdGVkX1+ciX/joohbLeb7dWR/XCJwnbmfLUfUxXaec/5DOyUCeR0aFigjirCrsNAQh+iMlePvkBeNwVKqZDBH0fTxo1DrxZpDHBS1Bo+1FdEOrEIBae9MW7s/A6cN6Kaa8C7OUnwR9NzOM8x2/4V9p9dKUlPbEhRGcp7dMB2qYjHLLpF0u3/c8KxVnz+COxpRJJwy0dC0vDJZMK8lQjkdRDlBkgGpDjgnbWaqWUZV3TC2DSVdAlmoe8v+LAJbc7ZBM9Ribx/iE7DChil+k53ftNyEw8yg9WJ6qC8HPLLA9+7eYrf/ckCBn+t7+OXJmjnigfps1Ua80jUJ55Aq+Xth33AzycXfcw5W9tKpxBjuUPkopsJqcPQ6Ee9iNwAZjPKNAhso99veyI6GhmpxkRU2BnZWqQ8m4/PRopvV/jqV/vjQ7aPkmPUfTWa1osxz6csiPni73EhhESZGaJQmHGexuwZG5N9RLcpQ8Ff59ec0oilqQWt2ttM1zFKtLmwQT6Nbr/Esg2bOD2lapak43IolAERp7cjxG+/agoKruvydjNw2rY2miC0UOG+38rcT8unsIDk1euV3wkRmmvJg55tRp5P92TPTTM7RMorWRNNzatTmpSaMsafbH6AkgsbN4TTuxe+JooRJVVKt6nbuVsv8YN4u8Kvi/hAI+C14B9rZ8jsFTOQDvVK5BJbQ7UyfV+JdqhHNSF9zqoUsA2yXEo1OdIXP0LGkx123CorMPkqAUQdLPnb5VuWuBoaH2fyvNKBx0hUxhv99P9FYBjBs53g/T9VTyuGlobNv+tD3cCc7SObjw4Mht1QZHOm6/Ffnupdc3tRviDFIk69cQjzLa6TpeK9htPlGVx7vhQz+DvRDeUhaYL1X4/iLNeZyY+wBU/EeTP34F+Quhop2Qx574VhQp7Cw7fdrMjz1OMwUlaICYOLhy5OLGALHFM44QFJy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/19/24 at 05:49pm, Mike Rapoport wrote: > Hi Baoquan, > > On Mon, Mar 18, 2024 at 10:21:34PM +0800, Baoquan He wrote: > > This is not needed any more. > > I'd swap this and the first patch, so that the first patch would remove > memblock_find_dma_reserve() and it's changelog will explain why it's not > needed and then the second patch will simply drop unused set_dma_reserve() Thanks, Mike. My thought on the patch 1/2 splitting is: patch 1 is removing all relevant codes in mm, including the usage of dma_reserve in free_area_init_core() and exporting set_dma_reserve() to any ARCH which want to subtract the dma_reserve from DMA zone. Patch 2 purely remove the code in x86 ARCH about how to get dma_reserve. Your suggestion is also good to me, I can rearrange the order and repost.