From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CFCBC54E58 for ; Wed, 20 Mar 2024 07:28:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 963646B0088; Wed, 20 Mar 2024 03:28:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 912AB6B0089; Wed, 20 Mar 2024 03:28:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D9686B008A; Wed, 20 Mar 2024 03:28:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6DE6A6B0088 for ; Wed, 20 Mar 2024 03:28:29 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A8B2B120C37 for ; Wed, 20 Mar 2024 07:28:28 +0000 (UTC) X-FDA: 81916589496.25.5F6EAE7 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf23.hostedemail.com (Postfix) with ESMTP id D080414000E for ; Wed, 20 Mar 2024 07:28:26 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=f4v7uAiz; spf=pass (imf23.hostedemail.com: domain of 3GZD6ZQoKCFoQGKJQ29E658GG8D6.4GEDAFMP-EECN24C.GJ8@flex--yosryahmed.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3GZD6ZQoKCFoQGKJQ29E658GG8D6.4GEDAFMP-EECN24C.GJ8@flex--yosryahmed.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710919706; a=rsa-sha256; cv=none; b=KrqkERFvgQH/0FuqnOCdEgALqMt0iWRVyv9YgPclDhpQY3XxHW6bY3BzQEc6CKCP4tsiSX nEAgg3ZWQpi05EwjlK6GWjbxEDaOh5kk58wRInPIOFXtIeFbiq54bLnsyFEEJnMHMyqgQ1 BjGQHqbttcx9mcxuxHv6r3r2991czag= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=f4v7uAiz; spf=pass (imf23.hostedemail.com: domain of 3GZD6ZQoKCFoQGKJQ29E658GG8D6.4GEDAFMP-EECN24C.GJ8@flex--yosryahmed.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3GZD6ZQoKCFoQGKJQ29E658GG8D6.4GEDAFMP-EECN24C.GJ8@flex--yosryahmed.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710919706; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8Cf3z+01pPTqaJgUbHcUbvvHLevh6MiiirhgfJW0FB8=; b=GS/haXxQt9ywFJyALZDxKPwbHE6uVXY53su84+HY344pM4IuV5BK3+P+u6x7p+BwDpQKqn PycSbzzI/kxu/nSlxx1CSv0HIO431PcNuGjWSEQSuDIx88Ko194A2Ep0Q3upmpVRc+rx+D jWxi3Qe4aQrj1Rq2Ksp3hD171pOWHWA= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dced704f17cso10681859276.1 for ; Wed, 20 Mar 2024 00:28:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1710919706; x=1711524506; darn=kvack.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=8Cf3z+01pPTqaJgUbHcUbvvHLevh6MiiirhgfJW0FB8=; b=f4v7uAizOJa70kPTPF9jIGHRE0sGGCevRV0PPrsfREGGij2Si2yowNLn9rZRj8XOUv 1uSGm9khVO2Ll4aBgRKGdpShqMr/vTDnDCli+jMVpWl3wRx2gyx6RLS45FSejQHQ+U17 p/T4pjlcPvCOKVSfgxTCNBPM7COnc3CzD/L+taTZan7X9kgUpZQHrPdjtATDQPyzaL4x bDZVtn1VJE5BUuk0kCb12WntqK3KZM9y4c+Jvcz5YGp138OclZG8lveqr9qyLDfykKZO r+ntCMtRNMCtXB/KmOZkQCY0osIEpwneg66gJKMbrjmQjeL1/+xA8aecGRYI3RBorepk cq7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710919706; x=1711524506; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=8Cf3z+01pPTqaJgUbHcUbvvHLevh6MiiirhgfJW0FB8=; b=d5vuxWobQXRbgyb7hq7jRQCcuG8PZ1vp30C9M3XYrYUju2InXpwzVMBLXyQLjK1pRB 5ope7DYgGx951bCUqhT8aFfwXYWbXa1P/FMZPLzC2YmCOCGT+BKS7dp6O+VRLsJs63P6 HIVrG/yeK4vqm/PqxB9Z0JUGIXFnJZYnhLswDI0u2hkN/FIKqwLBofiYg00XQXFdIE6l MOpbVV3tO8sACA3DURz63PCEgohYScKGOROo5ZzizPIAZTzHNHrTiXGZ4kp7j63PKu2Y d4qUXxqW8NCbTDM0NLHGkwQ/bYfJjKsApYa1DZXPGf8XJ32UokWylqeuYluTdP0JTI1J gmHg== X-Forwarded-Encrypted: i=1; AJvYcCUfCFaR8KOPWZQtvahVmTX9CR8ze8NZnI9HKBn+HhjKGanG9RcDo1Pzja37wWU9FV9AgfSFt//G1TO2NQVRME4Jn9A= X-Gm-Message-State: AOJu0YyeRhpJ0kwUtry6IfdHAa2sd80FztqrpjCEy0KVxLuNS6bU+B9p YY5DhCUguQ1QxY/dI1ltQTEso+1tiA07Z/MEtlZl+nVl15/eUWVxqV1AYdviC9gl/Hzrwhv0XXf rG9I8FOOlnBD7s9v4LQ== X-Google-Smtp-Source: AGHT+IEfa9xOQhFmuNxE4o9OfZO2Vc/0uULHRYTxqzo99fLnSbA+gg07/JJm2omiBe+ZV95gvHGh1ZOhZxkIbXjt X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:6902:2290:b0:dc2:5456:d9ac with SMTP id dn16-20020a056902229000b00dc25456d9acmr992058ybb.5.1710919705944; Wed, 20 Mar 2024 00:28:25 -0700 (PDT) Date: Wed, 20 Mar 2024 07:28:24 +0000 In-Reply-To: <021efce7-1e40-43a6-9bfd-0d968bfcd5a8@kylinos.cn> Mime-Version: 1.0 References: <20240126075547.1521556-1-mengfanhui@kylinos.cn> <021efce7-1e40-43a6-9bfd-0d968bfcd5a8@kylinos.cn> Message-ID: Subject: Re: [PATCH] config/mips: support zswap function From: Yosry Ahmed To: mengfanhui Cc: tsbogend@alpha.franken.de, geert+renesas@glider.be, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, nphamcs@gmail.com, chengming.zhou@linux.dev Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D080414000E X-Stat-Signature: ckoaqaoru1qk4djrnqxcob7586z589in X-Rspam-User: X-HE-Tag: 1710919706-169614 X-HE-Meta: U2FsdGVkX1/sgh/X3beT2Z+baxnXyH/EP2ZoHwX9aU5YQik+cZXTolAHpjL/woKBqtbFa8jONaZFsBEuEeAFlg4s29j1pAtAz6X4mnD7spWVdnGTq8v+8uwSHxA4Q66tj5lf7RK5icQ2QkEcpfulVrjHhaH1/5DfX5wSJNbWegZHPRTtxVX1wwNrXmUlQdL1lrkWYgLLx8mqJWGaZZBzINOl1XATzXj0JWGMxlk5Sl8QDt/UQQLo11y0twTJTF4LMeIVLmQGHuIG58DPG0/6wgh4bl4vcq3HhLb5HL+NZa3UTdEcG/m4UTY+lkRvz3FGGV7XukVgUT1EUAJzZ0uiRYp007d35nFegU8wDtmEiVMojHZj5RgIeUR/8EssEx3gwvcMrNRFp3y1Mc0lfVISHgOFMI54bvHaYvJrEpSzuP80/2NvA7XPpAjaM8H3d4UXmHfXBdu47D3xgqBaMTHlbWUYfwQT28aEa+jqsQs4pjILsRErKAqLfGyuLZAIJmJlTDmXW3jJI5AFlWx3GuljSFGW4Chc9IqAw546eaphMFBSIUCipxJeKaS9USGJQJN43C/hUhDHPRkrUT+liA/kl1vfRqMMIphovltba5xi/3Slb0d3OPeXBNw+V4QmQypgqnS6FYCXZBmy7ciIubpR6MhJ8GkotVYPdOMq5K9Sms3CkyCJofp5RRuFC2HPI5x/04HGlTE1MyCX0BCMXuxq4Fzi5xujJ8Rr4l83rSLHZ2dQFJVaBi8ymP+wJmJELJ2m1TCovLKTjgt/mjERbOg8OYmYX+nWhVqZUmpA6tFsFENJNpzzivw/Buuzhuv/0hnm5NBMq0q8IrnoNUgjqjjy0OcB7uvxGdadQjdPh+su+/Vtw4gzPXPnjBXshxTfENWMhaPqz8XrSrPvcNovfAAU+b62T80H2F/LdeeFduF8OEd7eVqWWxVr1iUhJcs0rXJTJJ0/JFboAmmd+5xoBzT WK9RZMz2 y8d/zH+OZIrVfsrT6cGJVVsm/Tq/1xat0WM1JLhooCeBw3ml5XBB4o2zLfA6R9LjsSh8IM04S0xtNydUCXQ1/e2CzGwdwfvd4xodb2AYWYEgTBduuU0ZXnIMwEdRmDTulMlZiqyLy7iHWxSVYQzST3vy6pARWqsyuMG/WEUEIIJS2CeRL26WgHfeFErXfdsM6MljLhMOMoWK29BRRZSUM9yWOxdhjE34Th8WQwXzvETMHGex9TfgQAUC2ZeZVwiX6rjYLMfeBGdt9WwCSwPAcrFFUhPzcwfQN4iJPchu0B8XCcaOvj4pLsHxOagT6NEcMKVds38tfEy4GWP2RL0n9qWy+HZLZ/PYuwIbakBxIgEt+XMXOPVsfZpmn5Cgv/0o+47MkMWxpP6Nwg1uPEsDNdtZ++9qLu6hyDTyNG7EYDFnbL8P6PMzNDGO+tu6m5UdGrbSroH/nVnAmI2fi1tNo4WsTh6TfzfFqalXKxXMQINjmypYA4hiTovVfDXRniMj6lXIys50atRpici7FWlILApeNXbWGQ8j6syudGt2SUIU7LLAn2X39m5HnsvqZUmp/818xwiIOdOOwt9cySmA/s2uMjZMDJCXL9se+dt49uzwGYVAoh5bfqqeBgh9+XEcsxhEMT/K4W9fqowLF5cnHxRp8/NgLXsAAiR0aqNQDnqxhkOqwDZH2eIYV4A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000052, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 20, 2024 at 02:44:21PM +0800, mengfanhui wrote: > Zswap and zsmalloc are compression methods, and kernel configuration can = be configured simultaneously. > zbud is an algorithm, and users can use that method if they want to use i= t.It won't affect each other. Zswap compressed swapped out pages in-memory. To store those compressed pages, it uses one of three allocators that implement the zpool API: zbud, z3fold, and zsmalloc. In that sense, zsmalloc is comparable to zbud, not zswap. I suspect you are mixing up zsmalloc and zram. Anyway, zsmalloc is the default allocator and should be better for almost all use cases. So unless you have a very good reason to use zbud over zsmalloc, please do not use zbud. We are trying to deprecate zbud and z3fold. >=20 > =E5=9C=A8 2024/3/20 14:00, Yosry Ahmed =E5=86=99=E9=81=93: > > On Fri, Jan 26, 2024 at 03:55:47PM +0800, mengfanhui wrote: > >> Solution /sys/module/zswap/parameters/enabled attribute node > >> does not exist issue=EF=BC=8Chandle zpool zbud initialization failed, > >> open CONFIG_ZSWAP CONFIG_ZPOOL CONFIG_ZBUD configuration,manual > >> zswap function by /sys/module/zswap/parameters/enabled file > >> > >> Signed-off-by: mengfanhui > >> --- > >> arch/mips/configs/generic_defconfig | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/arch/mips/configs/generic_defconfig b/arch/mips/configs/g= eneric_defconfig > >> index 071e2205c7ed..14884df392f4 100644 > >> --- a/arch/mips/configs/generic_defconfig > >> +++ b/arch/mips/configs/generic_defconfig > >> @@ -13,6 +13,9 @@ CONFIG_CGROUP_DEVICE=3Dy > >> CONFIG_CGROUP_CPUACCT=3Dy > >> CONFIG_NAMESPACES=3Dy > >> CONFIG_USER_NS=3Dy > >> +CONFIG_ZSWAP=3Dy > >> +CONFIG_ZPOOL=3Dy > >> +CONFIG_ZBUD=3Dy > >=20 > > Any reason for choosing zbud over zsmalloc, the default zswap allocator= ? > >=20 > >> CONFIG_SCHED_AUTOGROUP=3Dy > >> CONFIG_BLK_DEV_INITRD=3Dy > >> CONFIG_BPF_SYSCALL=3Dy > >> --=20 > >> 2.25.1 > >>