From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F428C48BF6 for ; Sat, 16 Mar 2024 21:04:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C99D96B0085; Sat, 16 Mar 2024 17:04:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4A156B0087; Sat, 16 Mar 2024 17:04:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3B876B0088; Sat, 16 Mar 2024 17:04:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A1C566B0085 for ; Sat, 16 Mar 2024 17:04:23 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4B16F405CF for ; Sat, 16 Mar 2024 21:04:23 +0000 (UTC) X-FDA: 81904130406.15.F205BC2 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) by imf17.hostedemail.com (Postfix) with ESMTP id 54D6040012 for ; Sat, 16 Mar 2024 21:04:21 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=i4uvy6T5; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf17.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.174 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710623061; a=rsa-sha256; cv=none; b=0f/7UAOM8JzpxuLNTQ4GpMRfsF1iGCvDCL8o4WWKLRnGHVMCXH7399rWz9n2oFYyCq2n71 ndvyItnKm/f72U83V760mbPCdIBm4GGAoM0zLGRpAnl9eNJG/3XxuyUK0xcTJ/bxN46HSc MoCiqycOBQNF7o+IetABNArk8bB9IvQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=i4uvy6T5; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf17.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.174 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710623061; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=13ysREvRIfRyhIebo3XESHYKkRzY1Wqd/fThUQgveOA=; b=HubqsNPYcQgCRM6NMPwzCWlPrT1wj9lizdxCfZFy0BNhwwg+Id9D9OpL1zBEnLb0QEBf4V 1DUqJP+veF5yVNr4i/O5HCCweELCFtPe+dNQTSea8z6TpQCQ3iBsm4BlkTNPBwSWl9Q4+v 3BLtAIH1gDTFIT/yO/sPs7pRtBPootE= Date: Sat, 16 Mar 2024 14:04:13 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710623058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=13ysREvRIfRyhIebo3XESHYKkRzY1Wqd/fThUQgveOA=; b=i4uvy6T5Rw32a4b1sjxEuMpV9lTE2Z3CJpjE+BdcfZUB1XYoOdMzfxqa7Wt5AKC+vP0m3k lnVBdSTi6zvDGJ3TndOL8xiTsYPmWwLkyPtjm28Bd54VV69WXVxAbzs/TUQ9X13h2Erjw9 PgUwRbwh6qo1bvtKxH7KWtxNuHI8HhI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcg: add NULL check to obj_cgroup_put() Message-ID: References: <20240316015803.2777252-1-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240316015803.2777252-1-yosryahmed@google.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 54D6040012 X-Stat-Signature: yn4kjaxpbxu31wa7j6scgxjxz8g8q9rp X-HE-Tag: 1710623061-336031 X-HE-Meta: U2FsdGVkX1/q78uAPWrgM9s+4Bfo6hrDhzR9WNrA6kyXOuXeyIX3TLexwgPviEbtrf1HNfS83nOK+3tqTbCCbOi37aKsn7F5OWF0w8/xJqf4aIW2QorDFxQBHssAXMQ3UU0JFr1p0+JYacE4BZvLq0khGKQN6Dfrhwi206IcqWtlFxNgl60ebt3OVsZbdVg6W02lAKMjHw2ap6CdeS74mxEmkAXt/6908yLODgixRGRnMd/CLgxNCM7MXUDrRJDNco36spwlFlW/WlHdeoNl6qsKH+dBNUX+Bpm+/2qObEj6zgG5PpvkVCW9b0YqEQSlyC0xP5iuN0zdK4KIPThc5V5CHj+o6V5oyb6C7z4KnLkiZ7Awyhl13v3+chuZnhlEq8DV6LTChVFDx5cL0b+UjVSicHZVgfCBWLr2HhWPa1i53wxXLJC2EImcNw8Mea5Yf8hfoEoDeqkUU7UkhARHGyEnzBYoZFVc5YGjLXR8q9C+tVWJmbIinxHxELMnUsFy1Z2cwxHf2Jn3lkUHGgn+WF7qQQ4uLDduj/du9ulY2QdUXdTWTdVO9YPlVfalciUnO5BCnmrPHnB8giU51KUaCugJ9XBsRon6jEZmOI0k0AMhy9fIRzHvorNG3/57zcWagjSKwvtWGUqlxyDFixLLOg5K27jiOnBiilPLxC1oh2bbZ79y2exgE+oO1xuIyqsvmgx/LoJfJDvyQyPD7eR1U1bw/RMve/Fi77cXVP8gni7ULlaDbrzUyULgZpkig7zKPNQcqVdU7SfBS+aXvaERJkKZGp/87LZe0cnTX793DKadw2UD2/Hcu0jStS/dFO7AQP+knb9K8v73906B1ZUNneNCoBMHEthXnhCjXSAutQfKgeJY1bLrdaIG+um8GJTEK6upsnj5I57isdHVcPABq51LQBwKvdFb/usPqdcae7W79CT1gm2vzbXElrcVHJUlnNw0zS0RcQokDfymk18 PehjW1Pg eBQuKimoZFEU2fUoBOjbKAmu2bd7kG/h4LgcC9RlSrlqnUyGl65c8PWKfAXt02zt2UnvQLy5xNOodF/nIn+hlRBzZZ9bjBLZe1yrQCUkySc40LTvWlssb8Sqg4oDUiLeJciejLCGj7emsdyqy1QGZdlau8hFzZlJNwJ+Rs44JqeLe7/RPF7hk8YaiY5KIABf5QwobNGwIIHCwm7GsMZgsJKULiw+x7xIqIh4Y9sxeRi6hOU0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Mar 16, 2024 at 01:58:03AM +0000, Yosry Ahmed wrote: > 9 out of 16 callers perform a NULL check before calling > obj_cgroup_put(). Move the NULL check in the function, similar to > mem_cgroup_put(). The unlikely() NULL check in current_objcg_update() > was left alone to avoid dropping the unlikey() annotation as this a fast > path. > > Signed-off-by: Yosry Ahmed Acked-by: Roman Gushchin Thanks!