From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4797C54E60 for ; Sat, 16 Mar 2024 15:41:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 396956B042D; Sat, 16 Mar 2024 11:41:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 344516B042E; Sat, 16 Mar 2024 11:41:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BF8D6B0433; Sat, 16 Mar 2024 11:41:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EB5206B042D for ; Sat, 16 Mar 2024 11:41:17 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BF6FE16032C for ; Sat, 16 Mar 2024 15:41:17 +0000 (UTC) X-FDA: 81903316194.13.D93ABB4 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf16.hostedemail.com (Postfix) with ESMTP id 2EE76180010 for ; Sat, 16 Mar 2024 15:41:14 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=resnulli-us.20230601.gappssmtp.com header.s=20230601 header.b=EGxTUsjJ; spf=none (imf16.hostedemail.com: domain of jiri@resnulli.us has no SPF policy when checking 209.85.128.42) smtp.mailfrom=jiri@resnulli.us; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710603676; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r08nE6M+052czd6TDRRSKiJ72BtB1MGicKvM+Jhq7Do=; b=zsQMke2VUJMXci55D9Kfcj7SMBhFE5NOE37lJ/AZqROT0cIh0Z1ekl11RJ5tHRbDhtacKu Z44k3W31ydk0gW6u4Mo8wjq7or8xBcH/57bzJ3Mk45GQ1mtcQDhv+BvkEW/LPV4sn9RIuQ Mg2qtIT4L3UO7Q6F+f6QGGgltSMMG9A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710603676; a=rsa-sha256; cv=none; b=uO8oQqLd1S8iq9LRHf3tA72DybLJddPlGiV8jvL8tMAUJGKeja7aq79NsPDS52v+6J7Fte PTNI/I08Bu/8o78+yUdSPTBq22mEPqPCPrtGNlIMd3uui7xnwv1Gjft+oTPgxq33Zuo6Ig xTm5q5m0XWP4Biwlr9tpeViDomdUGKE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=resnulli-us.20230601.gappssmtp.com header.s=20230601 header.b=EGxTUsjJ; spf=none (imf16.hostedemail.com: domain of jiri@resnulli.us has no SPF policy when checking 209.85.128.42) smtp.mailfrom=jiri@resnulli.us; dmarc=none Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-41409c98f02so2432535e9.1 for ; Sat, 16 Mar 2024 08:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1710603673; x=1711208473; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=r08nE6M+052czd6TDRRSKiJ72BtB1MGicKvM+Jhq7Do=; b=EGxTUsjJ5tRLrR25hbRxZZASKESXSaW26ORxqwrzDV6tXsmM3FpFCWnl4ldLu16wJO XzstzXU+Xz8NEU9FHgm3LDTi5AKz0i9WjYGoEilh3wm0erzUhYURlkN50QCvMo08uTN9 O3QfcUz5QV1RNjwffUlHfutySWYEFX9QBjN7S1kp8murvgaJ7X1zZ3k22kUK/PqJoFeI QMM8GgUhkAG24prrdt4NFoZvuytJcevi7QtTMDuHvfvKb7CUy8bp5K85whMgrFQbWlD4 AlW937JjDWLFc9Junw25OQcHaqSXAsQuxqHuTrAHq8OslXue9NVD2aCut3ciKv0iklBr wA6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710603673; x=1711208473; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=r08nE6M+052czd6TDRRSKiJ72BtB1MGicKvM+Jhq7Do=; b=G9Fh4rmQTuotqk2jw0rOpxSjQk2b0Z78sYTU53MRve6yXY0h6gBZgn1qgbWPzkeC6o AIwAs5QEtQJ4JtHE1PFCIYRmr/7fLsBA+jFQfIsAnKts+4hso45RGDoOqu/3EuAKuJS/ 1V+KepG6TXx2FT9viNjFnyuQ80dU7bfQTOv2svjJx1Cwoa6mNQPnQnf+sCmyNsvbXu5e 7fClyOhLV0D1ayToV/TUqTALRCoiXAkvysU1eaFFwDZ9hKM798oqo+v1V8P7hgooo7cp JgYbqmHIqRi9YDGGMyLULs1Qd1MtZ7xRMwi5jom29EkuV+90+ZusYF5mvgXovW5gP+z8 Y1lQ== X-Forwarded-Encrypted: i=1; AJvYcCVhl7SyolyargYp9f7oSND/urPZNXb7URFNN5dxFdlZet1wt58AFpXGzBhhFMfFlCAZv0cLcHIKDsDWH6FUkcAdw00= X-Gm-Message-State: AOJu0YzpVFIGG3HARh5G654PaM6BLOwGtvSv7RC3QfPmampPgdmwrvy0 bhPw/YtYtylm2SCw0z7xKD2Upv7lr3zTPw750c3+WlH536Y5i3ul9F3QJNVg1IM= X-Google-Smtp-Source: AGHT+IGVtnHAsQI+NrgyOQlqywZZb9eSCnpF7NvP2GYs/VAan2qIio3AQRHayTDkuUxMqOc2pwF4uw== X-Received: by 2002:a05:600c:45c8:b0:413:1212:3eed with SMTP id s8-20020a05600c45c800b0041312123eedmr1818806wmo.3.1710603673172; Sat, 16 Mar 2024 08:41:13 -0700 (PDT) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id g6-20020a05600c4ec600b004140726eac3sm2366569wmq.6.2024.03.16.08.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Mar 2024 08:41:12 -0700 (PDT) Date: Sat, 16 Mar 2024 16:41:09 +0100 From: Jiri Pirko To: David Rientjes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, peterz@infradead.org, mingo@kernel.org, danielj@nvidia.com Subject: Re: [patch RFC] mm/slab: introduce KZALLOC_FREE() cleanup-ed allocation macro Message-ID: References: <20240315132249.2515468-1-jiri@resnulli.us> <171412ef-1a93-3e56-2b7b-3baf83233eb2@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <171412ef-1a93-3e56-2b7b-3baf83233eb2@google.com> X-Rspamd-Queue-Id: 2EE76180010 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: peedqc19cufc66dc648c7znqyahn3cf6 X-HE-Tag: 1710603674-675341 X-HE-Meta: U2FsdGVkX19k4GEPR19OFuzzR0Wyvs4XKKMqRFlUd4v+uOY5+w1eG06JNZMYNl+47HQFecO4kqYV6nMkUgwYdQLzgvlheiwrl+dG78NBtt50zLjSXP8qD5yze+nQ2VSjtFrrqKHDH9GVXx2pUFGcazbpfIAbE83nTcK7Wkgjs07WBvJsFI932Km3LNNiE6uYTdKGOsfIe/1yzavFs+Mvh8npzNFoYCn2Id+69FDPDkb0wwoGWfdaUzbfy+OOmGSvQtV9B6lp4xg5CxJDDRwCgdP+zwszFXU0A/E0kZ7X/KeMbv+CCmIfHub4mckf4XwcW6u12gxMKWtsuZxKuNER7FIaJT1T3qQrzZPO6QVurLpsz8X23VbStqyZi+jtZTSDTRX5GsfwkkVIqQkAf3eAfI4pkNWu15e/51X/l2y9RzmRfjs0zzGfcI3T5HV9Ra8Mals7WcOVRviFE0+exRfMXp4rYuyvwS38nUrnQ5K+0hJdPsDOBwZJklYZiBvKrxXJnlGf1Yq3+PTdhg9Bs+C7lClYBGtilFDxULuX3jChuuNWXVk3sgCjmIjhlLtSCV68Iz6W0+37VYNUHlgQNtqgFMvSxE1TF9dJRgFbMSBEXM5sQyDv4lKHeX9wqgtj5C4XfpvHr7mSA5+dFwm3cELDsqbaPHOHIWcak2nYJw/Q8z6OhC+co16NTiQN1BLDsuN8aaZLxdby1K7kO3cOEWJadI05p+vRwf8t1JlSCo52Z4NQs/AoPYjvRnDZvig7MXS9KHBbYEhxGNbq8Jc86kSRYfrwidShvDjiSUw6NKBchACK56H9yUcDVut0ZSS+wMoCJejGKYqZ723ifjrnI5Pockkfs6/mWJtxesGuWe1wM1yeP4pJfUqgDnR68BUWEa4RCzTjYqlMn6uNbkH4eWdktHAPdMphJt3qaohEPkyPR0wHfkwlKT7unI/QvVA3QTIa+Ckl6+NZesusCreV/tH 7MRaFfTd Kh3QQZ/bbCuYrk5kN1CsGOXn26zuDYkzLyk6E+nG3cIyFcEWOy/5NYttrQCxli6/6KMFDgSjwPpoH+1vyViObGl2eEZ4KxfWUsoWmq/eN6pBTOQTivr1d57baqbQSU0wyQwQ6K33PPI2Ic1285hL6aSVXYRYnca3i5o5b5bqGE4V4x5GpSbctzAC0GHrhJp6EyI10SeIjM6/fMfixYKZYaOFrDmG6gDiwabK1edIB8RvKY08VDh0mFrYLrXLg30YjOgG99AdncoeS53ApJPiumUqlcR1Y/Huk2pRmw1d/NI87JKszar2qKBMsGF2pGNwfQQBI7TdRIyOwCmyp64Ki+Sj2gg0ABMooLBSPID7jlU+gFN/c2ugzQbDeHfBtPbTDl3qgRW+Rd7OTBFbptZbaGIgliSjnJlwtOpXNtL06BV9x1taPFYwVOmFj/9OBEp+2A8cuo9SrFwRz9ee7ZJoq/AneGz2/UJexIkA90HsaK3Y4/kOizJhDByXNnIMYlJVUSMmIwQkXPKOWHQBz0jSP6VzaftDi3OuDQKHrjWr200JSO0XNI1Z/ATN8Hq1fXbq6DNSiHHYUxVIGWkIbtTaMRPA4TQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Fri, Mar 15, 2024 at 10:39:02PM CET, rientjes@google.com wrote: >On Fri, 15 Mar 2024, Jiri Pirko wrote: > >> From: Jiri Pirko >> >> With introduction of __free() macro using cleanup infrastructure, it >> will very likely become quite common to see following pattern: >> type *var __free(kfree) = kzalloc(sizeof(*var), GFP_KERNEL); >> >> To follow the CLASS() flow from cleanup.h, introduce a simple macro >> KZALLOC_FREE() to wrap this over and allow the same flow. >> >> Show an example usage in gpio-sim driver. >> > >Seems highly specialized especially for kzalloc specifically, so not sure >this warrants its own macro. Yeah, but having like 2-3 macro variants would probably cover vast majority of usecases now. The rest could still do things manually.