From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C30B2C54E58 for ; Sat, 16 Mar 2024 02:52:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F11680156; Fri, 15 Mar 2024 22:52:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A13D800B4; Fri, 15 Mar 2024 22:52:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0E9480156; Fri, 15 Mar 2024 22:52:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DF570800B4 for ; Fri, 15 Mar 2024 22:52:56 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A8EE9A0F72 for ; Sat, 16 Mar 2024 02:52:56 +0000 (UTC) X-FDA: 81901379952.08.A5FFE77 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf22.hostedemail.com (Postfix) with ESMTP id 8F5D3C000E for ; Sat, 16 Mar 2024 02:52:54 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=V7PAUZlH; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf22.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710557574; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bBoX08MQ+GnGsn3Ys1XDLWs0vSpU6QZ104y6JQ1iJRA=; b=2ECsoMSKWiFpLBx87rHURjSX01a0ddCEvWsT02KJ0RmnGrPjn1iRxg6QBMTZrSdM5ll8QJ h9Q4uL5YiP9eFImNgHw1+ogwOM9Jl8npPUInRv2gMGkeIqgbPpZpGhYwoXS4MG0qzzSYH6 KFFB0XcBYNXycwU7iUm1EIwwndnTlZ8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=V7PAUZlH; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf22.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710557574; a=rsa-sha256; cv=none; b=IVFFJOP3yB2k+FsYYgAH3hIVB3+bm/IBVvIsZfPdPqt++9gNP2sx+drF5fw0nX2VbxlU++ dR6s3nu4+cjKN5nuTxtrKMcgVcTxNnHJYMW5Jc57TbEgGnKZw8LghkAIFjFoNJQslKWQlL qWnp0C6Xp7+4t8W7oxGviJkHAks5KDU= Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1def59b537cso8483615ad.2 for ; Fri, 15 Mar 2024 19:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1710557573; x=1711162373; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=bBoX08MQ+GnGsn3Ys1XDLWs0vSpU6QZ104y6JQ1iJRA=; b=V7PAUZlHTg3zerQjFEunMfB4PGt33lAk3/ZO9WHxfmGho+inwfW5E04WbMaFzAWwS0 qEq2f87n3BanIqdoiGABZb77y1iqQizcLg2kkwAd3l41wYyfmtmLOyQlxfmsEs9cbpLx KVOAIqczZMMo25iyD0ytrb6IJQSMus+WDUK0HLJ6RBG3/qwB6uci0C5tQsNd1G6pMhNg J8+/5VEnZ2OJ7+PsrGahCFH5k3vqjPNypJnnTCF3o+eb7gy7L8u8DVcZpxv5lkFAa/sI +O6BF3xYJMMCKkmz25URrEx4PpfuWpz9dDT0qYhCxCHOpxDfyLP67cxtRR7K+tU7NqpN VqKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710557573; x=1711162373; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bBoX08MQ+GnGsn3Ys1XDLWs0vSpU6QZ104y6JQ1iJRA=; b=CxCOUsBoEzNeFI2IPpF2IUp1b7WTIkJ1xJTlqeBHz856K43eFlLfI92v6CV2dc81BP Vaq7ByQavYnerRJdP4lv0pmMmGv8TFzf6ACStKBD8vKtJacUv2TTMOx229YjM5rjzEDr YOCqCpo3/D457IT9HL62Ox+3XU9XCC30DK4p4xyVmwnqpARtjrYEw8SzeM9H8azugki7 wMMfg2KhYRoSxSZB51ZE+GXTNprK96OZZohCshlz0aa7IXIo2ZxBsXUDLyYDodN5GlRS gUKZCZqH5bBFbnRq8bw5jKy9INbo0VETT5yueqKhy9kcpGWQOgctRDclN4etf93Fnevp Gn3Q== X-Forwarded-Encrypted: i=1; AJvYcCXPcHm4O9HHl1hkoRW4g+9l908q0CXtjQPPgRg3onR8dOhYMZ83Qc/gY4WqcgiS07y/YiS73dWyVdza4pRRofyaO+A= X-Gm-Message-State: AOJu0Yyfbhw0PvO/+5OwmozvwfzAj3/MkXBlDUqTg6qGkiLD6L5uph0r BJn7z6WfJUrCLNscbSvz78aycwq3vb5vRcpMBKHjVN4g8Uuq0jDGXSLIYfpxoUA= X-Google-Smtp-Source: AGHT+IF+mhHYlAObRzpfXYn3IGnPDczeVjZaH7QVUqvtIq9UdyOULCBCqzY79zAwu/GemLxZ182Fng== X-Received: by 2002:a17:903:2446:b0:1dd:9cb3:8f96 with SMTP id l6-20020a170903244600b001dd9cb38f96mr6055795pls.42.1710557572964; Fri, 15 Mar 2024 19:52:52 -0700 (PDT) Received: from dread.disaster.area (pa49-180-185-123.pa.nsw.optusnet.com.au. [49.180.185.123]) by smtp.gmail.com with ESMTPSA id f5-20020a170902684500b001dddbb58d5esm4736209pln.109.2024.03.15.19.52.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 19:52:52 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1rlKAC-002Wnj-2F; Sat, 16 Mar 2024 13:52:48 +1100 Date: Sat, 16 Mar 2024 13:52:48 +1100 From: Dave Chinner To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Greg Kroah-Hartman , Kees Cook , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Muchun Song , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Ahern , Simon Horman , Julian Anastasov , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , Luis Chamberlain , Joel Granados , Catalin Marinas , Will Deacon , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Theodore Ts'o , "Jason A. Donenfeld" , Sudip Mukherjee , Mark Rutland , Atish Patra , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Chandan Babu R , "Darrick J. Wong" , Steven Rostedt , Masami Hiramatsu , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Ian Rogers , Adrian Hunter , Balbir Singh , "Naveen N. Rao" , Anil S Keshavamurthy , Petr Mladek , John Ogness , Sergey Senozhatsky , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andy Lutomirski , Will Drewry , John Stultz , Stephen Boyd , Mathieu Desnoyers , "Matthew Wilcox (Oracle)" , Roopa Prabhu , Nikolay Aleksandrov , Remi Denis-Courmont , Allison Henderson , Marcelo Ricardo Leitner , Xin Long , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Alexander Popov , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-fsdevel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-xfs@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, kexec@lists.infradead.org, bridge@lists.linux.dev, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-sctp@vger.kernel.org, linux-nfs@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org Subject: Re: [PATCH 11/11] sysctl: treewide: constify the ctl_table argument of handlers Message-ID: References: <20240315-sysctl-const-handler-v1-0-1322ac7cb03d@weissschuh.net> <20240315-sysctl-const-handler-v1-11-1322ac7cb03d@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240315-sysctl-const-handler-v1-11-1322ac7cb03d@weissschuh.net> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8F5D3C000E X-Stat-Signature: 7nqcs71pa1p345rwx716kntiq6ugzcks X-Rspam-User: X-HE-Tag: 1710557574-470224 X-HE-Meta: U2FsdGVkX18+FMcRU/M9fmznztbqUlPTy/fHyCGRK8fcLNYfHFW5nBg3vx1Q4ENHjoWni9Enrpoahlevl5dcdp7omwMM9PzlPCiaySQVAarZrXRHZ+7kLk47v++/Ej4foxWYZzQXtXj0k8ALmO7Cr5MhNX9KvGIDieKCoEbWndMDjojej0zj2H44LQYJRgk+Sd9bMR3pjfMskHxYYVirqRSJpo7/D4IiEUYKdXHq5Qu8Us15weRTJilps3fK6az+GSLCaFxpsa7Ua9hIJKyMi1Ld0Nf+lXcl1h8BTsHIo/x3WU4GxwgcJwOcdsADl5FcDu8W+EUvA+5IdDZ9m6DGFQEpxvdS4XDPYrgPSyjrLMlbM6iSMpTarkIo8JNZKDclR9fZfkHhUx0sNn4i4tH4NbXYNxKmwqQqfwVnyoYi9Wo++Oau8m//FnLBo/R/ijsZmJvs1WYYBCfy87NeSB/q00CGRAHqz5/AFh7ERGSCvUuLUiHxolQF4r/3xiwrGBuxWj/XoPrQGoYnZUCIbufu0Kw6FcSO4vSIMFCrP8WyY6E51/VtApNq2xDlBuPuU3sXj1BuRZUaEaDwilhzj6X963vmw6RA8FXlPmCRw4B9MguvTkMswKy2LTphastBSBjV1EPnys2Xmsw9q+X3+SNBIZGj/+uoIv0KdMRPTlG2LHUazZXwbwpzNosCjyIbi7fMhgtzDF0X+zy6F2+R3W0n8VZzGBXyh7DFzn8L52lrQNT3d+qMNp/A18iWM6nreqHytv4p6Rngj+gEKVLLjFmaUJCiFscIvfE5VQXl89u7eH1kOq43vmW8kao6mv+VEgA7g7ddZrVOBhzsaYy/0Zxs1LbSYcSyBmEC0tyxaKAh1ZSNw5uGvHafU7aVD5fiCFG1xvDs2SagENGxFofixFfCwf6NX6IxCs++GRzsTZkJqrS30kLBIDKZN6lHvV90azrDhdMiFs2ZcX/AE+lDl5/ UczmJYo7 as0QoFCUcZKe7Mwb1kABBiyVv2WR+5AqHWcZASn1QITs0clv8XHfwjbb0a6Keom7EBxInslXpJZXPCEuUMgNmknumaKFEXzbiuziEh2hzpIEdGgL8G5B/K9A7MQ+oWXHCnTFS5EjOaISHdidc//P/aE8Fn3k/OHfKgpDO4dqgJ8ov8nSCerAp02mNUGKcg6XSynrMmVdfxpMFmmfeHg2iCfgHvt3/MspCrZ80LU3WYJWr33+D9Yd0mH5KLRi8JiLu08QwfS/jHzPhGuAMpnF1weHH2Rnzf9TWKVETmtvcw1m4tSzftCxjjgr2jBVvO4X77iiM3OdHIqyP3SnUssqmjt5DPJsz6z1wfizDnHctZc22yRhg7rHv+5Wem3UJLfjttF0QjPV/JPtNR0P6uOE7SJ61g6mymg/NZi/LpFt6ZBKWH+avkTB54QUawLlmhvkbZu6uTObIfvELxfrrK54tIqnYyG216MLsUaRb8ihyPLspqucvjHMyP6aNfdT6XVmgdld0DvpWvyYAEIR1JIC8trfdSldxNaUWVE5oIncGLfYnvvGmV9uvPrTpoE1ApEG8TWf7SpJ0VyyZZEffZxg1r8z8aGXtJ03whilnud2AJjFvOv0ff2IpCFDh62x9TLHYJNGAkjZh++N1SfshjqbYtqp9P7b8sjQFL/PxjGD5aGuOVC6AhJ5TO2I2jkO7eo2WJTys2BjjJGz1szLXCK3LwN6nzLJYErHuf5ObvLvnHDyR51vNEU3nEK1AHtJzJTs03ac0hwPMjU/YpMDb3u1pXNgJbwJjyGZfv7B765/Q5wXAVYVza3ssKu2rRD5C33mlV1WAPYJrzayjkY8wruA0lyBYcBg622va+p/mcS1OpJymqu96Nr6QcGj2qeR8F2Oy/Q+Em8mobkZqE18ga/AfkhFmKuzyA03qcd87D2xeyQlqb0CFwXevuBZa21u6fVIzcZe91XDMktZiHDAKG8UqxSXOvld4 CzObvfaJ 8PENCpi99qZJoQWC70E1ZB6dMDbM4tt8/sEzJS1GoPT8j7IDn+Xegxt1K4gs2NT7fyLe9mjTxeVZ3WscQ2F6OmnFJ+Pg+oT5XPefN4MeEnve2Gz8Y+SiXq4awFuU58MwQpp2sHH7jDT25mqjBKYAYthx1VDCpU9PrBCI2kEUwa5YCIw0kxBR9p4UqJh7YwHBTpRsfvip34RXppAf09voJD+Xk0nwKJZaMKx8v3i1PWzFZ3gH0gaL9Wy5D4kY18kQc31SjpNP3/XxoP7HnSvnstoIMwacJ089kDXhL21DSXUP26YtcvKmrfIS+lPfSDgj6wCWuTqbQ9stlNlCr5WOSoCf1kkcTZy7f5D5pRT+GRAKldcFImHWnApsSojUC8b24BzDLazPK1A7Or6HWR3siDcE9fKz8sJWA7Mezr7x6hnl8nvvD7T7gewJNmavsvua17m0sFhZUzhj+okM2N9yB63HgpfP406q56mNel/xvpZbXdj6jXR4qUF9wJtHXjldCbUkHUqDrQlhTzI0qZDO0sckiWyFvp0Uawzu5bMbQ8r0r6hmIqvzL+si4Gl/YeWO0jT3wI9xg6iLXkGtBo7pwRYKHBIZwIgZ4WfwTvPDkNxbRbidIuWY5EzqcGQtvO2z+m2xsXEyYmFaF054WFASQadhr+LBemVA9rCycbEiUpMszgy0Xg0nx1ICWoJGNGsUHEkFt8MUimdVUbZpf7e9biT8WW79PkErS7bVMLcYCPMVR4rWBfLg6KC3n4plBEs83BvVgrOOSd4bLyMxIbEXydpsCkT0/ibGUSrvwuZfhD6C02rglo05FkjnyAx0n6sPZYIPqSkpAU9JrLUDp2b14rhU1svTiAPa+w8/alkKu9ANQ7Jb6CGhTJUUf89gLqV7ZC9r4wuYM8lre/P3Fv4GV+ygFe+LFfHF7cAwUuLi2ZwG4Hz54FEMvbaeHxrFcchnDQxHV3jxTanzaBllMpmwA2l2F3T8R abTb6xeU MCawPZe/wYaNpnMTJnjU9slEXofcnwMB1O+Z+zkHSHwWWopdsw+no5+kkbw4qwFkiOedmbEnw+mIUC5YY+XQVoPTrsrabwUBmwOOwWx3Bj5RVO+K8GakssUnNVWoC1GSkXFjn0ixuGAYmbbhfkYFgyo+F0aCedTjfP8H0ShWkyJSQHYaU3NdY3IJj8I5tIHgCUHSiu4mEzG4AHEuxokuq7Mz9nj2Hxmm2tjOOUB8BtoUO4tUM6vzeg/t9ubWrvr2IFbviQ2XEgy2hC2gESe5QMNUVzCoeEJh8/efxHMiYVB4J85zCfYi7ZzWkoeGCxcorVapdTA+jnYfmQOsm1A++4mjBNLz/5HQRY3WZ+HqImlrybV7Rvpc0cp4XD20y8Pu6vbUb5g3R9kO8uKeLbVHpSCnmBtJxEJ9XMGDnKi3uIvA3BnQf9AB3roZ3Yj7BqJZ5pbD7Zko7eikiruNBIZ+24MBMvqfoIUR7662dxLL58WkXX9H2XZ0kdpPzcPJEJRk4gMjBDlIkz3Agvn5z/dSIrP2r9hPTpFNa5Vyh/3oFj5Lg4rAFd4azdpal1PouL5oSLsaIDInKzF7ion90g9ANMy/4JKNN1nAOL0Fm8vsEgzyQ9tjIv/GdJG+d0huOZQ3KhN6U5KLb7qT9J/7KBywezuKyzv1XNYxiUfSHrE5UviMMYTh+XjY9I6VMlKToe5YDwo2YNNJ74oZW3EU6+Cd+WF3GyKlwKeCluJ5f+beJ5bkNIgXfhgmdgiKNU8VLKoDzTqQ+7epDBBTaVz2MKlTfvdwkjNCD19SIBW3e0W/NYaD0YMr0wns6THXq9v7kGtw8JNJbRR8h7MOci8LcOAxh1avWqZSk9A6PODZfgiFJ/UrsMdcivhtB8RzhdU7N0KdHo7G9INbcfRyt7fIlAFQCc3XdHzgg6IDF/Jeyk+XVNX/FqMlADfQiAIH7H0fWAGlMprF02OoQW9eAoIYHZXKW+vBCfR+y xS5HLjcg MQcA7Z8RouFQdMMAxWnTWFKn7Rci9IN0D3FYK45Jx1I3duloEA+1dS2uSQKSWCtnup1q09LHXnquPcaTuhaugD04F/nKmO4mJc+Mr9Zb0tr3CFxnZJ3K8xxN3bX5yD0FfAETsEyGMV2LV/2N2X2rCvzvpvWZFROI8r0Jz0VCVo66Ngrg+r+sJDSgSHuj9j1U4646jEW2WjuYi0pfF+GLYwH0LyZljXP/PSBa9WTgRjr9pzTfSDM52J/2wtcoe5h8AYzlsL6foHSI/5uSfkXjSRK9eAhlBl4Fg/TNBNQOSFqZrA8rGJ6pDYcSAJHVMT2xnc4EOAHUTCfWlVCP+OZj1YnUgDS97bZ/NhIsVOCxYY076PRFkRJoIUc54jC9Ug5RBIS5yMmy+cdds5Of/Vf3IwBhIHrvAoOcdJiUOJSFSn5pSi1yOeA8vhYrXO3zcUQKLzu5BE2zIJoxieatrlDmLnUfujggRQsTIdJ5+/rfBWjddoZgcff0Wp0I4ZyMF7nRi2clbkdvhHk9rU4q265O/10YV53M5K7NSbAh6wUAwQSlRZWx13ThGjLolhnLBsmqZhsc9xzgPabiDVAnVCBu5XSTWCP7bAzD/gL1kRNbPu0xOtCju9soLEpW2udZTaL3cRQCMVlEuy/r8lRTnxvpK2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 15, 2024 at 09:48:09PM +0100, Thomas Weißschuh wrote: > Adapt the proc_hander function signature to make it clear that handlers > are not supposed to modify their ctl_table argument. > > This is a prerequisite to moving the static ctl_table structs into > .rodata. > By migrating all handlers at once a lengthy transition can be avoided. > > The patch was mostly generated by coccinelle with the following script: > > @@ > identifier func, ctl, write, buffer, lenp, ppos; > @@ > > int func( > - struct ctl_table *ctl, > + const struct ctl_table *ctl, > int write, void *buffer, size_t *lenp, loff_t *ppos) > { ... } Which seems to have screwed up the formatting of the XFS code... > diff --git a/fs/xfs/xfs_sysctl.c b/fs/xfs/xfs_sysctl.c > index a191f6560f98..a3ca192eca79 100644 > --- a/fs/xfs/xfs_sysctl.c > +++ b/fs/xfs/xfs_sysctl.c > @@ -10,12 +10,11 @@ static struct ctl_table_header *xfs_table_header; > > #ifdef CONFIG_PROC_FS > STATIC int > -xfs_stats_clear_proc_handler( > - struct ctl_table *ctl, > - int write, > - void *buffer, > - size_t *lenp, > - loff_t *ppos) > +xfs_stats_clear_proc_handler(const struct ctl_table *ctl, > + int write, > + void *buffer, > + size_t *lenp, > + loff_t *ppos) ... because this doesn't match any format I've ever seen in the kernel. The diff for this change shold be just: @@ -10,7 +10,7 @@ static struct ctl_table_header *xfs_table_header; #ifdef CONFIG_PROC_FS STATIC int xfs_stats_clear_proc_handler( - struct ctl_table *ctl, + const struct ctl_table *ctl, int write, void *buffer, size_t *lenp, > { > int ret, *valp = ctl->data; > > @@ -30,12 +29,11 @@ xfs_stats_clear_proc_handler( > } > > STATIC int > -xfs_panic_mask_proc_handler( > - struct ctl_table *ctl, > - int write, > - void *buffer, > - size_t *lenp, > - loff_t *ppos) > +xfs_panic_mask_proc_handler(const struct ctl_table *ctl, > + int write, > + void *buffer, > + size_t *lenp, > + loff_t *ppos) > { > int ret, *valp = ctl->data; > > @@ -51,12 +49,11 @@ xfs_panic_mask_proc_handler( > #endif /* CONFIG_PROC_FS */ > > STATIC int > -xfs_deprecated_dointvec_minmax( > - struct ctl_table *ctl, > - int write, > - void *buffer, > - size_t *lenp, > - loff_t *ppos) > +xfs_deprecated_dointvec_minmax(const struct ctl_table *ctl, > + int write, > + void *buffer, > + size_t *lenp, > + loff_t *ppos) > { > if (write) { > printk_ratelimited(KERN_WARNING And these need fixing as well. A further quick glance at the patch reveals that there are other similar screwed up conversions as well. > diff --git a/kernel/delayacct.c b/kernel/delayacct.c > index 6f0c358e73d8..513791ef573d 100644 > --- a/kernel/delayacct.c > +++ b/kernel/delayacct.c > @@ -44,8 +44,9 @@ void delayacct_init(void) > } > > #ifdef CONFIG_PROC_SYSCTL > -static int sysctl_delayacct(struct ctl_table *table, int write, void *buffer, > - size_t *lenp, loff_t *ppos) > +static int sysctl_delayacct(const struct ctl_table *table, int write, > + void *buffer, > + size_t *lenp, loff_t *ppos) > { > int state = delayacct_on; > struct ctl_table t; Like this. > diff --git a/kernel/events/core.c b/kernel/events/core.c > index 724e6d7e128f..e2955e0d9f44 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -450,7 +450,8 @@ static void update_perf_cpu_limits(void) > > static bool perf_rotate_context(struct perf_cpu_pmu_context *cpc); > > -int perf_event_max_sample_rate_handler(struct ctl_table *table, int write, > +int perf_event_max_sample_rate_handler(const struct ctl_table *table, > + int write, > void *buffer, size_t *lenp, loff_t *ppos) > { > int ret; And this. > @@ -474,8 +475,10 @@ int perf_event_max_sample_rate_handler(struct ctl_table *table, int write, > > int sysctl_perf_cpu_time_max_percent __read_mostly = DEFAULT_CPU_TIME_MAX_PERCENT; > > -int perf_cpu_time_max_percent_handler(struct ctl_table *table, int write, > - void *buffer, size_t *lenp, loff_t *ppos) > +int perf_cpu_time_max_percent_handler(const struct ctl_table *table, > + int write, > + void *buffer, size_t *lenp, > + loff_t *ppos) > { > int ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos); > And this. > diff --git a/kernel/hung_task.c b/kernel/hung_task.c > index b2fc2727d654..003f0f5cb111 100644 > --- a/kernel/hung_task.c > +++ b/kernel/hung_task.c > @@ -239,9 +239,10 @@ static long hung_timeout_jiffies(unsigned long last_checked, > /* > * Process updating of timeout sysctl > */ > -static int proc_dohung_task_timeout_secs(struct ctl_table *table, int write, > - void *buffer, > - size_t *lenp, loff_t *ppos) > +static int proc_dohung_task_timeout_secs(const struct ctl_table *table, > + int write, > + void *buffer, > + size_t *lenp, loff_t *ppos) > { > int ret; > And this. > diff --git a/kernel/latencytop.c b/kernel/latencytop.c > index 781249098cb6..0a5c22b19821 100644 > --- a/kernel/latencytop.c > +++ b/kernel/latencytop.c > @@ -65,8 +65,9 @@ static struct latency_record latency_record[MAXLR]; > int latencytop_enabled; > > #ifdef CONFIG_SYSCTL > -static int sysctl_latencytop(struct ctl_table *table, int write, void *buffer, > - size_t *lenp, loff_t *ppos) > +static int sysctl_latencytop(const struct ctl_table *table, int write, > + void *buffer, > + size_t *lenp, loff_t *ppos) > { > int err; > And this. I could go on, but there are so many examples of this in the patch that I think that it needs to be toosed away and regenerated in a way that doesn't trash the existing function parameter formatting. -Dave. -- Dave Chinner david@fromorbit.com