From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BA73C54E58 for ; Tue, 12 Mar 2024 18:24:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9C556B00DE; Tue, 12 Mar 2024 14:24:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4BD16B00DF; Tue, 12 Mar 2024 14:24:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D146C6B00E0; Tue, 12 Mar 2024 14:24:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C08BA6B00DE for ; Tue, 12 Mar 2024 14:24:07 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 848CE1C0FDC for ; Tue, 12 Mar 2024 18:24:07 +0000 (UTC) X-FDA: 81889211334.12.0B008B1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP id ADCFFA001E for ; Tue, 12 Mar 2024 18:24:05 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=OTp6Uakl; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf25.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710267845; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xm7GbgXJn9YwnZvlLSry0HH3FBwrqzxic0mWxiDob2w=; b=cq3GalGPnIxy3xo+ynDCzg0TLUsJdXKAofO88AqFm4SptfjSjA/03RSMKC4qMZgjsmS/Ss eEMC/0pEQybo76rKyLMxZKTyB3GJpaIdgoNrRDj4cV6DVp38ASJ3o6SSWP6iaxLihtVOU0 yueM0uooB4Qr9fCLn/N4BmR+L+GwTIA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=OTp6Uakl; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf25.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710267845; a=rsa-sha256; cv=none; b=u0lOBKR3R61yrzjd31lNfke6vJ1MyKDP38acdduTpIEW/4V7gdjMlDTGXUITxXImZMVwEi jNxlW0nGX8fNSJG/y5f+h8Y2SMGJB8BIKx/shUVN7mrsGrFmL49hgr7+Ymf9ivtSQfk/vO 7+8QX8KYs3CFgTFxm8iOJG2Dxe2lAjA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xm7GbgXJn9YwnZvlLSry0HH3FBwrqzxic0mWxiDob2w=; b=OTp6UaklGT+zH4v4znpg1opiV8 NB3qzGKgQ392B3qikqglBFCsBTZ/ITN3RepSR8mfOqliJyZ8P6vPZWkEucocxDznHbj4Q8NfZfSky r5hTRDUZtyzJbyw73C5MTADF9M6rbHpyplQ1wQIgs9XZNG9ePr9M66bkibeHQOOlcLP3fMH9P6+hi rkYDd5T5ESp2blS0iNFsOmZsRFfyoXXGyEpntSNeY3aC4c03h5T8VeDIou+zIEnxN5h/BV6aPJXxC 2GVLUijB40Xr9Z48KdwiQJqHSi94QEkQDxVUzv/muVg34lq8ha3PURBB6fDGIIcoOPe8F6nKukVgT Lo3t+Kmg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rk6mv-000000076Ob-0eEr; Tue, 12 Mar 2024 18:23:45 +0000 Date: Tue, 12 Mar 2024 11:23:45 -0700 From: Luis Chamberlain To: Vlastimil Babka Cc: Suren Baghdasaryan , akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v4 13/36] lib: prevent module unloading if memory is not freed Message-ID: References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-14-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: ADCFFA001E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 61agxji874mcibc11mdccfuzc6cko5kx X-HE-Tag: 1710267845-606384 X-HE-Meta: U2FsdGVkX18eucTOqvUNVUK97rhdzmjygNXBShWRFW+P7N4/vTorVnp8VInKeTdl0c49okQjU85wLzHYgYLZZA0ywZkr6HDOV6tdEZDqODc+az+CXhyV0hU3XVZ+vaqzlC+rYIqgUzG4oqUECkFTH+MkO6KHodLpaVwxTaiamTjGkwxICgbw2atrWkZGVnsaGlLLFV4McyP3jMQTXubR9ejXqglo6nX9xZLjqWSrbfUje+0/PyJAvTEvSVNKIWXJuIPhR+1ilNBwH/ijHn1L6DO4K8/jKkw7594ZQuS3MjnD3xjGDf1sTJBdoUQMsBvq/mUxZie1b5olofRlv5A/mJBEaN6cVh5DA72HuRq0lljQN1wPOkgVrYNLgP6yLYwwoFBPZ390iy7RYeLxrv42Qz73bl2af4hVhLVuzIpoKxZduk3Qeg0UhgdImdq6pbHMbkETztq4GQN8hjjYV5/HLcUew/6o2m4jqE2rMJbCuHjKaOg2BRd30xS1hPs0ZMQnO4F2Iit+I2I0exPyo8W1AoFYU9IXq0DYBp2pHPKSeq+Q1blPw+emsraDMZpEzSh16ecq045t6KEz261dLVfnkuj/USwO1opq9C5FORK3ymkyQHIi6O6khh+6TOEsfAOrFRA/mVWgAohPQrQAW7HA3t/LF9mKzhK8KYmWiqHa4zAWwJToJ9bSO6p2F93jy3gHuVDYFY+CpZXQAsgQnZejBe5O+YaW8n16OnwrhlvL6AYfMzownfCvGaKfsRswzUIej48PsaRR/hDh/Yu0KQrPSnyQmQsYdqqkAqox3MD6HG0KSdYm4zhELDAiBjV7iVry91zeMXoQvjy4wRuv3/eKq36Rsk5oqiykkKCdN5od1hdQSFGbeHTsguA3GfMVLLLzicLOmfED1Bs7Z9Gox+VoYVJIPJmLbckFGDG/nRuy60/fD193pj3oYphHqElUO61LZ2K0QSvnG0dsonmjYEL PMSKafWm eiB9HUR6dVLoq2mMNWvUrqslpZIt7jzX9D38zxodHzNBtX99JykmriV28JevKTV1T7vY0h7afMmqX2TtLyuvxT7VVaVVuc/bgta0S0ly+C0sZ4290fIS/Kw7yeMpBELUZvA7tp1VvkVPOFwuwUgnSY8uF1QkkHKIHckeS5IvPXAv7cce0lUBg+SxsyZ4jhoA7LfAflYpolhdtC8+bkR1wHDz30U/VWRXdlMwG1Z47TXIWuXyN/ESaVOpZlU2QJZ4ZroGuA763nAjbRSp7WmYNvbnglIeadduwbW9rMAWTNZ4FMUUo8CUnllpoMsuJRAhYDQZK0UFuPkmDrVJklQfKFd7gjNnVCbctYwrkg4wtgM7/uv3wEM6UZ3vmpg84itkte0p+a2C0hBnxUnKAdRHTlEcDJXhgJjJ2ra9lih7YHH+v1R0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 05:58:40PM +0100, Vlastimil Babka wrote: > On 2/21/24 20:40, Suren Baghdasaryan wrote: > > Skip freeing module's data section if there are non-zero allocation tags > > because otherwise, once these allocations are freed, the access to their > > code tag would cause UAF. > > > > Signed-off-by: Suren Baghdasaryan > > I know that module unloading was never considered really supported etc. If its not supported then we should not have it on modules. Module loading and unloading should just work, otherwise then this should not work with modules and leave them in a zombie state. Luis