From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4E65C54E58 for ; Tue, 12 Mar 2024 20:37:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 399D78E001A; Tue, 12 Mar 2024 16:37:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 349A98E0011; Tue, 12 Mar 2024 16:37:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2116C8E001A; Tue, 12 Mar 2024 16:37:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 121988E0011 for ; Tue, 12 Mar 2024 16:37:18 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AACB28098A for ; Tue, 12 Mar 2024 20:37:17 +0000 (UTC) X-FDA: 81889546914.29.6340A52 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by imf06.hostedemail.com (Postfix) with ESMTP id 0F17518001C for ; Tue, 12 Mar 2024 20:37:15 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HZXpeDYD; spf=pass (imf06.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710275836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uAqALqr1rdPH8sdbmVB4VkVDqs3g9V4IllJSBYc1FHc=; b=qAIH8TzaVlfbYcDmYx2UUt67KLrJVgSQ5zQONQQK3QNctqmvri1KxKCqi3YnFmJh6YgXUr wVij69Gd3G9NTnnKKamjuqYq1lmNjO6Tn++rVyZ6DF2o/cqgdspfN3JZO9oNedHiWme4Oh 4D84Ln2H+YUvp1y7g7zHJ4XJDX/kjrM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710275836; a=rsa-sha256; cv=none; b=6ZazCw4nekrBeXdHgCfv3gv6upyCaBErmtAnxx4ul7l90Rg0G6L+qi+cnFobA305bTglRY EZMjKLX9QDGAfvmwecG98GbXEIh+ilIe3RufRCVdMEQc1V0a/ItIavfuTabOqLorlAzGQI 8Lc5QKUsDVXEj9Mq+UmIJ8Pud7eKiqw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HZXpeDYD; spf=pass (imf06.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Tue, 12 Mar 2024 13:36:54 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710275834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uAqALqr1rdPH8sdbmVB4VkVDqs3g9V4IllJSBYc1FHc=; b=HZXpeDYD0w65xyXfNRa7nKoN85fwgSPBYCylhns9hpHruUJ3UL5pTGeoeVWfGN0tweYVBf UKF4GnESETxQFudkc7MEA5P8Gg2KhzWNWGMn9Lt+P+7G6a+/J/s22SGiV6rW7oKL1P7Q5h p8LVxeur3vJydFpomBcAYoJToGWwexQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Matthew Wilcox Cc: Vlastimil Babka , Linus Torvalds , Josh Poimboeuf , Jeff Layton , Chuck Lever , Kees Cook , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Alexander Viro , Christian Brauner , Jan Kara , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH RFC 2/4] mm, slab: move slab_memcg hooks to mm/memcontrol.c Message-ID: References: <20240301-slab-memcg-v1-0-359328a46596@suse.cz> <20240301-slab-memcg-v1-2-359328a46596@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 0F17518001C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: hik7ekbp74wosbeo59997sm7obid6a35 X-HE-Tag: 1710275835-188036 X-HE-Meta: U2FsdGVkX1+snvUYUwNQOkmPwTZelOU4B15WgBlX/M8/KKTwhLfji1onuIPUH6m3Wpwmyx8GfJlxUqcnLHr3MAX6C2jaasgWicixg20ZowAp+tC4bj7PMnFZZ35odQAMfJFvgwysbYaRqL52OtT+VHAqcSlpdV0p9JrtZZ0PYWabeudcSCi3IXKwdVyo1SjMTnIYOZPjbwgv6Z7g2rpr3fQEbJLKz783r0X0FhXQ0hibXI18PwS7LPvS8KB9lBKGAd4eKS4Ju8jd3PwkbGpg3BPLuCZAhd0dTqG15NSOFr76fmLjo+WeBBXgowRIrdU42zEGnDWkfzRDW9ix5Y4KLDYuGFNX5LVjEY+TdFk7cXlamarwPeCn+7MG27pswWSxOJUrt4BcfClAlk56VYE5pbhw7bfVNQJIV2NLgSCDDQjmL1ym8FpQMZkICFvoda6mthYD5CG1qp581bYUf+vs3qmakd5mfAZAjzHNBgmM+gf5A/y8aNt4VQRKB5ZrhJKLpLEUMKnop69wRHtRAlp2qiyRAi08L2qcoQGD2rkArwBi+e1qqCL/P9O4Wk15jsIrpuXHB5ztxI0r4Bj6w/Co5N/pzku8iR/wIZXeasAdt5NiVuPuZBSIGtjsM2kIVsOIIhA6cMvgFPBDrpz4fqwiANEjGOMkhvW2ED47J/qQX9X6BNQypPdfCtfsyFRYXS/mSpWbXrakPquCRLvrfajrnmFZSJlp9D6cGS0yeK/CC0w/9QZ7VnQgmXwlcDtCvcrP8AmTISYAgbRB1uWt2xZuVfDopG7H32tksKbjVJ+oAQR9JpDBuUYY+2U50xcNtWuxWgnFvjbZMVzwgyu88Piu+fEWSini83+yLRSdC9wWHpSq0+eahKX/SFNHP9fxTQABm/jiOJ0sj5nDySQY8LuwxLbQZaA0uBHHk1z4Ueo25AI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 12, 2024 at 07:32:57PM +0000, Matthew Wilcox wrote: > On Tue, Mar 12, 2024 at 11:56:31AM -0700, Roman Gushchin wrote: > > On Fri, Mar 01, 2024 at 06:07:09PM +0100, Vlastimil Babka wrote: > > > The hooks make multiple calls to functions in mm/memcontrol.c, including > > > to th current_obj_cgroup() marked __always_inline. It might be faster to > > > make a single call to the hook in mm/memcontrol.c instead. The hooks > > > also don't use almost anything from mm/slub.c. obj_full_size() can move > > > with the hooks and cache_vmstat_idx() to the internal mm/slab.h > > > > > > Signed-off-by: Vlastimil Babka > > > --- > > > mm/memcontrol.c | 90 ++++++++++++++++++++++++++++++++++++++++++++++++++ > > > mm/slab.h | 10 ++++++ > > > mm/slub.c | 100 -------------------------------------------------------- > > > 3 files changed, 100 insertions(+), 100 deletions(-) > > > > Reviewed-by: Roman Gushchin > > > > Btw, even before your change: > > $ cat mm/memcontrol.c | wc -l > > 8318 > > so I wonder if soon we might want to split it into some smaller parts. > > If we are going to split it, perhaps a mm/memcg-v1.c would make sense, > because I certainly don't have a good idea about what's v1 and what's > v2. And maybe we could even conditionally compile the v1 file ;-) Good call. We already have cgroup/cgroup-v1.c and cgroup/legacy_freezer.c. Thanks!