From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9D16C54E67 for ; Sun, 24 Mar 2024 02:57:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CF006B0082; Sat, 23 Mar 2024 22:57:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37ED36B0083; Sat, 23 Mar 2024 22:57:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26D8D6B0085; Sat, 23 Mar 2024 22:57:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 180E16B0082 for ; Sat, 23 Mar 2024 22:57:17 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id ACB8A807F8 for ; Sun, 24 Mar 2024 02:57:16 +0000 (UTC) X-FDA: 81930421272.22.8BD79F2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 010144000A for ; Sun, 24 Mar 2024 02:57:14 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XCWD+DFa; spf=pass (imf04.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711249035; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n+TBDAPYKAkzCa4g/UJwRwmAT/evwdu5C0HNn4WKYUA=; b=Xxvj9V3DkL5qaR2hIUd0AuhmR/lN/bQ3CAvBvqbhMiRV7zA0P8uIbjnExaUYqOjvhmJnDZ Qbos8HJTybhpVy2NvIi3giEIRnfg5+Ho7YVpo1IQmoxBYdwD2EQVo2cyuzJugwlTYkLhFg aEsDzPI+XxDE5NUn5wSRSBiUyEDiCPA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711249035; a=rsa-sha256; cv=none; b=TRh2uhYfHy4aDCxx9unb9L4zDt/DVAeyMg4QFuF3J3cq3r0NwWcKuHEea3DWYt4sMrmMsQ cChFjhxzKjgk03pY9SstEjfI6JnOUI/gHv2kx8j7votjyL1FLQHSqhwkCOwvT+aWQ9ZfJh D3caHWo9VpbdMiegOeeN6psg+HQFu6g= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XCWD+DFa; spf=pass (imf04.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711249034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n+TBDAPYKAkzCa4g/UJwRwmAT/evwdu5C0HNn4WKYUA=; b=XCWD+DFa6LUL6uFCzyVufEnfvWr8Pmw3jCPVKgUHvoVO2k3Ls4HABofUqTOu8g49jdrZRw FkNRZybq7toX4SsgJSBgISKhaHl/STgyET8tYB2AuhxNp+Mm86ZdCE6U73FsPSeg3K6hBO 5Po1jaHFD/rinezvS03LDsimhIuU3gw= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558--yiJeQbhMVyWzc5LN26Xbg-1; Sat, 23 Mar 2024 22:57:09 -0400 X-MC-Unique: -yiJeQbhMVyWzc5LN26Xbg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A10ED29AA384; Sun, 24 Mar 2024 02:57:08 +0000 (UTC) Received: from localhost (unknown [10.72.116.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8A68F2166B31; Sun, 24 Mar 2024 02:57:06 +0000 (UTC) Date: Sun, 24 Mar 2024 10:56:56 +0800 From: Baoquan He To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , Dave Chinner , Guenter Roeck , Oleksiy Avramchenko Subject: Re: [PATCH 1/1] mm: vmalloc: Bail out early in find_vmap_area() if vmap is not init Message-ID: References: <20240323141544.4150-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240323141544.4150-1-urezki@gmail.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Stat-Signature: rnce6fkast5iw3ydd43nwipq917wrqyq X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 010144000A X-Rspam-User: X-HE-Tag: 1711249034-339898 X-HE-Meta: U2FsdGVkX1+H0u9LdY0o2SoEGOAwwoDICGkF9DP330gf5XULqISPiFBbTyBkKCyuI/j0dZCtlO8HFm/7Smmq8bC/+jOSyD/Z6ECs1e6VsXDqZHqaN6Xu4NcNPAKU7yYjyp0ydOdkaMyxob16roAB6BZUyRGCbH+ka0t9AdUKchN6nzBCsTNqknaV6ZrLCuI0SCdexdSi+HawOY4ckxhhwRdzx/9YSGTQnNk5eF+4VyBsYhBy9XP0bsIqoDgti2/+eOlKHyoxk5XS1XzDICrbYS69Rm3YbQ2pmJQ126oA9GiyaC42D0Ux0ua1VQxv+tQqRnuHMFBrha5T4PB098u4S2Vk/szOSExuASZJDLAQJdlCxNnTxRXNSxjftRqllNWOXP8pO1VghtnYxFhgnvmaF7BPSFNKXghEK/xNHSQawo7pXqsjBexR1Lva/kP1YY8YJX9ZXl7fL5n+w2zUOmdbnoDvRJ7awer+a0Q7Otz5Azxj2OFKSJqM2/1uNRVJFsC/d/q81b5P+N9LeR75mAx7gzevAIKD3UnhU7jiIBkfsmz/icglVEJVYgWLc7SM2plIbog3FCxMtmEtFpPWeuJNVqj1tZIIoHF5tzW1ORBK+/wbtXK6IR8+Gp1WdYyR+ztJ0rFokGnvCAhJDORQWQO5C8dEyM4kuKA8L7DwXqTuk0nSwzwuaUxX0JQtoUYqo0PDiJKvjrEi1i9gDI+Qd1Vg5zIEDGbzSsYJG22gdi57rRMokRki2NLEHJpJ1leIH4XMOSjwQ4jph9HN1czVOoE5baeYYZsdQ4UPkc6Pgp9gOE69mOdFpJSN9aiy+P1FDoAkaPFuYphmI7z/V2yM7qgq/kCpF+wznyRD35TnT2Tkm5mfweZdhsNVXOaV34LReiDBjvqpJfP+q9L9gbcT6X57uy8Jd2tNv5HSgw/MK2V5ZeTu+qbvDaCu3dUhp8v5VcYa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/23/24 at 03:15pm, Uladzislau Rezki (Sony) wrote: > During the boot the s390 system triggers "spinlock bad magic" messages > if the spinlock debugging is enabled: > > [ 0.465445] BUG: spinlock bad magic on CPU#0, swapper/0 > [ 0.465490] lock: single+0x1860/0x1958, .magic: 00000000, .owner: /-1, .owner_cpu: 0 > [ 0.466067] CPU: 0 PID: 0 Comm: swapper Not tainted 6.8.0-12955-g8e938e398669 #1 > [ 0.466188] Hardware name: QEMU 8561 QEMU (KVM/Linux) > [ 0.466270] Call Trace: > [ 0.466470] [<00000000011f26c8>] dump_stack_lvl+0x98/0xd8 > [ 0.466516] [<00000000001dcc6a>] do_raw_spin_lock+0x8a/0x108 > [ 0.466545] [<000000000042146c>] find_vmap_area+0x6c/0x108 > [ 0.466572] [<000000000042175a>] find_vm_area+0x22/0x40 > [ 0.466597] [<000000000012f152>] __set_memory+0x132/0x150 > [ 0.466624] [<0000000001cc0398>] vmem_map_init+0x40/0x118 > [ 0.466651] [<0000000001cc0092>] paging_init+0x22/0x68 > [ 0.466677] [<0000000001cbbed2>] setup_arch+0x52a/0x708 > [ 0.466702] [<0000000001cb6140>] start_kernel+0x80/0x5c8 > [ 0.466727] [<0000000000100036>] startup_continue+0x36/0x40 > > it happens because such system tries to access some vmap areas > whereas the vmalloc initialization is not even yet done: > > [ 0.465490] lock: single+0x1860/0x1958, .magic: 00000000, .owner: /-1, .owner_cpu: 0 > [ 0.466067] CPU: 0 PID: 0 Comm: swapper Not tainted 6.8.0-12955-g8e938e398669 #1 > [ 0.466188] Hardware name: QEMU 8561 QEMU (KVM/Linux) > [ 0.466270] Call Trace: > [ 0.466470] dump_stack_lvl (lib/dump_stack.c:117) > [ 0.466516] do_raw_spin_lock (kernel/locking/spinlock_debug.c:87 kernel/locking/spinlock_debug.c:115) > [ 0.466545] find_vmap_area (mm/vmalloc.c:1059 mm/vmalloc.c:2364) > [ 0.466572] find_vm_area (mm/vmalloc.c:3150) > [ 0.466597] __set_memory (arch/s390/mm/pageattr.c:360 arch/s390/mm/pageattr.c:393) > [ 0.466624] vmem_map_init (./arch/s390/include/asm/set_memory.h:55 arch/s390/mm/vmem.c:660) > [ 0.466651] paging_init (arch/s390/mm/init.c:97) > [ 0.466677] setup_arch (arch/s390/kernel/setup.c:972) > [ 0.466702] start_kernel (init/main.c:899) > [ 0.466727] startup_continue (arch/s390/kernel/head64.S:35) > [ 0.466811] INFO: lockdep is turned off. > ... > [ 0.718250] vmalloc init - busy lock init 0000000002871860 > [ 0.718328] vmalloc init - busy lock init 00000000028731b8 > > Some background. It worked before because the lock that is in question > was statically defined and initialized. As of now, the locks and data > structures are initialized in the vmalloc_init() function. > > To address that issue add the check whether the "vmap_initialized" > variable is set, if not find_vmap_area() bails out on entry returning NULL. > > Fixes: 72210662c5a2 ("mm: vmalloc: offload free_vmap_area_lock lock") > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 22aa63f4ef63..0d77d171b5d9 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2343,6 +2343,9 @@ struct vmap_area *find_vmap_area(unsigned long addr) > struct vmap_area *va; > int i, j; > > + if (unlikely(!vmap_initialized)) > + return NULL; > + > /* > * An addr_to_node_id(addr) converts an address to a node index > * where a VA is located. If VA spans several zones and passed LGTM, Reviewed-by: Baoquan He