From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D73D9C54E4A for ; Fri, 8 Mar 2024 17:02:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 611D28D000D; Fri, 8 Mar 2024 12:02:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C24E8D0002; Fri, 8 Mar 2024 12:02:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B1208D000D; Fri, 8 Mar 2024 12:02:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3D0D38D0002 for ; Fri, 8 Mar 2024 12:02:18 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 043D01C032B for ; Fri, 8 Mar 2024 17:02:17 +0000 (UTC) X-FDA: 81874489956.30.68E381D Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 7C5232000E for ; Fri, 8 Mar 2024 17:02:13 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=SjKkr9M7; spf=none (imf03.hostedemail.com: domain of BATV+b04b5aca088d081a4ba5+7502+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b04b5aca088d081a4ba5+7502+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709917334; a=rsa-sha256; cv=none; b=wyq9tkob3p8jZu/191grPDUAesjUrR6vRG/ME45ZznatY5pgeKJwqsctc3Y5OP9yGn2uGn YyNkd8L76JusPvzTmBhe7UHcGPQXwx4MryVLIqe12OXZw3Z/MmC3b4FzN1t4yB204Cwjcl MtvOXQX/ZP6jgrE0qpd/KT7MZaDkSZQ= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=SjKkr9M7; spf=none (imf03.hostedemail.com: domain of BATV+b04b5aca088d081a4ba5+7502+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b04b5aca088d081a4ba5+7502+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709917334; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4qt6B2DEelMk3i3au76miwVYGuqD69MMNvsQhf9L6eU=; b=TB6CEEVR3ZaK981IBznB1JgtzeOjz3H0ISh1fNebMZx8EAwHDozUivDlGWDHrECyOV/aFP EFqO1z08iz2xN7EXiyd6fJqSdtnfpmyRIeRaJ4b3ArUiwYo2EIVyPwFVBkYCTfH2JDrAey YiFmeSSqy4vy/p28UmWf1gZielpJrKs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4qt6B2DEelMk3i3au76miwVYGuqD69MMNvsQhf9L6eU=; b=SjKkr9M7HMCTOJeUS7mscRYx5K lu8Smc7Bhj+S8mDp4VsgDShum2AAGcEXflC1jcpUhkEKrYpF7Bbp4xI42lx8mhtr+euAwApC5Z2z8 3ffgWeSG/txUpX5DOj1uG/xkuo05nYQLUhkPFHxvw0tRJoronxRdMYz6DJ92mTWRVW4HkkMFhA3RH QhOXe42tfkLsAn5aZr8HjFlGiilvCmARmuR1YxooOxh8Nt64TfxiAb9obIMj1KEYClj//0VG669Ps eZLe3sQOoNSqU+vWomQSz11n0w3kQAOd38T37PSYk2o7kMWG0sbtdtNNYnZInnflW4kpZfEPTMu8N qwnrrJ+g==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1ridbo-0000000AMNk-086d; Fri, 08 Mar 2024 17:02:12 +0000 Date: Fri, 8 Mar 2024 09:02:11 -0800 From: Christoph Hellwig To: Alexei Starovoitov Cc: Christoph Hellwig , Miguel Ojeda , Linus Torvalds , linux-mm , Andrew Morton , Catalin Marinas , Will Deacon , Linux ARM , Daniel Borkmann , bpf , Bjorn Helgaas , linux-pci@vger.kernel.org Subject: Re: vm_area at addr ffffffffc0800000 is not marked as VM_IOREMAP Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7C5232000E X-Stat-Signature: bemskw4g6i6ijc6nhyqunxjptmpoqjqk X-Rspam-User: X-HE-Tag: 1709917333-314623 X-HE-Meta: U2FsdGVkX1/FoFA13tdZr6JNcUOjwEA2mPoenWhbCOE5NB8HrDH4emFZSL3PxATDNDqIgQQnmnrNTsH9BEBe6nTJxwDy8PcUtLlcGzes2xwyrXm/rXCuoj/SHRUf39NsM2GK/SW3fZyR66qHo9BW5gmTzc5fUPgZgaQoWtd8c16IeiFQCsh8vd3ZwddyodzSvD+it2ejLQLYeVUSQnLSKG5THXejffTJO+om6a/OQ7WepsZ8if9zD52oGUeaxIbIMgV2Uq1R43D8FcM5J90JcDrxvEvGZXCsZvUwCuD7Hqdb/mK9DEI6Yx4jbWf6LBLCrnQmxBZwff2ZP6ah6alaECRtzGmxpGXe0ZgixAONjL9DxG6Ryb1IiTeIgGo6eM2o10yif1sVewO4ZNycJam1HDoCc6v4Fp8cIy70Uca+eAr/cL22R2hfdl64f5KmfCPCciZcT7yzxy921ifja0D3yC8UcYeqivx48pbZ76xelGQAzat3mkNkl+emgSbUTeuWPonpstkRSnGj11xA+1YIzd4Tg1DZ5Zx8dUhWDq41U/EhezMIdeAihlhcnHdiYFxhpT7PDWsydtfvb2FH2QZ1K8jDSDfLKmbmgZW6wDa9An/ajnyEOBccV4tXc/To6g2JKEkaBJs3omXQ0Rf1nH5htCIEC7G5bd4OOTy0wwEkcRDEQQ1L6gmQNmcKYkNFKMUZ0wAwOAZ+tuRwuSDkgn+nFfdlsdT/8IMuJLsZuo/yp7kpI99pKbxql9GgTz+ItquhwZzZkyABn2vSAvLPMXnat9rjys+q04fMdD023srvOcl7hUGJwmGvPNuh8RqaNlBG+sglF7+WVTBLnYeW6P39t+NH3zh8fpVzS2krMaGAXlzq7UDa2FaY+YkX4ILZx7zpNa2aprwskzkjKS9QMjuNHuzkpZOT0H3T/G8xiVwNH7zrS0UYdQKO0uGoPrB1vmCzUFqKkyY6hhBiCseazJK 90hP3UEg /W5xX67Fp3jvfRB0TpQ+P1ws+kYmB2/kQtcr5Ilpw8vIngRI9dDeX9w6PyDaAcQFwqHcRRHEy4rWD1KfxO1kHoY+pEpMOo4VydQ0sx1+UrEqudCDlFoLkIiCzJJI2YLwycaYoD7ehDKrW5eZf7aFzueQlwKfQh8P1hyyQ5idXlptsCVNIqQJs32pTHxFUyT/HW7wpuif05wPd9miT13RdvzoIDCqbJ4+NUPsUT5OATPsLGQ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 08, 2024 at 08:33:18AM -0800, Alexei Starovoitov wrote: > vmap_range_noflush() is static in mm/vmalloc.c > There is vmap_pages_range_noflush() that is in mm/internal.h, > but it needs pages instead of phys_addr_t. > Newly introduced vm_area_map_pages() needs struct vm_struct *area > and struct page **pages. > In this PCI case there is no vm_struct and no pages. > ioremap_page_range() is the only api that fits. afaict. Except that we want to enforce a vm_area with the ioremap flag for ioremap_page_range, and just adding a NULL check defeats that. The right long term thing would be to actually create a vm_area for the PCI_IOBASE region, but until then we just need a lower level API. That's why I suggest to add a vmap_range() that is basically the ioremap_page_range before you added the checks, and make ioremap_page_range a wrapper around that that checks the area. If/when we get PCI_IOBASE handling converted to the proper vmalloc/ioremap areas we can remove that again as well as vunmap_range which is just used for PCI_IOBASE and other equivalent ISA_IO_BASE in powerpc and somewhat unusual case in arm64 that I need to look into a bit more.