From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A3B0C5475B for ; Fri, 8 Mar 2024 10:28:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E4DB6B0365; Fri, 8 Mar 2024 05:28:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 493896B0366; Fri, 8 Mar 2024 05:28:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 333626B0367; Fri, 8 Mar 2024 05:28:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 24BC76B0365 for ; Fri, 8 Mar 2024 05:28:14 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DBA9D14154D for ; Fri, 8 Mar 2024 10:28:13 +0000 (UTC) X-FDA: 81873496866.29.E44B98F Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf23.hostedemail.com (Postfix) with ESMTP id 15FDA14000D for ; Fri, 8 Mar 2024 10:28:11 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="R/BOHj4e"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709893692; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jBDERlcMFtZu/muYJ2+aOhb4NEueDDD1cqxDNs7/Kqs=; b=5R6tEqgZJiwrg2XKwUPtgBBjdB658Na3i1L3oJ9HrUbxYHCCL2qk3QAPKzdSxfQx+b6Z0K MeJkxpySGSUf9nJv9kyS/Qhml0kUpvEkBXzynysc85sczaoxvO2wJY5KJFQhYyf8bfwqAe ZIaNA76QvFkOR6Bh/A+1peD6e3ZO1DY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="R/BOHj4e"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709893692; a=rsa-sha256; cv=none; b=sdNV5fG4QoFNFmMVkrUHtgyNd/uwotlu5Atizziy49AKkyG+7bzaQBqmQZXP9WaSshkFtk uJIsKaTCz9npTy1QGvLmhmTHA0D5UYCCEcLhLVHHnmEXtXkUFvQ2KhUIio7CTfw54X+rIj DDbxpGtZlc572B3pL8cM83P6zfYY660= Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-512bde3d197so1833203e87.0 for ; Fri, 08 Mar 2024 02:28:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709893690; x=1710498490; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=jBDERlcMFtZu/muYJ2+aOhb4NEueDDD1cqxDNs7/Kqs=; b=R/BOHj4e1McmJYmiM0wAweg5FO71Ie62QDr0Kz55oI+RIWfp6Fz7lk6Oov5BOizetg coCiKv1ypsiJY5zz0kcKUp9nuG2Jgys0QdHJv9cOh5yXhUoFktrwA10R000oDSzuRRTz KxlON3kzd6eC8UtpgJmcA978J1zwYgiRkjwi7V1iqTIK25iU5gsEpmC//Xodr+zGNqM9 doIsNZLW7g96gOuqGKvA40/Ad2fLtxCFjcFLMSI4vNHQ5bl/pLrfQJ5ijOKNmyA7IDj2 /tT+5yyvEb64bDxQsl2xMmDNo/J7hh+bZ03GgML36Ymqk7wZlEbItS2EFmNXZuwow/i6 HC3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709893690; x=1710498490; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jBDERlcMFtZu/muYJ2+aOhb4NEueDDD1cqxDNs7/Kqs=; b=QGv+KjouH26VXehydL2UeSzGuvVYV9pWbftTvDjvn52JyCUD5G2LzIigFLyGCRhVfb th14584ZDVWEPQcieKwf3kAFcKBGqmjXDcq6DyUI8IKqyXbuJt0fGyk4urzZnizzy3Vd obRN0Xb+jqLWWXfl0yIL64leL3Azr87H+u9Ko23x5s2BLDvR1WyqVXWMXNwYBGxoRKy0 CJkAtiRr/CLVXOxJXgpkYkKKNLnmcuIp0K18Tj3EMwwwnnNJmFDNTpwdKiFZvfkDfCMo rum+WQe+n2cHXZB3AI0BcmZEV3xuDcfbLuqQJIjZhPCewJIkuc//KPRMy5Aph66v6dgK 1eKw== X-Forwarded-Encrypted: i=1; AJvYcCVvAqfXh+k90HMsV/sgjFlV6qA0r+LYMIr8ARF4HpGM8OUbVsNNVoKDhYJkykkfQ4xpKFtCd437nWhyHrqdi1v1I30= X-Gm-Message-State: AOJu0YyiyCadFbLf3n1C/S812v1WBfrarMj8aQInix/HApN0szoJT/Rq rmKOyr+AfEBWIfukdPfZ45Cnadh1/XtWu06a8gXQqlhz1jTeH4kM X-Google-Smtp-Source: AGHT+IEMWl0js3+29IRQOofJrkKm0NRvkzc7iWaN92QgEAsMgbOrM9gjzbja4OSrLul7AlcHmIBDrw== X-Received: by 2002:ac2:47f3:0:b0:512:cda1:9bab with SMTP id b19-20020ac247f3000000b00512cda19babmr3031431lfp.13.1709893689854; Fri, 08 Mar 2024 02:28:09 -0800 (PST) Received: from pc636 (host-90-235-19-15.mobileonline.telia.com. [90.235.19.15]) by smtp.gmail.com with ESMTPSA id i15-20020a0565123e0f00b00512851da32esm1238742lfv.248.2024.03.08.02.28.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 02:28:08 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 8 Mar 2024 11:28:05 +0100 To: Baoquan He Cc: Uladzislau Rezki , rulinhuang , akpm@linux-foundation.org, colin.king@intel.com, hch@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lstoakes@gmail.com, tianyou.li@intel.com, tim.c.chen@intel.com, wangyang.guo@intel.com, zhiguo.zhou@intel.com Subject: Re: [PATCH v7 1/2] mm/vmalloc: Moved macros with no functional change happened Message-ID: References: <20240301155417.1852290-1-rulin.huang@intel.com> <20240301155417.1852290-2-rulin.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 15FDA14000D X-Stat-Signature: crsobj4pkwcz6g34x55cio1hrniy4ojt X-HE-Tag: 1709893691-10129 X-HE-Meta: U2FsdGVkX188tSlaZBKJqDkXd0LXVPnF3kw1pDQCyHeLc9+B9VnBgzePM+HDrfYkrLc1tsOiomtYeLWvEs/UoknkBOM/gEOa9bG+PLUJO3yLoWFnVzPQ3hb+JwiBc5UuODAFp8M16v/m6qHUqKz7T0mXLmJEb9SyyZDWeLodZK77Ic3QwRjFKsiAGGGivtI6XEAaa73llAmBFr8ShsV6BiuTOVaKjqFYt9tkc/vurVBoiYd0vHJEr3QNqJ7V3crNmXPGYM10bEf/KzZo32PCzkpHQQvHVnHyRLW4b8KZCmMNoHwTso7kKkci3+KmUdtwuQCQ2ORRFKu2eSMmXkczYqee1Kvos35bNNxGG6SWSMbLPrVxGo8YsVajmbMss0+zvQCbA/mi7N0mFQilsgSkQXiZVqAg18aftkZORmaxOGmEh5+UBOJBAsTn11AlUzJ2OmiKCW+5iihksXLjEbp3z3+3DmWjrOza1+nkFnSrpBL/ST4HfH89ws90JZ7bAJYcrwCgkfJwYA4abbhmJRh+CFbd0plTiSPDt7bi3qOxZJ28QOHwgGQ0MfVLKj+QwT0VEwxDM52w7G0bMtDYTpNXLm2HreAT4VajEXFEix0EcO8ZdMk9tPjdU8YooiURIJjhDsCdoUaA+Vpc8iP4IDPsdslnEeas0oXtiIo9cNu28xjH5170XwYTucDq2Q+qvM0sy4O3VT+5z9Vnl3OyZafSxPaxC/U6u3Fl5B9jhWSqFU9/WLQbJa8WRNo6u0KI1o0+DTBAV7FWui471FSxkmvgByUvlsxrhfbX94KwrXbNS2iJs5CRfSv3QqzHs4HCR5OIinvH4aWM3yzwnqVpKRai/5pD4Q9MRgMDgJ7XtX3Xhvc/EUul55Bcte5TyQGE+KrtsYLJ2iTmqsST7ckeAMLbLoSh1dlUe7xde9jW52GIXJkXcxOAskJAGRLlBvc8ECYSoAW9fWGe3UM0UprYgG3 362KK6H0 Tmpjj9DSaAYkSLqeDIAMTV1t5XK0PsQXVypCTht+zWuruN8aDmPTs0r+NKPxEhkTyjj+0jyOMKgsqQMY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > I would remove it, because it is really hard to mess it, there is only > > one place also BUG_ON() is really a show stopper. I really appreciate > > what rulinhuang is doing and i understand that > > it might be not so easy. > > I agree, I was hesitant, now it firms up my mind. > > > > > So, if we can avoid of moving the code, that looks to me that we can do, > > if we can pass less arguments into alloc_vmap_area() since it is overloaded > > that would be great. > > Agree too, less arguments is much better. While I personnally prefer the open > coding a little bit like below. There is suspicion of excessive packaging in > __pre/__post_setup_vmalloc_vm() wrapping. They are very simple and few > assignments after all. > > --- > mm/vmalloc.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 0fd8ebaad17b..0c738423976d 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1924,8 +1924,7 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, > unsigned long align, > unsigned long vstart, unsigned long vend, > int node, gfp_t gfp_mask, > - unsigned long va_flags, struct vm_struct *vm, > - unsigned long flags, const void *caller) > + unsigned long va_flags, struct vm_struct *vm) > { > struct vmap_node *vn; > struct vmap_area *va; > @@ -1988,8 +1987,11 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, > va->vm = NULL; > va->flags = (va_flags | vn_id); > > - if (vm) > - setup_vmalloc_vm(vm, va, flags, caller); > + if (vm) { > + vm->addr = (void *)va->va_start; > + vm->size = va->va_end - va->va_start; > + va->vm = vm; > + } > > vn = addr_to_node(va->va_start); > > @@ -2565,8 +2567,7 @@ static void *new_vmap_block(unsigned int order, gfp_t gfp_mask) > va = alloc_vmap_area(VMAP_BLOCK_SIZE, VMAP_BLOCK_SIZE, > VMALLOC_START, VMALLOC_END, > node, gfp_mask, > - VMAP_RAM|VMAP_BLOCK, NULL, > - 0, NULL); > + VMAP_RAM|VMAP_BLOCK, NULL); > if (IS_ERR(va)) { > kfree(vb); > return ERR_CAST(va); > @@ -2924,7 +2925,7 @@ void *vm_map_ram(struct page **pages, unsigned int count, int node) > va = alloc_vmap_area(size, PAGE_SIZE, > VMALLOC_START, VMALLOC_END, > node, GFP_KERNEL, VMAP_RAM, > - NULL, 0, NULL); > + NULL); > if (IS_ERR(va)) > return NULL; > > @@ -3063,7 +3064,10 @@ static struct vm_struct *__get_vm_area_node(unsigned long size, > if (!(flags & VM_NO_GUARD)) > size += PAGE_SIZE; > > - va = alloc_vmap_area(size, align, start, end, node, gfp_mask, 0, area, flags, caller); > + area->flags = flags; > + area->caller = caller; > + > + va = alloc_vmap_area(size, align, start, end, node, gfp_mask, 0, area); > if (IS_ERR(va)) { > kfree(area); > return NULL; > -- > 2.41.0 > Reviewed-by: Uladzislau Rezki (Sony) Looks even better :) It can be applied on on top of: [PATCH v8] mm/vmalloc: Eliminated the lock contention from twice to once We are a bit ahead since v8 will be taken later. Anyway please use the reviewed-by tag once you send a complete patch. Thanks! -- Uladzislau Rezki