From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D00F4C5475B for ; Fri, 8 Mar 2024 04:56:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34E0B6B0336; Thu, 7 Mar 2024 23:56:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FE416B0337; Thu, 7 Mar 2024 23:56:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C67B6B0338; Thu, 7 Mar 2024 23:56:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0DA1C6B0336 for ; Thu, 7 Mar 2024 23:56:52 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D7065A0AD2 for ; Fri, 8 Mar 2024 04:56:51 +0000 (UTC) X-FDA: 81872661822.11.612A7C5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 207C840009 for ; Fri, 8 Mar 2024 04:56:49 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="T4CRU/Hk"; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709873810; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FpAzxbK4c61fYlxUcROxFoZVfcD/2ddhJfA1Sk/q7Y8=; b=Nn4DhQyU8IS78dCTsy40ZMqrgTM7Y2eKuUeAQbVIQvG6njDJlus/lqqFZsWi1OFnGoK9Yb 5H80Wx2z8uncvFZdRuO4sF4eNpym9cQ10xbnqXxQq2NE9/o5XA+uuri0OBCUu9hmvY7RGJ HDUcf0Rt0b5zdCDBbt8Tvoj723I2RAQ= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="T4CRU/Hk"; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709873810; a=rsa-sha256; cv=none; b=3dptHH/zFZNfPY4qBQmeKlo1GzB9Sw5UUMOnLktyE9JTXlll12EMxqwHJrgdOLzdOlxf3+ rVsKxaRCcUKG3eek04VDoXwFEVGi8rGLHKiSVG8kN4Gac6l5MTQ3HoB94bcsr5hnNowK8W p3XdSVlKNPL/FWrCNpy4u0lF5IYsX1o= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FpAzxbK4c61fYlxUcROxFoZVfcD/2ddhJfA1Sk/q7Y8=; b=T4CRU/HkppN1YdmOI1o79jRpwo 8lkIaoPUIavYephzeW+DqvejzhfiF5EF43G7i1t+h2z6ka+Lc96wTIyzWCa1CAPous7m/tXQ5J9lq BrjbbugCuMC+/GkVcdo3JQVAKYK1PNFdvf2rEWumSzjWTXa3cS+vY7wQpUok92Jbq2iiEbJSoKg6J UeJL2RBHTm2cPMzZOA+rUA6JqjFN42qIoG//W0xDFuc9pc4pzrpxNsbLEBg43dOwHIS+DPR3WI1wB 6abFKCRW0cO9s63i+/7r9pGbf0ihv/z8l3hnYmhcYFQzbtGGza9hraeK4VitikeroWg3L75ENcxUg 0bqU2JqA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1riSHm-0000000Akts-1dMG; Fri, 08 Mar 2024 04:56:46 +0000 Date: Fri, 8 Mar 2024 04:56:46 +0000 From: Matthew Wilcox To: lipeifeng@oppo.com Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, david@redhat.com, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Minchan Kim Subject: Re: [PATCH v2 0/2] reclaim contended folios asynchronously instead of promoting them Message-ID: References: <20240308031126.750-1-lipeifeng@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240308031126.750-1-lipeifeng@oppo.com> X-Rspamd-Queue-Id: 207C840009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: c5dfwsw4fo7oy5xogu6o5oqcxp9o17f5 X-HE-Tag: 1709873809-164412 X-HE-Meta: U2FsdGVkX1/dZL8uk/BhMVt7JlBvsAgLbnovdSmYynGdLRLUS1OEOOtH8UU+KRy0THbzLMklQZYs1tJ6zGIlaaTTgkPKByJUhsIY+cqJfIXR/R9bZ+a8+J7DixrJ8jYIkfca2v4eMOUHMAkzYDABUTaBZvI1fHs435FqN5tD2YqQKYeiu1eueUI2xMxVSXDubXsbNnHVLXcQ9eQiZpGAe9WEftyWxbihQDoq/H2KkTi8POfTWQHXFYOzFhNN9pOPTi235keFkEcrk0n4iSaLZA+7bVfaXK5Dtf/oVhwe+Yg6ao/FmPzQ4BUc+pARcimvJvdQFfPYmXsYbnuei2IiRQD6oC0rR4puDjcgpdsNzC00SJZNqZPzylsnTpHLZL5WsktjSbEaERNt8CZq9R99dSO5mv250puS8ECZrBhrVy9DgIfvEOA7nGHL+CE57mbWubCTafjzGwWu9ax+yMpE7OzdkwG4lJ7rXLo4SBiunTwkeHzs1m2Nu+XGx0iyTHKi7U/IQwrpcyCPB4XUY2EbYLNORQfGDCIrcGsK+c593mdqEbZIEjPT87+nXq0XwnTOX30uXJzGRexb4MbfzskAKatilW9SLRrcR+IHrmdsxXC/neQKsCDKBJ+S1uQYXPeHKNahfBPK4DSXSmaRMRdYhEndntqfajhgcsa8VdH3eB1KanSDRcHl6rp1xnrLvOVbCBNbnBDZk9OJZPf4ZFX0/FYXuPVK/VmTe18AdsYMR1yKXijB6T5TAiErkxPMAW9YdzNsqo/aZY36ew+EJwMbuLcUVtOfmWDGqXRlpZ6X+0tNu7UHuZFajbZegotityQSmwREsAiZp5xlIbIDlVcB1nwU58rgBQxxeiaXmstowHuqIv3urmJmVVLq/NUmsBFTgzLBfEBQHK2dUtOhYLrohkMCcxR3dDYpl8YLsVwjulQZHvG4kLkb2IDW9lauIDZG6KEtLwj8AQIFjLkzGxz +CI8QGeD LFB35RqpIJQbQbJrNA7gARg3pRUh6gQEcl8k250upiS+Ft61OcEbuH3y0Rez/oUGy2PVrC2/F1cT6YS5ur9EblfVIEA12NLhGXzZaAg+hrc3A6bAWOShsA5qeCvmkKNIN/W3HUtcbSiLt8FWrHSzEY1sKW4MPpkpANFCAYusnXh807EWRi5IX+JEX5qy7VHlgt+Q2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 08, 2024 at 11:11:24AM +0800, lipeifeng@oppo.com wrote: > Commit 6d4675e60135 ("mm: don't be stuck to rmap lock on reclaim path") > prevents the reclaim path from becoming stuck on the rmap lock. However, > it reinserts those folios at the head of the LRU during shrink_folio_list, > even if those folios are very cold. This seems like a lot of new code. Did you consider something simpler like this? Also, this is Minchan's patch you're complaining about. Add him to the cc. +++ b/mm/vmscan.c @@ -817,6 +817,7 @@ enum folio_references { FOLIOREF_RECLAIM, FOLIOREF_RECLAIM_CLEAN, FOLIOREF_KEEP, + FOLIOREF_RESCAN, FOLIOREF_ACTIVATE, }; @@ -837,9 +838,9 @@ static enum folio_references folio_check_references(struct folio *folio, if (vm_flags & VM_LOCKED) return FOLIOREF_ACTIVATE; - /* rmap lock contention: rotate */ + /* rmap lock contention: keep at the tail */ if (referenced_ptes == -1) - return FOLIOREF_KEEP; + return FOLIOREF_RESCAN; if (referenced_ptes) { /* @@ -1164,6 +1165,7 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, case FOLIOREF_ACTIVATE: goto activate_locked; case FOLIOREF_KEEP: + case FOLIOREF_RESCAN: stat->nr_ref_keep += nr_pages; goto keep_locked; case FOLIOREF_RECLAIM: @@ -1446,7 +1448,10 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, keep_locked: folio_unlock(folio); keep: - list_add(&folio->lru, &ret_folios); + if (references == FOLIOREF_RESCAN) + list_add(&folio->lru, &rescan_folios); + else + list_add(&folio->lru, &ret_folios); VM_BUG_ON_FOLIO(folio_test_lru(folio) || folio_test_unevictable(folio), folio); }