From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84BE2C5475B for ; Fri, 8 Mar 2024 04:48:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7EA56B0334; Thu, 7 Mar 2024 23:48:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D2EA76B0335; Thu, 7 Mar 2024 23:48:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1DE26B0336; Thu, 7 Mar 2024 23:48:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B06C86B0334 for ; Thu, 7 Mar 2024 23:48:16 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 86E56C07C9 for ; Fri, 8 Mar 2024 04:48:16 +0000 (UTC) X-FDA: 81872640192.11.E4DE8CB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id A8F4B10000B for ; Fri, 8 Mar 2024 04:48:14 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=APwAU7AK; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709873295; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LxjuFNAUKeIOEL7W0q/ITwUIwiyJ0DZTl11x/jFKSno=; b=ppRlnfYpJlxGKfRZC+5+fFeXgCbG963slQLemSJhIY89vDv963z28531HUkbMHIlnhrzaM 5w0Uyk/7/XWjq2S1Ch1mMdHPpTCK+6XCmVUZJLLYjEv/OkXrlQGtip/HPs+i8DGwrwABJ+ tjQVvyq5bz4g0rmDoatdQbqpDqlDCbI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=APwAU7AK; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709873295; a=rsa-sha256; cv=none; b=69j4hxSSote9F7FDt9mLCjufr31NNQzHsr9vi/mHl6sdbLvN8GugQup3xv5ezABTquumv9 vM7NmPNTBlcCaVKkCJ1zJhD6X4I2FI3jTlOiE9xe87n9fhf9kcu9bE411rJx/MiehsnhlL RVvOs/2RlpO0ZXvHX75Tfq2wu5FRtws= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LxjuFNAUKeIOEL7W0q/ITwUIwiyJ0DZTl11x/jFKSno=; b=APwAU7AKRRqvh6r+7psrPXWkMu ku2AhuGhVtQENwRKOdvLoWEN5nlM6nCi1eJEJJTkPebLFDD5ampvvXRY1JOs90reMJENTsOE3rLbn pyT7bNUQPxq+12vqqzshMaSUME04YQuturdgwimDJ9BZxrV8kGhqElbvzNfIpFQim34nVxvY2FYe1 fTrbiXnQsrufek2iFWtbzvz3KZ0I5ygCVBLsK0sSzJxp3TVBUpNlVzE2uz63QMNxSMeLL1UQ0dmt/ wAr+3Kxm2gXs0tZP12Z+o7nmkBA3a1FozYBDGquHn8XjWv4uTt2pjP0rl5ZJJDMoVxbxsClHs0H23 CUXxT2NQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1riS9T-0000000Ak19-13sR; Fri, 08 Mar 2024 04:48:11 +0000 Date: Fri, 8 Mar 2024 04:48:11 +0000 From: Matthew Wilcox To: Kent Overstreet Cc: linux-mm@kvack.org, Vlastimil Babka , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: Re: [PATCH] mm/slub: Make __ksize() faster Message-ID: References: <20240308031325.218676-1-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240308031325.218676-1-kent.overstreet@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A8F4B10000B X-Stat-Signature: sgtdqk95mdbp79ipkhe19ug67h5911k7 X-HE-Tag: 1709873294-177535 X-HE-Meta: U2FsdGVkX19c0ucAqnAP9nFKR8ps98OLzvVdPCqyBJdwyPwYB/ABjRR04u38EBRb4gONhpz2rR1HgexSgicYwtHHbCDIxTxJ54PnSmy6KiWo13KXA0oUJJd88ERiU6zXUoUIBjKhh+g0N3hEnbUVObBga6aZef8VsX6F2hmOV9e/CSeaUKBksmlBgwQJqr+RNA+RvC3JjNukSDjM3FuohALD0/MsSTUAG7tAadDdCtBxX9CtumxPS9WaZ5fUhBO5hw9Dkhx9pz6eN0rdgJTdT40q1S7r7IBrA9k5tSSfuuaS7xWQUS4MFHTVLsKb4TS0PxLc8v+VvkqoxKU8tlfQhJgrS9tziTwqr1kVRu1k6RPwD6YxujA7Q/bKBFpCYElsGZ0LWTzPjX2TFjM1IkS79t7oTDPTrs1OMKxSULGzdvGp5iu75e0UDQQUOeaX4P8mBKkvtaBy61usg4ROmoBxMNXogLnnUnz2DIMSH+n69p/fTobEoGjAlNkxkWEnzb0OLJOdI8yw1nr+J+XVqrLQrY8BrMRw9CMOkZGRshh1eaFEIVUjsEbQeEijzrZdz1Vo5gGgo/KD9bfoV88HXLGZji/a/MI5uFQdhU9e8dFAw+H2g4wC2vEShDeWGZlpcb8GPUMeoX/+1ifYe79mwOhRCl6/EAsks5qp6rDC6axddWkSPGBV9+lnloLrytnUYnBoleUIsQLgzj7ofIDQlqdMmQrDDXBze8TUJgXQfXNREWsyBAj4svn5GKqPlqxW7eMHoIq4csXKQE0v9f5amzrRi7z1BgjKrxbzBq83RCtSRGHcfCza/e8OASg43++YSNoXVQBjFjn4ZYRVaGqCJyB2Bnm/y9XRB3mLezM/KsxxXGLqVhUtAWTkRF5CTG6Vazq4hSYvQzc5cJhiRkbFkkzluGDpC9gcQnYuJ/s6DV0tlPdmyl5TJegMBVjVk5cmh5XFeh97J1wRwg8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 07, 2024 at 10:13:22PM -0500, Kent Overstreet wrote: > This steals it to make __ksize() faster; it's now a single dependent > load, instead of two. This is going to be important for tracking the > amount of memory stranded by RCU, which we want to be able to do if > we're going to be freeing all pagecache folios (and perhaps all folios) > via RCU. Do you have any measurements? I don't necessarily object, it's just that I would have thought we were already bringing slab->slab_cache into cache as part of the freeing operation.