From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC0AAC5475B for ; Thu, 7 Mar 2024 03:33:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A968D6B00F6; Wed, 6 Mar 2024 22:33:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A46A96B00F7; Wed, 6 Mar 2024 22:33:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E7A76B00F8; Wed, 6 Mar 2024 22:33:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7B9336B00F6 for ; Wed, 6 Mar 2024 22:33:10 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 44051C0B75 for ; Thu, 7 Mar 2024 03:33:10 +0000 (UTC) X-FDA: 81868822140.30.BF95F34 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 71F97C0004 for ; Thu, 7 Mar 2024 03:33:08 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QVs6Jsgh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709782388; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hXNVkaPG+oW3QWS3kpjvLcsLvniwXLJOKpM6BAtv1ao=; b=ryRMjNZe2cfDsmbbUeZ1mIfpw0qkLFngxaIB7kTRuzREOKYkkL68Eg7Dncd9jCDM69wOuK 5+59DM844T/OwjccaZ8AQ3MJQiOF7kndicQAPVcHVSvwLmv9fZa6AqQftxX0enfvMH5bh4 CHM37jF/Z/+qjnVo0Z7zPesPWxLvAlo= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QVs6Jsgh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709782388; a=rsa-sha256; cv=none; b=iUU/lJ6kvxBm+OACWlDka6yAQ5vXMZzgqNzN1SCEi5cdGfe7msz4txrCrwi25f7bOJsMx/ wJuhsO9PZ4iyW2LYy33yIyqLuhr/bJrkkWJgYY1yp/AwSKR2AEi3e0yQI8ZQfewSVPzVSc zMmCTiynyDUDw9MLeKIzOShjvHjcf20= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709782387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hXNVkaPG+oW3QWS3kpjvLcsLvniwXLJOKpM6BAtv1ao=; b=QVs6Jsgh+mnFJUKi8Kty/qdCDcsM8QYlIGkPSBGYDynV/x/dG6YpEGLqH3Pdq45zKj8FVt f+ekJwk/d0TPhOC/AZ1QpGiNpOFYHzYqCfDf52VLR3y9Cv6Bc6/8+kqVstG6IPNAtEqTf0 ysFxn8uBhYTEHFbCJc/ZK2rghGeIsoI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-686-r2unvn5uNdO4XiDR5xnrNw-1; Wed, 06 Mar 2024 22:33:03 -0500 X-MC-Unique: r2unvn5uNdO4XiDR5xnrNw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5DCB0101A523; Thu, 7 Mar 2024 03:33:02 +0000 (UTC) Received: from localhost (unknown [10.72.116.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A51A437F6; Thu, 7 Mar 2024 03:33:01 +0000 (UTC) Date: Thu, 7 Mar 2024 11:32:53 +0800 From: Baoquan He To: "Huang, Rulin" Cc: Uladzislau Rezki , akpm@linux-foundation.org, colin.king@intel.com, hch@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lstoakes@gmail.com, tianyou.li@intel.com, tim.c.chen@intel.com, wangyang.guo@intel.com, zhiguo.zhou@intel.com Subject: Re: [PATCH v7 1/2] mm/vmalloc: Moved macros with no functional change happened Message-ID: References: <20240301155417.1852290-1-rulin.huang@intel.com> <20240301155417.1852290-2-rulin.huang@intel.com> <140860ab-59f2-4633-8a55-fb6cfa854250@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <140860ab-59f2-4633-8a55-fb6cfa854250@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Rspamd-Queue-Id: 71F97C0004 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: m4ugsa43k7uyq1rm5f4ysanzohhqbsxt X-HE-Tag: 1709782388-378950 X-HE-Meta: U2FsdGVkX1/iCH1yUJbUoLyB7OROGHDvXFMOlHhDXrPrThl4Fhi+kcXUDK2CguXhgLdCMTTVgaEyKL0agz0ZLR4Qq3DA6zcsVcuCSJZjaQ3Al04pFT6HCFYGZBk+EHLKBQy93Ig0S6vKcdBUq3DHapPX4CN0ToEW867/BvDwm0T+EwiFh2XWGL0A2tsqEfnTpFm8hoC3JWU39X/LIl+1aUECy/fSl0eUh3FKGcCJuJ8a7oQGy74EaxsFwx2vIK7nvxRoip7Kq5xqb72KHkcFtKOgdwp6EBRkkWA06TbsPbzgsjPby5Lczgpvm3ZmAJ8Ng5VCQMvcfcVowUlGLDsWV2ancrxZM3v723W7OTT+S5ANV7S5SWw/o2N65WHvP5fAKFMPIKtwanyEG4FfN1sCMRTUD1IOW8e+6jAFIfc72PiabWroTo1BK0VPMHqiQZSpUDbZIwhCuWktIxQddVuvNpLReZUr1YFCR3W/JSHdUz7YMttRvqpN64k37JGlBPUln+P961zXFPpUfgDaYVcyO3H9NQyFGHje0sWSn8gr6bh9ioBAeLlffDvRSDh09m/2zL3g1/L/cZGnH+jYxtcijkt5C4uaBpcNEergTAbZamSDw16hsejOGNZ73TkG3dvGTYWJIrR2WcN78flF3R762g8utaQlMfub9NFToSQAgtfuP0Bm2kCUnrUVOGU4e4TTQNWIPHcgaJIv6oFFnjfveCgzLjMbGIaO09B8PZruQIr0WLHVVCGS7N7pR7TjVakaDznANt56Moi5mRcCiqCUXU2NVLz/mdr6qQP76LorhLEeSDonxOw83A7rMNAtuqQ+UW6TFNOv3fFL9JdDWTQgFLC2g3Jjlk3S9CloZAD3m4JNKmRlhj9bHDkYESscYZjcW9VTtFand8BAzIHHYf01iA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/07/24 at 11:01am, Huang, Rulin wrote: > We have made changes based on your latest suggestions. > 1.Removed bugs_on. > 2.Removed adjustion of macros. > > We submitted patch v8 based on this. Thanks to Baoquan for the > discussion, and could you please help to review and confirm if there are > any problems on the latest version? Looks good to me, I don't want to exhaust a newcomer's enthusiasm and patience before you get used to this :-). Will ack, thanks for the awesome work.