From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7509C54E41 for ; Wed, 6 Mar 2024 21:47:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FCB06B0093; Wed, 6 Mar 2024 16:47:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AC8F6B0095; Wed, 6 Mar 2024 16:47:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59BA26B0096; Wed, 6 Mar 2024 16:47:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4A8386B0093 for ; Wed, 6 Mar 2024 16:47:39 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 20C92140F51 for ; Wed, 6 Mar 2024 21:47:39 +0000 (UTC) X-FDA: 81867951438.10.FAB6178 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 796C22001B for ; Wed, 6 Mar 2024 21:47:37 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ulofxWQT; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709761657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jvnV7ivzHuL2TDxoO3oNzjy//Q2uCBE3YzaKocgvIWo=; b=Gcrr5q2U9sc8E7WP0AweIeDc1WjZwtH/Od/FSPjOTXFpC/ueGGKOtfctsWpT9GaNIOi20F LH1Vwwy417lMzU/gpTfsY8NbiAP3x8i/63AlKdmkJrAiS7xrFzZ/GQyiqivfYJcgwZE5vu mJj/4GZTXfwoUrW79Hb3ZVvSD72YxYM= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ulofxWQT; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709761657; a=rsa-sha256; cv=none; b=D3WWnMvxVwhjjY/jiAa7gMPwAS5PTMKFuv6jlvG3BqiSLIYZs3kPn1LxNaYrO4zWe/l5uo JBdglL6NFoFjj3lsdcPGYWCr/qdhIW96YJx+dOXTp5zXhER6fXonrfq44ZnLC3VgHB43NZ X08R0aGuEG/zha14oO9bQnnaXJORnKc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jvnV7ivzHuL2TDxoO3oNzjy//Q2uCBE3YzaKocgvIWo=; b=ulofxWQTkaFdeU0wWp9j8DCtj6 aN2+O8I+vkH+CbR2YohvXXDLPX2uK5NIF0WEkCcJcefP2pjmYhgbj85PwdNiAi40u2AWF1s8oTM1F TGtRAI633VZnWXdoRlqvP6FJv3WhRFf66xr6905XP4NQMiq2T5v0rAx7jhdRaUHqAYbaVrqGoBqFR vX17aIUbxJDknRoIWoxIg7QmpbcKzDdy3bthzWXpcdhiUHbW0s0tIrXpLXTvKMWHMp6+wZTvQfwA+ AIikB5LcBNVV4m1y85tyEvBHozviwqtepdDhNHpcM0ZHJ4bESnKfm38+pHj3VqJ05f0g1iTwbWLBo /cUVdF/A==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhz6t-00000007gE8-1XVg; Wed, 06 Mar 2024 21:47:35 +0000 Date: Wed, 6 Mar 2024 21:47:35 +0000 From: Matthew Wilcox To: Andrew Morton Cc: linux-mm@kvack.org, "Borah, Chaitanya Kumar" Subject: Re: [PATCH] mm: Fix list corruption in put_pages_list Message-ID: References: <20240306212749.1823380-1-willy@infradead.org> <20240306134557.e14fad1abdf7a537e5d287d5@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240306134557.e14fad1abdf7a537e5d287d5@linux-foundation.org> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 796C22001B X-Stat-Signature: 35ksabpzicupdefqp38jc3i14k1wb3kg X-HE-Tag: 1709761657-977942 X-HE-Meta: U2FsdGVkX1+gKASHSMDli8FRycrSWg/CIaw3P1UW4aZbUslIpeX1kH+SPz+hfg1b++FTR5v72a0NYOsUHrqmOV+Yt/gud3rjJtJ2SPXWA4m9NcoTsB+j0uEqWIf7kMTl3B8H8zXEOnflSp0t1NhX9L4RuTEOW1Mn3qAiLOK9JVNDKqbmKXwFG+B73FXc9IvgQyJ0GZmcSYUkC04etDnj57qrQUQYGk8uVK3C9IiatPNT/RYhEyCalUjOvtZg8yCo8YbWyyqcmOaqT9xX5a8WtSCRlWxpNzIjIH2hLODr7zIeJxoIZtpCSYk00WLhOJOPBOHwtgZQKmvPqE0FnXIGDW+BmJ2FdNibLSx5uLCr/pu+WEk/aXNWBaFgv1oS0sLwPxczUD1KTVPYg6kr7GNMKRZrXmmJBdf2WWtVg1tXtSmVZWTwgEXcmNK0ZtQFjaMwnzMJFAjcdC17QyfHi3Q7Qo6KmJrbT4BKbWUKaHeE8B9FNclLWLJbda+kVUDd/xPOWErfILO14UC094Ebv6h+CjqVc5sFfXnUA8GBzOXDUpiB0gD5EhW76nnaN+GUHW4Zos3g1xXOnRlj6iDn3hASL2OwobBAShWVi8eNIfFNJq44ah6pqNsjxv4XdzmarXSSYEWeWpcxONOdl0hcXtKHwRgrF/AteWh2Qm2q/8c292w/XkPAzONXF8qkNZ07Nd/yNxPwWY2zIzgHDycNv1jYqWnKgUkHvgreIciMWhfuY7V89ecfGbtfvVRUrk43iTxfET+tHBgvuahTzI71L+Un2ZaOIhXrAOf24WdzskpkCxFatPagwaOASaBmcp1Dt6L/hD4PvYRzcFOoaOMChp9HavbvKKkViiUln7MA8WnfvlnI5WP289uvB1OKMy0a62uh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 06, 2024 at 01:45:57PM -0800, Andrew Morton wrote: > On Wed, 6 Mar 2024 21:27:30 +0000 "Matthew Wilcox (Oracle)" wrote: > > > My recent change to put_pages_list() dereferences folio->lru.next after > > returning the folio to the page allocator. Usually this is now on the > > pcp list with other free folios, so we try to free an already-free > > folio. This only happens with lists that have more than 15 entries, so > > it wasn't immediately discovered. Revert to using list_for_each_safe() > > so we dereference lru.next before disposing of the folio. > > > > Reported-by: "Borah, Chaitanya Kumar" > > I'm unable to find the bug report on linux-mm. Help please? https://lore.kernel.org/intel-gfx/SJ1PR11MB61292145F3B79DA58ADDDA63B9232@SJ1PR11MB6129.namprd11.prod.outlook.com/ (wasn't cc'd to linux-mm)