From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3043DC5475B for ; Wed, 6 Mar 2024 06:29:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 898DA6B0083; Wed, 6 Mar 2024 01:29:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8481F6B0085; Wed, 6 Mar 2024 01:29:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 737DD6B0088; Wed, 6 Mar 2024 01:29:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 660A76B0083 for ; Wed, 6 Mar 2024 01:29:28 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3A364A135D for ; Wed, 6 Mar 2024 06:29:28 +0000 (UTC) X-FDA: 81865637616.09.5BD762E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id BE8AC100015 for ; Wed, 6 Mar 2024 06:29:26 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MfRhLri6; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709706566; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qyc7uUfABoD9IcjrTXlAmcqLlDUePbIzkZ9Um7DxAU0=; b=wbdEdpilB7fjRtnaLrXcVLsjOylWF+kuKAoRpIHpEaL4Ksa9YH3NV6mo+duyUWHF3m0uI6 3vnHWtcfC1peEPFjir1QpTWn+GyKZzTqiviXab2ykr95t9dwtCklU0/E6k5Jo+i7ZihrQo d1jEG2OAc0p3ZAraSABPJv19GjlcGb0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MfRhLri6; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709706566; a=rsa-sha256; cv=none; b=7nnXOV12N6mj8V/nNlLra5JVaCeQU4I3CJ4C0vu53OdZ/6X79COCULjDBYRHrmYykPwKHW i8SjnCMs9muSAjQPmrqwqfLptGeDDRtWe0Z9n8frBBww14Z+QxHqj7jd1NQV4B/KGTfhLy cRLDLx0KhttkHnLZX28+2waXp2qWrms= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E5F2A61939; Wed, 6 Mar 2024 06:29:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D312C433C7; Wed, 6 Mar 2024 06:29:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709706565; bh=t2prn8NVfSlgCXr/ufwWnITjShOYjafeq9mcR4kzmvg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MfRhLri6MiYJ+a8DZTv59cV8JbopCdO+KDu2/kDALeTLRDcDbQZ5ZzxMVRIcB3XOw XlhEmGG9FfA6RXiMK9HLhrOPMl5cKnjJyKaugvmVK6bGJNJROchNsH6FCmqyya9bfQ 15JjE4TxrrT+5tTqK1PZWtU608MrBxqvqp0UJA1XM6iRTcLwq802/IkeuleIBe4TFn l+PmZrxvAxpr/z/RDBNSS2VYyrl4WK5hjLt2TTB7qpA4mx58o3Dqj5qV3eAi9w+ABv V2ABDFP8hCc6yI7H4X0n05yHnyO0tBKRobIdXY7hDbwwKsxl8dAUxu/nkXoi9umx1q w76VXD6hrSSfg== Date: Wed, 6 Mar 2024 08:28:30 +0200 From: Mike Rapoport To: peterx@redhat.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christophe Leroy , x86@kernel.org, "Kirill A . Shutemov" , Jason Gunthorpe , Yang Shi , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Muchun Song , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com Subject: Re: [PATCH v3 06/10] mm/kasan: Use pXd_leaf() in shadow_mapped() Message-ID: References: <20240305043750.93762-1-peterx@redhat.com> <20240305043750.93762-7-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240305043750.93762-7-peterx@redhat.com> X-Rspamd-Queue-Id: BE8AC100015 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: rmhyx5u4dzwjr559kp7i8ifhsgw41zt5 X-HE-Tag: 1709706566-231847 X-HE-Meta: U2FsdGVkX1+2KNBBjVmSqv1pzvS+0PYP1fJ5skZapYEyK5R736KcOinHLk/84e03eMwGulo22G7rZuCLdCO7PqY1nbrZkN18Xp1jxMRL9UonYcPmoQz5phtxlkGE1H2R3Kb5kLkq+KNUaLahxKxPPIDQqtzcmWuh+d8vWi43B5LbyC5A2mD3nqqsqLUhLxZk7tFwAWlQzRWP/eTuBbt972CN2KX9OT69B2quc9U8rCZza8G9oiWHYkSRrJCMejxqaqF3ydqkZ93ZOLWLOJ16HnKKL9JHZqaUKjFC7Bd8gj3pj4Ec7fYOOjxTm5XYZ+LdqFJ/Uxg3KGrCrNqWh1DEtfDmRw23NGl7GydlcjLNj5XnpL1XtRJFZBOsr91+f2j5Xro0cxYW7FskiJ6sd2AuXRE/Cify+3cg2YRPBlpK5fvt7rYODvAS6DiGbL6ExlHoE3j8OP2/3/705PwMw4jq95s9HQdI5lh4Rr/HK4bz/0X50soazFkhe2aMUdsV4TFRkRE07EWvNsfpL4116Sg/BMgYVHJVEpiM5Ntr7uc8yUiTEBQk9Ni4h5WIjdB1MGaQLPhZQDPThQfF1sKNLRiU5z/2ow1S3nrdByxgbtPpSKLa6374WHZfBQCHv+mY9M9w7X9/akUwbQzKjYn+uLMgq7C6XH4AizjVtpdsZSnlYn73oAGFkprS2LjLqLYM8M94efy1SLoeI8foW0TljnN7+aj+QgSnXo+YzCr2mR57xos9pnDeo9QXxhYAUmLUSs/+dLavbtZhv/1xH2kZOt6K33qTfgPGmUApGKhxbn2T1mA6uDdPJB2HmVAqIb/cA/KOHOpTk3KthR2H3UWbe8E1oze9wZO+NXAgtAJfwiqUPtT7tIcnn/9P6HC5lycB3DQUck7MgThoFnHOs/MftVRx5+3KEzXWptlnn1LnKTonM1Mj7xiM92+hBPcu2i2o5qSIP83bfonrzYv56YkkmfF BeFH2BBd QvlaGl/HcIw0PEUQ8DMMcPwgwEBZC7eIUP29M X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 05, 2024 at 12:37:46PM +0800, peterx@redhat.com wrote: > From: Peter Xu > > There is an old trick in shadow_mapped() to use pXd_bad() to detect huge > pages. After commit 93fab1b22ef7 ("mm: add generic p?d_leaf() macros") we > have a global API for huge mappings. Use that to replace the trick. > > Cc: Andrey Ryabinin > Cc: Alexander Potapenko > Cc: Andrey Konovalov > Cc: Dmitry Vyukov > Cc: Vincenzo Frascino > Cc: kasan-dev@googlegroups.com > Signed-off-by: Peter Xu Reviewed-by: Mike Rapoport (IBM) > --- > mm/kasan/shadow.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c > index 9ef84f31833f..d6210ca48dda 100644 > --- a/mm/kasan/shadow.c > +++ b/mm/kasan/shadow.c > @@ -199,19 +199,12 @@ static bool shadow_mapped(unsigned long addr) > pud = pud_offset(p4d, addr); > if (pud_none(*pud)) > return false; > - > - /* > - * We can't use pud_large() or pud_huge(), the first one is > - * arch-specific, the last one depends on HUGETLB_PAGE. So let's abuse > - * pud_bad(), if pud is bad then it's bad because it's huge. > - */ > - if (pud_bad(*pud)) > + if (pud_leaf(*pud)) > return true; > pmd = pmd_offset(pud, addr); > if (pmd_none(*pmd)) > return false; > - > - if (pmd_bad(*pmd)) > + if (pmd_leaf(*pmd)) > return true; > pte = pte_offset_kernel(pmd, addr); > return !pte_none(ptep_get(pte)); > -- > 2.44.0 > > -- Sincerely yours, Mike.