From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E85F9C5475B for ; Wed, 6 Mar 2024 06:21:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35F356B0074; Wed, 6 Mar 2024 01:21:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3111B6B007E; Wed, 6 Mar 2024 01:21:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D6C26B0080; Wed, 6 Mar 2024 01:21:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0B90A6B0074 for ; Wed, 6 Mar 2024 01:21:12 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 890B3A02BE for ; Wed, 6 Mar 2024 06:21:11 +0000 (UTC) X-FDA: 81865616742.24.E859857 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf11.hostedemail.com (Postfix) with ESMTP id 35D5E4001A for ; Wed, 6 Mar 2024 06:21:08 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AATwXqWj; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709706069; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0IbIZM1wJ1TFNyjTNUClDPxuOd0mBcvmECiySaXjJUA=; b=SnsptcvrjjFI72WEjfcOBuYwP0vNE88Jpajd+UACs4ECFOeoe3JA0bgXQN/RF6MGPK/zB0 WrKcT2CbbU8nPUwwktJfeFBQD3LB9usrMjxLcPl796g+RFB0G/p9z9AYkvdJYixp4r+L9Q nz0CNS0U449oM9TnrxUMzMMWr1zARV4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AATwXqWj; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709706069; a=rsa-sha256; cv=none; b=R9KgtekSbz4pey70+bKrDh2ciDt9tAvez7b/p1yE/jjLWXgEshtqnnf/WMbJWGy91Gr/8j 53i4k+L4KydZKCOlNuDhnfnBmLlywSsnk2PrZbe6I0NONqOLL7oWJVCUZcahNMXIHw2CAA XgZku4fTPunBavug9obo/9Kkb3vPBik= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4732CCE20A4; Wed, 6 Mar 2024 06:21:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD50DC433C7; Wed, 6 Mar 2024 06:21:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709706065; bh=JwLG1O9cTgT6rkMYgbnDYqcO11kWTExWKYTlhvhWHJg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AATwXqWjQfueEDfBMEZ5dhrm03fz5RHLyzkdJGraEOK7KDttG/SS43Bid5GYATyIF DFMzYHL4cyn4geHVTtCg0pA+p/+0OrWjPJTcmwQNqP2wWzcPSZNU5DWQHAL1U/t4La TvGEgiZDmaHCrZZDADKhIgusABdfrqms3jNXJrtIwFrkPWv5k0GoGkwnhVn7t8augu +d0WdJBf+Fd+9L0kTfkzD+2yi1heH2pGlnsBk/vlQyRb3Obq5ckrKv9yMGjlxlIqIr WYaQXfuCtkenVS7ve+wf0kfgpkjt95MmhLYUhBpokX9Pc3pJAytnyPfbRdrHTY7x+7 aK0aeUuEn0z4Q== Date: Wed, 6 Mar 2024 08:20:11 +0200 From: Mike Rapoport To: peterx@redhat.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christophe Leroy , x86@kernel.org, "Kirill A . Shutemov" , Jason Gunthorpe , Yang Shi , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Muchun Song , Michael Ellerman , Nicholas Piggin , "Aneesh Kumar K.V" , "Naveen N. Rao" Subject: Re: [PATCH v3 02/10] mm/ppc: Replace pXd_is_leaf() with pXd_leaf() Message-ID: References: <20240305043750.93762-1-peterx@redhat.com> <20240305043750.93762-3-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240305043750.93762-3-peterx@redhat.com> X-Rspam-User: X-Stat-Signature: 89xtb6yo9159mahq85d9w1m3wb3towhg X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 35D5E4001A X-HE-Tag: 1709706068-900700 X-HE-Meta: U2FsdGVkX1/4lxxGHqUr6gi+0PqLDZ3yRq4A/es6fNE+uH+9pPVpwatv2O5V2a1nCXbcKsSIamjGmu6SIANZBflWGYutuYZYRy5wCEomFZsyYZoTUMmevehNHUH0Ow9dddm3oMkm88BMF50WnWAinPkRoxOcZhzjbjUp9Mlj9IIAEVNLCRzgbbCHt1woW3YhtaeSW/ArEtFNfAXBiu8xbHt+TZLwuxb+ZBvKMEE4ai/EL5G7Ob3M5lus0t3rQTnuG+8T8nSzayVyBIfF3oyQmvRvdHY7T86igytl8vRpEClv14mVUXPm4pP3gNhkjXCd82Q4HzqegEgn1zKBSDgIFYLxq+BhkuaZd4rzR9CMsWOhw49xKE4iBt8saJ/OYqEKenLlSTpfxMvW2DJu/vUTdj2U/EDg0fr3RTGjR/Uj6ODHGHTMrHBfrcELYDGUYcu9lafMB3hKYT63xb1Yuynlvf7RGlGP14FXR/ZGR3QwuXLEoxhq49M9Xe5Zg2PbFSuzGecGsLvZ136p1fCwYiTJNeTI8vR/txqmhlqnI7p6kHVnI8QPh82OCj5b0go92JoBDXayVLikaEJJLaIDvP2jB7wJ4IDvoKK2CmBbOXpvH8XsfdojaU4Mn9hB5arzImFKP1biLy/s6/28UD76SRQM0UJc/rRJtWqldl3v5Cq4O0VBLQke47ZC8eMyXqZdmcH9gZ9gXptIpqEsYnqDoW2NXHErzSRGAuzyefHCx+rFoErqQSHMqdk2CIfu88FPc8QEUC9vI5nxSSBDthSn40mYk1NMAnLYkv7oEVMXgEHfsnFGQCLLzmQ3L6NCuDJPE/CK8a+FVvGCTG94qOPPW2Os/8cnAKRq9sZbKdAlfPvCoKGqEFUh7Qn6AquGPLoqJR9X4zH9aJukTdWKQk6AFR0aM2ay/eBML5FmgRuMIaIXHIAATLouUsIx843AgTG+YX0FjDUYU9WQQohPAY8mcXt aACUqMDz 5SSzWJSfjOtQaLY5QMcupYSNji4F5e9Lrn60QUvx3MVuD0jXGGjBGWcGoO0Gq3VtPAwiTNiGrhVmnNXp/IpSmh0mEBIcNzw3OupRxKHpEdu7oBMxVAmFJRyDzzhbcQw/6gjUt04oPxo4fhcbWrKjrboYzNpmfhapFNzIrJ4Zcy8dOCYoOlGcV7ZgvIcPyygpJMhh8TiPgBYjFuOsUki7PUHnnQonP1WFq/IaFaI4uC66gcW7C9J9ZGaa5UbHz2qhYlSYJMymGp9BW3KkqZg6CwQgKWwG1BobVGgvtRxZEu46G38T1A3dEWWvlm4tkbY9dVOKJgQ4jk6B6nGJFX9sQvAZ6iIzkIEonHFjE1hBFZWbmOoMgdBTlEpVHrwzBdiMbVT+Y9zYLntUEJnzF51/HoouEpO+A1PDEc3uQJX4Miwhi9uoFye2p45zQwG/deY9y/7Qg5j0508D9sdM1jkrRWEVC5HZBkwrcgEqfS1lrQdxBaqPkUGsa93ZklkNTJBUBYmab X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 05, 2024 at 12:37:42PM +0800, peterx@redhat.com wrote: > From: Peter Xu > > They're the same macros underneath. Drop pXd_is_leaf(), instead always use > pXd_leaf(). > > At the meantime, instead of renames, drop the pXd_is_leaf() fallback > definitions directly in arch/powerpc/include/asm/pgtable.h. because similar > fallback macros for pXd_leaf() are already defined in > include/linux/pgtable.h. > > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc: "Aneesh Kumar K.V" > Cc: "Naveen N. Rao" > Cc: linuxppc-dev@lists.ozlabs.org > Suggested-by: Christophe Leroy > Reviewed-by: Jason Gunthorpe > Signed-off-by: Peter Xu Reviewed-by: Mike Rapoport (IBM) > --- > arch/powerpc/include/asm/book3s/64/pgtable.h | 10 ++++---- > arch/powerpc/include/asm/pgtable.h | 24 -------------------- > arch/powerpc/kvm/book3s_64_mmu_radix.c | 12 +++++----- > arch/powerpc/mm/book3s64/radix_pgtable.c | 14 ++++++------ > arch/powerpc/mm/pgtable.c | 6 ++--- > arch/powerpc/mm/pgtable_64.c | 6 ++--- > arch/powerpc/xmon/xmon.c | 6 ++--- > 7 files changed, 26 insertions(+), 52 deletions(-) > > diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch/powerpc/include/asm/book3s/64/pgtable.h > index d1318e8582ac..3e99e409774a 100644 > --- a/arch/powerpc/include/asm/book3s/64/pgtable.h > +++ b/arch/powerpc/include/asm/book3s/64/pgtable.h > @@ -1439,18 +1439,16 @@ static inline bool is_pte_rw_upgrade(unsigned long old_val, unsigned long new_va > /* > * Like pmd_huge() and pmd_large(), but works regardless of config options > */ > -#define pmd_is_leaf pmd_is_leaf > -#define pmd_leaf pmd_is_leaf > +#define pmd_leaf pmd_leaf > #define pmd_large pmd_leaf > -static inline bool pmd_is_leaf(pmd_t pmd) > +static inline bool pmd_leaf(pmd_t pmd) > { > return !!(pmd_raw(pmd) & cpu_to_be64(_PAGE_PTE)); > } > > -#define pud_is_leaf pud_is_leaf > -#define pud_leaf pud_is_leaf > +#define pud_leaf pud_leaf > #define pud_large pud_leaf > -static inline bool pud_is_leaf(pud_t pud) > +static inline bool pud_leaf(pud_t pud) > { > return !!(pud_raw(pud) & cpu_to_be64(_PAGE_PTE)); > } > diff --git a/arch/powerpc/include/asm/pgtable.h b/arch/powerpc/include/asm/pgtable.h > index 5928b3c1458d..e6edf1cdbc5b 100644 > --- a/arch/powerpc/include/asm/pgtable.h > +++ b/arch/powerpc/include/asm/pgtable.h > @@ -182,30 +182,6 @@ static inline void pte_frag_set(mm_context_t *ctx, void *p) > } > #endif > > -#ifndef pmd_is_leaf > -#define pmd_is_leaf pmd_is_leaf > -static inline bool pmd_is_leaf(pmd_t pmd) > -{ > - return false; > -} > -#endif > - > -#ifndef pud_is_leaf > -#define pud_is_leaf pud_is_leaf > -static inline bool pud_is_leaf(pud_t pud) > -{ > - return false; > -} > -#endif > - > -#ifndef p4d_is_leaf > -#define p4d_is_leaf p4d_is_leaf > -static inline bool p4d_is_leaf(p4d_t p4d) > -{ > - return false; > -} > -#endif > - > #define pmd_pgtable pmd_pgtable > static inline pgtable_t pmd_pgtable(pmd_t pmd) > { > diff --git a/arch/powerpc/kvm/book3s_64_mmu_radix.c b/arch/powerpc/kvm/book3s_64_mmu_radix.c > index 4a1abb9f7c05..408d98f8a514 100644 > --- a/arch/powerpc/kvm/book3s_64_mmu_radix.c > +++ b/arch/powerpc/kvm/book3s_64_mmu_radix.c > @@ -503,7 +503,7 @@ static void kvmppc_unmap_free_pmd(struct kvm *kvm, pmd_t *pmd, bool full, > for (im = 0; im < PTRS_PER_PMD; ++im, ++p) { > if (!pmd_present(*p)) > continue; > - if (pmd_is_leaf(*p)) { > + if (pmd_leaf(*p)) { > if (full) { > pmd_clear(p); > } else { > @@ -532,7 +532,7 @@ static void kvmppc_unmap_free_pud(struct kvm *kvm, pud_t *pud, > for (iu = 0; iu < PTRS_PER_PUD; ++iu, ++p) { > if (!pud_present(*p)) > continue; > - if (pud_is_leaf(*p)) { > + if (pud_leaf(*p)) { > pud_clear(p); > } else { > pmd_t *pmd; > @@ -635,12 +635,12 @@ int kvmppc_create_pte(struct kvm *kvm, pgd_t *pgtable, pte_t pte, > new_pud = pud_alloc_one(kvm->mm, gpa); > > pmd = NULL; > - if (pud && pud_present(*pud) && !pud_is_leaf(*pud)) > + if (pud && pud_present(*pud) && !pud_leaf(*pud)) > pmd = pmd_offset(pud, gpa); > else if (level <= 1) > new_pmd = kvmppc_pmd_alloc(); > > - if (level == 0 && !(pmd && pmd_present(*pmd) && !pmd_is_leaf(*pmd))) > + if (level == 0 && !(pmd && pmd_present(*pmd) && !pmd_leaf(*pmd))) > new_ptep = kvmppc_pte_alloc(); > > /* Check if we might have been invalidated; let the guest retry if so */ > @@ -658,7 +658,7 @@ int kvmppc_create_pte(struct kvm *kvm, pgd_t *pgtable, pte_t pte, > new_pud = NULL; > } > pud = pud_offset(p4d, gpa); > - if (pud_is_leaf(*pud)) { > + if (pud_leaf(*pud)) { > unsigned long hgpa = gpa & PUD_MASK; > > /* Check if we raced and someone else has set the same thing */ > @@ -709,7 +709,7 @@ int kvmppc_create_pte(struct kvm *kvm, pgd_t *pgtable, pte_t pte, > new_pmd = NULL; > } > pmd = pmd_offset(pud, gpa); > - if (pmd_is_leaf(*pmd)) { > + if (pmd_leaf(*pmd)) { > unsigned long lgpa = gpa & PMD_MASK; > > /* Check if we raced and someone else has set the same thing */ > diff --git a/arch/powerpc/mm/book3s64/radix_pgtable.c b/arch/powerpc/mm/book3s64/radix_pgtable.c > index c6a4ac766b2b..1f8db10693e3 100644 > --- a/arch/powerpc/mm/book3s64/radix_pgtable.c > +++ b/arch/powerpc/mm/book3s64/radix_pgtable.c > @@ -204,14 +204,14 @@ static void radix__change_memory_range(unsigned long start, unsigned long end, > pudp = pud_alloc(&init_mm, p4dp, idx); > if (!pudp) > continue; > - if (pud_is_leaf(*pudp)) { > + if (pud_leaf(*pudp)) { > ptep = (pte_t *)pudp; > goto update_the_pte; > } > pmdp = pmd_alloc(&init_mm, pudp, idx); > if (!pmdp) > continue; > - if (pmd_is_leaf(*pmdp)) { > + if (pmd_leaf(*pmdp)) { > ptep = pmdp_ptep(pmdp); > goto update_the_pte; > } > @@ -767,7 +767,7 @@ static void __meminit remove_pmd_table(pmd_t *pmd_start, unsigned long addr, > if (!pmd_present(*pmd)) > continue; > > - if (pmd_is_leaf(*pmd)) { > + if (pmd_leaf(*pmd)) { > if (IS_ALIGNED(addr, PMD_SIZE) && > IS_ALIGNED(next, PMD_SIZE)) { > if (!direct) > @@ -807,7 +807,7 @@ static void __meminit remove_pud_table(pud_t *pud_start, unsigned long addr, > if (!pud_present(*pud)) > continue; > > - if (pud_is_leaf(*pud)) { > + if (pud_leaf(*pud)) { > if (!IS_ALIGNED(addr, PUD_SIZE) || > !IS_ALIGNED(next, PUD_SIZE)) { > WARN_ONCE(1, "%s: unaligned range\n", __func__); > @@ -845,7 +845,7 @@ remove_pagetable(unsigned long start, unsigned long end, bool direct, > if (!p4d_present(*p4d)) > continue; > > - if (p4d_is_leaf(*p4d)) { > + if (p4d_leaf(*p4d)) { > if (!IS_ALIGNED(addr, P4D_SIZE) || > !IS_ALIGNED(next, P4D_SIZE)) { > WARN_ONCE(1, "%s: unaligned range\n", __func__); > @@ -1554,7 +1554,7 @@ int pud_set_huge(pud_t *pud, phys_addr_t addr, pgprot_t prot) > > int pud_clear_huge(pud_t *pud) > { > - if (pud_is_leaf(*pud)) { > + if (pud_leaf(*pud)) { > pud_clear(pud); > return 1; > } > @@ -1601,7 +1601,7 @@ int pmd_set_huge(pmd_t *pmd, phys_addr_t addr, pgprot_t prot) > > int pmd_clear_huge(pmd_t *pmd) > { > - if (pmd_is_leaf(*pmd)) { > + if (pmd_leaf(*pmd)) { > pmd_clear(pmd); > return 1; > } > diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c > index 549a440ed7f6..9e7ba9c3851f 100644 > --- a/arch/powerpc/mm/pgtable.c > +++ b/arch/powerpc/mm/pgtable.c > @@ -410,7 +410,7 @@ pte_t *__find_linux_pte(pgd_t *pgdir, unsigned long ea, > if (p4d_none(p4d)) > return NULL; > > - if (p4d_is_leaf(p4d)) { > + if (p4d_leaf(p4d)) { > ret_pte = (pte_t *)p4dp; > goto out; > } > @@ -432,7 +432,7 @@ pte_t *__find_linux_pte(pgd_t *pgdir, unsigned long ea, > if (pud_none(pud)) > return NULL; > > - if (pud_is_leaf(pud)) { > + if (pud_leaf(pud)) { > ret_pte = (pte_t *)pudp; > goto out; > } > @@ -471,7 +471,7 @@ pte_t *__find_linux_pte(pgd_t *pgdir, unsigned long ea, > goto out; > } > > - if (pmd_is_leaf(pmd)) { > + if (pmd_leaf(pmd)) { > ret_pte = (pte_t *)pmdp; > goto out; > } > diff --git a/arch/powerpc/mm/pgtable_64.c b/arch/powerpc/mm/pgtable_64.c > index 1b366526f4f2..386c6b06eab7 100644 > --- a/arch/powerpc/mm/pgtable_64.c > +++ b/arch/powerpc/mm/pgtable_64.c > @@ -100,7 +100,7 @@ EXPORT_SYMBOL(__pte_frag_size_shift); > /* 4 level page table */ > struct page *p4d_page(p4d_t p4d) > { > - if (p4d_is_leaf(p4d)) { > + if (p4d_leaf(p4d)) { > if (!IS_ENABLED(CONFIG_HAVE_ARCH_HUGE_VMAP)) > VM_WARN_ON(!p4d_huge(p4d)); > return pte_page(p4d_pte(p4d)); > @@ -111,7 +111,7 @@ struct page *p4d_page(p4d_t p4d) > > struct page *pud_page(pud_t pud) > { > - if (pud_is_leaf(pud)) { > + if (pud_leaf(pud)) { > if (!IS_ENABLED(CONFIG_HAVE_ARCH_HUGE_VMAP)) > VM_WARN_ON(!pud_huge(pud)); > return pte_page(pud_pte(pud)); > @@ -125,7 +125,7 @@ struct page *pud_page(pud_t pud) > */ > struct page *pmd_page(pmd_t pmd) > { > - if (pmd_is_leaf(pmd)) { > + if (pmd_leaf(pmd)) { > /* > * vmalloc_to_page may be called on any vmap address (not only > * vmalloc), and it uses pmd_page() etc., when huge vmap is > diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c > index b3b94cd37713..9669c9925225 100644 > --- a/arch/powerpc/xmon/xmon.c > +++ b/arch/powerpc/xmon/xmon.c > @@ -3342,7 +3342,7 @@ static void show_pte(unsigned long addr) > return; > } > > - if (p4d_is_leaf(*p4dp)) { > + if (p4d_leaf(*p4dp)) { > format_pte(p4dp, p4d_val(*p4dp)); > return; > } > @@ -3356,7 +3356,7 @@ static void show_pte(unsigned long addr) > return; > } > > - if (pud_is_leaf(*pudp)) { > + if (pud_leaf(*pudp)) { > format_pte(pudp, pud_val(*pudp)); > return; > } > @@ -3370,7 +3370,7 @@ static void show_pte(unsigned long addr) > return; > } > > - if (pmd_is_leaf(*pmdp)) { > + if (pmd_leaf(*pmdp)) { > format_pte(pmdp, pmd_val(*pmdp)); > return; > } > -- > 2.44.0 > > -- Sincerely yours, Mike.