From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 087EFC5475B for ; Wed, 6 Mar 2024 06:24:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97E2A6B0074; Wed, 6 Mar 2024 01:24:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 92DF86B007D; Wed, 6 Mar 2024 01:24:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81CF56B0081; Wed, 6 Mar 2024 01:24:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7344E6B0074 for ; Wed, 6 Mar 2024 01:24:47 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1AE3440453 for ; Wed, 6 Mar 2024 06:24:47 +0000 (UTC) X-FDA: 81865625814.26.A053479 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 9D9391C000A for ; Wed, 6 Mar 2024 06:24:45 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PJzwl3aD; spf=pass (imf20.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709706285; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=05fUSKrvP06RDmLuxO73Q2iXg9TpqdAfg7sRsYw/8Ig=; b=x9snhCO5G4ZkYHTnOaVIQahcDPIHywdKZzcFHWOTVNLeLDWxiRf2JvQk2qPW6otRYq4627 8Jn6PUg4PY98TzdU60jqiXWdv4cmmL21oIPjazW1bkYyFNU7BEVT64Z+9YiqIlnrPfN8Ah y2lSOJ6CmDuHQR72P2wDzz2Q8DSPrcI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PJzwl3aD; spf=pass (imf20.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709706285; a=rsa-sha256; cv=none; b=W/rEGbGDPyXcK/WboReN7uu9HZhSTrCdqyXpQSeB+hqyGsQqF8TULQpv8WfuqEncTttXei LWWnbtvGEfQCkDA+v+06Ik59l6sSb0TnzKgQPX5AVgT5dwjM/xSqgakbLD8Ej1G2nq/aMG g5gmSydZIzUsfp86XaBvxm8zzDkwpLw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BC5616170B; Wed, 6 Mar 2024 06:24:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90084C433F1; Wed, 6 Mar 2024 06:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709706284; bh=Ul9xyIM/xyWLYImXlcZ+ekHRz3h/sTxONmN5nrLAWX0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PJzwl3aDmw2R/PvwbEBvPZ3u+NLY0fqRSSGQgKs2InVezXhX/9DQWsIrHIhu6BbPu lgBAiYFIW15YCX3uOOubXQRSCklHU0tR1/Wnu1iyHq5KnLswQs0CahMqIfxtbisXtq o+T42dG+q7+R2aeWH0os80Ht3TAr1gN7h+7a4H9djzp65CmezNaMO/BHAz0PwmAW7E 7n/IBVf10MWU7PGd5fTqa+TdvYH8Xr+kr8N8PPUfHnmMCXFCxS3kLQE06IWLreXIeE z2km+RVZaY98fb9Wc0TVXUnk09iQW67QBULk7oHkE0cuQRikKMqfSIuqO8YrFtBMGh NjwIRRPzm4buw== Date: Wed, 6 Mar 2024 08:23:50 +0200 From: Mike Rapoport To: peterx@redhat.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christophe Leroy , x86@kernel.org, "Kirill A . Shutemov" , Jason Gunthorpe , Yang Shi , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Muchun Song , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Subject: Re: [PATCH v3 04/10] mm/x86: Replace pgd_large() with pgd_leaf() Message-ID: References: <20240305043750.93762-1-peterx@redhat.com> <20240305043750.93762-5-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240305043750.93762-5-peterx@redhat.com> X-Rspamd-Queue-Id: 9D9391C000A X-Rspam-User: X-Stat-Signature: 5ckt9q43ewhbpbimwt8u1n557sud159g X-Rspamd-Server: rspam01 X-HE-Tag: 1709706285-467512 X-HE-Meta: U2FsdGVkX1/5Zvw7oTI0HL+JG4GaR0DIEkqnP9NNfTJuwtj0NCB9gsHncAV0Gs6Fi2ypvLrZ3R0JH1KJ3verRqr8Op2vJ/86MAgBqCHIOxtLQveJdbmwDN7xVn4SbE5iTvGQMcXz9AMYa7Bo/4F0KX7Q4tYunKy6WbzgMObnVuYms3ylcPxiAN60dCJGs7K/USmHmQrgMM4MOmTS7Yg/Dkk9tcLx7tuc4bZmcofoCg7a0ve2JbL7oFMdvEBaRNupb6+pILqQDF1vumiDqd7yn7TrY7dxQ1sW293cszADXPVbV/rNv3jdmXQYY7IugD6NtBgmnFJNqcuD8RJFPmz9NLLH5fvHKhoLNgHQ2XwFuj9L4rW0m48zezp4alhLXcJ5Ca7IVbzJu9792yEd8ahgFFeMJfU6yhYplYUaksXEr5s3Nsj1u9P8a4Akq9rL3vZql9uNzh326cf/aWxkgizmSyPq7vCzGcEYUy5Ch/dyBUW3ltlmQ2ZtWPDPxhFh2Y6zfHpwnF23PPsWyvVIarxx2F57REuAtU992pbCnOF1Es8+arjWUMrJVCN9cYeZINsegXLycGkGIwzuMeFsIN9Tj1Ed7AMRgMLlQoT+1pWpxJOq58gzksFHUYVO5nYNRPcwTBdXyJrgTu/YRjAyj3+s7M/bWKqCJL/Hey4u6TvFpHo5PdVVJegMYfqSkJdUxd6y5+WLzfu3UtMHgupo0ptNd2ZQ5vU92NjdEZbxVf0+wMidWlykPVenzlcRBTsmKr2LZAyJRh3lWqg3UuDqIBEaOe8Q5yiyQckoJqS1MvRBDpCClUjz5EiTahuFMvy7hNpqrWWmRTdSBnuzhDRarV/+DZiG5+tjoQz10U7c8mnirGmefq75KnpcCskvUJwgpQzbIQkCPwlGYfLni4AZBxJLFbO5OfMUNsH5SLIcrtO0E3mynPbgLfn7cOp1L1ijr2CK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 05, 2024 at 12:37:44PM +0800, peterx@redhat.com wrote: > From: Peter Xu > > pgd_leaf() is a global API while pgd_large() is not. Always use > the global pgd_leaf(), then drop pgd_large(). > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x86@kernel.org > Signed-off-by: Peter Xu Reviewed-by: Mike Rapoport (IBM) > --- > arch/x86/include/asm/pgtable.h | 4 ++-- > arch/x86/mm/pti.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > index 69ed0ea0641b..d6e993a5659f 100644 > --- a/arch/x86/include/asm/pgtable.h > +++ b/arch/x86/include/asm/pgtable.h > @@ -1418,8 +1418,8 @@ static inline bool pgdp_maps_userspace(void *__ptr) > return (((ptr & ~PAGE_MASK) / sizeof(pgd_t)) < PGD_KERNEL_START); > } > > -#define pgd_leaf pgd_large > -static inline int pgd_large(pgd_t pgd) { return 0; } > +#define pgd_leaf pgd_leaf > +static inline int pgd_leaf(pgd_t pgd) { return 0; } > > #ifdef CONFIG_PAGE_TABLE_ISOLATION > /* > diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c > index dc0a81f5f60e..c17aab24c1b3 100644 > --- a/arch/x86/mm/pti.c > +++ b/arch/x86/mm/pti.c > @@ -185,7 +185,7 @@ static p4d_t *pti_user_pagetable_walk_p4d(unsigned long address) > > set_pgd(pgd, __pgd(_KERNPG_TABLE | __pa(new_p4d_page))); > } > - BUILD_BUG_ON(pgd_large(*pgd) != 0); > + BUILD_BUG_ON(pgd_leaf(*pgd) != 0); > > return p4d_offset(pgd, address); > } > -- > 2.44.0 > > -- Sincerely yours, Mike.