From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3BB6C54798 for ; Wed, 6 Mar 2024 02:19:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D51D76B0075; Tue, 5 Mar 2024 21:19:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D01EC6B007D; Tue, 5 Mar 2024 21:19:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B54456B007E; Tue, 5 Mar 2024 21:19:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A66516B0075 for ; Tue, 5 Mar 2024 21:19:00 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8141AC02FB for ; Wed, 6 Mar 2024 02:19:00 +0000 (UTC) X-FDA: 81865006440.13.3C1477E Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by imf19.hostedemail.com (Postfix) with ESMTP id 403A61A0013 for ; Wed, 6 Mar 2024 02:18:56 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=XkYHRoXB; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf19.hostedemail.com: domain of yan.y.zhao@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=yan.y.zhao@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709691537; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SP5VWbVyFNZ8iTKEziTWUXCvnkjh6bqeIPUgMDqzCmg=; b=dNdzh5z+agC4JQRTnBOutxqLHZJQJ+Y12jfBXMI91Hu7xz1eCIE/qIb/tX5Q4DDsV2IOhA 3H4R7iiq+dbOoxxTl34Dc/7U5T2AY2u0EKvZbiDW7PFWzyWwlBHVgl0fmhCyl/8hqlvVbX 4JNGLU9Mn4q8VuGsGpv6uXKAbYGySYY= ARC-Authentication-Results: i=2; imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=XkYHRoXB; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf19.hostedemail.com: domain of yan.y.zhao@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=yan.y.zhao@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1709691537; a=rsa-sha256; cv=fail; b=tbQC0H/TbtynSD/s9M+TM7NhwpkXpmALbqt31NeYxYAci2tE0YpTy2ViGjDGGrG0PiwH9n OOyOgOxqznaHSv8bNe7IBkzdltGZOtBJ472wIxkRVKhjBaHmo3qBAPMAERQamdorLiHDKM qqR+CVvBzkAP13CCZK0TP7n17H9H9HM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709691537; x=1741227537; h=date:from:to:cc:subject:message-id:reply-to:references: in-reply-to:mime-version; bh=FU/QqbWavtxhiowV49K10UC40h3nDdFk4SU990kGbVg=; b=XkYHRoXB7WaW0Gvj708135hN05toxy+eMUPRdMlO3c/biHVnR1Err05O z1j0ovbNJlpetCtvwzXPOFHOoKO96Dl3yEB9kb/ytQHjbdo0OsVZMZAj1 OkItOVFLhuY9uupSOHi7nuErv8y0JWX9tamzXfP6u1pVCa41V2RY004hJ j13tq0w2rFDplmsNxOEX2vywxwMt+sWHs4Dg1CJotBMGreUwiNWSEdNeM Jw+6DjHSX+qOgZrBytCrmbZ2RyvMw5wsFzPR4aHqRUqfp0F8T7s096qt6 41SMZobQ+GHZTNA9RPr6HC2VWNl6BxPO7NsTHsP37YDum1hqyv7KlGld3 g==; X-IronPort-AV: E=McAfee;i="6600,9927,11004"; a="15001023" X-IronPort-AV: E=Sophos;i="6.06,207,1705392000"; d="scan'208";a="15001023" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2024 18:18:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,207,1705392000"; d="scan'208";a="10172282" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Mar 2024 18:18:55 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 5 Mar 2024 18:18:55 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 5 Mar 2024 18:18:55 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 5 Mar 2024 18:18:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DmPO8D2gn8ftCfCrKFq9aX26psC2s9SleAqfrY3C7CRSyKRtZ4/H0rmtjK6G3i4/NDtn7HhuoQz2PZsowtFgqdpCdfby0nmPZeoZc2BmRJDLMSLOI3JYL7e/hmCT5XowOTCOPaFSJQ6BaD+lmsgF9/+YBJrJjVl2NhSwEbHJzQ/tyWWz0FLLIFam3oJgc9bhSvKKSMI1LZywvJ/Kfe5cbQ2JUqhMnl7rZpF9wweqsd15Sy9eST6U+d7oWzdn/wIPYXYaDE6nzq9EasxISnYwnWJHr4FryP7++zD5yPayeZ1mDPVorprIsOcjbGnqQawhVJsb5GB10lg9kKytmggtWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SP5VWbVyFNZ8iTKEziTWUXCvnkjh6bqeIPUgMDqzCmg=; b=ONMBu0dvp95rmWGQ/07q6+jU8Uo5JpcRVobGWHVmdT4ugwZI2TAeyeVBnkdvqq67zFwsTMSB9yKyrGlegwE3CNBYSl7I5W54K7ZPCiOap7r2Zbt5Wm/JCR8BhzVqepEVgUXzBgsjiov2xZk5dLsZpb6+MtS6zGH6yQu4dcEBFxqWedAhk0y2fQLwx+WgtjwtOkSV+wH8yeqaZ5GyUafvBYhnEyfpLYZZC8AR3KE2gM1ttTLQvNewM+eWuQOoBtiOooW5/LCetN5Exwhot348SpyEF/0yVhBAjMbuMaDMlinKga3TC4BUdezMaD73Hf7k8mntmBn0lkW142yZXmjg7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS7PR11MB5966.namprd11.prod.outlook.com (2603:10b6:8:71::6) by DM6PR11MB4548.namprd11.prod.outlook.com (2603:10b6:5:2ad::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.23; Wed, 6 Mar 2024 02:18:52 +0000 Received: from DS7PR11MB5966.namprd11.prod.outlook.com ([fe80::55f1:8d0:2fa1:c7af]) by DS7PR11MB5966.namprd11.prod.outlook.com ([fe80::55f1:8d0:2fa1:c7af%5]) with mapi id 15.20.7362.019; Wed, 6 Mar 2024 02:18:52 +0000 Date: Wed, 6 Mar 2024 09:49:00 +0800 From: Yan Zhao To: Sagi Shahar CC: , Ackerley Tng , Ryan Afranji , Erdem Aktas , "Isaku Yamahata" , Sean Christopherson , Paolo Bonzini , Shuah Khan , "Peter Gonda" , Haibo Xu , Chao Peng , Vishal Annapurve , Roger Wang , Vipin Sharma , , , , , Subject: Re: [RFC PATCH v5 24/29] KVM: selftests: Expose _vm_vaddr_alloc Message-ID: Reply-To: Yan Zhao References: <20231212204647.2170650-1-sagis@google.com> <20231212204647.2170650-25-sagis@google.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231212204647.2170650-25-sagis@google.com> X-ClientProxiedBy: SI1PR02CA0003.apcprd02.prod.outlook.com (2603:1096:4:1f7::20) To DS7PR11MB5966.namprd11.prod.outlook.com (2603:10b6:8:71::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR11MB5966:EE_|DM6PR11MB4548:EE_ X-MS-Office365-Filtering-Correlation-Id: 29bf49e5-74a5-4b94-4c83-08dc3d83c420 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zHfhWuubjYqfynC6UkiFL/wJuguHFUgUbHDs1pcDM/2WKt5bKCK/6/buj0c6325JwwbI4cgrtaFFHCbfldV5xjugy0a3X0I6y3QaUjjiBiauULRMym60o3eP1brOrZe2h1DWQ8aDdkBwVC7obG06pu8VzsnLMWwLfLbgGd5AFdiGMUquOwnELKfM2p1sVCRlAJ3R6Y6mjLEZpuACiFeEP/1duCiHAWhz6N6HYHLJsKAdpy0baNkrZPlXy/7VU66hBiw27zDu06GJLytNyovavkFzSqNFDEsUirALZOjMYZMEson9EHtkreQWTKRCCMqpMVce5NHAWNQDNkhYaDR7yPqlNdkBZpmkhOi9pEXebSevXGqixj1n2c376JK/Qo+wmkV2YFAEvPVCqo/CLSgcYsGtxXvljP8Zt1h1jWwgySRu/H54g5GtsLjiT7Ntow051PEfhVRmWohWY3FWk9hhCYJz/eaGF8EraCx19+07A4N0Sg19GbfzRr5FQQLBW+4H5TtoiQiAzg7OaqmiIdyWw3ERj8XGNmh5srLU/Kr/NnW6b0oknhnPtxy5H/aM75/e4hASS1XKUmyZjrvNfg/PLEP3UyR6qbbQ4Za0FUM/sT9dM/7bOYBjgprmfyP5pqdFAyNM7IKZw/mJdkL4e4jY6rsyPKNsgqQC4Xp1t03niQo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR11MB5966.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3gdBFs/evYC4N9hImEde5/m7o8vqVGiCXEFByTXhQ1Je2LbKdy4x+L5ZTv+E?= =?us-ascii?Q?RhAyeD5zOhq64lZJQjVHPBGQgay8lavXYEfIfHjMAekozoiYOU0iyjA+vmQb?= =?us-ascii?Q?xjT/77FDYxSYVD1E7IEBGPFUvCLPW/KJoDxS32it95SXeJT4OI4dMfUHUlDf?= =?us-ascii?Q?DlMYELUB6l19ZHNuqPMVAt60UhEQxLJ0KOHZ9r23OWhTu98jpIJyZMxD1a5P?= =?us-ascii?Q?O8wYra2mgb4JfXsheo0EpD9yi0LaAVdorPgp1AsPJ55QJ4IBxbIeRn/13FS+?= =?us-ascii?Q?eIGqDocMe1TuhRJcfgC0mluWK6zE2TTKOWkAuRABfRbK35c8DWf2/1CvOrgN?= =?us-ascii?Q?V8vz9iHjjUtRPilpr5AuzK7oo7QZ/XosOgHoiWOZ1nLeFDvqUGDuv3SeCv6X?= =?us-ascii?Q?XNoCboMWYIXGcTPnxAXs5bn9xWA9sK8yqfPX51AeCxQV5i9Jqfj58BZhr6Hq?= =?us-ascii?Q?+80htmLBmA/651mhN//auox9xM8zeYdy/r/cAUfNRfqKx8szz8o0lu7MVK5h?= =?us-ascii?Q?dQPGajQk26NimBu+pFdoOMixDl1SXxrnqvHHCV9HmM+bzNUcrEMCOH3i8oWe?= =?us-ascii?Q?mfW6cLuGLc4pPRF9Uw9ynZrRPwzQTFqvo6ECp7fMnmI5iDBn1GuqJITVKgdx?= =?us-ascii?Q?SkrRtyLDnTTVFR7O18EvZl2fJaHaE9pmB5ValNcOSwYYmoeRHbhGBiUb4M/s?= =?us-ascii?Q?e9/ArYcbmvItN2f57ZBYgUh0l+rB83mi0dz6hVS45Hu3b/93kPB6FKCD0odx?= =?us-ascii?Q?3JLQkLgJMvl9d4rO50H/L2oLT8QNWgZt4rkfZzKY8yWLLPEAsN2ymBwjYsXf?= =?us-ascii?Q?w3N+gQXiOOmcpakMrsj6BMlkVd6MbXQx9MXSIvrLUaRf1fOyL35kBzawXxJw?= =?us-ascii?Q?LLdqDZAXqSDjrwZUo6KXBz/88+SEIA1xFQQCAKKgMVkQ2JxH7tDnZOoTI6YZ?= =?us-ascii?Q?FAYgeAUMfOZmZx0bF8JWRe8Kt8x22XnFGWjO5DkcPsmDiLOI6Dbm6+V0wRyh?= =?us-ascii?Q?Tdumc1n/TZKjNKLNgwvtW8FFmM6FHasLL5lT48BJ43vTNJ6h7V7PGrix2SL4?= =?us-ascii?Q?ck7QOciVYXqV4aciuThc9ZMhzm3I81ggN/XlLWYNRMFNqOianCO7wwWTVMJu?= =?us-ascii?Q?omAStZDoiiQjdZ0W3PgTY4xrC4wple9Ypzpc8I2vsYPP8TaCM+ZPXLY3xS7p?= =?us-ascii?Q?wFvqgXug4efjhXgBlh6isbzT7vgPgaQbMY3zX9hAHDLMTPm3b3xSjuAg1hFr?= =?us-ascii?Q?eZ4+NfhzTT/KtU1aPkOSOPioJMkMJayWNgkEkxA5iH12h7/6ee7ujtrBEipx?= =?us-ascii?Q?syWV3xMJwWIIhOOegFMBRBTqFJxO5Ga2A5MVOCn+f32Z16JnaeWbMMn1QDU9?= =?us-ascii?Q?g+AxPhsG2Wuu4J9DMxWy13gRLPs0i/ipH+lFgZ2TXpnoaM+y1tmJzBOT9GLm?= =?us-ascii?Q?JmjWHznXe+LN+1C+4H+7AknMNzHmmV40Yn9HnQfmSLzj8ROUygC46fkFL36O?= =?us-ascii?Q?l3CjErYf5AWml197xQMjeDPiR802NEi0pny2mpQszpwEtaRpt5g93Njr5+ZU?= =?us-ascii?Q?yYnfN056O0FfSP2xZnKEAEzmZLRWwOfpeD/GV3Ok?= X-MS-Exchange-CrossTenant-Network-Message-Id: 29bf49e5-74a5-4b94-4c83-08dc3d83c420 X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 02:18:52.4584 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fVtm8SGqZj/dnwWJHMamWl0Qjuv5Tg/Hln2wCITDC5F2hM0Ng9BdWABOffGis5AXo+H5PC63Ajm55xpGMcm/VQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4548 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: 403A61A0013 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 7tmwkppjmrg47gr9f4irtsnyuby7c3uw X-HE-Tag: 1709691536-13881 X-HE-Meta: U2FsdGVkX19liuB9EzfLhrPqP76+zK8EjkqZ4cUgMTA8AaFsC5e2x4gsjbTz5DpBU2qId8f85k9L5sdaJ217oLB6xautjh2zAOpHNyqbX0SYvj/9Lx1oquhZiisD4icysDegkM1tX+J0thRpvMrhJmF+2W9AeJaXVoYZxJ7rz8LPp/DT7pbSr/RL/BA71lsZ3tDMUDXC69gkDmg5DnVzjuzgLOLVUpPyg73yx6WwRo1DbHoPN059SZPYYWYhPrVARqjWtbXg81Pav2iMlfNLm7DpwDHlscIefvGFQkyvT3mWJUHmoi311WfySwCJVCtwYqOgkdnUgILONU3d7FYmXaCWYlpy1nc26oq+U23UB8L6i+hjH9xtsOBEO8uyFClAB7w+pAWs2ShvheB7bFfPuSjYxxbXN0U/cUlR9rW1EB4oDhVQ/v7EeQ1D8vB7FOz8mfLm02nb5iry5VwM4F/5p7F46BdEN4MNk6+tWH8qBpIMDXgKxWJuMXK+bPVDXWxhoAxwO0MqpRsJaB3Ad2jCJ1S1lTQEvNrsCRXCuWo5Zwh/Q05whQWGAUbwzdltKKYirafesYyTf1ExmJja+zGOfZOkljYp1HQhkkJ8ovTW55unM6WOWYn+XJqWDojywgpsSvJzKu/3RwCk2CjL6GlYmrXflPFZ7ow6dRnypHidNm9YdjdYtVMwDjvmmhBmuCbPYYjf23jZ3fTmROcdhKtqyerkTz2Qf6RIN2iRjFkeUA9T2FDS3pYlWTZuL/aSAmYOe4JI+nHyK0lzU/jDcKCD9iCPs3n4WlZ1m1O8Ce9/UqTAvUJIFlMhhq/67bHXBEMpT2eEmBqULYocAOe8/Qr9DCZUY5E4MsswYTwWMYCAFaKEXraCuu02IpUggHn9ChXeTzMDAii8Le1C+thZXJEFD2NI21v0MxiGmdVTZqDYpopOdPss0ikfWAqqyAwHh0fkrM+WSHsWXSyou4SQYHk S1HJfMnM U7pd9uIv4JsnCCwmcIAoS70YA05r5/FSoxWqspSFAsfVNs//moNPwUyihbbhfwCeEcwCS7qHyTJto3OtJbtETaB0XLsJBVXmzZYDWJrqn+56lJDo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 12, 2023 at 12:46:39PM -0800, Sagi Shahar wrote: > From: Ackerley Tng > > vm_vaddr_alloc always allocates memory in memslot 0. This allows users > of this function to choose which memslot to allocate virtual memory > in. > > Signed-off-by: Ackerley Tng > Signed-off-by: Ryan Afranji > Signed-off-by: Sagi Shahar > --- > tools/testing/selftests/kvm/include/kvm_util_base.h | 3 +++ > tools/testing/selftests/kvm/lib/kvm_util.c | 6 +++--- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/kvm/include/kvm_util_base.h b/tools/testing/selftests/kvm/include/kvm_util_base.h > index efd7ae8abb20..5dbebf5cfd07 100644 > --- a/tools/testing/selftests/kvm/include/kvm_util_base.h > +++ b/tools/testing/selftests/kvm/include/kvm_util_base.h > @@ -561,6 +561,9 @@ void vm_mem_region_delete(struct kvm_vm *vm, uint32_t slot); > struct kvm_vcpu *__vm_vcpu_add(struct kvm_vm *vm, uint32_t vcpu_id); > void vm_populate_vaddr_bitmap(struct kvm_vm *vm); > vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *vm, size_t sz, vm_vaddr_t vaddr_min); > +vm_vaddr_t ____vm_vaddr_alloc(struct kvm_vm *vm, size_t sz, > + vm_vaddr_t vaddr_min, vm_paddr_t paddr_min, > + uint32_t data_memslot, bool encrypt); > vm_vaddr_t vm_vaddr_alloc(struct kvm_vm *vm, size_t sz, vm_vaddr_t vaddr_min); > vm_vaddr_t __vm_vaddr_alloc(struct kvm_vm *vm, size_t sz, vm_vaddr_t vaddr_min, > enum kvm_mem_region_type type); > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c > index 28780fa1f0f2..d024abc5379c 100644 > --- a/tools/testing/selftests/kvm/lib/kvm_util.c > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > @@ -1410,9 +1410,9 @@ vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *vm, size_t sz, > * a unique set of pages, with the minimum real allocation being at least > * a page. > */ > -static vm_vaddr_t ____vm_vaddr_alloc(struct kvm_vm *vm, size_t sz, > - vm_vaddr_t vaddr_min, vm_paddr_t paddr_min, > - uint32_t data_memslot, bool encrypt) > +vm_vaddr_t ____vm_vaddr_alloc(struct kvm_vm *vm, size_t sz, > + vm_vaddr_t vaddr_min, vm_paddr_t paddr_min, > + uint32_t data_memslot, bool encrypt) Is it better to expose a helper function with meaningful name? It's annoying to count the number of "_" to figure out which version is used, especially when there're "__", "____" versions :) > { > uint64_t pages = (sz >> vm->page_shift) + ((sz % vm->page_size) != 0); > > -- > 2.43.0.472.g3155946c3a-goog > >