From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2E66C54798 for ; Tue, 5 Mar 2024 23:58:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 329A76B0075; Tue, 5 Mar 2024 18:58:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B2B06B007D; Tue, 5 Mar 2024 18:58:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 153916B007E; Tue, 5 Mar 2024 18:58:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F2DD86B0075 for ; Tue, 5 Mar 2024 18:58:13 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9DDD11203A5 for ; Tue, 5 Mar 2024 23:58:13 +0000 (UTC) X-FDA: 81864651666.10.4618EEA Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf02.hostedemail.com (Postfix) with ESMTP id B637D80002 for ; Tue, 5 Mar 2024 23:58:11 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VVek7XPV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709683091; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CRPbTjVgyE4PYwh/jnpL0ufRys+ZJBqz1o3jrQedx1Q=; b=jNFyrymxmTcx9M9IdWuL6uFz4mC9n7dBjrwFhJuz7LhNP1xRmnWy+jE89A8j1OyFXjIXUP Cf46YIYcRYaUfww47CEiFMk4wSHN7OjFZuJ8IIAnqnRDPAMz7yPE1A0mWXm10lV9ILTOuG hzeOq2cjtllk8ehcHlh1eokoSX5xlx4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VVek7XPV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709683091; a=rsa-sha256; cv=none; b=Wm3Jr+QclDsa1YYwT2OJdMaKqYSYfKg5wzQzg3/OZOspauzlPbSxIHLr7ImWpds+ZvKgqE DRcp3ZXX/2kZLIP9qH/kcHAI7PkmTV9SUgWIPgonwTo50i7Av3uNzkWXvKAlrhbQd87ChK sx9YrmFs+3yUzG56bZ6en/VCrs6W9ps= Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6e56787e691so238183b3a.0 for ; Tue, 05 Mar 2024 15:58:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709683090; x=1710287890; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=CRPbTjVgyE4PYwh/jnpL0ufRys+ZJBqz1o3jrQedx1Q=; b=VVek7XPVS+OxvrKiN1rd3QhU6qNUGbnNnKEKp4Pu2oU5A/ZoM7/f83yNr+KxGw3nq2 Sri1PxuEzciwecvzhc8AXPBcOy9TckuuLU+8hb2HP50EEfZU4x3sXh3FY4NGxvRZid5/ XlgWIIrg+OV6fEiG4vLqLU3/ZIdz05tEN38vRHY7IuTWWN4ROLtByvQql+uf5ns2Sc7I tnw2n3KLVb3fJbX3REvCRv3fP2sZeNHwOPEEopskZ0Gnik2vz1aUDG1d4ShSFwWWgi7J M6evW7mU0uDEwpr7h6p2mKAXaWIYxJxp2nipnyoWcJ8Zjwf9XUPhlTYAknCBkIM26Zr0 1Wcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709683090; x=1710287890; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CRPbTjVgyE4PYwh/jnpL0ufRys+ZJBqz1o3jrQedx1Q=; b=t3lVJ7XcqROAsnhglaaLRos2DExkTTi2vXIguTbdJQDCc4pcPQgVq9y/GWmQ4QAu3e wQC0aF6QNqo0kL5PxVLBfH80wn7qW55wjYP3focA+chbiSe1GY/PAye8ITsENwYybJpk nPtUOHVkKuVqRs24SwTNzIUk7cXEyx/swbF7JK+T3pK4/oeTtsmZvIANFIhnYVxjOsXd oS9XnQEDFgBQEvp1Z0EqYOyigDwohqREYTxpyzNP0DF4g8Ru7kwPvqNznBCaloZ3d+5t lGf3G0hs4uFyqbiRJn+C3869uC0Jix4qmiHfcsKeHEcFoIWtNRi2atLq8OAK01mgRMQP pImA== X-Forwarded-Encrypted: i=1; AJvYcCWllytgAsV4lB+P5Zl8jWHQqx75NbDWdjBiCPVY9fiEm5heYYs2KwJgDj8VDhPXKHC2xfebEBbbc1UWKuPEWuLnp+0= X-Gm-Message-State: AOJu0Yw1lLPV3wMLHVAAq7NdBnzELh13d+fhof1rrrxMTgbmyBxnjEJS d+hZtw5JoAznGCkY27NytV2l0ZQj2y6Ibuf0y9S27nUDhrW+Foeu X-Google-Smtp-Source: AGHT+IFkyfofyClB+sf4ug0A6uUDjt2ZbsKesCzqOAmB+JwKyE/QcgD3QAAH8mfPCIEOeeVjDbPGeg== X-Received: by 2002:a05:6a20:e111:b0:1a1:48df:d55c with SMTP id kr17-20020a056a20e11100b001a148dfd55cmr4371695pzb.0.1709683090406; Tue, 05 Mar 2024 15:58:10 -0800 (PST) Received: from debian ([2601:641:300:14de:881:34a4:d51c:3425]) by smtp.gmail.com with ESMTPSA id jw13-20020a056a00928d00b006e5574db193sm9885184pfb.18.2024.03.05.15.58.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 15:58:10 -0800 (PST) From: fan X-Google-Original-From: fan Date: Tue, 5 Mar 2024 15:57:53 -0800 To: shiju.jose@huawei.com Cc: linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, tony.luck@intel.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, rafael@kernel.org, lenb@kernel.org, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, mike.malvestuto@intel.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [RFC PATCH v6 01/12] cxl/mbox: Add GET_SUPPORTED_FEATURES mailbox command Message-ID: References: <20240215111455.1462-1-shiju.jose@huawei.com> <20240215111455.1462-2-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240215111455.1462-2-shiju.jose@huawei.com> X-Rspamd-Queue-Id: B637D80002 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 1eubnpwxck5r7tx48x4u3tfhpzirwqic X-HE-Tag: 1709683091-25257 X-HE-Meta: U2FsdGVkX1/WGXmpf1twoBKt2VoN8zPHAiUI8XTHaRhuSASQsa4XjI0B6IcUoupPjyu7oNotR6Ecj2HLtGnrK4gVtAJfoPtJuHrVY/vvDi6GPUPMc8bpYU8+4wUP0SEzBmcVIhMZasR9E+/eiTR6RhmV4MH/aJEjgkQpxcs8YRYLQa9gXRWkZYlG6z6zSun4wZAXCCUx3ZVJFFFGFJw9LEXKzDCf3Uk6umc83tBxx7bV5SrXYUHnXo+5UhffCgl0RKsnc8+7fLUNmonqGyO9zeAsnMu4kdfI9VSl8b1zhD1ki/VK378OZM13Q5Bqh2OLpXW5nMgBRqgaVU5qDv+6hxz77JstzAgQxyO8jh9BXJZPkjAqqLuH30s6ej9KkuL2Kl/vkH03Ujlf/xfQeYgMeQt+PsC6j5ndKIB6mtD9XdrEBJzns/zmBHfmVfKurVygF062IQc8EsbAfXIB16XrqVhszxm7LyjgjDGomxvnKhRxzZvjxQ4m+j8Te20VXzG/KqnxpLULdDIeKb/24de+QQ4T+pvUDeecKtYS7OtPK6py+2sMjmDSe/GEvLrpudQvuwVYzzgql5XusCek1kyVz4Dd1P+4FhXKlbCYAtBwPWkkHY+JfsUFhZR3zON9P9XFGiIUwssVlYAhlksnIq95bVbrdzKRb3noXdu0UKLATtxf1HKOeKhZYuCuslsHYuKsT5WLgF4fA7yVa6RRY7sXloAlNUyVjZaVDzh7NazQ4udYqXryBDUFsJRnFmORLfAQV41S9TjBpPvRFyO7YEhATf+QZ1l1pK5eHLt3VjqbK52ujr/lDkqJVbRaL1rKkZGiTYZNz8D4le+20OFDR53dAoLdhTvZn87Mz1UlHfw8Ei0OauI3kuw7upr8eHOEvnkyRE5j8LMC9sbTVPSt2yhtf/pxsFYRNqsEeZBba7QEVpO4oWS3KlGrMeMtfPPaJzzdH81jba6ZTt+CiHtHIPu Nh/PnZdJ utPrzvbza0SEiICCangdVYcnTePOln9/CKWhXShWhIO/Gka7kJtQQJ4IUcjH4CB1Py2Pn6TsD0ejetOIRc5zZZLWGFO9Lp1qowTNxu+w+sc08Vvt2iv6wRg27Vn3qdPmlz3Ch156RCtZlgz+RcHFt35Bd+Lhmpp9I24mA8L99Nd/Dkstq632OHZlO07yEqj2ek7d/L6njD31OF3NPgdheqofx2kXtqEn4jUtrQnOZzO8rWdPeQl/MSlGdqLbtUUeI+1ZV4WDGC3t6P3exCkiMgRRsodv44nzfjASqMhbZUzRKZXOfm8y2sNRXJGTapGzRRMQnq/8KX+8KqmexFUqS2sb9aCp+K+i+9fqbX1KYSuK3U8Us7es/IxwKbQ067IQlI/XnjtO/KP1m+w60Upwpj8E70N9duttPmT/Ga5AOXuM9VLMF0y5D5KNUJUzozNKzbT9TGkE7KkERWjbCDPAAO5eAekzNm2PCd+s9IG3UB3WKjh29ZozLTiBMCjBP340fyjGLh1br1qmKoAvRtTRP1ReGxe0zZHViOWP8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 07:14:43PM +0800, shiju.jose@huawei.com wrote: > From: Shiju Jose > > Add support for GET_SUPPORTED_FEATURES mailbox command. > > CXL spec 3.1 section 8.2.9.6 describes optional device specific features. > CXL devices supports features with changeable attributes. > Get Supported Features retrieves the list of supported device specific > features. The settings of a feature can be retrieved using Get Feature > and optionally modified using Set Feature. > > Signed-off-by: Shiju Jose > --- > drivers/cxl/core/mbox.c | 23 +++++++++++++++ > drivers/cxl/cxlmem.h | 62 +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 85 insertions(+) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index 27166a411705..191f51f3df0e 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -1290,6 +1290,29 @@ int cxl_set_timestamp(struct cxl_memdev_state *mds) > } > EXPORT_SYMBOL_NS_GPL(cxl_set_timestamp, CXL); > > +int cxl_get_supported_features(struct cxl_memdev_state *mds, > + struct cxl_mbox_get_supp_feats_in *pi, > + void *feats_out) > +{ > + struct cxl_mbox_cmd mbox_cmd; > + int rc; > + > + mbox_cmd = (struct cxl_mbox_cmd) { > + .opcode = CXL_MBOX_OP_GET_SUPPORTED_FEATURES, > + .size_in = sizeof(*pi), > + .payload_in = pi, > + .size_out = le32_to_cpu(pi->count), > + .payload_out = feats_out, > + .min_out = sizeof(struct cxl_mbox_get_supp_feats_out), > + }; > + rc = cxl_internal_send_cmd(mds, &mbox_cmd); > + if (rc < 0) > + return rc; > + > + return 0; > +} > +EXPORT_SYMBOL_NS_GPL(cxl_get_supported_features, CXL); > + > int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, > struct cxl_region *cxlr) > { > diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h > index 5303d6942b88..23e4d98b9bae 100644 > --- a/drivers/cxl/cxlmem.h > +++ b/drivers/cxl/cxlmem.h > @@ -529,6 +529,7 @@ enum cxl_opcode { > CXL_MBOX_OP_SET_TIMESTAMP = 0x0301, > CXL_MBOX_OP_GET_SUPPORTED_LOGS = 0x0400, > CXL_MBOX_OP_GET_LOG = 0x0401, > + CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, > CXL_MBOX_OP_IDENTIFY = 0x4000, > CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, > CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, > @@ -698,6 +699,64 @@ struct cxl_mbox_set_timestamp_in { > > } __packed; > > +/* Get Supported Features CXL 3.1 Spec 8.2.9.6.1 */ In current code, block comments starts with /* and the real comments go from the second line. Fan > +/* > + * Get Supported Features input payload > + * CXL rev 3.1 section 8.2.9.6.1 Table 8-95 > + */ > +struct cxl_mbox_get_supp_feats_in { > + __le32 count; > + __le16 start_index; > + u16 reserved; > +} __packed; > + > +/* > + * Get Supported Features Supported Feature Entry > + * CXL rev 3.1 section 8.2.9.6.1 Table 8-97 > + */ > +/* Supported Feature Entry : Payload out attribute flags */ > +#define CXL_FEAT_ENTRY_FLAG_CHANGABLE BIT(0) > +#define CXL_FEAT_ENTRY_FLAG_DEEPEST_RESET_PERSISTENCE_MASK GENMASK(3, 1) > +#define CXL_FEAT_ENTRY_FLAG_PERSIST_ACROSS_FIRMWARE_UPDATE BIT(4) > +#define CXL_FEAT_ENTRY_FLAG_SUPPORT_DEFAULT_SELECTION BIT(5) > +#define CXL_FEAT_ENTRY_FLAG_SUPPORT_SAVED_SELECTION BIT(6) > + > +enum cxl_feat_attr_value_persistence { > + CXL_FEAT_ATTR_VALUE_PERSISTENCE_NONE, > + CXL_FEAT_ATTR_VALUE_PERSISTENCE_CXL_RESET, > + CXL_FEAT_ATTR_VALUE_PERSISTENCE_HOT_RESET, > + CXL_FEAT_ATTR_VALUE_PERSISTENCE_WARM_RESET, > + CXL_FEAT_ATTR_VALUE_PERSISTENCE_COLD_RESET, > + CXL_FEAT_ATTR_VALUE_PERSISTENCE_MAX > +}; > + > +#define CXL_FEAT_ENTRY_FLAG_PERSISTENCE_ACROSS_FW_UPDATE_MASK BIT(4) > +#define CXL_FEAT_ENTRY_FLAG_PERSISTENCE_DEFAULT_SEL_SUPPORT_MASK BIT(5) > +#define CXL_FEAT_ENTRY_FLAG_PERSISTENCE_SAVED_SEL_SUPPORT_MASK BIT(6) > + > +struct cxl_mbox_supp_feat_entry { > + uuid_t uuid; > + __le16 feat_index; > + __le16 get_feat_size; > + __le16 set_feat_size; > + __le32 attr_flags; > + u8 get_feat_version; > + u8 set_feat_version; > + __le16 set_feat_effects; > + u8 rsvd[18]; > +} __packed; > + > +/* > + * Get Supported Features output payload > + * CXL rev 3.1 section 8.2.9.6.1 Table 8-96 > + */ > +struct cxl_mbox_get_supp_feats_out { > + __le16 entries; > + __le16 nsuppfeats_dev; > + u32 reserved; > + struct cxl_mbox_supp_feat_entry feat_entries[]; > +} __packed; > + > /* Get Poison List CXL 3.0 Spec 8.2.9.8.4.1 */ > struct cxl_mbox_poison_in { > __le64 offset; > @@ -829,6 +888,9 @@ void cxl_event_trace_record(const struct cxl_memdev *cxlmd, > enum cxl_event_type event_type, > const uuid_t *uuid, union cxl_event *evt); > int cxl_set_timestamp(struct cxl_memdev_state *mds); > +int cxl_get_supported_features(struct cxl_memdev_state *mds, > + struct cxl_mbox_get_supp_feats_in *pi, > + void *feats_out); > int cxl_poison_state_init(struct cxl_memdev_state *mds); > int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, > struct cxl_region *cxlr); > -- > 2.34.1 >