[linux-next:master 11602/11963] ERROR: modpost: "acpi_device_notify_remove" [drivers/i2c/i2c-core.ko] undefined!

[linux-next:master 11602/11963] ERROR: modpost: "acpi_device_notify_remove" [drivers/i2c/i2c-core.ko] undefined!

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   11afac187274a6177a7ac82997f8691c0f469e41
commit: 0a56aa8d77de2237d80e1df028ee2222af94e60c [11602/11963] i2c: acpi: Unbind mux adapters before delete
config: riscv-defconfig (https://download.01.org/0day-ci/archive/20240305/202403052102.hlG8I44z-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 325f51237252e6dab8e4e1ea1fa7acbb4faee1cd)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240305/202403052102.hlG8I44z-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403052102.hlG8I44z-lkp@intel.com/

All errors (new ones prefixed by >>, old ones prefixed by <<):

WARNING: modpost: missing MODULE_DESCRIPTION() in vmlinux.o
WARNING: modpost: missing MODULE_DESCRIPTION() in arch/riscv/kvm/kvm.o
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/nls/nls_iso8859-1.o
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/btrfs/btrfs.o
WARNING: modpost: missing MODULE_DESCRIPTION() in crypto/xor.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/zlib_deflate/zlib_deflate.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/clk/sunxi-ng/sun8i-de2-ccu.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/virt-dma.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/virtio/virtio_dma_buf.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/drm_panel_orientation_quirks.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/base/regmap/regmap-i2c.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/pcs/pcs_xpcs.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/gadget/function/usb_f_acm.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/gadget/function/u_serial.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/gadget/function/usb_f_serial.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/gadget/function/usb_f_obex.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/gadget/function/u_ether.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/gadget/function/usb_f_ncm.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/gadget/function/usb_f_ecm.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/gadget/function/usb_f_eem.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/gadget/function/usb_f_ecm_subset.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/gadget/function/usb_f_rndis.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/gadget/function/usb_f_mass_storage.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/gadget/function/usb_f_fs.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/gadget/libcomposite.o
>> ERROR: modpost: "acpi_device_notify_remove" [drivers/i2c/i2c-core.ko] undefined!

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [linux-next:master 11602/11963] ERROR: modpost: "acpi_device_notify_remove" [drivers/i2c/i2c-core.ko] undefined!

[Hamish Martin]

On Tue, 2024-03-05 at 21:15 +0800, kernel test robot wrote:
> 
> > > ERROR: modpost: "acpi_device_notify_remove" [drivers/i2c/i2c-
> > > core.ko] undefined!
> 

My recent change introduced a build failure when building as a module.

ERROR: modpost: "acpi_device_notify_remove" [drivers/i2c/i2c-core.ko]
undefined!

I think the issue is that I called acpi_device_notify_remove() which is
not exported (i.e. no EXPORT_SYMBOL_GPL).

I'm not sure if the correct fix is to mark acpi_device_notify_remove()
as exported (my gut says no), or to instead modify my new code to call
the already exported acpi_unbind_one() - acpi_unbind_one() is already
exported. 
I was only calling acpi_device_notify_remove() to trigger
acpi_unbind_one() anyway, so that seems like what I should do.

Please let me know which fix is preferred and I will prepare a fix to
the original patch.

Thanks,
Hamish M

Re: [linux-next:master 11602/11963] ERROR: modpost: "acpi_device_notify_remove" [drivers/i2c/i2c-core.ko] undefined!

[wsa-dev]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]


> I was only calling acpi_device_notify_remove() to trigger
> acpi_unbind_one() anyway, so that seems like what I should do.

Sounds reasonable to me. Mika might have more insight, though.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [linux-next:master 11602/11963] ERROR: modpost: "acpi_device_notify_remove" [drivers/i2c/i2c-core.ko] undefined!

[wsa-dev]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]


> My recent change introduced a build failure when building as a module.

I will revert this change to remove problems in linux-next. It does not
make sense to push a fix together with an incremental fix that late in
the cycle anyhow. Please resend the updated patch as a whole. I'll try
to get it into 6.8.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]