From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C2F8C54E41 for ; Tue, 5 Mar 2024 15:52:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E46B6B007E; Tue, 5 Mar 2024 10:52:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 86D796B0080; Tue, 5 Mar 2024 10:52:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E75D6B0081; Tue, 5 Mar 2024 10:52:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5C2C96B007E for ; Tue, 5 Mar 2024 10:52:08 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2D838160EC6 for ; Tue, 5 Mar 2024 15:52:08 +0000 (UTC) X-FDA: 81863426736.05.292A2F4 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf29.hostedemail.com (Postfix) with ESMTP id 08E1A120009 for ; Tue, 5 Mar 2024 15:52:05 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fBoFlOhl; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of kbusch@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kbusch@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709653926; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c5ZIjtn84+RGrKPpS181y3wEWWbDN+8mLamK+w2N/o4=; b=FQr1G8pOeMmFR79q/tyE/QMu0UFEdryqp3cR1kZyR7RW1tt9H3acriM42m5yz9NNDMwQrM t562CzMqaEHgPYRqcibu5zg/XkiARSt/wdrnqISmXg6iDosKuOMpi5dQo5qjINp56qvzQW Al5JVVVNxdOUhnkYq9GIOrwNDAapD8U= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fBoFlOhl; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of kbusch@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kbusch@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709653926; a=rsa-sha256; cv=none; b=lenhJIi8+KX5MFi943ennzYAtv0oGtGhXIrEuRLs6DfQ261NYTa/Lr1s3yMKFCwt8u8eer SV2jS7Jvd+UGtRc8J0ui7HYxDjHiuxD3LRWBxBpUrUDyY066DOptXojassAThN5fuIfi8p AAjmdqyjVk+87RlwR/2eFdoLZMwS6O4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1B95DCE1877; Tue, 5 Mar 2024 15:52:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DB4CC433C7; Tue, 5 Mar 2024 15:51:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709653921; bh=pSqyVUiOhZxz9FIInEYMAmoXZWKPhnt0IQNLfQGtXOo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fBoFlOhlhaEkFpkwIhtzKscT84AMxoyIqH1ke1DoX3oTGvoYraBWWNLX9PB1wDsDX 8/jrkloUt7VxJU24ln5/zi811lztKw0pkpRiqC5TgWE3Z3l2yBlrPTsMwI7n+JTnPL cIBn53riFq9sACKU+PDs51snnPNJif2TZriANWE8lPNacPlZ3ZEjjBSL+Ajm8tvqj0 Xh39F7UKx8jqNW9DJE3CBRQ781zgONKaHkjALazRttLlPWK1iLUFRVRnO9bb0lDH+E AJgD1u7Xsepu7WvnlIDZLfAruLkrmiYG+GBGJiaH7MHjj517QXOLR7xfuwktrP6dWh 5IQc8QXtatQIw== Date: Tue, 5 Mar 2024 08:51:56 -0700 From: Keith Busch To: Leon Romanovsky Cc: Christoph Hellwig , Robin Murphy , Marek Szyprowski , Joerg Roedel , Will Deacon , Jason Gunthorpe , Chaitanya Kulkarni , Chaitanya Kulkarni , Jonathan Corbet , Jens Axboe , Sagi Grimberg , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, kvm@vger.kernel.org, linux-mm@kvack.org, Bart Van Assche , Damien Le Moal , Amir Goldstein , "josef@toxicpanda.com" , "Martin K. Petersen" , "daniel@iogearbox.net" , Dan Williams , "jack@suse.com" , Leon Romanovsky , Zhu Yanjun Subject: Re: [RFC RESEND 16/16] nvme-pci: use blk_rq_dma_map() for NVMe SGL Message-ID: References: <016fc02cbfa9be3c156a6f74df38def1e09c08f1.1709635535.git.leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <016fc02cbfa9be3c156a6f74df38def1e09c08f1.1709635535.git.leon@kernel.org> X-Rspamd-Queue-Id: 08E1A120009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: eb1q36yudtngi7ggj4c6mc8thyfedufi X-HE-Tag: 1709653925-639019 X-HE-Meta: U2FsdGVkX1/JLiyx73HvlMF9BTpAkNcNFXb2x7JMJTOy8GhGFfuNXkR4D1Ih6yKvQOj7fzZU7JpiDSpEeSfOmXCVZzxJHPF6XrbGiShWjENM9G656kdj3AhK8QRHiHKJ3pOF3GYoahqePg2oQTHKqBVGkv3dgip9TEuo6ciqBeYcNnPGR07C5driCcOK6DxdQMOAz/3OfV4cZsbBR+wB/nZOVCQ0qa1nCqOeJFYLywmHLK9CkPxMH2b50zT9n9Jn/K6D7fpcnFH5xWbN8sPZyWORw4r24/7Ta42LlAm2vUrkpHSdzwzUJ9SRBj/5Jw9m8Lg8sI2Nqe2W9Q67nH69qA64jHVIDyYxr2sqdIEi2zWAPyuEiEwT85FoL8Ki3PGrxMUgN74QmeePh9HrGvzkxyR4KH+OAWW8b7WRrRdnCKz/HULTiKIoqonjRGWXygrCSCvrJ65IFk4oJGC0cjNTy8us/MugPBSgt+4HkA+2WUhG+vrsRUjfvAVtK9PR5M2dUnGDqnq/m+zv8UWJvdiF3JOx/87uUTWSSL58Q0NEYjTYLwF0zH4KlXYnCNa2s7Tb0EWVaRdIy+08vTDg+Lst32haWTBG2owGLrAhyrn5wsGB9YEBN6boa/lZmbJCEg5kNR6e77PaBUlEsogqKZDgWGOA0KCKvc6PqAMzxNdjYZ0HGgjFBWCLGOaAsQNwVSOZEucRNZTkUeaFqNAIk7uh9fUvyc3//if/6qe4dXEFVQsrfNjxfK+yTls45tOX8BC5Vy/DcD/KQN2ArR1+CJOGzyCe/lj1t5DNwCAACVlwFoL0zms93zZL4xPgl6zKDstJ2VY/yaomOjwIhuYO1rRdac3ZTzXBu6jJ2DvTsbEhqVpFAyTEKOPgrShjUHptw3jMx9wLLAhr9u+p9EHnzR0YwUTaG+RQEX5KhpL5M3HZ9wnmJ57O0hreuesX30IXfjmfk+lA5hZgdKI8q69XK9+ TBXCPFXJ d7CGRVGUZXCLtZazuPOmJ1NPyxd0tSb8ud44M9nkaFyireg+1EJ2Q4+0ASMoM9X6+K5d3u1dc/dwISnal0irZ0P0iyfTuBjKNnAmOWpCJHZrLoAxKXLRxWmW+PtBny+Pmi17uT8cMna4xMsv+nl9C9P7SqfAIxPa8ViL1pcF7BgaUtLEcOe7KfadTVYcfvdz3K1QFkVZ13lmqJbnabe6QsDbz9Vxcb+kizQerCp5cuha2qjQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 05, 2024 at 01:18:47PM +0200, Leon Romanovsky wrote: > @@ -236,7 +236,9 @@ struct nvme_iod { > unsigned int dma_len; /* length of single DMA segment mapping */ > dma_addr_t first_dma; > dma_addr_t meta_dma; > - struct sg_table sgt; > + struct dma_iova_attrs iova; > + dma_addr_t dma_link_address[128]; > + u16 nr_dma_link_address; > union nvme_descriptor list[NVME_MAX_NR_ALLOCATIONS]; > }; That's quite a lot of space to add to the iod. We preallocate one for every request, and there could be millions of them.