From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12DBDC54E49 for ; Tue, 5 Mar 2024 03:25:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 956B26B008C; Mon, 4 Mar 2024 22:25:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E17C6B0092; Mon, 4 Mar 2024 22:25:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75A046B0093; Mon, 4 Mar 2024 22:25:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 57E0A6B008C for ; Mon, 4 Mar 2024 22:25:23 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 30C1E1201DC for ; Tue, 5 Mar 2024 03:25:23 +0000 (UTC) X-FDA: 81861544926.19.E979118 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 29C47120006 for ; Tue, 5 Mar 2024 03:25:20 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K6KKfWDG; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709609121; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eXTTezTItt5z2XMw6Q17X/iZd/LoWGe+NHrzVPyEt0Q=; b=nK0tsiEE8AXM4hrL/0ao7DuYRkyntMQ8raTfSNYjNMJLQlL2v/AzSkx/hhULbX0/7ss9PQ LHFgph794Z3EiGDdVuAHVIN4YfQFn/tcxUbP7+oOA/lWbKocjcUp4gAyhK4sUh85Tk8Ka/ TWkMEiIfviH4R08yx5ZCndwmPPyilJ4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K6KKfWDG; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709609121; a=rsa-sha256; cv=none; b=P8bF+Xt8SmsNz7nIp+2QnjPjy5899hof1cSWq3Qz7gO/52HiqqoBFpFJyLFaokvZPN/ie8 T8XqBlKbpn+r2FXFiHXrc7l3+A4POXb75xZFhFWIgluK2htF8JKN7dIIf+HxljK2Qvt6AD AtBdRGopxYOkdljuJxTDEXPywaO8jx8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709609120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eXTTezTItt5z2XMw6Q17X/iZd/LoWGe+NHrzVPyEt0Q=; b=K6KKfWDGkKObITOikS/Ah9Kfh6yBUb3ZhIW0v7QAhLuEYrAgS3IvnwjM1YClzkLS2su/S7 cDe9chR/WXmss0pVMIJ5eBz/81qC1wAjxphW3a6gnAHZBekd+cXpu0EE+pnCRE+JEuv0KP /H2bz1QdxGHzZbMmFm0RGGRQk4qBEjk= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-539-2BsrU1JHNiOfsmmgZeJyKA-1; Mon, 04 Mar 2024 22:25:19 -0500 X-MC-Unique: 2BsrU1JHNiOfsmmgZeJyKA-1 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-1dc2d4c7310so10424265ad.0 for ; Mon, 04 Mar 2024 19:25:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709609118; x=1710213918; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eXTTezTItt5z2XMw6Q17X/iZd/LoWGe+NHrzVPyEt0Q=; b=RxMkbFkcPQUfXQY6En+EVa0z8Jy7R4yh/ltoE1Ph8eE9+/fDGRvoX1YbZHee9noFf3 Yj9PLuvJF5QrwOMsFPteWMsS1/8HJKw0m9YIeZirp2+H8mNfs2VhqBpmVQar4nHahpnH TN50DynxktDZG2FtvehiquHrREXbfYEzIAG+OwWsTBSp8oHmyNihZUNAZmD0Mmvk9pvg WXNxrSEnC/ZwWpSwqoCvUCVNyPrhS2Csm9PfGU94raxLJ3fRgO3A+mRaMdEJ3tBR4m+4 4n2BZbdkbMgSKLMkdsVBlF/1A0PJ8co8v0cFqF1U5DQzvPZNUvLvIcjSk4M34Ccdo6J3 bndw== X-Gm-Message-State: AOJu0YzKcF8Rp1D7WLONV1F4rr9lYIGu7V+uShFYAbQRq/fXxNmjKomQ r1+9MrQLFSZR38Uyyx2z/129M9IrukdWjbos2HKE2p59M5yJZBFTjUAd4jV2OkZiHoq8bgnS75s PHMtNmI4wIJt+SjPMify+xVxJ/D0gzT4YyZ1Wh1wIw8M3P7m9wQAa4o0ytgc= X-Received: by 2002:a17:902:c246:b0:1db:94a9:f9f0 with SMTP id 6-20020a170902c24600b001db94a9f9f0mr11472353plg.2.1709609117815; Mon, 04 Mar 2024 19:25:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IGIT6J3aH98CJa99vypNuCkuIr31GHtAWR9nzM3gesoAnf9BMJ50CuNlEcikNQPLHQwQIsAoQ== X-Received: by 2002:a17:902:c246:b0:1db:94a9:f9f0 with SMTP id 6-20020a170902c24600b001db94a9f9f0mr11472335plg.2.1709609117503; Mon, 04 Mar 2024 19:25:17 -0800 (PST) Received: from x1n ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id p1-20020a170902e74100b001dd0a41447fsm3620111plf.233.2024.03.04.19.25.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 19:25:17 -0800 (PST) Date: Tue, 5 Mar 2024 11:25:08 +0800 From: Peter Xu To: Jason Gunthorpe Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Yang Shi , "Kirill A . Shutemov" , Muchun Song , Andrew Morton , x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Subject: Re: [PATCH v2 4/7] mm/x86: Drop two unnecessary pud_leaf() definitions Message-ID: References: <20240229084258.599774-1-peterx@redhat.com> <20240229084258.599774-5-peterx@redhat.com> <20240304130334.GR9179@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240304130334.GR9179@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 29C47120006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: rc9qub79b3jyqz7i9txpu4nbcerz9per X-HE-Tag: 1709609120-39 X-HE-Meta: U2FsdGVkX1+whVazXAtptWGkxOk9mP7nzYlPUbX5ZkzoOVjUWr0oUQwIn26ZUI2IpLmAMJkNZrnAmVDwwKSOu8TulR7nVD4lZZnAwcYKVlqlGls+EXFV39Xh+FlOrp/RR8RJsm8MeiM2xSQV8CwNRRfyXUsgUoRgNX+VmqL4SrMlIHNh//l7a4ctmc0JaaaSvy1apSXD553TzHKlFHT5roPeXnkkTQ4/TfrgT5C/V5EDqWNcDHDWcjC65CCVOfIHZDXRE4bG5Bp/bSy2O2CwuIRct8wZTMfKcsd/Xr/lEl3Fw3k1Lqn/WcAz6iX1PVipJQZdQ5J589eWLEbn794J3sYFH/mcTIkcYp+tCFG8ea5FOuE8K4JCmTFR3zG54Ikz2/6IWtTDcIfIC3eteZl76631/OW7StEZmbvNFAlSJTCzv2toSRJXYH99VrC94epCLx1rUo8mYa51TcDdCnoW7JC5RtHEb76nPX+k5eMiWPje68af5nHLGHYTK/MAGd+sREByPbq50x50+3M3UfYByEZ1h/ffcuRpIucnokoLz4LV1C92b7EDyPO2/QVuvGQWQmKwzPTwQJ5HIGKIMg0YqcyhS0CE6LXRsj3ypqeMglhoy7sn/X0eu8y2vW0hUwAZzQJqpTBW4mKpMyjdYw/zuJH1gjTnhNYpwQeNIhUi9pEgljOI1zblFinnm+kSJ8/t9y8EPpBu0RSMZS45bWXZxDZeLdHmPHsohTJYtah6C9D/DVB0nskTpyM3Xo6JSGsJvaeq6vnpqkf56OM9eIqGA7iL/4PjUTqpK1WUFNkwEim5Ba5XPudufbHqSzDl1fsrPXX754+eUIU6LZsQ7vGXMcL32HdhY0wcxJWA0Cqs5D6KW1FJtQaD03TzvCwuQwxvCk+PVeUqdAjvayEv+pnm9XGXNbSZvtJXIC8DhgDTo2DX/IMmmfjDpgEQk7b5uQ7iXHQMhcfAsBGw1kcaBSL ws6uFdw4 XFcVvnftQn+BVAMLTSSr2lIVQdkJ0bNOsVZzX9SBCnT9taWCmuDM6NUpesvSz7ODb18oRySO4j2QH9gk5y+AH9Y4wnei4355asU2vWs0uzsJ1TpOciQWp+LwbDEL7uu+ZhP7hHcJvtfIylxf+2TNRr+gstfWHzcmTEmcWlnV0LncJ0Nf8EncYCAVb7Ok81Ik+MU0WwZZqVFk44vcWz9U8dKS1VD1Nlge8yKxJldAbHBOK7VyH0yWCk6NcEDirrZFEOptbjzOYdVZXSMm9HVDbQO5vhj5E2uGH8dWKwdkObOdRsHl+i5xUTWi0/c4Zio+Je6zsGUv4tA7ceUxFHYo3Nn8K/T7S0j3sLoFOl4XK4i3CcII5zn8gLjO5MF4sNgvXWK1DMxozQrnzvLw0fWV+YRf6cLKDLdkdNZQeN+9ABGvzcwbDGfqx0uTt5b0dzRH0nuKw4JtGvEDESb8GN+9JP6SbGm0MoBJ4qLstR6LYkDnJEI44TIePTEV3ogFpG40wiXL3RbMpQUhamgLBJysQJbqDNwM4S9X3FQPm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 04, 2024 at 09:03:34AM -0400, Jason Gunthorpe wrote: > On Thu, Feb 29, 2024 at 04:42:55PM +0800, peterx@redhat.com wrote: > > From: Peter Xu > > > > pud_leaf() has a fallback macro defined in include/linux/pgtable.h already. > > Drop the extra two for x86. > > > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: Borislav Petkov > > Cc: Dave Hansen > > Cc: x86@kernel.org > > Signed-off-by: Peter Xu > > --- > > arch/x86/include/asm/pgtable.h | 1 - > > include/asm-generic/pgtable-nopmd.h | 1 - > > 2 files changed, 2 deletions(-) > > Reviewed-by: Jason Gunthorpe > > > @@ -31,7 +31,6 @@ static inline int pud_none(pud_t pud) { return 0; } > > static inline int pud_bad(pud_t pud) { return 0; } > > static inline int pud_present(pud_t pud) { return 1; } > > static inline int pud_user(pud_t pud) { return 0; } > > -static inline int pud_leaf(pud_t pud) { return 0; } > > It would be nice to have a final patch making the signatures > consistent on all the arch inlines, it should return bool not int. Makes sense, will do, thanks. -- Peter Xu