From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21637C54E58 for ; Tue, 12 Mar 2024 04:07:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE39B6B0186; Tue, 12 Mar 2024 00:07:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A94CB6B0187; Tue, 12 Mar 2024 00:07:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95BA26B0188; Tue, 12 Mar 2024 00:07:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8581E6B0186 for ; Tue, 12 Mar 2024 00:07:56 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 043EA80F0F for ; Tue, 12 Mar 2024 04:07:55 +0000 (UTC) X-FDA: 81887053752.30.6937AD0 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf01.hostedemail.com (Postfix) with ESMTP id 4019B40002 for ; Tue, 12 Mar 2024 04:07:54 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=L4P4edmP; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of 3GdXvZQoKCLgwmqpwYfkcbemmejc.amkjglsv-kkitYai.mpe@flex--yosryahmed.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3GdXvZQoKCLgwmqpwYfkcbemmejc.amkjglsv-kkitYai.mpe@flex--yosryahmed.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710216474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RtyFjQ1ew/Km7nQfV9Ii5WtnlkpNOm8r5T7xPWUQ1Vg=; b=TwrVr5Rm/qZ0BhfbmV0mVmRnztYFeFvo2SWGC0nj6bcNWvuWz/W4NuGzizqq9uzttPd5/9 4yBPROaB3hIJA9Vq+fLBpPhD7NDsGIe2cMopwWD3sMti9urLZAlGxBI06pL9maOdckm+hX KCcIKYhxaU42FMNEnr3Vimlb0GT7Qvg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=L4P4edmP; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of 3GdXvZQoKCLgwmqpwYfkcbemmejc.amkjglsv-kkitYai.mpe@flex--yosryahmed.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3GdXvZQoKCLgwmqpwYfkcbemmejc.amkjglsv-kkitYai.mpe@flex--yosryahmed.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710216474; a=rsa-sha256; cv=none; b=1NktERluP9s0Y+bnqBQGgeK2GN0MyYLt+m5OLljfmRw2uJw5WQ/6vSV9JbRwv44F+C3E6a GgQGTP7uSH6T29AdHLXf2WH0JY5njhfM2Du/k0Qu+knjRppx1EPhC59QNL/55KZR16PVri d/xc5nJ8Do5lR2VhigzDstGJcytgDuI= Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-60a0a5bf550so63606747b3.3 for ; Mon, 11 Mar 2024 21:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1710216473; x=1710821273; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=RtyFjQ1ew/Km7nQfV9Ii5WtnlkpNOm8r5T7xPWUQ1Vg=; b=L4P4edmPmTCnlnmXzGPVTvj8oCy3vzmrcFJJOlXdzf1jhp4X1blxxvgykkYU7hzWai wsDNBgs1b1Zn7kiomWeGaANJ10S2mfGXKlndXVfT+HF/qdl27QvriMdF2L06Cs8I90jB KE55NXUoPM8QS1ci/vkq2akuoACzFDSTvy+4yrYRdJ/Z2wIDKLm/Ir58CyTtoz9Dkt8v J4S8PvnfBvp1Zku1ZHNRrqwVUv/YwG2ZRSEcy/cDfkmLsiKbE/2y5FGfICBXoQwz8dM2 WwFek1q3SrJcdPmws5/Rtiayhiszl2i+N4Ri9GJyPCaZDgMA/cOh8i0dalUHaoI68gVn 60yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710216473; x=1710821273; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RtyFjQ1ew/Km7nQfV9Ii5WtnlkpNOm8r5T7xPWUQ1Vg=; b=B/gS4ySRqdTwVO1qEBP7cdFjOkVF1jh4yZkSRh+ZsuLYEWkqbsWUh5ZJmhs/Aml7HU 227glznphJFlsN9++BFVPycG5nkq7LSJzp+7Wr2xMHvZnreNQrbnRdlEXHtESDia7vdc Rw8FZm1kJWhh8WGu36PI3SpRugcoCVSBxWllViV/SBjrHmoFFOXKcO/hwaTukqQMiz6J 1RCPDVYU76uz7NUTY4fojL3DbZWw87FUXhMIzn/Tz9G+sYn+wd9B5kfs1QPjtXmAKcbb jWGyLciw1mzwh7NQQxsA2CzrwPvIoxUokOeq4ZNUc/6Zhe7KVGY+TjyLvL25N62tySOY QHnw== X-Forwarded-Encrypted: i=1; AJvYcCWt0Fz23E3c9g8GRGXe5BMJiA/nkuZMcgAJuVgtmJRnNw2Sm7+TT8tixWYGLyBG9/B6k6LXjQTKy9r/TeOEa4tTRwM= X-Gm-Message-State: AOJu0Yy1JG1+xlmYOvXMyFFWuHNDy0iQbn19W88BBnPqTuZEevhUrWBh mMo8IEOi71IIWeKGCwB0PwjSX9B3VYz6fvRLOjfzf5bbwTc0tXpoC1suI9YD/Emri9dQbFx2B+8 ayFiEbh2ZDKyE7MZ05w== X-Google-Smtp-Source: AGHT+IG/iOZyVwkauiddFoT8Ft1lhQSt8JC0GtCjLf0h8UyhUxK4XKmzq7fY16L4xzPeeRHZ4Geo+Jy3Lm05Gn3/ X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a81:9146:0:b0:609:e89c:983f with SMTP id i67-20020a819146000000b00609e89c983fmr2319782ywg.10.1710216473351; Mon, 11 Mar 2024 21:07:53 -0700 (PDT) Date: Tue, 12 Mar 2024 04:07:51 +0000 In-Reply-To: <20240312023637.GB22705@cmpxchg.org> Mime-Version: 1.0 References: <20240311161214.1145168-1-hannes@cmpxchg.org> <20240311161214.1145168-2-hannes@cmpxchg.org> <20240312023637.GB22705@cmpxchg.org> Message-ID: Subject: Re: [PATCH 2/2] mm: zpool: return pool size in pages From: Yosry Ahmed To: Johannes Weiner Cc: Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 4019B40002 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 54haismpdmn9r1k7dixuqa7iosz3ijih X-HE-Tag: 1710216474-496940 X-HE-Meta: U2FsdGVkX1/JB/ZV9lnLBa6ArrZKYZz3rzNb/W67cpJe5HqWO/VQvjOWgt0AflktPk+aTMSV2ZBt8rs5+j7fbDP4SUov/DCge52OTtkM9Xt5GWedkZQ7nwW9qJGehu6ZXfcHtsRoRK+sGZ4v2pe9vNRIg/n+Q6T2Qcp4gKYRHGbncFA1TT1vkWHoqKJmZ1BkvZ06iJJV7GZJy/p89GZDZA8Br1TmWSVjCiVpu++WB8VdwSBf68pr1Z55U5m5VT0MFOeGbH02+t0W9hB05g2ORseNLDPI4vCLXbbSsdoJdY8iB/IndwcyL6n5zexqoajJQFUYgxpfNiq782GkiF56FKr9ryiDzBprCPNxF7WMEc31T8BDxedmBbAGBOILUKvmsFhKljQp9MQcMAx/DCSdKaPRfsThTca0oJX33zzQP7ssduv4qvoK4pYJ7VOMDGaFIOrtX7lLLV4orqRb0u3nlqEWwgJH29h3vvDuv/MGmqo+wMz1o36/aW+S3KXP82nLEaVr+oWdn92NdlbEBwRjw2Cb7CoAQUMiwuLjXFdAgetOvw0t/IVzpz3ItYIalbDxIVmwLrzQt0jFYAhH2EgN2ZxamDxFMU4ckXHveRArc2m8sXN4jz2kqV/fzu/2BbAdDcTvzs2qv2n8gWqraqa15guOPvxLlSyYj6xv1kPDn6DZ+GOS+ksNAiTt+1nwfm2AJ3TiSraDRD8y/4oshIG/8LbBnM+Thpo6i5M1vCN/a6GjGDQLq9IeiRjWjWIKWesFZKpOX5WOL15WtcuexheyF2qMZkpIEmmJrcD30tMVImRfuKiwOIwG4iPr4ROwX3pnBG53xbatfHZkqWYIne93EVkW8RHFY4GApMERU2NYgqnK8C/w+cbbtnjYlsCYNBU4VGFwfHWS2QeikHXTS3JIh0vajNdBGDO9xX7KXagrlKcIWi0WRtmmNSgv+pquG2fuWZ0Wupgn7BwhMDUKkyV SnaeFX+J GHSD2sc1fqkQ91+34JZJW2sDn3pRuT9IZGduqE2gD0DaryJM1mcLmisK11T5f5OEgIi1CT3dO4VUvHm5MGt/OQkpZZJPXvpACs7AqxH1SvkIR8DMIjcnQDFrQqHkaS8YhK0oHNC4aTdHr6kZTdfY4WSwvWD0en3bb6lWtYjcFVl7HMNKrTQp8xu0DaG2yyJ9KJ9eC2TQ1ExvarZsEOwzc1KeGaW8fryA3tz4TJRADBXradU6Lk1siBZ6gUIxsBsKX/jB30VW6nJvhAjkibc/bNFdL4UVir19ZkRkwVTAMi5362dC0kSbqBHQhjy8PLRUFSSVWxrBxb4v9h9uu3ptz3XHhsfY+Xwe5uBS3eKYzUQx0t7GxImNc608wJPVbYVZgK90RXpAz1gySiD4lLBPWgf1UpKfKAQDuOvxOKla3sGJ8QByvZpYCCCr5FklHHDgfQepx9clT5EZb0bA2OkNbBxyrpBNhe5JmJ+hctTdLBEC2ljAoJI8KLHyeDM6Q0u5s+br9szd+9JUBgREhJ4/i/ABdF7njNV5Ov60ekSpCjbzbYex+i9HSZXYUgtkzIzsfd5TM55BmeLN+jpfCUppeI31fu05NivsiWI4eT6s0Ce41zsIdp3lpnTc+EXasMg71dOXZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.079177, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 11, 2024 at 10:36:37PM -0400, Johannes Weiner wrote: > On Mon, Mar 11, 2024 at 10:12:02PM +0000, Yosry Ahmed wrote: > > On Mon, Mar 11, 2024 at 12:12:14PM -0400, Johannes Weiner wrote: > > > All zswap backends track their pool sizes in pages. Currently they > > > multiply by PAGE_SIZE for zswap, only for zswap to divide again in > > > order to do limit math. Report pages directly. > > > > Nice. Although I would prefer renaming the zpool interface to > > total_pages and renaming the zpool backends functions as well to use > > pages rather than size. > > Ha, I was on the fence, since it's kind of churny. But if you don't > mind, then it works for me as well. If we are cleaning up, might as well do it all the way :) > > > Either way: > > Acked-by: Yosry Ahmed > > Thanks. LGTM. Feel free to carry the Ack forward.