From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0758EC48BF6 for ; Mon, 4 Mar 2024 17:38:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 900A56B007D; Mon, 4 Mar 2024 12:38:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AD8F6B007E; Mon, 4 Mar 2024 12:38:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 775B26B0080; Mon, 4 Mar 2024 12:38:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 64D116B007D for ; Mon, 4 Mar 2024 12:38:45 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0AE42A0CED for ; Mon, 4 Mar 2024 17:38:45 +0000 (UTC) X-FDA: 81860066610.10.2F2CD77 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf03.hostedemail.com (Postfix) with ESMTP id 221132000C for ; Mon, 4 Mar 2024 17:38:42 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709573923; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=323MR+nsrEt/XxTa8RcVMpUABUkgB5f8tr1051H02/E=; b=GjAUDCFvfhkNLWBClebrYJbfBjzgDGRAaIb951ZB/4Uq84hVXJcEGdJMCsQQxwMU+owT9S 5B4RXM6iz/HVendyaWFcgH/2ZGaMD9n4cAjRpiWUKSXXAZ56qusw2s33+pNpimN4KOOS/+ yizuCQn+zBm+1rJeHZ83GjQ5QBS4VkY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709573923; a=rsa-sha256; cv=none; b=j1X+EQmAlGNr8dbgO0WZQj74WXpKx1XJ5RayGKhFl+ZoWppxOChPnvbUSbi5+tldG0uKYy 71yWLwB/78seS4SaA97dZRYAOreR7oestpHB8XCDOjHvEyriGw0dAib37nBkhKnLbRr8xO Wnpe3VBMD72AK4b8JWJsKEZbW0FA9pw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id ED6F5CE13D7; Mon, 4 Mar 2024 17:38:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01DE8C433C7; Mon, 4 Mar 2024 17:38:37 +0000 (UTC) Date: Mon, 4 Mar 2024 17:38:35 +0000 From: Catalin Marinas To: Ryan Roberts Cc: Andrew Morton , Mark Rutland , John Hubbard , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] arm64/mm: Export contpte symbols only to GPL users Message-ID: References: <20240226120321.1055731-1-ryan.roberts@arm.com> <20240226120321.1055731-2-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240226120321.1055731-2-ryan.roberts@arm.com> X-Rspamd-Queue-Id: 221132000C X-Rspam-User: X-Stat-Signature: ze8cxfyi77fh4jejb9yxe6wpmuazw7dc X-Rspamd-Server: rspam03 X-HE-Tag: 1709573922-920118 X-HE-Meta: U2FsdGVkX1/WShqtikgvSgOxZr/t+/M225eHxKwLXV5dOed4wLopiRLyUgg59BIVV+hJ4yPg4NLQgva1d3551B/hggZ0SMsMSTVgm4NgQFJ1uHCtvTh7TVDRDlmqekCTDuNZf8S1K4TZmxkbAAkpEhsrv37MNEB9UkismsTJ5JBurdWh2DGPlMhmRtWWp5puIo0fWu4ajiyk9+wEUDYpLYz4te81zFXaMJBCDm/GEToj/P+Vo80o8Nar+Y+RK25GTWaMBZZEB24MVEhnjZ6IqJVEWAvliU2x+kLaWts/UIwpTW90WCouchcUVP+jsaSsL5o289zKaCkmB/vMpknU33VKhYr7qSRuvwdA9MfTZXJ3xqMbr/9fOR57DvVEcKVUztnjF2fMQnFTtNfF9CV+NRRbq5WwQC/2dIIG/GPCEJUizxT364VuJz76xGBD7SdNs/v50V+NGeAFwPEUgNKZM1dxtR4/KkyFCdDv4kL6swvdIKJ/HjMGLkzN5gd2Yz6nAbpIvt3hSHM+uQKPnHX/uR/R2lM7O1kZNLOxTmqD7Xu2xqcuFkGh6D39ZMJxrAIJfpvHw8j/FeopMrru9DVH3Oqwa4LDXO3/cICncrRHQGpDnTtbe0e3l/Cn/HqoUtB76J+SW4TtmQMyWNYQ+tfUqsjZ1H5w3p1INP7cDVkRO3LdNTO/EdfQKdlMQYFGZL3vE0UZjT3Ry20cS3a7AnPkPoyxCt/B9NnQ6mqz60Esdg5Fbhe/jFOrVMdTgh8PapaVELLYb3IrzyQTQdOTaUelWzqC7kyGdZgb1X7X21mSKXhEMDIhxoyAd5BH56UPltrKf5XCq9+oa7QEp/vXT2JaSwTjiyaVzrZi8hDF8gk+I7i9MaXvWBXmcEwD8sDXQ3t8P0CD8R+GhA49na0PE7SqRQRVySlHulDc50A7eDT1U942ZYKCmkkeU3cHiJ9tfazPZFW9VzpPGd5CpPSG7AN 6PD5my3H aoBrgUeVU/so69Cpe66a7jY2TdgHwL5hQR8qU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 12:03:20PM +0000, Ryan Roberts wrote: > The contpte symbols must be exported since some of the public inline > ptep_* APIs are called from modules and these inlines now call the > contpte functions. Originally they were exported as EXPORT_SYMBOL() for > fear of breaking out-of-tree modules. But we subsequently concluded that > EXPORT_SYMBOL_GPL() should be safe since these functions are deeply core > mm routines, and any module operating at this level is not going to be > able to survive on EXPORT_SYMBOL alone. > > Link: https://lore.kernel.org/linux-mm/f9fc2b31-11cb-4969-8961-9c89fea41b74@nvidia.com/ > Signed-off-by: Ryan Roberts Acked-by: Catalin Marinas