From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09045C5475B for ; Fri, 1 Mar 2024 19:27:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E2976B0075; Fri, 1 Mar 2024 14:27:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6921C6B009F; Fri, 1 Mar 2024 14:27:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55D266B0082; Fri, 1 Mar 2024 14:27:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3B25C6B00A0 for ; Fri, 1 Mar 2024 14:27:02 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DCE8C1A0571 for ; Fri, 1 Mar 2024 19:27:01 +0000 (UTC) X-FDA: 81849453042.12.15C9723 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id AB44E20009 for ; Fri, 1 Mar 2024 19:26:59 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Ybvg9RV0; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709321220; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/2k9Ny7iGQGTNen6Wn7IjRx3a2E4Jj92/u6+1Zea9no=; b=Xswp1o7PLygk2mqoXNELfX2Pc/TCMnZF2BBVAeKv2N0xeDdbErPUG9bXv1aGejkni0u0lo FuhYDfQWphNbdc+OuRliAdrIxhZpwf5aBmM6ZYTc5ObFKfOXWK3qMRJgCvgixO2k+bMpEW yVO6KK9mmSRlkCPMs9n9L00mkWyodCI= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Ybvg9RV0; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709321220; a=rsa-sha256; cv=none; b=ClQPSKp5d9hsA8eB26X3cBLl2pMXBvJH7QLSckYb2c3K2RxzgO/QCm3zbuNv/dPc9U4OBc chUJ5hR37e8qo++dXwMJOqDOGfVIUVJ9dh+YmvzmtzKdUEUuX+Js4JXjr6lCh+gakl6lyR DifXqy/TT+27xm/j63iVDDx7JWkkvxY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/2k9Ny7iGQGTNen6Wn7IjRx3a2E4Jj92/u6+1Zea9no=; b=Ybvg9RV0Gde632PiFIc43hHze0 iWF8DGBZ7TOlrbN1f5/ZIZ7wcE/sxUzP3jY8eCH/OBRd9eeCx95AC6rnwCVVc/MEOAEw4DV6kbv/x 6eQS9KZCEL4JaE9SiTP910MCvJWfrAyb6LG9z3rlYnDqmG/fT+NqN31YVFNYyka0S8bupSuzmrvkY VFoNblpQDTSbUZr2+hV7Kj45r4KdPjQFEVbe7zJXGJGxCXe4OHlGYTU0Ylihekg/aQO/tcLmGNcoc fNdSJPtktbPi0OM11Rd7zM3vvyD3zLUXrxWhuyV0UlPZvrgBXlXLnvnFsiiOCUprp6lIjnAH6whvH fy3nW0Vg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg8X1-0000000BhNj-0rOA; Fri, 01 Mar 2024 19:26:55 +0000 Date: Fri, 1 Mar 2024 19:26:55 +0000 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, djwong@kernel.org, mcgrof@kernel.org, linux-mm@kvack.org, hare@suse.de, david@fromorbit.com, akpm@linux-foundation.org, gost.dev@samsung.com, linux-kernel@vger.kernel.org, chandan.babu@oracle.com, Pankaj Raghav Subject: Re: [PATCH v2 03/13] filemap: align the index to mapping_min_order in the page cache Message-ID: References: <20240301164444.3799288-1-kernel@pankajraghav.com> <20240301164444.3799288-4-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240301164444.3799288-4-kernel@pankajraghav.com> X-Rspamd-Queue-Id: AB44E20009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 95wgtni3nb11aug5jsqunidizhc9rzie X-HE-Tag: 1709321219-707189 X-HE-Meta: U2FsdGVkX1/HM8uggjgKS4FMzuo8+lYCPJAm/ft1fG6CPOsxCSXc8PY4TFXZxmoMvVKL/5TH5U2k6akdLPQL5xxVKxhiTAukfBd+cssboHNp4kS4gvPQnK3LuvU8JPpqdbkYzYggqd/WfOpP3prGYWqP4BQPXXAZWqEof36m0simsvmfLeZiiBFFIL5Lm8Gc/FsYSJcX/CFgbfGbUL9ByeZASF2Kg8cr+V7/IQq7qNvMSc+x+360iP/nQM1UkXB8n16G9VXchi6mr3ZAnk77fhtYHk4lTJ04JUhNfjvo7+DVqW/9jLHGiC4gkUt+mdRruKUP37Lt3OHx2OJoJ0V5MySBIaYiDuM3fVd+MtiKlOSxJgpkWWVkj3T6SraisD2v1Z7Syw5pEO5//sTYYxDAimgpWdO5jgRPrT3gP+GVsbjLO278m7rVaPoPv/0WUeJzwYaYc9dew0E3fXKzjFwxo5EJXac1hDfkFvg3NSxYPhfDLdejb+uWeE933vX3gOEWsuD21ILLpD2NcVXBwFFTMvRobScoCx/M9x6HofWczjXkM2Voffw6lOgRLpblnlMFgbpL+i3g6IZi+wBtPsGDTIVRRVtxOhlQUBSD+XMVq/Crn98yy2ImPxugGwrlVQBz2ZdPza9eF3GAippwVnrWCzIHRIPnrSXQomqexY1T4Vs/UdlCxyjqDqeGE561XfzFL5PuwyitYR29tHOG3LFauieZ7IHcvfoatax9+Jf7Q9R+1QvyLg0VcqfRnsNQ6CbSRFF9rHlZBcd5RrUgpszWPzI9L5Wxl6E02Qpy2B1maTlxKL6WGT67NTVz4Kdl18HpK3Vdfk8ZyvA4c9YTROidO2EHB2pAGBLNurixBE1zGXPn6J4TXJyn5ujn9to41/vFEQ9buJAOqKDI2Ua2doJGfreaQ6aMvZ8mY7Z7rIQGFqEWfS9/6ZTlyI5duBVpMDFyXie6FGP3KoCmkCZ6O2N Taxqp7p+ A41BqM/a3uKPxBbfFL7Qp8w/uOOWwgnWN5T4R3/xQ4Nathie8/MUBW1mnsNMalMK18uk6o1oV80xEyfEBJQ6rVjT/yuj94squCgX+owq52AO897YY4o0+XXfA19yQSK3jWVa5ZyOHXvVvckduOprBkd6Ve6P9jPCcW5DVxuCcjDbf0wCZBMx5ZBO6fw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 01, 2024 at 05:44:34PM +0100, Pankaj Raghav (Samsung) wrote: > +#define DEFINE_READAHEAD_ALIGNED(ractl, f, r, m, i) \ > + struct readahead_control ractl = { \ > + .file = f, \ > + .mapping = m, \ > + .ra = r, \ > + ._index = mapping_align_start_index(m, i), \ > + } My point was that you didn't need to do any of this. Look, I've tried to give constructive review, but I feel like I'm going to have to be blunt. There is no evidence of design or understanding in these patches or their commit messages. You don't have a coherent message about "These things have to be aligned; these things can be at arbitrary alignment". If you have thought about it, it doesn't show. Maybe you just need to go back over the patches and read them as a series, but it feels like "Oh, there's a hole here, patch it; another hole here, patch it" without thinking about what's going on and why. I want to help, but it feels like it'd be easier to do all the work myself at this point, and that's not good for me, and it's not good for you. So, let's start off: Is the index in ractl aligned or not, and why do you believe that's the right approach? And review each of the patches in this series with the answer to that question in mind because you are currently inconsistent.