From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3F61C48BF6 for ; Thu, 29 Feb 2024 20:55:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3ADB56B0099; Thu, 29 Feb 2024 15:55:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 35D2A6B009B; Thu, 29 Feb 2024 15:55:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 224876B009C; Thu, 29 Feb 2024 15:55:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0F87D6B0099 for ; Thu, 29 Feb 2024 15:55:07 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D512514037F for ; Thu, 29 Feb 2024 20:55:06 +0000 (UTC) X-FDA: 81846046212.16.9E678AC Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by imf24.hostedemail.com (Postfix) with ESMTP id ACDD6180008 for ; Thu, 29 Feb 2024 20:55:04 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=softfail (imf24.hostedemail.com: 198.175.65.9 is neither permitted nor denied by domain of andy.shevchenko@gmail.com) smtp.mailfrom=andy.shevchenko@gmail.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709240105; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mNVy4GO7NGiQh8IYEcZGUCuSXRbSje4CwNILt5T2RXw=; b=TjRc7ZGZUmTg5LzpnbjyLh7CMtryCkri5auDy9QIifYVBIoqHVAJtfefeopEuWvoKKohV8 rn/PFApuyEXEyVSZtyqXH9HnX9MEm7k+1xegoOxqHHH/2YYGxr+OSHAf2ONJLJ1IlhUZkF c5DdcqRbEFvL28Ip4kTv/aXNL2UdU60= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709240105; a=rsa-sha256; cv=none; b=CMoHwtfRWsXG13vmOopw9KbGw8vTUlw9n03V/uQg6Mozv+BsS0mDGsLct3fO6JV/QWVFNy pP5TkcK09uPM/pXu2yGJb5FAoCOw9YP8cdMLO4xpGN5jlbpOipgBfcI9q8L7ikyKwBcDcu sGHPswRoej8byf6NyoUkFr9xv/MyXio= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=softfail (imf24.hostedemail.com: 198.175.65.9 is neither permitted nor denied by domain of andy.shevchenko@gmail.com) smtp.mailfrom=andy.shevchenko@gmail.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none) X-IronPort-AV: E=McAfee;i="6600,9927,10999"; a="26211656" X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="26211656" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 12:55:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10999"; a="913992414" X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="913992414" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 12:54:47 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rfnQO-00000008nBm-1H3p; Thu, 29 Feb 2024 22:54:40 +0200 Date: Thu, 29 Feb 2024 22:54:40 +0200 From: Andy Shevchenko To: Kent Overstreet Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "Michael S. Tsirkin" , Jason Wang , Noralf =?iso-8859-1?Q?Tr=F8nnes?= Subject: Re: [PATCH v3 01/35] lib/string_helpers: Add flags param to string_get_size() Message-ID: References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-2-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Queue-Id: ACDD6180008 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: h4rca77zmuqeg851mz1osqebqgr7fkyi X-HE-Tag: 1709240104-613009 X-HE-Meta: U2FsdGVkX18f5rWQLuy41jyHk0boSJlaVTALHIMHCN0NaYFABXWxOPuMocaNB+g3PwethpqNRWCNlAL1zzJK60nvRc5I5lIPajHTjH6th/Sakv482gWPO9EIH6+kPZXOSgxAkUPoS7ssiKM7BFpJNhcOqRXtFSMAstuO3YKcwUSAXT8tndcWQvIwvSaBxHTMYL32OIxEx5ydbl6nqLyArIqseBX29mzXKXeIdtAReYQ0S+wJBIa+m4ZWObLCc4XlX3DacUdF+xbv0EJ2hWBYv1RTQUQyQXnxVZFOf6QBqas01iiD8qwaYYeGn2rbpT4EwMSWPbtm5x5tK6HquWfbvVmvXafn0bOyRc1tFs8RmUENhbir8sxlxGC5Rj/Y6WPSegNI3OBgnXk/f0GXokZ3rXm61UpTsSLu7WBU6M9o27MCKWBUgeblPChJbJJ13xA2cdc5Vri9xILKtO1wXENQ7+DqF5M7SlhtD5N4w0QfXJ1S4tgYc/AVkBQm5/Yyi3dWDabSygkOMbLGafR5AYnWqS4oKwNZeIIfYRTlAsvfeDNBk4GU7Rr8ity1XIfDCtJGiYpIyBRWMUE+s07xb+unc0OHIR5V2YhkxmAUxKDh3mPdpo1tSHRg3ZulK5P/pGyhDtYyDFtxfypckYCYijRs/iBy0Yi4TbgMAb1/9xOAk7jyNYk2oEvbbU9Zj8T+74Yt5pA83pKfJIuzoHvAXm5qWfM4xqr8zc2RwEvRKRJpMfuG7dNN0NwconNB+w2gY97ml6/dj4eSMM7z3SKg52ffHqiUmUuyrT06waR5DE8lSi3FfFd6QlP7zhR86Nu6XVLwxw0iAfmqOfZUXD4gSeWEaSO5+mMTNY9XjKHBXl59V2eVJmTTVVlXyKYHOyJnMpUOJ7RN7HP3x13iHZtJE1v7IhiFuLD5R8RobW7lRTptZPISUMeiNlwJ7avDFXPDYGYEbehuSu4vfL4Xj5Lr916 Bru4HHPU 7onUzyL41iqIQb81mwO4cjn+o7F4hhtaATxg6wgmYNa11B2/ZC7bUJyRveA5B+AvuN0CAX9zpSJVwOT5yvrU/LXjfsyG8rNCCMAS7UkXL5iQil0TGoi0nKE42mNoKRsKZOn7sVjMgyQDIKJeWxp4ppH7B7BH3x64gWVSmZTCLKDWVvomwHRTeRVvJE4niDaf2pQiuZBOhEL8MrAmui0xZAv5ygL3Yq5OayeFZp7zLk5fP6ufkHY48HSR+dCppNTX2Lruhh6Hg8Xdc58K4nDemW10Zp7X4zM/L1yGVxP46Th8jbh+2EvWp4g+AZivsMZWSUQZpJvib71vCQFSjV1bRYg2vhMZgqxcJZTKQCh09wzZ3i4WnkPiK51dytDVr/VmJ8/dSdweuZbUgFdMfJqDEC16nlG05kTIcQ3JX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 05:06:24PM -0500, Kent Overstreet wrote: > On Tue, Feb 13, 2024 at 10:26:48AM +0200, Andy Shevchenko wrote: > > On Mon, Feb 12, 2024 at 11:39 PM Suren Baghdasaryan wrote: > > It seems most of my points from the previous review were refused... > > Look, Andy, this is a pretty tiny part of the patchset, yet it's been > eating up a pretty disproprortionate amount of time and your review > feedback has been pretty unhelpful - asking for things to be broken up > in ways that would not be bisectable, or (as here) re-asking the same > things that I've already answered and that should've been obvious. > > The code works. If you wish to complain about anything being broken, or > if you can come up with anything more actionable than what you've got > here, I will absolutely respond to that, but otherwise I'm just going to > leave things where they sit. I do not understand why I should do *your* job. Nevertheless, I have just sent my version of this change. Enjoy! -- With Best Regards, Andy Shevchenko