From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD864C48BF6 for ; Thu, 29 Feb 2024 15:41:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 643B16B0098; Thu, 29 Feb 2024 10:41:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F4066B0099; Thu, 29 Feb 2024 10:41:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 495FD6B009A; Thu, 29 Feb 2024 10:41:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3AD726B0098 for ; Thu, 29 Feb 2024 10:41:17 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0E0601C0054 for ; Thu, 29 Feb 2024 15:41:17 +0000 (UTC) X-FDA: 81845255394.30.315EC2D Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2097.outbound.protection.outlook.com [40.107.212.97]) by imf05.hostedemail.com (Postfix) with ESMTP id C2A56100011 for ; Thu, 29 Feb 2024 15:41:12 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=memverge.com header.s=selector2 header.b=eTSea7Qi; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=memverge.com; spf=pass (imf05.hostedemail.com: domain of gregory.price@memverge.com designates 40.107.212.97 as permitted sender) smtp.mailfrom=gregory.price@memverge.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1709221272; a=rsa-sha256; cv=pass; b=BwtOyOQ2rUcOAyVUpA37dzRZf05o8qvUmNTT9Tq9fa3zYqUk3xwa3CNngVyCfRc/YposG0 hAdtHY5PoV+TiH/pNuL9IdQDFAkr7t0KIeKtMFr9HgXxlAGHom8iX9ea2Pdy9qqLposMLi Ny2NAAkUZZOgmjf8RBebNr9M6sJsiq8= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=memverge.com header.s=selector2 header.b=eTSea7Qi; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=memverge.com; spf=pass (imf05.hostedemail.com: domain of gregory.price@memverge.com designates 40.107.212.97 as permitted sender) smtp.mailfrom=gregory.price@memverge.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709221272; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/mGd8bfRFUpFMIyCr6SEVD2PcnZDGN8b7eJ4HYi0wuM=; b=iBhnZXlEM5WyY8YNpVa4gDdKtmUMRsx5jkgzM8StkhUifz8laaJ4McYAPIphQBpA0rtAIH rKoaeISR+XsIxTXrN0buULqz53pH0rOAdbBEEu9q4BEE0KT+v1nPSsEfLWsq77nOR7iDtq XSE0sFq8PhDJkWDgCIV2EQv7qFmp2ws= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hAIud8SQ/W55IPqpH8UO6vElFLl9rxjzxEy7Iqq6nUml+LZPjnapI5S7D9paWPXlHGwdSCFsSMME5ZmLn3ZxHpJ+2OLu2VCD7hdum8QtNNZPZaKiGKo6J50ibL1xB6gfBNXN8eNkwcSD5rkWqFle1/bhkPpc+l2oku+E1spDsHiEqHJ57zqy4ak80u4UK0R4QMYkPobIrNKPJuRUHdt60Y2FU6xqtvSRIPYKphbY1weaH5JiJ+3pqeG1B2GEUE/ojoFmvIL3hVd4lmApVlysuuUdgGPdU8lERDTII6is1NhDpNRqlaKXms6ug2A4fTBPq3qi2/gcfHZaTlXtPqtcJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/mGd8bfRFUpFMIyCr6SEVD2PcnZDGN8b7eJ4HYi0wuM=; b=BBesZD/o9BgRGvqmSpxJFjQJm9n7Ih+PiaLqF+BNQOu6yhMcl4RZZCD8lHhGRh6EOXRWDkPYXLRG6XydmBp3ztw7XcQZs0Mii7Bhz27tOLdbJXdxAHhEs8kYiP6AyH8Y40Ns1I8KKJtNyAy14vzqgWusKh3x21eeO5TLDUTHkes/aoC9ip3kIHsJOkionyjQjQzjgE6WdQ4LrHjSzXrvG9/Ci6a7iOfyd3psYZtTKm/0mZ/b3wEUFrFE87RliLqvpUr00rHGdReYBPIBMvALoxniy7Ki1z+m8gMLHqnSMT+UQd5s+gZRqGVyTN3j4ZL3FGzqhCtUPgiLWOg+7d3ztg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=memverge.com; dmarc=pass action=none header.from=memverge.com; dkim=pass header.d=memverge.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=memverge.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/mGd8bfRFUpFMIyCr6SEVD2PcnZDGN8b7eJ4HYi0wuM=; b=eTSea7Qi+q6TLM3jLQ9Ovw5/QK8i+AOiMaxd2JK0zsMyjo8w7tENe/TAVZOIXji1XFh9HrxoXtC9DJwOdPKg2G8k4UbY5mrmFThKrKwGkPj6olyzTmmHfGd+sr0W8XoUv3BB8WZsrfPZpj8PUkdqb9vWb+A1SO5M11Dxn272o8w= Received: from MW4PR17MB5515.namprd17.prod.outlook.com (2603:10b6:303:126::5) by PH0PR17MB4987.namprd17.prod.outlook.com (2603:10b6:510:e9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.39; Thu, 29 Feb 2024 15:41:09 +0000 Received: from MW4PR17MB5515.namprd17.prod.outlook.com ([fe80::20e5:e2db:35fc:d24c]) by MW4PR17MB5515.namprd17.prod.outlook.com ([fe80::20e5:e2db:35fc:d24c%7]) with mapi id 15.20.7316.023; Thu, 29 Feb 2024 15:41:08 +0000 Date: Thu, 29 Feb 2024 10:41:05 -0500 From: Gregory Price To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH] mm/mempolicy: Use a folio in do_mbind() Message-ID: References: <20240229153015.1996829-1-willy@infradead.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240229153015.1996829-1-willy@infradead.org> X-ClientProxiedBy: BYAPR05CA0069.namprd05.prod.outlook.com (2603:10b6:a03:74::46) To MW4PR17MB5515.namprd17.prod.outlook.com (2603:10b6:303:126::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR17MB5515:EE_|PH0PR17MB4987:EE_ X-MS-Office365-Filtering-Correlation-Id: 6022ae0f-b080-4d2f-c18f-08dc393cd94f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tzVIWDZd9YlFd06ysze5bTEeGpCoI6PZ5sQvvFlvLf5xfbqDXdemUHzEKR84F61o4RBsYuUTzoHwkuRISoKmZqPao73pIdW/xHKmh3DxL9AJKFE7gsbm/vbgMe+J1i5vQmY7FKEkBNqWXeuRUzqtvHwjlsg8ciPCAz/+gKrZo1ACkjjLWpFxBXs2DmbK4YI2EGGVf2tkLsZ2qpN8ShGMnh2RzO1oOmqld6U4rHR9aZE0pGplBZQHZRUHdqIvuCKtvebesaCbcKouRAGmN1G4yCkC4OZQLGar3zjoJKbm0B2ppmJcRSGJQi2+11V8xvRF/QpFGu8zH9L7phPHZooNQpta4GtyV/tLH3xtADbY6if6HXHJQF3CA8g61zy/ip47THDs2H0/HFc0WyrGKAEHjGoqIB37zhNR8dKZtWSpP2rE1Rm4EOc/lT8kn5Z/tpgVZWAWTOGjwC1nDTFxN05v45c0J+HeVzcCmTAc2fAgVIrcAVc+/PTQ63ijHT6UvMv4fTOMIQKyeuRhDX5rbkq/8hynsirBkpmkEtfrthJj32iQ0x8YjepH38Gely5qIID7Od0X09q+emUGzNdTvG2zM9WDr59z61oOTDeETwkE2Lg8UpJ5t0/h0k8j85gP5AT/vgcU2IiLLWij4n99Cl9e3Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR17MB5515.namprd17.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?k9VQe2j/2cCM/42mY8AY0N61eZLDbhmFiL3X7eat2uSGu/J7Mp/ewY8PEEJu?= =?us-ascii?Q?G4WPGRtspG+yDwNNb8zmYBwHGq+De9qm1gVyEgQhHqYsuLJIS3s/ZXvIVOyN?= =?us-ascii?Q?7OZBhQ8EwUSvZeiZdAOlMDoHOdwAcKs9298d0DALRcQ/jl+I70GskK318S8q?= =?us-ascii?Q?KnDSO+fPn09ur4ZmJlvTtpFNv9XkkxyMWTPzpp8PMl3sSHbso5gX1hEoC5iA?= =?us-ascii?Q?KLag78wU0nDq2vfI8c3Y0UyCC7RHmzXgPOxFxrk5x5zzQPvzXZlFE6Sj8Ag4?= =?us-ascii?Q?4j6s8F/iAsY2cdJEvPJXlkov3CaLsjAWr+xmzr9Dsos7azvLbJgOtl2JrLx/?= =?us-ascii?Q?RdBt+5qFFkD/0mzxaSFLSHqZosty5ao6xNgm9m0rOGznWTF3WSYQUATps1AG?= =?us-ascii?Q?v9wu/cZB67tnfAQoe1TzcFbqu+96H3crDdrB4HY2fr90zVLuiCxAtha9Y2oK?= =?us-ascii?Q?tfy/saEOyLjz/dWz5ntOVh297T5WfMKzka6TQTZe+Q48FbMMUzp6iJsN9dZM?= =?us-ascii?Q?hC8yGGE6pYdUEt9Msx3NQxWAYQr1MvLqvUZB2a7lN4tttcalmsEo3cJ9TOOg?= =?us-ascii?Q?GZSr88JY9XdNksP9X0H8OSjpA7NG57SsaZLYcH8pAtQ7Y68sItiAza0GeRxV?= =?us-ascii?Q?ChbHYjifGTLdPThCesPuEg8d7V6sH/88dWrRkkxiUmsb8Mfmyt2a2izFdaMR?= =?us-ascii?Q?lWEUg7qOa7OreqmKGIBxEXZzJZB9nkwyS+/hdkVnLR/OBeeAsBpWT9Qn5iFR?= =?us-ascii?Q?tFg9gzvwWPTzP1K+sxC0r8u6F0pwW67IDEFE+tcabDhGqClf33ARWy6iJH3i?= =?us-ascii?Q?VqhAD39L5/yc4M635/pDblwv3syXFXtZ1RFpixg0h6gPJIh92s2lPzNeSAon?= =?us-ascii?Q?QmBOs0iE7iTVmpAdzgK+qpRTSFvRcoqRKBetw4Yk7lYvR2GBhJxgy8lfC6PY?= =?us-ascii?Q?HD4eviIrqopgH32PsJqcExw7yu7L6dpjB5+kHvDfb1+8ZTAoxPJ+W+H5OqIa?= =?us-ascii?Q?NXJF9kgYW6Gy/zcHfGkL1ShIfSJdzn9Ytba2jDqXD5jUfBaDZET8CYpxBWYZ?= =?us-ascii?Q?+k5J+VbiSdjjkJ3MMqi/DSkpVx5JyB/qvqupA+RCko6/dqd7vB1i5aN26DgC?= =?us-ascii?Q?itIORwLbc9DGCBANW+lh7iAKmFbhO6MqIbmE5FQbbYT/2Vp9Bwjm0eUhjlJO?= =?us-ascii?Q?SSMxP+t8mUjh59MY5cO6gsMqcGdA7DHWddWc70JVkqoWjkELZFJh32ojiRTF?= =?us-ascii?Q?smWVPX8kP5qjUhaF7kZJsTuITH0bkcK1S1hocFdUGJ2g8xdkMk6nJUf6+WhI?= =?us-ascii?Q?TZVCmIXZEYrfndvNJLh/d6aWKao3ZhVgZ6Izc26Pe9Kd5HMIDDW2Z0qvU1Hz?= =?us-ascii?Q?gCrzE7jKmwkyjDXOqj/qvyiAypda6gagc8EZjwRNXhdeqbZonfuJqTp8hjEH?= =?us-ascii?Q?D5ALKOq9JW4aqRB/M4Mq6fUbtzU3c9Nye4k6fQJHUd3MTLCeNKV52iIaoY5h?= =?us-ascii?Q?cWOYyf5AQi7rIJyomvoQPa6R4h5xQt8PX4P0AzfVmBAaxmuEMxQt+vf9zNw3?= =?us-ascii?Q?DCGJSiIUskfnwJuOH49YAk+Q6xAy3W9lcAY4b0UNnsxSxNX5FQK8dD4zKTen?= =?us-ascii?Q?oA=3D=3D?= X-OriginatorOrg: memverge.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6022ae0f-b080-4d2f-c18f-08dc393cd94f X-MS-Exchange-CrossTenant-AuthSource: MW4PR17MB5515.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 15:41:08.8111 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G1U59sdHq3/gA+HjxgpiXejTxS14Gui3F/OkU2NcXyoGSe+b71ArP+YOur93U9PvNiB2xH5XisSQ/aPhZAbd2sebTY9CBFx8DSRxQFjdxIQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR17MB4987 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C2A56100011 X-Stat-Signature: 3rh85ybzur1zudwcz8o89j1jb6an5q3p X-HE-Tag: 1709221272-283501 X-HE-Meta: U2FsdGVkX1+V5CudZ5oWneyi4y920WbZ5cveeVNYyK2COCLfyzzTpYonpxx2It8Xx0TlHqi8dLKMM9zSLWgCeBtBSNEt9Kigdng+v8ZHiJsndOBo39nxkC6qmybegqKyWSBlZBM6gCOdjR33yEw6wtNwWNiciHvh1940NQeIq3fpfRZw2m7NinP9vrDbJjtdlI5XpvQkIFXSJN/4r5DiDLD8Sh/pjZjuPdQXMAka/Owd8ufkY6hymIsivd9wjixJQka6TiiOsnMKXUnTB4RXLbiEZwsEhOMc4VfGwDVa4R+CzGe7pZW7SNaulsp3WgXRpia36jdUSXeDtZ67NZAOaxHWnFKot4mTD+woDBlkqdBiKd1ne6LFd6u8NklvZrbuQt83LYZObK3dWO6my1o32/q/EhTpLoNujqwOV/xmw9QF4a/pszc07Lxare4oGN+BTukNbiq6b/V57s59HRzbvm95DF6A6tpDACrK+PK42sSycLypAoWYWPcCMSRTk2FKs1y00dRNfeGQSs45MU2ZAswmRTpROApki9P+SAXcWUGL1rFBO1mWOZRG1gMjPfewtZRm0rbx4zml/zeY39PzKcxtmfX/mLbuHHMPSUdOXoqZcxvl9CK4fQ6Xow4xiB5/67ZKM7RxA9FuHGD/FMkWrJAwYEsIPif7gRShl/3huYkEyELZt0pLXv3HuRL9A4qzY862zcpzrCIxEZjcgxn+hRjH89CgCovF4Ut4j9NG09swanncKbrWZL79RR+PHyz5fDEzA4tOSWERQC0ru5Y3x9QG8YIuxYgs4268PG/iaUOeR2eJSEERhEzFgpFky28jQImxfBkumtGqk/iCTJV6ZPKXNHsNt0ETLBJwWQhTBf7XN9bE8XSTdLiC2T7Szlcv3JoEKYdCqNEcinTlVYVkuYbedEaPbGg77eIcs07aRi/JZCK3syGyotkRx0soib2QWWzV2+8SLXGdavb5KFk H35hURzD E7kXgSvYwO4fBM7Zby6vnUrZWSjW4WKbpzL2mFDEcb37VbtEl+BObY7lZEZFgU01qYbYvwi4dIfF+/Lf7gaRqPS/IcZjO5jdVYENyiTMg5H5HyBt1fP/keoU7SE0XUxs50RBEiAsQTSdARKHlp33jHZ1y+oulSPnXrAiAiZ8ugD9Y6j8/Og22T/kIAfJ+3wnLhLKR0gSW6fn+WlT2fTwDw2vk1kW6EZ6qaQXgXubXiBA1NljNN5Ia2QbJjvh0/A/QrOh1rwqlbyT0gx0Np4ds5WzRbsm9onq9gp+W33VbOwqMC7lPfFZfHEgqIzC5LEPnSyzST/q+161yKnYO8Ung4is376B82D6Az6sdSxN3/t1Ps44f6APlGLFUjBXFjKxd0OYc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 29, 2024 at 03:29:45PM +0000, Matthew Wilcox (Oracle) wrote: > We actually add folios to the pagelist already, but then work with them > as pages. Removes a call to compound_head() in PageKsm() and removes > a reference to page->index. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/mempolicy.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > Reviewed-by: Gregory Price > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index f60b4c99f130..adc036980713 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -1356,29 +1356,30 @@ static long do_mbind(unsigned long start, unsigned long len, > */ > if (new->mode == MPOL_INTERLEAVE || > new->mode == MPOL_WEIGHTED_INTERLEAVE) { > - struct page *page; > + struct folio *folio; > unsigned int order; > unsigned long addr = -EFAULT; > > - list_for_each_entry(page, &pagelist, lru) { > - if (!PageKsm(page)) > + list_for_each_entry(folio, &pagelist, lru) { > + if (!folio_test_ksm(folio)) > break; > } > - if (!list_entry_is_head(page, &pagelist, lru)) { > + if (!list_entry_is_head(folio, &pagelist, lru)) { > vma_iter_init(&vmi, mm, start); > for_each_vma_range(vmi, vma, end) { > - addr = page_address_in_vma(page, vma); > + addr = page_address_in_vma( > + folio_page(folio, 0), vma); > if (addr != -EFAULT) > break; > } > } > if (addr != -EFAULT) { > - order = compound_order(page); > + order = folio_order(folio); > /* We already know the pol, but not the ilx */ > mpol_cond_put(get_vma_policy(vma, addr, order, > &mmpol.ilx)); > /* Set base from which to increment by index */ > - mmpol.ilx -= page->index >> order; > + mmpol.ilx -= folio->index >> order; > } > } > } > -- > 2.43.0 > >