From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 915FFC48BF6 for ; Thu, 29 Feb 2024 07:56:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0D346B0099; Thu, 29 Feb 2024 02:56:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BBCBD6B009A; Thu, 29 Feb 2024 02:56:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5D876B009B; Thu, 29 Feb 2024 02:56:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 934826B0099 for ; Thu, 29 Feb 2024 02:56:28 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 48C85C0219 for ; Thu, 29 Feb 2024 07:56:28 +0000 (UTC) X-FDA: 81844084056.04.57DF981 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 2A02C8000A for ; Thu, 29 Feb 2024 07:56:24 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OcNZpG3O; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709193385; a=rsa-sha256; cv=none; b=t7cXdL5g72HkNnEL4DeAJCys3h/LD4WGxf9kl6Vo23NZLynTBAqd8aoCOEFD7zv2A2O/vH 9tr1CaoNFbUqgJKZhHUIWZ0n4d28aeBTKAV1bmQgkdlhK7RUa3KhF1/fYLOv8UqyrB/vD5 0Da37uKrNXUQDes7eVTOepZV2VRCZdU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OcNZpG3O; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709193385; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rZYUQ2/MyEIs+wTU4JfVi5JkU9l2GM3/3Nd9NcCBnAo=; b=cPSRWEutaF8civLI56I87frIWKn60qxUaDV+n0cYbeP/I52CISujGozGJPCa88YagPxUg+ +M5wV0HlklBCWfD03aRwDPfaffOLOh1Addm2IBkLIoowBPpVhDfCltcySSVDP4QIbEQQZA jVg0TKdrnyIcO+O71wBxfAEAqYf/A0Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709193384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rZYUQ2/MyEIs+wTU4JfVi5JkU9l2GM3/3Nd9NcCBnAo=; b=OcNZpG3OqsPzefSEb+z7yVLiWaxHDw4HUkeb04QiETegz7Tlhyw0xJ736Ay30oBZuQ2gpy uwLfIUnvV+l1pziHTd3UTUK0HFOV7Hst26lC31qASqJBYt43dn+W8KMrf08DXNm9Xi8VU2 Xbzt66PwreGN6UgicytwGfp2GSmwhNo= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-mlPtsRzXO2GvYPDmAHDccw-1; Thu, 29 Feb 2024 02:56:23 -0500 X-MC-Unique: mlPtsRzXO2GvYPDmAHDccw-1 Received: by mail-il1-f198.google.com with SMTP id e9e14a558f8ab-3651eecf80dso1091715ab.1 for ; Wed, 28 Feb 2024 23:56:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709193382; x=1709798182; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rZYUQ2/MyEIs+wTU4JfVi5JkU9l2GM3/3Nd9NcCBnAo=; b=cJLrzJxsozZjTgFM2oVLCMLh3JdiYdP1bfRyxCnUSHloOfUhBqLCoMNipi+8Xq+os3 rv+8lUKCJ9lgy7qb0vfGihUC7iXTD6Yv7EwlywxIOFhhZvVHpqyCU4znwuWxBOt89smX RB5mQB0yj8VbljF1S2KZKhdPxFm91rz+whUvXjn1yXRbwM3C+gdVEKqeZirYru2usEgd c8NNB7kGGQ2NcaaQLO+usFiAsWKts+CJVP5IscX4RelvONnXjgHz4cKikjSlgzT7P6Tn bba6cJtZu9D6PRjhTruwabO2N5lFpOTbhicuzh2FyInT5Zg+OSTvxnc6hD73xTpbo5As LM1g== X-Forwarded-Encrypted: i=1; AJvYcCVmx2HDh0zV3jiYx1CfaFAPbu+oIKdQ1cHPQB3yB///kD8YSFSR7D431XvpvtisYR0bCYVCUWxC8yXEOuBSTAiK+Sk= X-Gm-Message-State: AOJu0YyF3Gqado2+rHWpRWZ2c8pgAhPCxTXkYQqmgBav/0X0WZBjSZy4 yuA3bfvDLgKA9lngtn0SpIUoA0759JUEjY5/5H9Sq7Lghz011PfNP+RpTgc4RX4w76dKC4j9tIt AIxNOQUK05hOE2lWc4z/swXbOZ7gwcZPFnSjOW5h1mi+XJx4Q X-Received: by 2002:a05:6e02:20ee:b0:365:aeb8:26d1 with SMTP id q14-20020a056e0220ee00b00365aeb826d1mr1725567ilv.0.1709193382273; Wed, 28 Feb 2024 23:56:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IFK2Caj/CnSM8btPacrXhbRxxuWkGYLUk6S0weGtsslNFGdZ2LEbvNGX15pEdr1SssPwwCMDw== X-Received: by 2002:a05:6e02:20ee:b0:365:aeb8:26d1 with SMTP id q14-20020a056e0220ee00b00365aeb826d1mr1725558ilv.0.1709193381990; Wed, 28 Feb 2024 23:56:21 -0800 (PST) Received: from x1n ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id ff11-20020a056a002f4b00b006e57b37a932sm664588pfb.9.2024.02.28.23.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 23:56:21 -0800 (PST) Date: Thu, 29 Feb 2024 15:56:11 +0800 From: Peter Xu To: kernel test robot Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Yang Shi , Muchun Song , Jason Gunthorpe , x86@kernel.org, "Kirill A . Shutemov" , linuxppc-dev@lists.ozlabs.org, Andrew Morton Subject: Re: [PATCH 5/5] mm/treewide: Drop pXd_large() Message-ID: References: <20240228085350.520953-6-peterx@redhat.com> <202402291233.CVhChP2c-lkp@intel.com> MIME-Version: 1.0 In-Reply-To: <202402291233.CVhChP2c-lkp@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2A02C8000A X-Stat-Signature: 81m37n3n56xum4xdm9wkot9j8hmsa1xj X-HE-Tag: 1709193384-333157 X-HE-Meta: U2FsdGVkX19L4Av2H7mZT/amzu4c4vGXyOnNJFjafrUZoRi/DxUfvXqCnjdYJFkEE39Pl8uVm4U7dLZB7nzbyXWfWcfgFnepsqfo6oiMwDTEBUOaIKsh2dGfI5Q72tFJH39DV2u8tN49eJ57zs50GDhE5QxnUfNb82L4uCZQzwBeo7QONDdwgpy/MwLP2ny/fgm/rXry1tk2z/K6zf2Lnj5ryCKOOkSr8H9Sa5QtCxuQOBB85jAZhXAOk1PMGRZdR3VhY6gz1worCituQJlYo2qeyP9XtuLHidUGceh0e+a14sSoLAQK/CvjuFWgzMvr4D1Xi6UxG5z+jJZdK5+TIuZhCglVSQd5XkiZHQpzB7IXnj/w8uRaM6zY5us599EXRsL8BsHjrarVswYABqUCUjGpWK83vZJOG4wGG+CGkdONz99XWeAMZTmHuGcuySlmizeebILuXP+M6tp+bkSb41A3LzeYH5UGmRQMuEwnbDTcbHAMkdlvODY0XbxnH8xNlTsxDOgrdD8cwUOdB1iwSvGVKn22lmo4nnAmUHm1/KUWpjxh6tUx23aRXSa/m1c6epM89iN+uYlHpLWsDce1NA5qZaI/HKKaXzkSCLcgdGpBzKU/rYEyx0ZMzkxNqQPnNJxTU0h4gxJKD4EvXpj5I2jnccMBdxsToICydGdFyBITWI+TjxxQqbYubAeogsi6H+9kqBn0kBQwDq7VxyCKs84xjbFx6Egx+0wZ3nc6ojOCmI7sesDB1bdxN/+myVvUNxj/CKwJLatgp6b2HdgRqhQGKSmGv7MTcEQVL1PYXF2CgVH/JrDOAspttPiP8LIpqF0YqlH/czd3L7cJay5w034+lAybO6ySLiYyUQILgICQOrbDHF9mRIVkoXQw4pc3C+PGd7NVa1t3OnXcRek+5XEzLxMprDYaSF/GOPhzKWraeo0ATwDMi4oPRiyOHkwI1bMAPGZ9ZBBf8QnyyY9 RBAPIpgR wSohv+m7TOedGU0479g8WMohF9o7k1jIz4hI2JgyD5cvx/poyFXX9JJIgMZ6yhXmZhi7cQxTCVkBENf3jiBxCes4UAXNGJUFHV5HMVO6ZcQXeWYBvbv5dBuLMt04xzxnGV4KLox868MEJ+J8wECyuXzHOyQ194viawliQ0Kd/u/5hAdn1ztbj51XfntoAo00IknnMw2dgClStf2EXvY3+rVqyDSzr+OeDOVx2ojbZfGYqhgTSNROz7X785IhZGZLmFdu4l7CTOl/e7cnUPj/OmviPXVJkKNgzrMCxRJY11lL2cR7IgzX5qIBGWm/AYUG69hq7dRY6nfP3SPg6Cnltl3dqVNHl9p/gwtTU46QstB+jmoh9A+GmW3+rWoJHF1LtDtEp7eFI2NnojurQyn7RxT/upspnWI7qf3xj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 29, 2024 at 01:17:36PM +0800, kernel test robot wrote: > >> arch/x86/include/asm/pgtable.h:1099:19: error: redefinition of 'pud_leaf' > 1099 | static inline int pud_leaf(pud_t pud) > | ^ > include/asm-generic/pgtable-nopmd.h:34:19: note: previous definition is here > 34 | static inline int pud_leaf(pud_t pud) { return 0; } > | ^ This is CONFIG_PGTABLE_LEVELS=2. IIUC patch 5 didn't do anything wrong, but when renaming pud_large() it caused this confliction, while in the past it was a silent confliction between the old pud_leaf() macro and pud_leaf() defintion, the macro could have silently overwrote the function. IIUC such pud_leaf() is not needed as we have a global fallback. I'll add a pre-requisite patch to remove such pXd_leaf() definitions. -- Peter Xu