From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF0B9C54791 for ; Sun, 10 Mar 2024 20:47:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F23846B0072; Sun, 10 Mar 2024 16:47:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED43F6B0074; Sun, 10 Mar 2024 16:47:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9C146B0075; Sun, 10 Mar 2024 16:47:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C5BC56B0072 for ; Sun, 10 Mar 2024 16:47:03 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8EDE9120123 for ; Sun, 10 Mar 2024 20:47:03 +0000 (UTC) X-FDA: 81882313926.03.922EF38 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id AF872140006 for ; Sun, 10 Mar 2024 20:47:01 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ALWKjMuA; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710103622; a=rsa-sha256; cv=none; b=bP6Vw8hQ48WsASLJzhop58NyKD/76INTuPwLYMLdCOk4o0EW2i21NUElwkyHPLgl8SLflL YccklqB9Wsl3M/oy4NRUE+v1c7hb6ym4dCrMGlIcZbGIuM2N74TM1vwyM/gZJxQInoy/t2 wXqWFQAgVN/Qq6UL0wrnxDsu9aWziRs= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ALWKjMuA; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710103622; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WYK/L7Erg4Pfw8PB4U9velw7yO48/QiLeyxD/2v3tGI=; b=e6Hj5daVjjO4uogc4X2WedWKLVYnOqgRp54OG2s0J+5VdFLaTJmycExL372hQsxngaPgTi xj3FE0VOLZA8vhUy2M/FzyuQzFW5S+UhtIWfWUKYisqnuUenn/znkqW4dxiGYtIYfIf6Iu sHVXX4IPjzin9t9GEb8leredlm3B644= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WYK/L7Erg4Pfw8PB4U9velw7yO48/QiLeyxD/2v3tGI=; b=ALWKjMuAys37bsddP9Dox53VAo DLUhY+QZWGlNdf3Bhn34XNOEyR+XvbJLHVVvW9H/GDobmXRQ4kAU3V/ok7MJt2afqXFa7yW7f/ZUG IAN7dvCixY1WXtZIgqpa/R96tmDo4qadX3Fh6/Z+SmhMR3R3q9Z2mo0tINpqD4GHjfV9VHGiaH/RH eqzMJVrkjtNYIVocc9pCLCqxfSV51cAHjAEQcy/lhA2spCS16Jq/yqTXz7U4vmHjND2shJEgiBv7E JbzZ+38YuXmmL7l/7zCEdZSoq6HGOFmfQBHX6YGvw7hddJzk+hA7WAs7Wx/CKXbVojXTdz+Qx61sj c1/RlcQQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjQ4Q-0000000GgnQ-1wZf; Sun, 10 Mar 2024 20:46:58 +0000 Date: Sun, 10 Mar 2024 20:46:58 +0000 From: Matthew Wilcox To: Ryan Roberts Cc: Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH v3 10/18] mm: Allow non-hugetlb large folios to be batch processed Message-ID: References: <20240227174254.710559-1-willy@infradead.org> <20240227174254.710559-11-willy@infradead.org> <367a14f7-340e-4b29-90ae-bc3fcefdd5f4@arm.com> <8cd67a3d-81a7-4127-9d17-a1d465c3f9e8@arm.com> <02e820c2-8a1d-42cc-954b-f9e041c4417a@arm.com> <9dfd3b3b-4733-4c7c-b09c-5e6388531e49@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9dfd3b3b-4733-4c7c-b09c-5e6388531e49@arm.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AF872140006 X-Stat-Signature: eos48ycqatio64kzzbx7u96u6ihbkz75 X-HE-Tag: 1710103621-969190 X-HE-Meta: U2FsdGVkX1/fzsiVl/QKMSev3WSDGPK2tcCpK+ag2l0uxIoWDNx2Tmc2+XEggr4bqJHUo9i1AiRsP5j6DtMZJq8vben7TMAGBTnhH3V6qJdG34PS2IKk6kFBexDRyY75kZofFKRqMDTeUDFyxfXjbJCctAE7YWHlgq7ewLabEFstQH9rxbT3JW42OU2DSK03qdoU5c4GkXVVsZctIhYZfLTWdOrOdahHQ1M75c8lbOaZTJa659kMBessMXIKoSOyocoZDGuqOUnHJ/tt6GbLvkJ6cMtakoWXGN+dSY15zcBngZ8O9BDEzmLqLRDWEKRPsQVe/tx0Cel3SPas4zqd6YqyvFdiBtUi+XyuszcLIm7yiINX3RKq+MmAfUoDcuDoz9PNiXXqagKpq5BeAmzLM1xfieB4aZEFpraiBIS0ihlAje+xkLe2fhmFistb3blFxPpXUj9K7cZlareUW8x8LarbFJY1mnEUzpTJGeB2fmeLPxApdqXhzjXOSD+WLQE7jwDDKVOdc3RfeDbBL5OhcnGX1J9wn4UDqDQWr1JESP8WFwLlJsGx3cPFKdPZhqJ5uCCyVXCN4nnPZQMtf2OSyNRAdg8ZMQhjxPeEnNQaVktgtuSfoFK7l/ZZJPplK4PIcKYPCpHgTxCuV0/eOvtK9UvnAluoa44Lwe26EuSifMmWIHrZwPcFE4jLtFLFGCVl4VGdc5UMZpErsWhd8LPt12dycDBsxKnf6BVHhz1fpZb9Mj1ZzjjPxugs3c/2WgvEPnTct0cOnwFqDMtJV1xRH6tq9zWzeEqq3OBLQieHG+bxB/WqEFIJnKFt/bXq5s1F6wLUspECrqMMzWeLUwu/0Zr0oJwE93DnKpP4vAVRYlR0q275+iUZbNK8AvEDcqIGJGiYZ/Dnl+JK/d0a+2iQiOsVrJxXb/XiJFs61ROFqkZk1UkyQoH8h3I0ZnAGBxNTWrXHR+x40y253J3Z/qM LMeSI0p5 5yVIgag3vh/YuIOVeaZ4jcR7hAk3DOkeFVIJqGJFFsHTdnbnJg+lP7D6pBEIF5ZxWr3+mwG08kZifTOObATxfnVIYuJk7qyOmqCPOAa8pfQQtE/+gAvQPwwNQjd6sUK5sV26jbe7GybMRGYo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002982, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Mar 10, 2024 at 07:59:46PM +0000, Ryan Roberts wrote: > I've now been able to repro this without any of my code on top - just mm-unstable and your fix for the the memcg uncharging ordering issue. So we have separate, more difficultt to repro bug. I've discovered CONFIG_DEBUG_LIST so enabled that. I'll try to bisect in the morning, but I suspect it will be slow going. > > [ 390.317982] ------------[ cut here ]------------ > [ 390.318646] list_del corruption. prev->next should be fffffc00152a9090, but was fffffc002798a490. (prev=fffffc002798a490) Interesting. So prev->next is pointing to prev, ie prev is an empty list, but it should be pointing to this entry ... this is feeling like another missing lock.